1. 20 May, 2016 25 commits
  2. 19 May, 2016 15 commits
    • David S. Miller's avatar
      Merge tag 'batman-adv-fix-for-davem' of git://git.open-mesh.org/linux-merge · e22cb5e7
      David S. Miller authored
      Antonio Quartulli says:
      
      ====================
      During the Wireless Battle Mesh v9 in Porto (PT) at the beginning of
      May, we managed to uncover and fix some important bugs in our
      new B.A.T.M.A.N. V algorithm. These are the fixes we came up with
      together with others that I collected in the past weeks:
      - avoid potential crash due to NULL pointer dereference in
        B.A.T.M.A.N. V routine when a neigh_ifinfo object is not found, by
        Sven Eckelmann
      - avoid use-after-free of skb when counting outgoing bytes, by Florian
        Westphal
      - fix neigh_ifinfo object reference counting imbalance when using
        B.A.T.M.A.N. V, by Sven Eckelmann. Such imbalance may lead to the
        impossibility of releasing the related netdev object on shutdown
      - avoid invalid memory access in case of error while allocating
        bcast_own_sum when a new hard-interface is added, by Sven Eckelmann
      - ensure originator address is updated in OMG/ELP packet content upon
        primary interface address change, by Antonio Quartulli
      - fix integer overflow when computing TQ metric (B.A.T.M.A.N. IV), by
        Sven Eckelmann
      - avoid race condition while adding new neigh_node which would result
        in having two objects mapping to the same physical neighbour, by
        Linus Lüssing
      - ensure originator address is initialized in ELP packet content on
        secondary interfaces, by Marek Lindner
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e22cb5e7
    • Amit Ghadge's avatar
      net: Fix coding style warnings and errors. · 6104503c
      Amit Ghadge authored
      This is a patch to clean checkpatch warnings and errors
      in the Space.c file.
      Clean up the following warnings and errors.
      
      WARNING :
      * Block comments use * on subsequent lines
      * Missing a blank line after declarations
      * networking block comments don't use an empty /* line, use /*
      * please, no space before tabs
      * please, no spaces at the start of a line
      * line over 80 characters
      
      ERROR :
      * code indent should use tabs where possible
      * space prohibited after that open parenthesis '('
      Signed-off-by: default avatarAmit Ghadge <amitg.b14@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6104503c
    • David S. Miller's avatar
      Merge branch 'tcp_bh_fixes' · 87553aa5
      David S. Miller authored
      Eric Dumazet says:
      
      ====================
      net: block BH in TCP callbacks
      
      Four layers using TCP stack were assuming sk_callback_lock could
      be locked using read_lock() in their handlers because TCP stack
      was running with BH disabled.
      
      This is no longer the case. Since presumably the rest could
      also depend on BH being disabled, just use read_lock_bh().
      
      Then each layer might consider switching to RCU protection
      and no longer depend on BH.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      87553aa5
    • Eric Dumazet's avatar
      tipc: block BH in TCP callbacks · b91083a4
      Eric Dumazet authored
      TCP stack can now run from process context.
      
      Use read_lock_bh(&sk->sk_callback_lock) variant to restore previous
      assumption.
      
      Fixes: 5413d1ba ("net: do not block BH while processing socket backlog")
      Fixes: d41a69f1 ("tcp: make tcp_sendmsg() aware of socket backlog")
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Cc: Jon Maloy <jon.maloy@ericsson.com>
      Cc: Ying Xue <ying.xue@windriver.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b91083a4
    • Eric Dumazet's avatar
      rds: tcp: block BH in TCP callbacks · 38036629
      Eric Dumazet authored
      TCP stack can now run from process context.
      
      Use read_lock_bh(&sk->sk_callback_lock) variant to restore previous
      assumption.
      
      Fixes: 5413d1ba ("net: do not block BH while processing socket backlog")
      Fixes: d41a69f1 ("tcp: make tcp_sendmsg() aware of socket backlog")
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      38036629
    • Eric Dumazet's avatar
      ocfs2/cluster: block BH in TCP callbacks · e1daca28
      Eric Dumazet authored
      TCP stack can now run from process context.
      
      Use read_lock_bh() variant to restore previous assumption.
      
      Fixes: 5413d1ba ("net: do not block BH while processing socket backlog")
      Fixes: d41a69f1 ("tcp: make tcp_sendmsg() aware of socket backlog")
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e1daca28
    • Eric Dumazet's avatar
      scsi_tcp: block BH in TCP callbacks · 7cb001d4
      Eric Dumazet authored
      iscsi_sw_tcp_data_ready() and iscsi_sw_tcp_state_change() were
      using read_lock(&sk->sk_callback_lock) which is fine if caller
      disabled BH.
      
      TCP stack no longer has this requirement and can run from
      process context.
      
      Use read_lock_bh() variant to restore previous assumption.
      
      Ideally this code could use RCU instead...
      
      Fixes: 5413d1ba ("net: do not block BH while processing socket backlog")
      Fixes: d41a69f1 ("tcp: make tcp_sendmsg() aware of socket backlog")
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Cc: Mike Christie <michaelc@cs.wisc.edu>
      Cc: Venkatesh Srinivas <venkateshs@google.com>
      Acked-by: default avatarMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7cb001d4
    • xypron.glpk@gmx.de's avatar
      net: pegasus: remove dead coding · e00be9e4
      xypron.glpk@gmx.de authored
      (!count || count < 4) is always true.
      So let's remove the coding which is dead at least since 2005.
      Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e00be9e4
    • xypron.glpk@gmx.de's avatar
      net: au1000 eth: simplify logical expression · 074ba1e2
      xypron.glpk@gmx.de authored
      (a && a > 0) is equivalent to (a > 0).
      Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      074ba1e2
    • xypron.glpk@gmx.de's avatar
      net: irda: avoid null pointer dereference · 30119059
      xypron.glpk@gmx.de authored
      Only dereference variable self after checking it is not NULL.
      Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      30119059
    • xypron.glpk@gmx.de's avatar
      net: ieee802154/adf7242: syntax error ifdef DEBUG · d1134128
      xypron.glpk@gmx.de authored
      If DEBUG is defined, a superfluous closing brace
      is introduced.
      Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d1134128
    • WANG Cong's avatar
      kcm: fix a signedness in kcm_splice_read() · f1971a2e
      WANG Cong authored
      skb_splice_bits() returns int, kcm_splice_read() returns ssize_t,
      both are signed.
      
      We may need another patch to make them all ssize_t, but that
      deserves a separated patch.
      
      Fixes: 91687355 ("kcm: Splice support")
      Reported-by: default avatarDavid Binderman <linuxdev.baldrick@gmail.com>
      Cc: Tom Herbert <tom@herbertland.com>
      Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f1971a2e
    • xypron.glpk@gmx.de's avatar
      net: ehea: avoid null pointer dereference · 1740c29a
      xypron.glpk@gmx.de authored
      ehea_get_port may return NULL. Do not dereference NULL value.
      
      Fixes: 8c4877a4 ("ehea: Use the standard logging functions")
      Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Acked-by: default avatarThadeu Lima de Souza Cascardo <cascardo@debian.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1740c29a
    • xypron.glpk@gmx.de's avatar
      net: thunderx: avoid null pointer dereference · 099a728d
      xypron.glpk@gmx.de authored
      In function bgx_lmac_handler only use a member of
      lmac after checking it is not null.
      Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
      Acked-by: default avatarDavid Daney <david.daney@cavium.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      099a728d
    • Linus Torvalds's avatar
      Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus · 07b75260
      Linus Torvalds authored
      Pull MIPS updates from Ralf Baechle:
       "This is the main pull request for MIPS for 4.7.  Here's the summary of
        the changes:
      
         - ATH79: Support for DTB passuing using the UHI boot protocol
         - ATH79: Remove support for builtin DTB.
         - ATH79: Add zboot debug serial support.
         - ATH79: Add initial support for Dragino MS14 (Dragine 2), Onion Omega
                  and DPT-Module.
         - ATH79: Update devicetree clock support for AR9132 and AR9331.
         - ATH79: Cleanup the DT code.
         - ATH79: Support newer SOCs in ath79_ddr_ctrl_init.
         - ATH79: Fix regression in PCI window initialization.
         - BCM47xx: Move SPROM driver to drivers/firmware/
         - BCM63xx: Enable partition parser in defconfig.
         - BMIPS: BMIPS5000 has I cache filing from D cache
         - BMIPS: BMIPS: Add cpu-feature-overrides.h
         - BMIPS: Add Whirlwind support
         - BMIPS: Adjust mips-hpt-frequency for BCM7435
         - BMIPS: Remove maxcpus from BCM97435SVMB DTS
         - BMIPS: Add missing 7038 L1 register cells to BCM7435
         - BMIPS: Various tweaks to initialization code.
         - BMIPS: Enable partition parser in defconfig.
         - BMIPS: Cache tweaks.
         - BMIPS: Add UART, I2C and SATA devices to DT.
         - BMIPS: Add BCM6358 and BCM63268support
         - BMIPS: Add device tree example for BCM6358.
         - BMIPS: Improve Improve BCM6328 and BCM6368 device trees
         - Lantiq: Add support for device tree file from boot loader
         - Lantiq: Allow build with no built-in DT.
         - Loongson 3: Reserve 32MB for RS780E integrated GPU.
         - Loongson 3: Fix build error after ld-version.sh modification
         - Loongson 3: Move chipset ACPI code from drivers to arch.
         - Loongson 3: Speedup irq processing.
         - Loongson 3: Add basic Loongson 3A support.
         - Loongson 3: Set cache flush handlers to nop.
         - Loongson 3: Invalidate special TLBs when needed.
         - Loongson 3: Fast TLB refill handler.
         - MT7620: Fallback strategy for invalid syscfg0.
         - Netlogic: Fix CP0_EBASE redefinition warnings
         - Octeon: Initialization fixes
         - Octeon: Add DTS files for the D-Link DSR-1000N and EdgeRouter Lite
         - Octeon: Enable add Octeon-drivers in cavium_octeon_defconfig
         - Octeon: Correctly handle endian-swapped initramfs images.
         - Octeon: Support CN73xx, CN75xx and CN78xx.
         - Octeon: Remove dead code from cvmx-sysinfo.
         - Octeon: Extend number of supported CPUs past 32.
         - Octeon: Remove some code limiting NR_IRQS to 255.
         - Octeon: Simplify octeon_irq_ciu_gpio_set_type.
         - Octeon: Mark some functions __init in smp.c
         - Octeon: Octeon: Add Octeon III CN7xxx interface detection
         - PIC32: Add serial driver and bindings for it.
         - PIC32: Add PIC32 deadman timer driver and bindings.
         - PIC32: Add PIC32 clock timer driver and bindings.
         - Pistachio: Determine SoC revision during boot
         - Sibyte: Fix Kconfig dependencies of SIBYTE_BUS_WATCHER.
         - Sibyte: Strip redundant comments from bcm1480_regs.h.
         - Panic immediately if panic_on_oops is set.
         - module: fix incorrect IS_ERR_VALUE macro usage.
         - module: Make consistent use of pr_*
         - Remove no longer needed work_on_cpu() call.
         - Remove CONFIG_IPV6_PRIVACY from defconfigs.
         - Fix registers of non-crashing CPUs in dumps.
         - Handle MIPSisms in new vmcore_elf32_check_arch.
         - Select CONFIG_HANDLE_DOMAIN_IRQ and make it work.
         - Allow RIXI to be used on non-R2 or R6 cores.
         - Reserve nosave data for hibernation
         - Fix siginfo.h to use strict POSIX types.
         - Don't unwind user mode with EVA.
         - Fix watchpoint restoration
         - Ptrace watchpoints for R6.
         - Sync icache when it fills from dcache
         - I6400 I-cache fills from dcache.
         - Various MSA fixes.
         - Cleanup MIPS_CPU_* definitions.
         - Signal: Move generic copy_siginfo to signal.h
         - Signal: Fix uapi include in exported asm/siginfo.h
         - Timer fixes for sake of KVM.
         - XPA TLB refill fixes.
         - Treat perf counter feature
         - Update John Crispin's email address
         - Add PIC32 watchdog and bindings.
         - Handle R10000 LL/SC bug in set_pte()
         - cpufreq: Various fixes for Longson1.
         - R6: Fix R2 emulation.
         - mathemu: Cosmetic fix to ADDIUPC emulation, plenty of other small fixes
         - ELF: ABI and FP fixes.
         - Allow for relocatable kernel and use that to support KASLR.
         - Fix CPC_BASE_ADDR mask
         - Plenty fo smp-cps, CM, R6 and M6250 fixes.
         - Make reset_control_ops const.
         - Fix kernel command line handling of leading whitespace.
         - Cleanups to cache handling.
         - Add brcm, bcm6345-l1-intc device tree bindings.
         - Use generic clkdev.h header
         - Remove CLK_IS_ROOT usage.
         - Misc small cleanups.
         - CM: Fix compilation error when !MIPS_CM
         - oprofile: Fix a preemption issue
         - Detect DSP ASE v3 support:1"
      
      * 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus: (275 commits)
        MIPS: pic32mzda: fix getting timer clock rate.
        MIPS: ath79: fix regression in PCI window initialization
        MIPS: ath79: make ath79_ddr_ctrl_init() compatible for newer SoCs
        MIPS: Fix VZ probe gas errors with binutils <2.24
        MIPS: perf: Fix I6400 event numbers
        MIPS: DEC: Export `ioasic_ssr_lock' to modules
        MIPS: MSA: Fix a link error on `_init_msa_upper' with older GCC
        MIPS: CM: Fix compilation error when !MIPS_CM
        MIPS: Fix genvdso error on rebuild
        USB: ohci-jz4740: Remove obsolete driver
        MIPS: JZ4740: Probe OHCI platform device via DT
        MIPS: JZ4740: Qi LB60: Remove support for AVT2 variant
        MIPS: pistachio: Determine SoC revision during boot
        MIPS: BMIPS: Adjust mips-hpt-frequency for BCM7435
        mips: mt7620: fallback to SDRAM when syscfg0 does not have a valid value for the memory type
        MIPS: Prevent "restoration" of MSA context in non-MSA kernels
        MIPS: cevt-r4k: Dynamically calculate min_delta_ns
        MIPS: malta-time: Take seconds into account
        MIPS: malta-time: Start GIC count before syncing to RTC
        MIPS: Force CPUs to lose FP context during mode switches
        ...
      07b75260