- 07 Jun, 2021 2 commits
-
-
Jonathan Cameron authored
Adds a stub needed to resolve a build conflict for the fxls8962af driver.
-
Jonathan Cameron authored
If I2C is not compiled, there is no way we should see a call to i2c_verify_client() on a device that is an i2c client. As such, provide a stub to return NULL to resolve an associated build failure. The build is failing with this link error ld: fxls8962af-core.o: in function `fxls8962af_fifo_transfer': fxls8962af-core.c: undefined reference to `i2c_verify_client' Reported-by:
Tom Rix <trix@redhat.com> Signed-off-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Fixes: af959b7b ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads") Reviewed-by:
Sean Nyekjaer <sean@geanix.com> Acked-by:
Wolfram Sang <wsa@kernel.org> Link: https://lore.kernel.org/r/20210603165835.3594557-1-jic23@kernel.org
-
- 04 Jun, 2021 1 commit
-
-
Jonathan Cameron authored
0-day recently added the include-what-you-use header checker and it gave a warning on an adis patch. As such I decided to run it on all the adis drivers and see if it made sensible suggestions. Note this doesn't represent a complete list of what it suggested changing as I filtered out a few on the basis they are standard headers used to effectively include a bunch of other headers. Could split this into a patch per driver if people prefer. Note to anyone else trying this tool is that it is somewhat of a loose cannon so you will be wanting to carefully check any suggestions before proposing patches! I thought about also reorganising the headers whilst here, but that would make this patch harder to read, or lead to another rather noisy patch across most of the files. Signed-off-by:
Alexandru Ardelean <ardeleanalex@gmail.com> Link: https://lore.kernel.org/r/20210603193616.3708447-1-jic23@kernel.org
-
- 03 Jun, 2021 30 commits
-
-
Stephan Gerhold authored
According to the BMA253 datasheet [1] and BMA250 datasheet [2] BMA25x also supports a bandwidth of 500 Hz and 1000 Hz but this was not listed in the driver for some reason. Add it to the bw_table to make the driver match the datasheet. [1]: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bma253-ds000.pdf [2]: https://datasheet.octopart.com/BMA250-Bosch-datasheet-15540103.pdf Cc: Peter Meerwald <pmeerw@pmeerw.net> Signed-off-by:
Stephan Gerhold <stephan@gerhold.net> Reviewed-by:
Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20210526094408.34298-3-stephan@gerhold.netSigned-off-by:
-
Jarkko Nikula authored
Add support for Intel Quadrature Encoder Peripheral found on Intel Elkhart Lake platform. Initial implementation was done by Felipe Balbi while he was working at Intel with later changes from Raymond Tan and me. Co-developed-by:
Felipe Balbi (Intel) <balbi@kernel.org> Signed-off-by:
Raymond Tan <raymond.tan@intel.com> Signed-off-by:
Jarkko Nikula <jarkko.nikula@linux.intel.com> Acked-by:
William Breathitt Gray <vilhelm.gray@gmail.com> Link: https://lore.kernel.org/r/20210602113259.158674-1-jarkko.nikula@linux.intel.comSigned-off-by:
-
Lucas Stankus authored
Refactor the capdac register write logic to own function. Also fixes the following checkpatch warning: CHECK: Alignment should match open parenthesis Signed-off-by:
Lucas Stankus <lucas.p.stankus@gmail.com> Reviewed-by:
-
Lucas Stankus authored
Slight simplication of the probe return on device register. Signed-off-by:
-
Lucas Stankus authored
Remove ordinary comments about typical driver structure. Also align one comment with wrong indentation. Signed-off-by:
-
Jonathan Cameron authored
Simplifies error handling and allows us to drop remove entirely. The regulator handling in this driver was unusual as it would try to acquire the regulator, but if that failed with an error would continue. We should get a stub regulator if one isn't provided in DT and an error could indicate an actual problem preventing the device being powered (perhaps a need to defer). So this handling is cleaned up (arguably that might be a fix but given no one has run into it, I haven't broken it out separately. Signed-off-by:
Matt Ranostay <matt.ranostay@konsulko.com> Reviewed-by:
Alexandru Ardelean <aardelean@deviqon.com> Link: https://lore.kernel.org/r/20210516172520.1398835-9-jic23@kernel.org
-
Jonathan Cameron authored
Simplifies error handling and lets us drop remove() entirely. Signed-off-by:
-
Jonathan Cameron authored
Simplifies error handling, plus allows us to drop the remove() function entirely. Signed-off-by:
-
Jonathan Cameron authored
Simplifies error handling and allows us to drop remove() entirely. Signed-off-by:
-
Jonathan Cameron authored
Changing from passing the spi structure into various functions to passing struct iio_dev avoids use of spi_get_drvdata and lets us stop setting that at all. Previous code was unnecessarily complex. Signed-off-by:
-
Jonathan Cameron authored
This simplifies error handling and allows us to drop the remove function entirely. Signed-off-by:
-
Jonathan Cameron authored
By using devm_add_action_or_reset() to manage the regulator disable, it becomes simple to use managed functions for all of remove. This simplifies error handling and allows us to drop the remove() function entirely. Signed-off-by:
-
Jonathan Cameron authored
The function is more explicit in showing the intent + quicker on some platforms. Signed-off-by:
-
Jonathan Cameron authored
Since: commit cbacb5ab ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") use of these format strings has been discouraged. As there are only a few such uses in IIO, lets clear them all out and avoid chance of them getting copied into new drivers. Signed-off-by:
Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/r/20210517125554.1463156-5-jic23@kernel.org
-
Linus Walleij authored
Add support to read and present the mounting matrix on ST gyroscopes. Cc: Denis Ciocca <denis.ciocca@st.com> Cc: Daniel Drake <drake@endlessm.com> Cc: Stephan Gerhold <stephan@gerhold.net> Reviewed-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20210518230722.522446-5-linus.walleij@linaro.orgSigned-off-by:
-
Linus Walleij authored
Add support to read and present the mounting matrix on ST magnetometers. Cc: Denis Ciocca <denis.ciocca@st.com> Cc: Daniel Drake <drake@endlessm.com> Cc: Stephan Gerhold <stephan@gerhold.net> Reviewed-by:
-
Linus Walleij authored
The channels were copied only so that the .ext_info member should become assignable. We now have compile-time static assignment so drop this code. Cc: Hans de Goede <hdegoede@redhat.com> Cc: Denis Ciocca <denis.ciocca@st.com> Cc: Daniel Drake <drake@endlessm.com> Reviewed-by:
-
Linus Walleij authored
The ST accelerators support a special type of quirky mounting matrix found in ACPI systems, but not a generic mounting matrix such as from the device tree. Augment the ACPI hack to be a bit more generic and accept a mounting matrix from device properties. This makes it possible to fix orientation on the Ux500 HREF device. Cc: Hans de Goede <hdegoede@redhat.com> Cc: Denis Ciocca <denis.ciocca@st.com> Cc: Daniel Drake <drake@endlessm.com> Reviewed-by:
-
Linus Walleij authored
Extend ST_SENSORS_LSM_CHANNELS() to a version that will accept extended attributes named ST_SENSORS_LSM_CHANNELS_EXT() and wrap the former as a specialized version of the former. Cc: Hans de Goede <hdegoede@redhat.com> Cc: Denis Ciocca <denis.ciocca@st.com> Cc: Daniel Drake <drake@endlessm.com> Reviewed-by:
-
Nuno Sá authored
Use the adis lib lock helpers to lock the device. This makes things consistent with other users of the library. Signed-off-by:
Nuno Sá <nuno.sa@analog.com> Link: https://lore.kernel.org/r/20210520115909.466275-3-nuno.sa@analog.comSigned-off-by:
-
Nuno Sá authored
Use the adis lib lock helpers to lock the device. This makes things consistent with other users of the library. Signed-off-by:
-
Lucas Stankus authored
Ditch platform_data fields in favor of device tree properties for configuring EXCA and EXCB output pins and setting the capacitive channel excitation level. As this covers all current use cases for the platform_data struct, remove ad7746.h header file since it's no longer needed. Signed-off-by:
-
Lucas Stankus authored
Add device tree binding documentation for AD7746 cdc in YAML format. Signed-off-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/2c2f4d486a94e0740e112bfac0d9306bdb7ea69c.1619841953.git.lucas.p.stankus@gmail.comSigned-off-by:
-
Linus Walleij authored
It happens that an ADC will only provide raw or processed voltage conversion channels. (adc/ab8500-gpadc.c). On the Samsung GT-I9070 this is used for a light sensor and current sense amplifier so we need to think of something. The idea is to allow processed channels and scale them with 1/1 and then the rescaler can modify the result on top. Link: https://lore.kernel.org/linux-iio/20201101232211.1194304-1-linus.walleij@linaro.org/ Cc: Peter Rosin <peda@axentia.se> Signed-off-by:
Peter Rosin <peda@axentia.se> Link: https://lore.kernel.org/r/20210518092741.403080-1-linus.walleij@linaro.orgSigned-off-by:
-
Tang Bin authored
In the function ad7746_probe(), the initialized value of 'ret' is unused, because it will be assigned by the function i2c_smbus_write_byte_data(), thus remove it. Signed-off-by:
Tang Bin <tangbin@cmss.chinamobile.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20210518095647.3008-1-tangbin@cmss.chinamobile.comSigned-off-by:
-
Andy Shevchenko authored
All of the users of iio_read_mount_matrix() are using the very same property name. Moreover, the property name is hard coded in the API documentation. Make this clear and avoid duplication now and in the future. Signed-off-by:
-
Nuno Sa authored
Some supported devices support burst read function. This provides a method for reading a batch of data (status, temperature, gyroscopes, accelerometers, time stamp/data counter, and CRC code), which does not require a stall time between each 16-bit segment and only requires one command on the DIN line to initiate. Devices supporting this mode are: * adis16495-1 * adis16495-2 * adis16495-3 * adis16497-1 * adis16497-2 * adis16497-3 Reviewed-by:
Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:
-
Jiapeng Chong authored
Variable in_loc is being assigned a value from a calculation however the assignment is never read, so this redundant assignment can be removed. Clean up the following clang-analyzer warning: drivers/iio/industrialio-buffer.c:929:3: warning: Value stored to 'in_loc' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by:
Abaci Robot <abaci@linux.alibaba.com> Signed-off-by:
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Link: https://lore.kernel.org/r/1621246317-62725-1-git-send-email-jiapeng.chong@linux.alibaba.comSigned-off-by:
-
Jonathan Cameron authored
The call to pm_runtime_put_noidle() in remove() callback is not balanced by any gets Note this doesn't cause any problems beyond reader confusion as the runtime pm core protects against the reference counter going negative. Whilst here, use pm_runtiem_resume_and_get() to simplify code a little. Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/20210509113354.660190-9-jic23@kernel.org
-
Dan Carpenter authored
These variables are unsigned so the condition can't be less than zero and the warning message will never be printed. Fixes: 9374e8f5 ("iio: adc: add ADC driver for the TI TSC2046 controller") Signed-off-by:
-
- 17 May, 2021 7 commits
-
-
Dan Carpenter authored
This return statement is indented one more tab than it should be. Signed-off-by:
-
Dan Carpenter authored
These variables need to be int for the error handling to work. Fixes: 2335f0d7 ("iio: light: Added AMS tsl2591 driver implementation") Signed-off-by:
-
Tang Bin authored
In the function ad7766_probe(), the return value of devm_iio_device_register() can be zero or ret, Thus it is unnecessary to repeated check here. Signed-off-by:
Zhang Shengju <zhangshengju@cmss.chinamobile.com> Co-developed-by:
-
Dan Carpenter authored
The devm_iio_device_alloc() function is supposed to return NULL and not error pointers. Returning an error pointer will lead to a crash in the callers. Fixes: cf5724e9 ("iio: core: simplify some devm functions") Signed-off-by:
-
Jonathan Cameron authored
Found using coccicheck script under review at: https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ This is a prequel to taking a closer look at the runtime pm in IIO drivers in general. Signed-off-by:
-
Jonathan Cameron authored
Add __aligned(8) to ensure the buffer passed to iio_push_to_buffers_with_timestamp() is suitable for the naturally aligned timestamp that will be inserted. Here structure is not used, because this buffer is also used elsewhere in the driver. Fixes: 67e17300 ("iio: potentiostat: add LMP91000 support") Signed-off-by:
-
Jonathan Cameron authored
The samples buffer is passed to iio_push_to_buffers_with_timestamp() which requires a buffer aligned to 8 bytes as it is assumed that the timestamp will be naturally aligned if present. Fixes tag is inaccurate but prior to that likely manual backporting needed (for anything before 4.18) Earlier than that the include file to fix is drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h: commit 974e6f02 ("iio: cros_ec_sensors_core: Add common functions for the ChromeOS EC Sensor Hub.") present since kernel stable 4.10. (Thanks to Gwendal for tracking this down) Fixes: 5a0b8cb4 ("iio: cros_ec: Move cros_ec_sensors_core.h in /include") Signed-off-by:
-
