- 11 Oct, 2011 28 commits
-
-
Larry Finger authored
Array XGrpKey has only 2 elements and uses (keyid - 1) as the index, which allows the possibility of memory corruption from an out-of-bounds index. This problem was reported by a new version of smatch. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Seth Jennings authored
In the case that a cpu is taken offline before zcache_do_preload() is ever called on the cpu, the per-cpu zcache_preloads structure will be uninitialized. In the CPU_DEAD case for zcache_cpu_notifier(), kp->obj is not checked before calling kmem_cache_free() on it. If it is NULL, a crash results. This patch ensures that both kp->obj and kp->page are not NULL before calling the respective free functions. In practice, just checking one or the other should be sufficient since they are assigned together in zcache_do_preload(), but I check both for safety. Signed-off-by:
Seth Jennings <sjenning@linux.vnet.ibm.com> Acked-by:
Dave Hansen <dave@linux.vnet.ibm.com> Signed-off-by:
-
Dan Carpenter authored
The '!' is dead code that was left over from a previous version. It causes a compiler warning: drivers/staging/dt3155v4l/dt3155v4l.c:335:3: warning: value computed is not used Signed-off-by:
-
Thomas Petazzoni authored
Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Lars-Peter Clausen authored
Commit c6fc8062 ("staging:iio: ABI rework - add in_ or out_ prefix to channnels") added the AD5868_CHANNEL macro to simplify channel initialization. Unfortunately the macro hardcodes the channel's address to AD5686_ADDR_DAC0. As a result writing to any of the channels will change the value of the first channel. This patch fixes the issue by calculating the channel address based on the channel number. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Jonathan Cameron authored
We had a random missmatch of these two. Lets pick the most common and get rid of the other. Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Signed-off-by:
-
Jonathan Cameron authored
We had a random missmatch of these two. Lets pick the most common and get rid of the other. Signed-off-by:
-
Jonathan Cameron authored
Again, there is a mix of the two names for the struct iio_dev. Lets pick one and run with it. Signed-off-by:
-
Jonathan Cameron authored
We had a random missmatch of these two. Lets pick the most common and get rid of the other. This patch covers the core. Others will clean up the drivers. Signed-off-by:
-
Dan Carpenter authored
The error_ret label should have been before the mutex_unlock(). It's a typo. Signed-off-by:
-
Dan Carpenter authored
This fixes a compile warning: drivers/staging/iio/light/tsl2563.c:696:2: warning: initialization from incompatible pointer type [enabled by default] drivers/staging/iio/light/tsl2563.c:696:2: warning: (near initialization for ‘tsl2563_info.write_event_value’) [enabled by default] The tsl2563_write_thresh() function returns zero on success and error codes on failure, so nothing is lost by making the return type int instead of ssize_t. Signed-off-by:
-
Dan Carpenter authored
We need to unlock here before returning. Signed-off-by:
-
Greg Kroah-Hartman authored
This is only used/needed by the vmbus core code, so move it out of the hyperv.h file and into the .c file that uses it. Signed-off-by: -
Greg Kroah-Hartman authored
This function is only used in the file it is declared in (channel_mgmt.c) so make it static and remove it from the hyperv.h file. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
This file was created by mushing different .h files together and it shows. This change removes some unneeded forward declarations. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
I have no idea what these were ever for, but they aren't used, so delete them. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
They aren't used anywhere anymore now that the debugging macros are gone, so remove it from hyperv.h as well. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
As there is no user of this variable, it's time to delete it. For dynamic debugging of the hyperv code, use the standard dynamic debug kernel interface. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
This also removed the unused function hv_dump_ring_info(). Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Used the correct dev_warn() call instead. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
These aren't used by anyone anymore, so remove them before someone tries to use them again. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
It's a global symbol, so properly prefix it and use the proper EXPORT value as well. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
No one outside of the hyperv core needs to include the asm/hyperv.h file, so don't put it in the "global" include/linux/hyperv.h file. Cc: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
After many years wandering the desert, it is finally time for the Microsoft HyperV code to move out of the staging directory. Or at least the core hyperv bus code, and the utility driver, the rest still have some review to get through by the various subsystem maintainers. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com>
-
K. Y. Srinivasan authored
net_dev is being de-referenced without proper checking; fix it. Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Reported-by:
-
Olaf Hering authored
Some commands sent by smartd will offline the device. With this change applied, smartd sill not monitor the device anymore. Signed-off-by:
Olaf Hering <olaf@aepfle.de> Acked-by:
-
K. Y. Srinivasan authored
Invoke cn_netlink_send() in a work context as opposed being called in the context of channel callback. On entry into the channel callback code the channel inbound spin lock is held and deferring to a work context avoids having to invoke cn_netlink_send() while holding the inbound lock. As part of this adjustment, also increase the timeout value for waiting for the user level component of KVP. Signed-off-by:
-
K. Y. Srinivasan authored
The host gurantees that there can be only one kvp transaction active against the guest. So, the transaction active state is needed only to protect against spurious user level calls. The current code had a race condition where the guest could prematurely return because the previous transaction state was not cleared - this state was being cleared after sending the response to the host and there was a window where the host could notify the guest of a new transaction before the transaction active state was properly set. Also deal with the case when the user mode component does not respond in a timely fashion correctly. I would like to thank Long Li <longli@microsoft.com> for identifying the problem. Signed-off-by:
Long Li <longli@microsoft.com> Signed-off-by:
-
- 05 Oct, 2011 12 commits
-
-
Jonathan Cameron authored
Basically make use of the gpio array functions. Technically the free doesn't need as much info as given here, but this keeps it clean and easy to follow. Signed-off-by:
-
Jonathan Cameron authored
This should never have been exposed to userspace Signed-off-by:
-
Jonathan Cameron authored
Just convert the raw reads in this patch. Signed-off-by:
-
Jonathan Cameron authored
This is needed to ensure the required name attribute is created. Using an id table is the route most consistent with other drivers. Signed-off-by:
-
Jonathan Cameron authored
There are far too many possible part numbers that are not covered in here to have such a generic name. So move to naming after one of the supported parts. Signed-off-by:
-
Jonathan Cameron authored
Straight forward conversion. Signed-off-by:
-
Jonathan Cameron authored
Follows directly from change made in previous patch. Signed-off-by:
-
Jonathan Cameron authored
Ensure naming reflects what is measured, not how it is done. Resolvers can measure the same thing for starters. IIO_GYRO->IIO_ANGL_VEL to ensure consistent naming. Signed-off-by:
-
Jonathan Cameron authored
Trivial conversion. Signed-off-by:
-
Jonathan Cameron authored
Scraps the pointless name define and adds an id table. It's not technically required in drivers with only one supported part but it does make the probe code more consistent. Signed-off-by:
-
Jonathan Cameron authored
When the new allocation code was introduced a stray pointer to iio_dev structure was left in the chip state structure. This was never set but was then registered with the core. Signed-off-by:
-
Jonathan Cameron authored
No functional change, just a trivial tidy up so all drivers do the same thing. Signed-off-by:
-
