- 19 Jun, 2012 14 commits
-
-
Miguel Gómez authored
Replace meaninful printks with pr_debug and remove useless ones. Signed-off-by:
Miguel Gómez <magomez@igalia.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Miguel Gómez authored
XGIFAIL() prints a message and returns a value, but it's used only in one place. Better remove it and replace the call with the macro content. Signed-off-by:
-
Miguel Gómez authored
Define real content of dumpVGAReg() only in debug mode. Remove old condition. Signed-off-by:
-
Miguel Gómez authored
Signed-off-by:
-
Miguel Gómez authored
Remove DEBUGPRN() macro which is defined as empty. Signed-off-by:
-
Miguel Gómez authored
Signed-off-by:
-
H Hartley Sweeten authored
The 'io_bits' variable in the comedi_subdevice struct is a bitmask of the input/output configuration of the the subdevice. It should be an unsigned int to correctly represent this. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Cc: Frank Mori Hess: <fmhess@users.sourceforge.net> Signed-off-by:
-
H Hartley Sweeten authored
The comedi_subdevice 'insn_bits' functions return the number of data elements used to perform the command. Most of the insn_bits functions return an open coded '2' to indicate this. The same value is available as 'insn->n'. Return that instead to better indicate what the return means. Signed-off-by:
-
H Hartley Sweeten authored
The comedi core does the sanity check to make sure that the data length the INSN_BITS instruction is 2. There is no need for the drivers to do this check. Remove all the sanity checks in the drivers. Signed-off-by:
-
Ian Abbott authored
Change the usbduxsigma driver to use the new attach_usb() hook in struct comedi_driver to auto-configure probed USB devices after the firmware is loaded. Move the release of the driver's static 'start_stop_sem' semaphore in usbduxsigma_attach() to occur a bit later for convenience, otherwise the new usbduxsigma_attach_common() would need to be split in two. I don't think the slight delay in releasing the semaphore matters too much; it's only used in the USB probe and disconnect functions and when attaching and detaching comedi devices. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
Change the vmv80xx driver to use the new attach_usb() hook in struct comedi_driver to auto-configure probed USB devices after the firmware is loaded. Signed-off-by:
-
Ian Abbott authored
Change the usbduxfast driver to use the new attach_usb() hook in struct comedi_driver to auto-configure probed USB devices after the firmware is loaded. Signed-off-by:
-
Ian Abbott authored
A previous set of patches by Ravishankar Karkala Mallikarjunayya replaced a load of printk() calls with dev_info(), dev_err(), etc. Unfortunately, these used the 'struct device *hw_dev' member of 'struct comedi_device') as the first parameter of these dev_...() calls, but that pointer is usually NULL, so the kernel log messages come out a bit wrong (they contain the phrase "(NULL device *)"). Use the 'struct device *class_dev' member of 'struct comedi_device' instead for these dev_...() calls. It will be non-NULL and somewhat meaningful to users. It's also consistent with those comedi drivers that already use the class_dev member in their dev_...() calls. Some of the messages included the format "comedi%d" with the minor device number used for the "%d". This is now redundant as it will be the same as the dev_name() part of the kernel log message produced by the dev_...() calls. Signed-off-by:
-
Christopher Brannon authored
A local static variable was declared as a pointer to a string constant. We're assigning to the underlying memory, so it needs to be an array instead. Signed-off-by:
Christopher Brannon <chris@the-brannons.com> Signed-off-by:
-
- 15 Jun, 2012 26 commits
-
-
H Hartley Sweeten authored
The depends on PCCARD is redundant. All of the comedi PCMCIA drivers depend on PCMCIA which can only be enabled if PCCARD is enabled. Remove the extra depends check. Signed-off-by:
Randy Dunlap <rdunlap@xenotime.net> Acked-by:
-
Lars-Peter Clausen authored
iio_scan_mask_match() returns NULL if the passed in scan mask is empty. This will happen if no channel has been selected and buffer is enabled. iio_sw_buffer_preenable() will assign NULL to indio_dev->active_scan_mask in this case. As a result iio_update_demux() will cause a NULL pointer deref, because it expects active_scan_mask to be non-NULL. Since it does not make much sense to start data capture if there is no data to capture this patch updates the code to fail gracefully in iio_scan_mask_match() instead of crashing the kernel. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
Jonathan Cameron <jic23@kernel.org> Signed-off-by:
-
Peter Meerwald authored
Signed-off-by:
Peter Meerwald <pmeerw@pmeerw.net> Acked-by:
-
Peter Meerwald authored
typos in comments, fix ring_sw module description Signed-off-by:
-
Peter Meerwald authored
IIO_ALTVOLTAGE is used by frequency/adf4350 and frequency/ad9523 Signed-off-by:
-
Peter Meerwald authored
Signed-off-by:
-
Peter Meerwald authored
Signed-off-by:
-
Peter Meerwald authored
Signed-off-by:
-
Lars-Peter Clausen authored
None of these drivers ever schedule any work, so there is no need to flush any scheduled work when the driver is removed. Signed-off-by:
-
Peter Meerwald authored
Signed-off-by:
-
Lars-Peter Clausen authored
The ADIS163xx variants use a different register address for the auxiliary ADC channel than the ADIS16400. This patch fixes them to use the correct address. Signed-off-by:
-
Lars-Peter Clausen authored
The channel spec for ADUS16334's temperature channel uses the address and scan index for the Z-axis acceleration channel. This patch fixes it to use the temperature channel address and scan index instead. Signed-off-by:
-
Lars-Peter Clausen authored
The ADIS16300 uses the same address for the temperature register as the ADIS16350 and not the same as the ADIS16400. Signed-off-by:
-
Lars-Peter Clausen authored
In the current driver ROLL_OUT register address is the same as the PITCH_OUT register address. This patch fixes it to use the correct address. Signed-off-by:
-
Axel Lin authored
Signed-off-by:
Axel Lin <axel.lin@gmail.com> Acked-by:
-
Leed Aguilar authored
Removed the following sparse warning: In function 'adis16080_read_raw': warning: 'ut' may be used uninitialized in this function Signed-off-by:
Leed Aguilar <leed.aguilar@ti.com> Acked-by:
-
H Hartley Sweeten authored
The PDEBUG macro is used to output a bunch of debug messages in the driver. These messages might be useful when first creating the driver but they shouldn't be in mainline. Remove it. Signed-off-by:
-
H Hartley Sweeten authored
The ISR_PDEBUG macro is used to output trace messages in the isr routine. This shouldn't be in a mainline driver. Remove it. Signed-off-by:
-
H Hartley Sweeten authored
With the PORT_PDEBUG macro remove we can now remove the inline port io wrappers. Signed-off-by:
-
H Hartley Sweeten authored
The PORT_PDEBUG macro is used to output the result of every port io operation. This shouldn't be in a mainline driver. Remove it. Signed-off-by:
-
H Hartley Sweeten authored
The CALL_PDEBUG macro is used to do function tracing in the driver. There are better ways to do this. Remove it. Signed-off-by:
-
H Hartley Sweeten authored
The PCL812_EXTDEBUG define enables a bunch of function tracing debug messages as well as a dump of the comedi_cmd info during the cmdtest. There are better ways to do the function tracing and the cmdtest dump shouldn't be in the driver. Just remove all of it. Signed-off-by:
-
H Hartley Sweeten authored
The step 2 tests to make sure that the triggers are unique is not needed for single source triggers. These were already trivially validated in step 1. Signed-off-by:
-
H Hartley Sweeten authored
The step 2 tests of the start_src, scan_begin_src, and scan_end_src triggers to make sure they are unique are not needed. These triggers all only have one source and it was trivially validated in step 1. Signed-off-by:
-
H Hartley Sweeten authored
The step 2 tests of the start_src, scan_begin_src, and scan_end_src triggers to make sure they are unique are not needed. These triggers all only have one source and it was trivially validated in step 1. Signed-off-by:
-
H Hartley Sweeten authored
These printk's are #ifdef'ed out with an undefined symbol anyway. Just remove them. Signed-off-by:
-
