1. 09 Apr, 2020 4 commits
  2. 08 Apr, 2020 23 commits
  3. 07 Apr, 2020 11 commits
  4. 06 Apr, 2020 2 commits
    • Lyude Paul's avatar
      drm/dp_mst: Don't drop NAKs for down responses · 61272e47
      Lyude Paul authored
      It looks like that when we introduced the ability to handle multiple
      down requests at once, we accidentally started dropping NAK replies -
      causing sideband messages which got NAK'd to seemingly timeout and cause
      all sorts of weirdness.
      
      So, fix this by making sure we don't return from
      drm_dp_mst_handle_down_rep() early, but instead treat NAKs like any
      other message.
      Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
      Fixes: fbc821c4 ("drm/mst: Support simultaneous down replies")
      Cc: Wayne Lin <Wayne.Lin@amd.com>
      Cc: Wayne Lin <waynelin@amd.com>
      Cc: Sean Paul <seanpaul@chromium.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200403200325.885628-1-lyude@redhat.comReviewed-by: default avatarSean Paul <sean@poorly.run>
      61272e47
    • Lyude Paul's avatar
      drm/dp_mst: Fix NULL deref in drm_dp_get_one_sb_msg() · cbfb1b74
      Lyude Paul authored
      While we don't need this function to store an mstb anywhere for UP
      requests since we process them asynchronously, we do need to make sure
      that we don't try to write to **mstb for UP requests otherwise we'll
      cause a NULL pointer deref:
      
          RIP: 0010:drm_dp_get_one_sb_msg+0x4b/0x460 [drm_kms_helper]
          Call Trace:
           ? vprintk_emit+0x16a/0x230
           ? drm_dp_mst_hpd_irq+0x133/0x1010 [drm_kms_helper]
           drm_dp_mst_hpd_irq+0x133/0x1010 [drm_kms_helper]
           ? __drm_dbg+0x87/0x90 [drm]
           ? intel_dp_hpd_pulse+0x24b/0x400 [i915]
           intel_dp_hpd_pulse+0x24b/0x400 [i915]
           i915_digport_work_func+0xd6/0x160 [i915]
           process_one_work+0x1a9/0x370
           worker_thread+0x4d/0x3a0
           kthread+0xf9/0x130
           ? process_one_work+0x370/0x370
           ? kthread_park+0x90/0x90
           ret_from_fork+0x35/0x40
      
      So, fix this.
      Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
      Fixes: fbc821c4 ("drm/mst: Support simultaneous down replies")
      Cc: Wayne Lin <Wayne.Lin@amd.com>
      Cc: Lyude Paul <lyude@redhat.com>
      Cc: Wayne Lin <waynelin@amd.com>
      Cc: Sean Paul <seanpaul@chromium.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200406193352.1245985-1-lyude@redhat.comReviewed-by: default avatarSean Paul <sean@poorly.run>
      cbfb1b74