1. 02 Dec, 2022 1 commit
    • Li Zetao's avatar
      ACPICA: Fix use-after-free in acpi_ut_copy_ipackage_to_ipackage() · 470188b0
      Li Zetao authored
      There is an use-after-free reported by KASAN:
      
        BUG: KASAN: use-after-free in acpi_ut_remove_reference+0x3b/0x82
        Read of size 1 at addr ffff888112afc460 by task modprobe/2111
        CPU: 0 PID: 2111 Comm: modprobe Not tainted 6.1.0-rc7-dirty
        Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
        Call Trace:
         <TASK>
         kasan_report+0xae/0xe0
         acpi_ut_remove_reference+0x3b/0x82
         acpi_ut_copy_iobject_to_iobject+0x3be/0x3d5
         acpi_ds_store_object_to_local+0x15d/0x3a0
         acpi_ex_store+0x78d/0x7fd
         acpi_ex_opcode_1A_1T_1R+0xbe4/0xf9b
         acpi_ps_parse_aml+0x217/0x8d5
         ...
         </TASK>
      
      The root cause of the problem is that the acpi_operand_object
      is freed when acpi_ut_walk_package_tree() fails in
      acpi_ut_copy_ipackage_to_ipackage(), lead to repeated release in
      acpi_ut_copy_iobject_to_iobject(). The problem was introduced
      by "8aa5e56e" commit, this commit is to fix memory leak in
      acpi_ut_copy_iobject_to_iobject(), repeatedly adding remove
      operation, lead to "acpi_operand_object" used after free.
      
      Fix it by removing acpi_ut_remove_reference() in
      acpi_ut_copy_ipackage_to_ipackage(). acpi_ut_copy_ipackage_to_ipackage()
      is called to copy an internal package object into another internal
      package object, when it fails, the memory of acpi_operand_object
      should be freed by the caller.
      
      Fixes: 8aa5e56e ("ACPICA: Utilities: Fix memory leak in acpi_ut_copy_iobject_to_iobject")
      Signed-off-by: default avatarLi Zetao <lizetao1@huawei.com>
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      470188b0
  2. 08 Nov, 2022 3 commits
  3. 03 Nov, 2022 1 commit
  4. 28 Oct, 2022 12 commits
  5. 23 Oct, 2022 9 commits
  6. 22 Oct, 2022 14 commits