- 05 Mar, 2024 2 commits
-
-
Colin Ian King authored
The variable mask is being assigned and bit-set but it is never being used apart from this. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/staging/greybus/audio_topology.c:764:15: warning: variable 'mask' set but not used [-Wunused-but-set-variable] Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Acked-by:
Vaibhav Agarwal <vaibhav.sr@gmail.com> Link: https://lore.kernel.org/r/20240229120541.219429-1-colin.i.king@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Erick Archer authored
When a struct containing a flexible array is included in another struct, and there is a member after the struct-with-flex-array, there is a possibility of memory overlap. These cases must be audited [1]. See: struct inner { ... int flex[]; }; struct outer { ... struct inner header; int overlap; ... }; This is the scenario for the "struct audio_apbridgea_hdr" structure that is included in the following "struct audio_apbridgea_*_request" structures: struct audio_apbridgea_set_config_request struct audio_apbridgea_register_cport_request struct audio_apbridgea_unregister_cport_request struct audio_apbridgea_set_tx_data_size_request struct audio_apbridgea_prepare_tx_request struct audio_apbridgea_start_tx_request struct audio_apbridgea_stop_tx_request struct audio_apbridgea_shutdown_tx_request struct audio_apbridgea_set_rx_data_size_request struct audio_apbridgea_prepare_rx_request struct audio_apbridgea_start_rx_request struct audio_apbridgea_stop_rx_request struct audio_apbridgea_shutdown_rx_request The pattern is like the one shown below: struct audio_apbridgea_hdr { ... __u8 data[]; } __packed; struct audio_apbridgea_*_request { struct audio_apbridgea_hdr hdr; ... } __packed; In this case, the trailing flexible array can be removed because it is never used. Link: https://github.com/KSPP/linux/issues/202 [1] Signed-off-by:Erick Archer <erick.archer@gmx.com> Reviewed-by:
Alex Elder <elder@linaro.org> Acked-by:
Mark Greer <mgreer@animalcreek.com> Link: https://lore.kernel.org/r/20240217154758.7965-1-erick.archer@gmx.comSigned-off-by:
-
- 19 Feb, 2024 2 commits
-
-
Marc Dietrich authored
replace old/implemented items with new todo list Signed-off-by:
Marc Dietrich <marvin24@gmx.de> Link: https://lore.kernel.org/r/20240218212557.22836-2-marvin24@gmx.deSigned-off-by:
-
Marc Dietrich authored
Update the comment before the udelay on how to replace it. Signed-off-by:
-
- 17 Feb, 2024 26 commits
-
-
Ricardo B. Marliere authored
Since commit aed65af1 ("drivers: make device_type const"), the driver core can properly handle constant struct device_type. Move the wwan_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Signed-off-by:
Ricardo B. Marliere <ricardo@marliere.net> Link: https://lore.kernel.org/r/20240217-device_cleanup-staging-v1-1-286479d9a3f0@marliere.netSigned-off-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the vme_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the vchiq_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the anybus_bus variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Christophe JAILLET authored
sysfs_read() is anly called from _show() functions declared by DEVICE_ATTR_RW(). Using sysfs_emit() is the preferred style and here, it saves a useless copy and a temporary buffer in the stack. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/588327734f374b5f5cb5c4d5725d884fdc83663e.1707654406.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
Michael Straube authored
Initialize two variables at declaration instead of first declare and then initialize them. This saves a line of code and clears a checkpatch warning. WARNING: Missing a blank line after declarations Signed-off-by:
Michael Straube <straube.linux@gmail.com> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240201081824.6998-4-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Remove return from the void function rtl92e_set_channel. Found by checkpatch. WARNING: void function return statements are not generally useful Signed-off-by:
-
Michael Straube authored
Remove braces from single statement blocks to clear some checkpatch warnings. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Tree Davies authored
Rename variable bForcedBgMode to forced_bg_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-19-tdavies@darkphysics.netSigned-off-by:
-
Tree Davies authored
Rename variable NumRecvBcnInPeriod to num_recv_bcn_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LpsIdleCount to lps_idle_count to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable Octet to octet to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Add a space in front of statement to fix checkpatch warning: Alignment should match open parenthesis Signed-off-by:
-
Tree Davies authored
Remove blank line to fix checkpatch warning: Blank lines aren't necessary before a close brace '}' Signed-off-by:
-
Tree Davies authored
Join broken lines across if statement to fix checkpatch warning: Lines should not end with a '(' Signed-off-by: -
Tree Davies authored
Join 2 lines to fix Warning: Alignment should match open parenthesis Signed-off-by:
-
Tree Davies authored
Rename variable SelfHTCap to self_ht_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LPSAwakeIntvl to lps_awake_intvl to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable PeerHTInfoBuf to peer_ht_info_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable PeerHTCapBuf to peer_ht_cap_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function MgntQuery_TxRateExcludeCCKRates to mgnt_query_tx_rate_exclude_cck_rates to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function pointer SetHwRegHandler to set_hw_reg_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LPSDelayCnt to lps_delay_cnt to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LPSAwakeIntvl_tmp to lps_awake_intvl_tmp to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function rtllib_rx_ADDBARsp to rtllib_rx_add_ba_rsp to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable FirstIe_InScan to first_ie_in_scan to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
- 24 Jan, 2024 10 commits
-
-
Geert Uytterhoeven authored
There are no more users of the board staging code. Signed-off-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Link: https://lore.kernel.org/r/eec1bfb2878237888a8c3bc866d18dc53900739f.1705932585.git.geert+renesas@glider.beSigned-off-by:
-
Geert Uytterhoeven authored
Since commits 1399ebac ("drm: renesas: shmobile: Add DT support"), 138588e9 ("ARM: dts: renesas: r8a7740: Add LCDC nodes"), and c9a0ed13 ("ARM: dts: renesas: armadillo800eva: Add LCD panel"), there is no longer any use for the Atmark Techno Armadillo-800-EVA board staging code. Signed-off-by:
-
Geert Uytterhoeven authored
With the EMMA Mobile USB Gadget staging driver removed, there is no longer any use for the EMEV2 KZM9D board staging code. Signed-off-by:
Niklas Söderlund <niklas.soderlund@ragnatech.se> Link: https://lore.kernel.org/r/f54fe56524e0266a3c705315f04870988912cfcf.1705932585.git.geert+renesas@glider.beSigned-off-by:
-
Geert Uytterhoeven authored
No one stepped up to complete the EMMA Mobile USB Gadget driver, bring it up to non-staging standards, and convert it to device tree. Signed-off-by:
-
Erick Archer authored
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, use the purpose specific kcalloc() function instead of the argument count * size in the kzalloc() function. Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) due to the type of the variable can change and one needs not change the former (unlike the latter). Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] Link: https://github.com/KSPP/linux/issues/162Signed-off-by:
"Gustavo A. R. Silva" <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20240119173900.11035-1-erick.archer@gmx.comSigned-off-by:
-
Hoorad Farrokh authored
Fixed a linux coding style. Reported by checkpath: WARNING: braces {} are not necessary for single statement blocks Signed-off-by:Hoorad Farrokh <hourrad.f@gmail.com> Link: https://lore.kernel.org/r/4vmxiuz5u2f2vehngdccj5q7bakpujagk72ty5ounfv2nfzxgr@lqkdn5fecc23Signed-off-by:
-
Meir Elisha authored
Fix checkpatch warning: please, no space before tabs Signed-off-by:
Meir Elisha <meir6264@Gmail.com> Link: https://lore.kernel.org/r/20240115083438.108901-1-meir6264@Gmail.comSigned-off-by:
-
Christophe JAILLET authored
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_max() is inclusive. So a -1 has been added when needed. Signed-off-by:
-
Christophe JAILLET authored
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, buInputt the one of ida_alloc_range()/ida_alloc_max() is inclusive. So a -1 has been added when needed. Signed-off-by:
-
Pranav Athreya authored
Adhere to Linux kernel coding style. Reported by checkpatch: drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines Signed-off-by:
Pranav Athreya <pranavsubbu@gmail.com> Link: https://lore.kernel.org/r/ZaDFm6XX7HiGWn58@pop-osSigned-off-by:
-
