- 08 Feb, 2015 2 commits
-
-
Trond Myklebust authored
When using TCP, we need the ability to reuse port numbers after a disconnection, so that the NFSv3 server knows that we're the same client. Currently we use a hack to work around the TCP socket's TIME_WAIT: we send an RST instead of closing, which doesn't always work... The SO_REUSEPORT option added in Linux 3.9 allows us to bind multiple TCP connections to the same source address+port combination, and thus to use ordinary TCP close() instead of the current hack. Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com>
-
git://git.linux-nfs.org/projects/anna/nfs-rdmaTrond Myklebust authored
NFS: RDMA Client Sparse Fixes This patch fixes a sparse warning in the initial submission. Signed-off-by:
Anna Schumaker <Anna.Schumaker@Netapp.com> * tag 'nfs-rdma-for-3.20-part-2' of git://git.linux-nfs.org/projects/anna/nfs-rdma: xprtrdma: Address sparse complaint in rpcr_to_rdmar()
-
- 06 Feb, 2015 5 commits
-
-
Trond Myklebust authored
pnfs_layoutreturn_free_lseg_async() can also race with inode put in the general case. We can now fix this, and also simplify the code. Cc: Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com>
-
Trond Myklebust authored
In we want to be able to call pnfs_send_layoutreturn() from within the writeback path, we really want it to use GFP_NOFS in order to prevent recursion. Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com>
-
Trond Myklebust authored
If we're sending an asynchronous layoutreturn, then we need to ensure that the inode and the super block remain pinned. Cc: Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com> Reviewed-by:
Peng Tao <tao.peng@primarydata.com>
-
Trond Myklebust authored
If we're sending an asynchronous layoutcommit, then we need to ensure that the inode and the super block remain pinned. Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com> Reviewed-by:
Peng Tao <tao.peng@primarydata.com>
-
Trond Myklebust authored
If we have to do a return-on-close in the delegreturn code, then we must ensure that the inode and super block remain referenced. Cc: Peng Tao <tao.peng@primarydata.com> Cc: stable@vger.kernel.org # 3.17.x Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com> Reviewed-by:
Peng Tao <tao.peng@primarydata.com>
-
- 05 Feb, 2015 1 commit
-
-
Chuck Lever authored
With "make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__": linux-2.6/net/sunrpc/xprtrdma/xprt_rdma.h:273:30: warning: incorrect type in initializer (different base types) linux-2.6/net/sunrpc/xprtrdma/xprt_rdma.h:273:30: expected restricted __be32 [usertype] *buffer linux-2.6/net/sunrpc/xprtrdma/xprt_rdma.h:273:30: got unsigned int [usertype] *rq_buffer As far as I can tell this is a false positive. Reported-by: kbuild-all@01.org Signed-off-by:
Chuck Lever <chuck.lever@oracle.com> Signed-off-by:
Anna Schumaker <Anna.Schumaker@Netapp.com>
-
- 04 Feb, 2015 2 commits
-
-
Trond Myklebust authored
If we're using NFSv4.1, then we have the ability to let the server know whether or not we believe that returning a delegation as part of our OPEN request would be useful. The feature needs to be used with care, since the client sending the request doesn't necessarily know how other clients are using that file, and how they may be affected by the delegation. For this reason, our initial use of the feature will be to let the server know when the client believes that handing out a delegation would not be useful. The first application for this function is when opening the file using O_DIRECT. Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com>
-
Trond Myklebust authored
Anna has essentially been performing the duties of co-maintainer for the past several years. In recognition of those efforts, I'd like to add her to the maintainers file. Cc: Anna Schumaker <anna.schumaker@netapp.com> Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com>
-
- 03 Feb, 2015 30 commits
-
-
Trond Myklebust authored
Fix an Oopsable condition when nsm_mon_unmon is called as part of the namespace cleanup, which now apparently happens after the utsname has been freed. Link: http://lkml.kernel.org/r/20150125220604.090121ae@neptune.homeReported-by:
Bruno Prémont <bonbons@linux-vserver.org> Cc: stable@vger.kernel.org # 3.18 Signed-off-by:
Trond Myklebust <trond.myklebust@primarydata.com>
-
Trond Myklebust authored
* flexfiles: (53 commits) pnfs: lookup new lseg at lseg boundary nfs41: .init_read and .init_write can be called with valid pg_lseg pnfs: Update documentation on the Layout Drivers pnfs/flexfiles: Add the FlexFile Layout Driver nfs: count DIO good bytes correctly with mirroring nfs41: wait for LAYOUTRETURN before retrying LAYOUTGET nfs: add a helper to set NFS_ODIRECT_RESCHED_WRITES to direct writes nfs41: add NFS_LAYOUT_RETRY_LAYOUTGET to layout header flags nfs/flexfiles: send layoutreturn before freeing lseg nfs41: introduce NFS_LAYOUT_RETURN_BEFORE_CLOSE nfs41: allow async version layoutreturn nfs41: add range to layoutreturn args pnfs: allow LD to ask to resend read through pnfs nfs: add nfs_pgio_current_mirror helper nfs: only reset desc->pg_mirror_idx when mirroring is supported nfs41: add a debug warning if we destroy an unempty layout pnfs: fail comparison when bucket verifier not set nfs: mirroring support for direct io nfs: add mirroring support to pgio layer pnfs: pass ds_commit_idx through the commit path ... Conflicts: fs/nfs/pnfs.c fs/nfs/pnfs.h
-
Weston Andros Adamson authored
Before mirroring support was added, the pageio descriptor's pg_lseg was set to null when an RPC was sent. Because of this, pg_init was called at lseg boundaries with pg_lseg = NULL, and it could be set to the new lseg. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Peng Tao authored
With pgio refactoring in v3.15, .init_read and .init_write can be called with valid pgio->pg_lseg. file layout was fixed at that time by commit c6194271 (pnfs: filelayout: support non page aligned layouts). But the generic helper still needs to be fixed. Cc: stable@vger.kernel.org # 3.15+ Signed-off-by:
Peng Tao <tao.peng@primarydata.com>
-
Tom Haynes authored
Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Tom Haynes authored
The flexfile layout is a new layout that extends the file layout. It is currently being drafted as a specification at https://datatracker.ietf.org/doc/draft-ietf-nfsv4-layout-types/Signed-off-by:
Weston Andros Adamson <dros@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com> Signed-off-by:
Tao Peng <bergwolf@primarydata.com>
-
Peng Tao authored
When resending to MDS, we might resend multiple mirroring requests to MDS. As a result, nfs_direct_good_bytes() ends up counting bytes multiple times, causing application to get wrong return results in read/write syscalls. Fix it by tracking start of a dreq and checking the range of pgio header. Cc: Weston Andros Adamson <dros@primarydata.com> Signed-off-by:
Peng Tao <tao.peng@primarydata.com>
-
Peng Tao authored
Also take care to stop waiting if someone clears retry bit. Signed-off-by:
Peng Tao <tao.peng@primarydata.com>
-
Peng Tao authored
To allow pnfs LD to ask direct writes to be resend. Signed-off-by:
Peng Tao <tao.peng@primarydata.com>
-
Peng Tao authored
Use it to indicate that LD wants to retry layoutget. LD can set it whenever it wants the common pnfs code to return and retry pnfs path through a new layout. The bit gets cleared when client does a new layoutget, when client closes the file (ROC case), or when kernel needs to evict the inode (non-ROC case). Signed-off-by:
Peng Tao <tao.peng@primarydata.com>
-
Peng Tao authored
Otherwise we'll lose error tracking information when encoding layoutreturn. pnfs_put_lseg may be called from rpc callbacks. So we should not call pnfs_send_layoutreturn directly because it can deadlock in the rpc layer. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
When it is set, generic pnfs would try to send layoutreturn right before last close/delegation_return regard less NFS_LAYOUT_ROC is set or not. LD can then make sure layoutreturn is always sent rather than being omitted. The difference against NFS_LAYOUT_RETURN is that NFS_LAYOUT_RETURN_BEFORE_CLOSE does not block usage of the layout so LD can set it and expect generic layer to try pnfs path at the same time. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
So that callers can specify which range to return. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
If current IO cannot be completed due to some transient errors, LD may want to ask generic layer to resend the request through pnfs again. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
Let it return current nfs_pgio_mirror in use depending on pg_mirror_count. For read, we always use pg_mirrors[0], so this effectively gives us freedom to use pg_mirror_idx to track the actual mirror to read from through out the IO stack. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
so that we don't reset desc->pg_mirror_idx for read unnecessarily. Remove WARN_ON_ONCE from __nfs_pageio_add_request to allow LD to set pg_mirror_idx for read where pg_mirror_count is always 1. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Peng Tao authored
So that we can detect the case if some layout segments are still pinned which is surely a bug that we need to fix. Signed-off-by:
Peng Tao <tao.peng@primarydata.com>
-
Weston Andros Adamson authored
This skips the WARN_ON_ONCE, but doesnt change behavior (the memcmp would fail). Signed-off-by:
Weston Andros Adamson <dros@primarydata.com> Signed-off-by:
Tom Haynes <Thomas.Haynes@primarydata.com>
-
Weston Andros Adamson authored
The current mirroring code only notices short writes to the first mirror. This patch keeps per-mirror byte counts and only considers a byte to be written once all mirrors report so. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Weston Andros Adamson authored
This patch adds mirrored write support to the pgio layer. The default is to use one mirror, but pgio callers may define callbacks to change this to any value up to the (arbitrarily selected) limit of 16. The basic idea is to break out members of nfs_pageio_descriptor that cannot be shared between mirrored DSes and put them in a new structure. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Weston Andros Adamson authored
Pass ds_commit_idx through the nfs commit path. It's used to select the commit bucket when using pnfs and is ignored when not using pnfs. Several functions had to be changed: nfs_retry_commit, nfs_mark_request_commit, pnfs_mark_request_commit and the pnfs layout driver .mark_request_commit functions. Signed-off-by:
Tom Haynes <loghyr@primarydata.com>
-
Weston Andros Adamson authored
'ds_commit_idx' is a better name - it is used to select the right commit bucket for pnfs. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Weston Andros Adamson authored
This is needed for mirrored DS support, where multuple requests cover the same range. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Weston Andros Adamson authored
This is needed to support mirrored writes - the first write can't just trash the lseg, we need to keep it around until all mirrors have written. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Weston Andros Adamson authored
Add a new operation to nfs_pageio_ops that is called on nfs_pageio_complete. Signed-off-by:
Weston Andros Adamson <dros@primarydata.com>
-
Peng Tao authored
Instead of calling layoutreturn directly, call pnfs_error_mark_layout_for_return to mark layouts for return and let generic code return layout when layout segments are freed. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <Thomas.Haynes@primarydata.com> Conflicts: fs/nfs/filelayout/filelayout.c
-
Peng Tao authored
So that pnfs path is not disabled for ever. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <Thomas.Haynes@primarydata.com>
-
Peng Tao authored
If current lseg is the last lseg marked with NFS_LSEG_LAYOUTRETURN, send layoutreturn. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <Thomas.Haynes@primarydata.com>
-
Peng Tao authored
And if we are to return the same type of layouts, don't bother sending more layoutgets. Signed-off-by:
Peng Tao <tao.peng@primarydata.com> Signed-off-by:
Tom Haynes <Thomas.Haynes@primarydata.com>
-