- 03 Dec, 2013 40 commits
-
-
H Hartley Sweeten authored
These commented out messages are just added noise. Remove them. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
The code to initialize subdevice[2] is commented out and incomplete. Just remove it. Signed-off-by:
-
H Hartley Sweeten authored
Remove the commented out message, it would just be added noise. Signed-off-by:
-
H Hartley Sweeten authored
Convert these messages to dev_dbg() and tidy them up a bit. Signed-off-by:
-
H Hartley Sweeten authored
Convert these warning messages to dev_dbg() to minimize the noise. Also, tidy them up a bit. Signed-off-by:
-
H Hartley Sweeten authored
Convert these debug messages to dev_dbg() and tidy them up a bit. Signed-off-by:
-
H Hartley Sweeten authored
The "success" message after an attach is just added noise. Remove it. The normal return value for "success" is 0. Signed-off-by:
-
H Hartley Sweeten authored
Convert these debug messages to dev_dbg(). Signed-off-by:
-
H Hartley Sweeten authored
An allocation failure will have already displayed a message. Signed-off-by:
-
Aldo Iljazi authored
Line 921: Removed the space before the semicolon. Signed-off-by:
Aldo Iljazi <mail@aldo.io> Signed-off-by:
-
Chen Gang authored
drivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user() in ft1000_ioctl() get_user() may fail and cause 'msgsz' uninitialized, so need give a check. The related warning (with allmodconfig under hexagon): CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_debug.o drivers/staging/ft1000/ft1000-usb/ft1000_debug.c: In function 'ft1000_ioctl': include/uapi/linux/swab.h:53:9: warning: 'msgsz' may be used uninitialized in this function [-Wuninitialized] drivers/staging/ft1000/ft1000-usb/ft1000_debug.c:533:17: note: 'msgsz' was declared here Signed-off-by:Chen Gang <gang.chen.5i5j@gmail.com> Signed-off-by:
-
Michal Nazarewicz authored
The rest of the code seem to imply that rmf_dumper may indeed be NULL. Change the code so that dumping is not even considered if rmf_dumper callback is not set. Signed-off-by:
Michal Nazarewicz <mina86@mina86.com> Signed-off-by:
-
Michal Nazarewicz authored
bus_info field of struct ethtool_drvinfo is an array thus it always evaluates to true in a boolean context. Therefore operation depending on it being false will never be executed. Signed-off-by:
-
Aldo Iljazi authored
Fixed the following coding style issues: Lines 66-70: Replaced spaced with tabs. Lines 75, 98, 182: Inserted space before the open parenthesis. Line 89: Inserted spaces around that '=' Signed-off-by:
-
Wei Yongjun authored
Fix to return -ENOMEM instead of 0 when the memory alloc fail in probe error handling path. Signed-off-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by:
-
Aldo Iljazi authored
Fixed a coding style issue, specifically: Line 1798: Removed parentheses since return is not a function. Signed-off-by:
-
Stephen Warren authored
The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non- default parameters. Select these based on the compatible value from the DT node. For all other HW, fall back to the default parameters currently in use. The values in params_bcm2835[] were posted to the mailing list by Paul quite some time ago. I made a couple of minor modifications since then; to set ahbcfg instead of ahb_single, and to set uframe_sched. Signed-off-by:
Stephen Warren <swarren@wwwdotorg.org> Signed-off-by:
-
Peng Tao authored
Got below warning when building with sparc: drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_aio_write': drivers/staging/lustre/lustre/llite/file.c:1247:9: warning: 'count' may be used uninitialized in this function [-Wuninitialized] drivers/staging/lustre/lustre/llite/file.c: In function 'll_file_aio_read': drivers/staging/lustre/lustre/llite/file.c:1188:9: warning: 'count' may be used uninitialized in this function [-Wuninitialized] Signed-off-by:
Peng Tao <bergwolf@gmail.com> Signed-off-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
register_sysctl_table/unregister_sysctl_table are defined regardless of CONFIG_SYSCTL true or false. so we don't need to surround them with #ifdef CONFIG_SYSCTL. Besides, current code got build warnings when CONFIG_SYSCTL is not set: drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:368:20: warning: ‘lnet_table’ defined but not used [-Wunused-variable] Signed-off-by:
-
Peng Tao authored
It is not strictly related to procfs. Besides, we already call obd_sysctl_clean outside of class_procfs_clean. Signed-off-by:
-
Peng Tao authored
Signed-off-by:
-
Peng Tao authored
No need to surround them with #ifdef LPROCFS. Signed-off-by:
-
Peng Tao authored
Got below warning when building lustre with 4.7.3. drivers/staging/lustre/lustre/obdclass/llog_test.c: In function ‘ llog_test_init’: drivers/staging/lustre/lustre/obdclass/llog_test.c:1058:28: warning: ‘ lvars.module_vars’ is used uninitialized in this function [-Wuninitialized] Signed-off-by:
-
Dmitry Eremin authored
This is only part of the original Lustre tree commit. It cleans up ptlrpcd_start error handling a bit. Lustre-change: http://review.whamcloud.com/6139 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3204Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by:
Ned Bass <bass6@llnl.gov> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Dmitry Eremin authored
This is only part of the original Lustre tree commit splitted to follow the "one thing per patch" rule. Lustre-change: http://review.whamcloud.com/6139 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3204Signed-off-by:
-
Dmitry Eremin authored
This is part of original Lustre tree commit. It removes never implemented suspend timeouts functionality from pinger.c which was commented out since 2007 and going to be replaced by adaptive timeouts. Also removed all references to this functionality from ldlm_lockd.c, ldlm_request.c and import.c which actually nevers executes or do nothing. Lustre-change: http://review.whamcloud.com/6139 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3204Signed-off-by:
-
Dmitry Eremin authored
This is SET_BUT_UNUSED/UNUSED macro cleaning up part of the original Lustre tree commit. Lustre-change: http://review.whamcloud.com/6139 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3204Signed-off-by:
-
Andrew Perepechko authored
This patch implements an extended attribute cache for a Lustre client. It is organized as a write-through cache: reads are performed from cache, updates are sent synchronously to the MDS. An additional inode bit MDS_INODELOCK_XATTR is added to protect the cache. Lustre-change: http://review.whamcloud.com/5537 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2869Signed-off-by:
Andrew Perepechko <andrew_perepechko@xyratex.com> Reviewed-by:
Jinshan Xiong <jinshan.xiong@intel.com> Reviewed-by:
-
Jinshan Xiong authored
HSM Release is one of the key feature of HSM. To perform HSM release, clients need to acquire the file lease exclusivelt and flush dirty cache from clients. A special close REQ will be sent to the MDT to release the lease and get rid of OST objects. Lustre-change: http://review.whamcloud.com/7028 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1333Signed-off-by:
Aurelien Degremont <aurelien.degremont@cea.fr> Signed-off-by:
Alex Zhuravlev <alexey.zhuravlev@intel.com> Signed-off-by:
-
Amir Shehata authored
When a system runs out of memory and the function ptlrpc_register_bulk() is called from ptl_send_rpc() the call to LNetMEAttach() fails due to failure to allocate memory. This forces the code into an error path, which most probably previously went untested. The error path: if (rc != 0) { CERROR("%s: LNetMEAttach failed x"LPU64"/%d: rc = %dn", desc->bd_export->exp_obd->obd_name, xid, posted_md, rc); break; } This print assumes that desc->bd_export is not NULL. However, it is. In fact it is expected to be NULL. desc->bd_import is the correct structure to access in this case. Lustre-change: http://review.whamcloud.com/7121 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3585 Cc: stable <stable@vger.kernel.org> # 3.12 Signed-off-by:Amir Shehata <amir.shehata@intel.com> Reviewed-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-by:
Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by:
-
Dmitry Eremin authored
After removing LIBCFS_HAVE_IS_COMPAT_TASK test we have a compilation issue with kernels configured without CONFIG_COMPAT. Lustre-change: http://review.whamcloud.com/7118 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2800Signed-off-by:
James Simmons <uja.ornl@gmail.com> Reviewed-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
-
John L. Hammond authored
ll_lookup_it() checks for O_CREAT in struct lookup_intent's it_create_mode member which is nonsensical, as it_create_mode is used for file mode bits (S_IFREG, S_IRUSR, ...). Fix this by just checking for IT_CREATE in it_op. This will not affect the behavior of either function, since if O_CREATE (0100) is actually set in o_create_mode then IT_CREATE must have been set in it_op. In ll_atomic_open() check for O_CREAT in the open_flags parameter rather than testing mode. Lustre-change: http://review.whamcloud.com/6786 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3517Signed-off-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
Lai Siyao <lai.siyao@intel.com> Reviewed-by:
-
Fan Yong authored
This is the coding style part of the original Lustre commit. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3335 Lustre-change: http://review.whamcloud.com/6669Signed-off-by:
Fan Yong <fan.yong@intel.com> Reviewed-by:
-
Fan Yong authored
Main part of original patch in Lustre tree (http://review.whamcloud.com/6669) changes server code and is unneeded by client. The patch only picks up common functions and data structures change. Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3335 Lustre-change: http://review.whamcloud.com/6669Signed-off-by:
-
JC Lafoucriere authored
This is only part of the original Lustre tree commit. Main part of the original commit changes server code and is unneeded at client side. Lustre-change: http://review.whamcloud.com/6534 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3342Signed-off-by:
JC Lafoucriere <jacques-charles.lafoucriere@cea.fr> Reviewed-by:
-
JC Lafoucriere authored
This is only part of the original Lustre tree commit. Main part of the original commit changes server code and is unneeded at client side. Lustre-change: http://review.whamcloud.com/6534 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3342Signed-off-by:
-
Mikhail Pershin authored
MGC uses lvfs API to access local llogs blocking removal of old code - llog_is_empty() and llog_backup() are introduced Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2059 Lustre-change: http://review.whamcloud.com/5049 Cc: Levente Kurusa <levex@linux.com> Signed-off-by:
Mikhail Pershin <mike.pershin@intel.com> Reviewed-by:
-
Peng Tao authored
This reverts commit ad8dbc93. The original commit was reverted in Lustre tree this due to interoperability problems with 2.1 servers. But I forgot to remove it from my patch queue. sorry for the noise. Cc: Patrick Farrell <paf@cray.com> Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
It is not used. Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Peng Tao authored
We need to include <linux/posix_acl_xattr.h> regardless of CONFIG_FS_POSIX_ACL is set or not. Otherwise build fails as reported by kbuild robot: >> drivers/staging/lustre/lustre/llite/file.c:2965:2: error: implicit declaration of function 'posix_acl_dup' [-Werror=implicit-function-declaration] acl = posix_acl_dup(lli->lli_posix_acl); <many similar errors omitted> Reported-by:Fengguang Wu <fengguang.wu@intel.com> Cc: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
