- 06 Apr, 2024 2 commits
-
-
Krzysztof Kozlowski authored
PCI core in pci_register_driver() already sets the .owner, so driver does not need to. Signed-off-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20240327174921.519830-2-krzysztof.kozlowski@linaro.orgSigned-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Krzysztof Kozlowski authored
PCI core in pci_register_driver() already sets the .owner, so driver does not need to. Signed-off-by:
-
- 28 Mar, 2024 1 commit
-
-
Damien Le Moal authored
Commit b4d3ddd2 ("scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices") introduced support for ATA NCQ priority control for ATA devices managed by libsas. This commit introduces the ncq_prio_supported and ncq_prio_enable sysfs device attributes to discover and control the use of this features, similarly to libata. However, libata publicly declares these device attributes and export them for use in ATA low level drivers. This leads to a compilation error when libsas and libata are built-in due to the double definition: ld: drivers/ata/libata-sata.o:/home/Linux/scsi/drivers/ata/libata-sata.c:900: multiple definition of `dev_attr_ncq_prio_supported'; drivers/scsi/libsas/sas_ata.o:/home/Linux/scsi/drivers/scsi/libsas/sas_ata.c:984: first defined here ld: drivers/ata/libata-sata.o:/home/Linux/scsi/drivers/ata/libata-sata.c:1026: multiple definition of `dev_attr_ncq_prio_enable'; drivers/scsi/libsas/sas_ata.o:/home/Linux/scsi/drivers/scsi/libsas/sas_ata.c:1022: first defined here Resolve this problem by directly declaring the libsas attributes instead of using the DEVICE_ATTR() macro. And for good measure, the device attribute variables are also renamed. Reported-by:
Geert Uytterhoeven <geert@linux-m68k.org> Fixes: b4d3ddd2 ("scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices") Signed-off-by:
Damien Le Moal <dlemoal@kernel.org> Link: https://lore.kernel.org/r/20240327020122.439424-1-dlemoal@kernel.orgReviewed-by:
John Garry <john.g.garry@oracle.com> Signed-off-by:
-
- 26 Mar, 2024 8 commits
-
-
Martin K. Petersen authored
Peter Wang <peter.wang@mediatek.com> says: This series fixes some defects and provide features in MediaTek UFS drivers. Link: https://lore.kernel.org/r/20240315083448.7185-1-peter.wang@mediatek.comSigned-off-by:
-
Alice Chao authored
Add mtcmos control function and config. Signed-off-by:
Alice Chao <alice.chao@mediatek.com> Reviewed-by:
Peter Wang <peter.wang@mediatek.com> Acked-by:
Chun-Hung Wu <Chun-Hung.Wu@mediatek.com> Signed-off-by:
-
Peter Wang authored
Reset mphy when resetting host. Backup mphy setting after mphy reset control get. Restore mphy setting after mphy reset. Acked-by:
-
Po-Wen Kao authored
Mediatek host power includes two parts: 1. ufshci power, which is the main power of ufs host controller. 2. ufshci crypto sram power, which is the power of ufs crypto engine. The host power control is actually controlling crypto sram power. Rename it. Signed-off-by:
Po-Wen Kao <powen.kao@mediatek.com> Acked-by:
Avri Altman <avri.altman@wdc.com> Link: https://lore.kernel.org/r/20240315083448.7185-6-peter.wang@mediatek.comSigned-off-by:
-
Po-Wen Kao authored
Move sip command and associated define to a new sip header file. Signed-off-by:
-
Po-Wen Kao authored
Add new mediatek host cap UFS_MTK_CAP_DISABLE_MCQ to allow disabling MCQ feature by assigning dts boolean property "mediatek,ufs-disable-mcq". Signed-off-by:
-
Peter Wang authored
Fix Mediatek TX skew issue by checking dts setting and vendor/model. Then set PA_TACTIVATE to 8. Signed-off-by:
-
Peter Wang authored
VSX (the upper layer of VCCQ/VCCQ2) should: 1. Always set to hpm mode if ufs device is active. 2. Enter lpm mode only if ufs device is not active. VCCQX should: 1. Keep hpm mode if vccq and vccq2 not set in dts. 2. Keep hpm mode if vcc not set in dts keep vcc always on. 3. Keep hpm if broken vcc keep vcc always on and not allow vccq lpm. 4. Except upper case, can enter lpm mode if ufs device is not active. Acked-by:
-
- 25 Mar, 2024 29 commits
-
-
Martin K. Petersen authored
Ranjan Kumar <ranjan.kumar@broadcom.com> says: Few Enhancements and minor fixes of mpi3mr driver. Link: https://lore.kernel.org/r/20240313100746.128951-1-ranjan.kumar@broadcom.comSigned-off-by:
-
Ranjan Kumar authored
Update driver version to 8.8.1.0.50. Signed-off-by:
Ranjan Kumar <ranjan.kumar@broadcom.com> Link: https://lore.kernel.org/r/20240313100746.128951-8-ranjan.kumar@broadcom.comSigned-off-by:
-
Ranjan Kumar authored
Update MPI Headers to revision 31. Signed-off-by:
Sathya Prakash <sathya.prakash@broadcom.com> Link: https://lore.kernel.org/r/20240313100746.128951-7-ranjan.kumar@broadcom.comSigned-off-by:
-
Ranjan Kumar authored
Update driver to include OS type in fault/reset reason code. MPI request sent through ioctl now automatically dumped on timeout. Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202403081903.q3Dq54zZ-lkp@intel.com/Signed-off-by:
-
Ranjan Kumar authored
Modify driver to set the Write Same Divert Capability bit in the IOCInit message for the firmware to know that the driver is capable of diverting certain Write Same commands as defined by the MPI specification. Signed-off-by:
-
Ranjan Kumar authored
The driver uses a controller-wide flag to block ioctls when a controller reset is in progress. This flag is set before controller reset is initiated and cleared after the reset has completed. Make the driver clear the controller-wide block ioctls flag after a controller reset fails and the controller is marked unrecoverable. Signed-off-by:
Sumit Saxena <sumit.saxena@broadcom.com> Link: https://lore.kernel.org/r/20240313100746.128951-4-ranjan.kumar@broadcom.comSigned-off-by:
-
Ranjan Kumar authored
The 'flags' variable inside an MPI request is a bitfield and should consequently be updated using a bitwise OR operation. Signed-off-by:
-
Ranjan Kumar authored
The driver did not remove the virtual disk that was exposed as hidden and offline after the controller was reset. Drive is removed from OS when firmware sends "device added" event with hidden bit set or access status indicating inability to accept I/Os. Signed-off-by:
-
Martin K. Petersen authored
Avri Altman <avri.altman@wdc.com> says: Device management commands are constructed for query commands that are being issued by the driver, but also for raw device management commands originated by the bsg module, and recently, by the advanced rpmb handler. Thus, the same code fragments, e.g. locking, composing the command, composing the upiu etc., appear over and over. Remove those duplications. Theoretically, there should be no functional change. Link: https://lore.kernel.org/r/20240309081104.5006-1-avri.altman@wdc.comSigned-off-by:
-
Avri Altman authored
Move some code fragments into ufshcd_prepare_req_desc_hdr() so it can be used throughout. Signed-off-by:
Bart Van Assche <bvanassche@acm.org> Reviewed-by:
Bean Huo <beanhuo@micron.com> Signed-off-by:
-
Avri Altman authored
Move out some of the dev_cmd initializations so they can be used elsewhere. Reviewed-by:
-
Avri Altman authored
Move out the actual command issue from exec_dev_cmd it can be used elsewhere. While at it, remove a redundant "lrbp->cmd = NULL" assignment. Also, the device management commands that are originated from the ufs-bsg code path, are being traced now, which wasn't the case before. Signed-off-by:
-
Avri Altman authored
Group those 3 calls that repeat for every device management command into lock and unlock handlers. Reviewed-by:
-
Martin K. Petersen authored
John Garry <john.g.garry@oracle.com> says: There is much duplication in the scsi_host_template structure for the drivers which use libsas. Similar to how a standard template is used in libata with __ATA_BASE_SHT, create a standard template in LIBSAS_SHT_BASE. Link: https://lore.kernel.org/r/20240308114339.1340549-1-john.g.garry@oracle.comSigned-off-by:
-
John Garry authored
Use standard template for scsi_host_template structure to reduce duplication. Reviewed-by:
Jason Yan <yanaijie@huawei.com> Signed-off-by:
Igor Pylypiv <ipylypiv@google.com> Signed-off-by:
-
John Garry authored
Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by:
-
John Garry authored
Use standard template for scsi_host_template structure to reduce duplication. Reviewed-by:
-
John Garry authored
Use standard template for scsi_host_template structure to reduce duplication. Reviewed-by:
-
John Garry authored
Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by:
-
John Garry authored
There is much duplication in the scsi_host_template structure for the drivers which use libsas. Similar to how a standard template is used in libata with __ATA_BASE_SHT, create a standard template in LIBSAS_SHT_BASE. Don't set a default for max_sectors at SCSI_DEFAULT_MAX_SECTORS, as scsi_host_alloc() will default to this value automatically. Even though some drivers don't set proc_name, it won't make much difference to set as DRV_NAME. Also add LIBSAS_SHT_BASE_NO_SLAVE_INIT for the hisi_sas drivers which have custom .slave_alloc and .slave_configure methods. Reviewed-by:
-
Martin K. Petersen authored
Igor Pylypiv <ipylypiv@google.com> says: This patch series adds ncq_prio_supported and ncq_prio_enable sysfs attributes for libsas managed SATA devices. Existing libata sysfs attributes cannot be used directly because the ata_port location is different for libsas. Link: https://lore.kernel.org/r/20240307214418.3812290-1-ipylypiv@google.comSigned-off-by:
-
Igor Pylypiv authored
The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by:
Hannes Reinecke <hare@suse.de> Reviewed-by:
Niklas Cassel <cassel@kernel.org> Signed-off-by:
-
Igor Pylypiv authored
The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by:
-
Igor Pylypiv authored
The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Omitted hisi_sas_v1_hw.c because v1 HW doesn't support SATA. Reviewed-by:
-
Igor Pylypiv authored
The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Reviewed-by:
-
Igor Pylypiv authored
The added sysfs attributes group enables the configuration of NCQ Priority feature for HBAs that rely on libsas to manage SATA devices. Acked-by:
Jack Wang <jinpu.wang@ionos.com> Reviewed-by:
-
Igor Pylypiv authored
libata sysfs attributes cannot be used for libsas-managed SATA devices because the ata_port location is different for libsas. Defined sysfs attributes (visible for SATA devices only): - /sys/block/sda/device/ncq_prio_enable - /sys/block/sda/device/ncq_prio_supported The newly defined attributes will pass the correct ata_port to libata helper functions. Reviewed-by:
-
Igor Pylypiv authored
Export libata NCQ Priority configuration helpers to be reused for libsas managed SATA devices. Switched locking from spin_lock_irq() to spin_lock_irqsave(). In the future someone might call these helper functions when interrupts are disabled. spin_unlock_irq() could lead to a premature re-enabling of interrupts, whereas spin_unlock_irqrestore() restores the interrupt state to its condition prior to the spin_lock_irqsave() call. Acked-by:
-
Martin K. Petersen authored
Justin Stitt <justinstitt@google.com> says: This series contains multiple replacements of strncpy throughout the scsi subsystem. strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. The details of each replacement will be in their respective patch. Link: https://lore.kernel.org/r/20240305-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v3-0-5b78a13ff984@google.comSigned-off-by:
-
