1. 04 May, 2020 2 commits
  2. 03 May, 2020 9 commits
  3. 01 May, 2020 2 commits
    • Rob Herring's avatar
      dt-bindings: Add a minimum version check for dtschema · ea5b8b5e
      Rob Herring authored
      The dtschema package must be somewhat up to date as the tools and
      meta-schema checks are still evolving. Implement a version check,
      so this can be enforced. This will help ensure new schema submissions
      get checked against the latest meta-schemas.
      Reviewed-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      ea5b8b5e
    • Lubomir Rintel's avatar
      dt-bindings: serial: Convert 8250 to json-schema · e69f5dc6
      Lubomir Rintel authored
      Some fixes were done during the conversion:
      
      Slightly better examples. The original example was for an OMAP serial
      port, which is not even described by this binding, but by
      omap_serial.txt instead.
      
      Added compatible strings, that were used, byt not documented:
      andestech,uart16550, cavium,octeon-3860-uart, fsl,16550-FIFO64,
      nvidia,tegra186-uart, nvidia,tegra194-uart, nxp,lpc1850-uart,
      opencores,uart16550-rtlsvn105, ralink,mt7620a-uart, ralink,rt3052-uart,
      ralink,rt3883-uart and xlnx,xps-uart16550-2.00.b.
      
      Removed "serial" compatible string. It's redundant with the node name
      (which, in OFW, serves the same purpose as the compatible string).
      Signed-off-by: default avatarLubomir Rintel <lkundrak@v3.sk>
      [robh: allow additional properties. clocks/clock-frequency can be
      optional on original 8250 series with standard clocks]
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      e69f5dc6
  4. 30 Apr, 2020 2 commits
  5. 28 Apr, 2020 5 commits
  6. 24 Apr, 2020 3 commits
    • Douglas Anderson's avatar
      dt-bindings: phy: qcom-qusb2: Fix defaults · 4bc77b2d
      Douglas Anderson authored
      The defaults listed in the bindings don't match what the code is
      actually doing.  Presumably existing users care more about keeping
      existing behavior the same, so change the bindings to match the code
      in Linux.
      
      The "qcom,preemphasis-level" default has been wrong for quite a long
      time (May 2018).  The other two were recently added.
      
      As some evidence that these values are wrong, this is from the Linux
      driver:
      - qcom,preemphasis-level: sets "PORT_TUNE1", lower 2 bits.  Driver
        programs PORT_TUNE1 to 0x30 by default and (0x30 & 0x3) = 0.
      - qcom,bias-ctrl-value: sets "PLL_BIAS_CONTROL_2", lower 6 bits.
        Driver programs PLL_BIAS_CONTROL_2 to 0x20 by default and (0x20 &
        0x3f) = 0x20 = 32.
      - qcom,hsdisc-trim-value: sets "PORT_TUNE2", lower 2 bits.  Driver
        programs PORT_TUNE2 to 0x29 by default and (0x29 & 0x3) = 1.
      
      Fixes: 1e6f134e ("dt-bindings: phy: qcom-qusb2: Add support for overriding Phy tuning parameters")
      Fixes: a8b70ccf ("dt-bindings: phy-qcom-usb2: Add support to override tuning values")
      Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
      Reviewed-by: default avatarMatthias Kaehlcke <mka@chromium.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      4bc77b2d
    • Rob Herring's avatar
      dt-bindings: Fix erroneous 'additionalProperties' · 2bdfd4fb
      Rob Herring authored
      There's several cases of json-schema 'additionalProperties' at the wrong
      indentation level which has the effect of making them DT properties. This
      is harmless, but let's fix them so a meta-schema check for this can be
      added.
      
      In all the cases, either the 'additionalProperties' was extra or doesn't
      work because there's a $ref to more properties. In the latter case, we
      can use 'unevaluatedProperties' instead.
      Reported-by: default avatarIskren Chernev <iskren.chernev@gmail.com>
      Cc: Lee Jones <lee.jones@linaro.org>
      Cc: Saravanan Sekar <sravanhome@gmail.com>
      Cc: Liam Girdwood <lgirdwood@gmail.com>
      Acked-by: default avatarMark Brown <broonie@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      2bdfd4fb
    • Rob Herring's avatar
      dt-bindings: Fix command line length limit calling dt-mk-schema · 8b6b8021
      Rob Herring authored
      As the number of schemas has increased, we're starting to hit the error
      "execvp: /bin/sh: Argument list too long". This is due to passing all the
      schema files on the command line to dt-mk-schema. It currently is only
      with out of tree builds and is intermittent depending on the file path
      lengths.
      
      Commit 2ba06cd8 ("kbuild: Always validate DT binding examples") made
      hitting this proplem more likely since the example validation now always
      gets the full list of schemas.
      
      Fix this by passing the schema file list in a pipe and using xargs. We end
      up doing the find twice, but the time is insignificant compared to the
      dt-mk-schema time.
      Reported-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Reviewed-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Tested-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      8b6b8021
  7. 22 Apr, 2020 1 commit
  8. 20 Apr, 2020 11 commits
  9. 17 Apr, 2020 5 commits
    • Rob Herring's avatar
      Merge branch 'dt/linus' into dt/next · 7e5ff591
      Rob Herring authored
      7e5ff591
    • Masahiro Yamada's avatar
      kbuild: check libyaml installation for 'make dt_binding_check' · 0903060f
      Masahiro Yamada authored
      If you run 'make dtbs_check' without installing the libyaml package,
      the error message "dtc needs libyaml ..." is shown.
      
      This should be checked also for 'make dt_binding_check' because dtc
      needs to validate *.example.dts extracted from *.yaml files.
      
      It is missing since commit 4f0e3a57 ("kbuild: Add support for DT
      binding schema checks"), but this fix-up is applicable only after commit
      e10c4321 ("kbuild: allow to run dt_binding_check and dtbs_check
      in a single command").
      
      I gave the Fixes tag to the latter in case somebody is interested in
      back-porting this.
      
      Fixes: e10c4321 ("kbuild: allow to run dt_binding_check and dtbs_check in a single command")
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      0903060f
    • Frank Rowand's avatar
      of: unittest: kmemleak in duplicate property update · 29acfb65
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 5 of 5.
      
      When overlay 'overlay_bad_add_dup_prop' is applied, the apply code
      properly detects that a memory leak will occur if the overlay is removed
      since the duplicate property is located in a base devicetree node and
      reports via printk():
      
        OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/motor-1/rpm_avail
        OF: overlay: WARNING: memory leak will occur if overlay removed, property: /testcase-data-2/substation@100/motor-1/rpm_avail
      
      The overlay is removed when the apply code detects multiple changesets
      modifying the same property.  This is reported via printk():
      
        OF: overlay: ERROR: multiple fragments add, update, and/or delete property /testcase-data-2/substation@100/motor-1/rpm_avail
      
      As a result of this error, the overlay is removed resulting in the
      expected memory leak.
      
      Add another device node level to the overlay so that the duplicate
      property is located in a node added by the overlay, thus no memory
      leak will occur when the overlay is removed.
      
      Thus users of kmemleak will not have to debug this leak in the future.
      
      Fixes: 2fe0e876 ("of: overlay: check prevents multiple fragments touching same property")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      29acfb65
    • Frank Rowand's avatar
      of: overlay: kmemleak in dup_and_fixup_symbol_prop() · 478ff649
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 4 of 5.
      
      target_path was not freed in the non-error path.
      
      Fixes: e0a58f3e ("of: overlay: remove a dependency on device node full_name")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      478ff649
    • Frank Rowand's avatar
      of: unittest: kmemleak in of_unittest_overlay_high_level() · 145fc138
      Frank Rowand authored
      kmemleak reports several memory leaks from devicetree unittest.
      This is the fix for problem 3 of 5.
      
      of_unittest_overlay_high_level() failed to kfree the newly created
      property when the property named 'name' is skipped.
      
      Fixes: 39a751a4 ("of: change overlay apply input data from unflattened to FDT")
      Reported-by: default avatarErhard F. <erhard_f@mailbox.org>
      Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      145fc138