- 19 May, 2022 23 commits
-
-
Martin Kaiser authored
Simplify the error handling in recv_func_prehandle. There's no need to goto exit, this would be the next statement anyway. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220515155401.352742-4-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
Remove some comments in HalPwrSeqCmd.c that contain no useful information. Signed-off-by:
-
Martin Kaiser authored
Use the ieee80211_is_beacon helper to check if the incoming frame is a beacon frame. Signed-off-by:
-
Martin Kaiser authored
Replace the numeric values with defines from ieee80211.h. Suggested-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Martin Kaiser authored
Extract the tid from the delba frame regardless of the recipient/initiator setting. Use the extracted tid when we process the delba frame. Signed-off-by:
-
Martin Kaiser authored
For an incoming delba message, the code checks if the delba was sent by the data initiator or by the data recipient. Rewrite this check using the ieee80211 helpers, making the code easier to understand. Signed-off-by:
-
Martin Kaiser authored
Use BIT(tid) instead of 1 << tid when we process an addba response. Signed-off-by:
-
Martin Kaiser authored
Replace an if statement with a ternary operator, making the code a tiny bit shorter. Signed-off-by:
-
Martin Kaiser authored
The process_addba_req function is called only by OnAction_back. Merge the two functions. OnAction_back has already checked that psta != NULL, we can drop the check in process_addba_req before merging the functions. We can also simplify the parsing of the tid by using struct ieee80211. Signed-off-by:
-
Martin Kaiser authored
Use the same code as ieee80211_process_addba_resp to calculate the tid from the capability field of an addba response message. Signed-off-by:
-
Martin Kaiser authored
Read the addba response status from struct ieee80211_mgmt instead of parsing the incoming frame ourselves. Signed-off-by:
-
Soumya Negi authored
Adhere to Linux coding style. Fix the below checkpatch warning: WARNING: Block comments should align the * on each line Signed-off-by:
Soumya Negi <soumya.negi97@gmail.com> Link: https://lore.kernel.org/r/20220513075107.23285-1-soumya.negi97@gmail.comSigned-off-by:
-
Soumya Negi authored
Adhere to Linux coding style. Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: line length of 101 exceeds 100 columns Signed-off-by:
-
Philipp Hortmann authored
Replace macro VNSvOutPortB with iowrite8 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/38611512677a18f63d9266cde1d20758c0feeb6e.1651957741.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
Replace macro MACvTransmitBCN with VNSvOutPortB and as it was the only user, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvStart with VNSvOutPortB and as it was the only user, it can now be removed. Signed-off-by:
-
Vihas Makwana authored
The check for ETH_P_IP is already performed in the outer if block and inner if check is redundant. So drop the check. Signed-off-by:
Vihas Makwana <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220508182400.22433-1-makvihas@gmail.comSigned-off-by:
-
Martin Kaiser authored
Read the back action code from struct ieee80211_mgmt. struct ieee80211_mgmt contains an "action" union. Each of its members starts with an 8-bit action code. Treat the union as addba_req when we read the action code although we do not yet know if it is an addba_req. This approach is similar to ieee80211_iface_process_skb. Signed-off-by:
-
Martin Kaiser authored
Use the defines from ieee80211.h for the back action codes. Signed-off-by:
-
Martin Kaiser authored
For management frames, addr1 is the destination address (da). Read this address from struct ieee80211_mgmt instead of calling a driver-specific macro. Signed-off-by:
-
Martin Kaiser authored
Do not check the category in OnAction_back. OnAction has already checked the category before calling OnAction_back. Signed-off-by:
-
Martin Kaiser authored
Define a struct ieee80211_mgmt variable in the OnAction_back function. Use it to read addr2. For management frames, addr2 is the source address (sa). Signed-off-by:
-
Colin Ian King authored
Don't populate the const array queuetopipe on the stack, instead make it static. Also makes the object code smaller. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20220507183414.26633-1-colin.i.king@gmail.comSigned-off-by:
-
- 05 May, 2022 17 commits
-
-
Martin Kaiser authored
The IEEE_* defines in the driver's ieee80211.h header file are not used. Remove them. Signed-off-by:
-
Martin Kaiser authored
Replace some of the driver-specific defines for action categories with the defines from ieee80211.h. Signed-off-by:
-
Martin Kaiser authored
Use the struct ieee80211_mgmt from ieee80211.h to read the action category. There's no need to parse the incoming frame ourselves. Signed-off-by:
-
Martin Kaiser authored
OnAction_tbl has only three entries. It's simpler to use a switch statement instead of iterating over the table. We can then remove the table itself and struct action_handler, which was used only for the table entries. Signed-off-by:
-
Martin Kaiser authored
RTW_WLAN_CATEGORY_TDLS is not used. Remove the define. Signed-off-by:
-
Martin Kaiser authored
Remove the unused str component from struct action_handler and the corresponding entries in OnAction_tbl. Signed-off-by:
-
Martin Kaiser authored
For some action categories, we removed the handler function, but we forgot the prototypes. Remove them as well. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does not handle the wmm action category. Remove the empty handler function, the entry in OnAction_tbl and the define for the category. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does not handle the ht action category. Remove the empty handler function, the entry in OnAction_tbl and the define for the category. Signed-off-by:
-
Philipp Hortmann authored
Replace unused return value with u64 to increase readability, reduce address and dereference operators and omit pqwCurrTSF that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Philipp Hortmann authored
The name of the function uses CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Philipp Hortmann authored
Added missing big-endian support in CARDbGetCurrentTSF. Reported-by:
David Laight <David.Laight@ACULAB.COM> Signed-off-by:
-
Philipp Hortmann authored
Replace macro VNSvInPortD with ioread32 and as it was the only user, it can now be removed. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Charlie Sands authored
Removes broken and unsafe rtw_p2p_get function and all of the code associated with it from the r8188eu driver. Signed-off-by:
Charlie Sands <charlies256@protonmail.com> Link: https://lore.kernel.org/r/Ymy7C/A2q+VzfBhO@sckzor-linux.localdomainSigned-off-by:
-
Vihas Makwana authored
There's a NULL check on pmlmepriv in rtw_mlme.c:112 which makes no sense as rtw_free_mlme_priv_ie_data() dereferences it unconditionally and it would have already crashed at this point. Remove this redundant check. Signed-off-by:
-
Jaehee Park authored
rtw_select_and_join_from_scanned_queue() cannot return '2' so this else condition is unused. Remove this unnecessary else statement. Suggested-by:
Pavel Skripkin <paskripkin@gmail.com> Signed-off-by:
Jaehee Park <jhpark1013@gmail.com> Link: https://lore.kernel.org/r/20220427153203.GA503502@jaehee-ThinkPad-X1-ExtremeSigned-off-by:
-
Vihas Makwana authored
The semaphore allrxreturnevt of struct recv_priv is initialized but not used anywhere in the code. Remove the initialization and the structure member. Signed-off-by:
-
