- 31 Mar, 2016 5 commits
-
-
Alexander Curtin authored
The channel_bytes attribute in the visor_device struct was meant to keep track of the number of bytes in the associated channel of the device. Not only is the variable never set nor used, but the information can already be accessed by referencing visor_device->visorchannel->nbytes. Signed-off-by:
Alexander Curtin <alexander.curtin@unisys.com> Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Alexander Curtin authored
The 'visor_device.devnodes' field was used for displaying driver version information through the devmajorminor sysfs attribute, which has recently been removed, rendering the field unnecessary. Signed-off-by:
-
Alexander Curtin authored
The visor_device.type field was included when preparing to remove the device_info struct. However, it's not used at all, and was already redundant by the existence of the 'visor_device.channel_type_guid' field. Signed-off-by:
-
Alexander Curtin authored
The 'description' variable in visor_device was added in preparation for removing the 'device_info' struct when the uislib files were removed. That attribute is never accessed nor set, and the 'name' attribute provides enough information to correctly identify the driver, it is not needed. Signed-off-by:
-
Alexander Curtin authored
The fields 'switch_no' and 'internal_port_no' were originally added to the visor_device struct in preparation of removing the 'device_info' struct in the now removed 'uislib' library. After the refactoring was complete, these attributes are not referenced anywhere, and there are no plans to use them. Signed-off-by:
-
- 29 Mar, 2016 35 commits
-
-
Claudiu Beznea authored
This patch removes "next" member of wlandevice_t since it is not used anywhere in the wlan-ng code. Signed-off-by:
Claudiu Beznea <claudiu.beznea@gmail.com> Signed-off-by:
-
Colin Ian King authored
max_d is not initialized and should be set to the largest D value of 6. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Dominique van den Broeck authored
Removing two "!= NULL" from fwserial.c as suggested by checkpatch.pl. Note that the associated expression "port->port.console" is a 1-bit-field that is already assumed as an implicit boolean (that is: without comparison) Signed-off-by:
Dominique van den Broeck <domdevlin@free.fr> Signed-off-by:
-
Dominique van den Broeck authored
Coding-style-only modifications to remove every warning saying: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Compiled against revision "next-20160327". (checkpatch.pl was updated to treat "UNSPECIFIED_INT" warnings as of commit a1ce18e4 ) Signed-off-by:
-
Ian Abbott authored
Fix checkpatch.pl warnings about lines over 80 characters in "comedi_fops.c". Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Aniket Sharma authored
This patch fixes the checkpatch.pl warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' + unsigned runflags; WARNING: Prefer 'unsigned int' to bare use of 'unsigned' +struct comedi_device *comedi_dev_get_from_minor(unsigned minor); Signed-off-by:
Aniket Sharma <badbuddha91@gmail.com> Reviewed-by:
-
Bhumika Goyal authored
The functions double_depth, check_card_fail, check_card_ejected are not used anywhere in the kernel. So, remove their prototype and definition. Grepped to find occurences. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
The functions rtsx_disable_card_int, rtsx_undo_delink, rtsx_check_link_ready are not used anywhere in the kernel. So,remove their definition and prototype. Signed-off-by:
-
Ben Marsh authored
Removes a blank line in order to silence a checkpatch.pl warning. Signed-off-by:
Ben Marsh <bmarsh94@gmail.com> Signed-off-by:
-
Claudiu Beznea authored
This patch convert usb_prism_tbl[] into a const array since it is not modified anywhere in prism2usb.c file. Signed-off-by:
-
Claudiu Beznea authored
This patch removes the memcpy() for two variables which were previously tested with memcmp(). The result of memcmp() was zero which means that the previously tested variables were already equal. Signed-off-by:
-
Ian Abbott authored
The zero-length file "ni_mio_c_common.c" was inadvertantly created by commit e563637b ("staging: comedi: Use ARRAY_SIZE for sizes of arrays"). Remove it. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:
-
Bhumika Goyal authored
The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head are never used anywhere in the kernel. So, remove their definition and prototype. Grepped to find occurences. Signed-off-by:
Julian Calaby <julian.calaby@gmail.com> Acked-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Bhumika Goyal authored
The functions rtw_get_oper_bw23a and rtw_get_oper_ch23aoffset are never used anywhere in the kernel. So, remove their definition and prototype. Grepped to find occurences. Signed-off-by:
-
Clifton Barnes authored
fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned'' Signed-off-by:
Clifton Barnes <clifton.a.barnes@gmail.com> Signed-off-by:
-
Clifton Barnes authored
fix checkpatch.pl warning about 'suspect code indent for conditional statements' Signed-off-by:
-
Clifton Barnes authored
fix checkpatch.pl warning about 'line over 80 characters' Signed-off-by:
-
Joe Perches authored
Remove the local inline and use the generic kernel rol64 instead. Miscellanea: o Added a newline between a multiple line macro for consistency with the other multiple line macros Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Chaehyun Lim authored
This patch replaces struct semaphore hSemScanReq with struct mutex scan_req_lock. It is better to use mutex than semaphore. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
struct semaphore SemHandleUpdateStats is defined but never used in this driver, so just remove it. Signed-off-by:
-
Chaehyun Lim authored
This patch changes data type of wid argument in wilc_wlan_cfg_get_val from u32 to u16. It is better to change data type of wid because wid has one of enum WID_T that is data type of u16. And, there is no need to use u16 type casting when calling wilc_wlan_cfg_get_wid_value function. Signed-off-by:
-
Chaehyun Lim authored
This patch changes data type of wid argument in wilc_wlan_cfg_get from u32 to u16. It is better to change data type of wid because wid has one of enum WID_T that is data type of u16. And, there is no need to use u16 type casting when calling wilc_wlan_cfg_get_wid function. Signed-off-by:
-
Chaehyun Lim authored
This patch changes data type of wid argument in wilc_wlan_cfg_set from u32 to u16. It is better to change data type of wid because wid has one of enum WID_T that is data type of u16. And, there is no need to use u16 type casting when calling wilc_wlan_cfg_set_wid function. Signed-off-by:
-
James Simmons authored
Convert cfs_workitem_t to proper structure. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/17202Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
James Simmons authored
Add the macro CFS_FAULT_CHECK() which behaves like CFS_FAIL_CHECK() except that any site may be matched by setting CFS_FAULT (0x02000000) in cfs_fail_loc. Add cfs_fail_err for use as a return value with CFS_FAULT_CHECK(). Signed-off-by:
Robert Read <robert.read@intel.com> Reviewed-by:
-
Jian Yu authored
On some customers' systems, the kernel was compiled with HZ defined to 100, instead of 1000. This improves performance for HPC applications. However, to use these systems with Lustre, customers have to re-build Lustre for the kernel because Lustre directly uses the defined constant HZ. Since kernel 2.6.21, some non-HZ dependent timing APIs become non- inline functions, which can be used in Lustre codes to replace the direct HZ access. These kernel APIs include: jiffies_to_msecs() jiffies_to_usecs() jiffies_to_timespec() msecs_to_jiffies() usecs_to_jiffies() timespec_to_jiffies() And here are some samples of the replacement: HZ -> msecs_to_jiffies(MSEC_PER_SEC) n * HZ -> msecs_to_jiffies(n * MSEC_PER_SEC) HZ / n -> msecs_to_jiffies(MSEC_PER_SEC / n) n / HZ -> jiffies_to_msecs(n) / MSEC_PER_SEC n / HZ * 1000 -> jiffies_to_msecs(n) This patch replaces the direct HZ access in the libcfs module. Signed-off-by:
Jian Yu <jian.yu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5443 Reviewed-on: http://review.whamcloud.com/11993Reviewed-by:
Nathaniel Clark <nathaniel.l.clark@intel.com> Reviewed-by:
James Simmons <uja.ornl@gmail.com> Reviewed-by:
-
Liang Zhen authored
initialise lock-class for each sublock of cfs_percpt_lock to eliminate false alarm ""possible recursive locking detected" Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6432 Reviewed-on: http://review.whamcloud.com/14368Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
-
James Simmons authored
Move the CPT handling declartions out of libcfs_private.h to libcfs_cpu.h where it belongs. Signed-off-by:
frank zago <fzago@cray.com> Signed-off-by:
-
James Simmons authored
The functions cfs_percpt_current() and cfs_percpt_index() are not used anywhere. Remove it. Signed-off-by:
-
James Simmons authored
libcfs contains functions to perform atomic memory operations. These functions have never been used so remove them. Signed-off-by:
-
James Simmons authored
Use signal_pending() directly instead of a one line function wrapper. Signed-off-by:
-
James Simmons authored
A few function declarations are in libcfs.h that are not needed. Signed-off-by:
-
Oleg Drokin authored
Commit b8ff756bc351 ("staging: lustre: libcfs: merge code from libcfs_ioctl into libcfs_ioctl_getdata") introduced a problem copying just a single pointer worth of data from userspace instead of whole libcfs_ioctl_hdr structure. Adjust the copying amount. Signed-off-by:Oleg Drokin <green@linuxhacker.ru> Acked-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Andreas Dilger authored
Use alloc_page() and use cfs_crypto_hash_update_page() to compute the hash instead of cfs_crypto_hash_digest(), since tgt_checksum_bulk() computes the hash by page anyway. Signed-off-by:
Alexander Boyko <alexander_boyko@xyratex.com> Reviewed-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
-
Andreas Dilger authored
Set cfs_crypto_hash_speeds[X] result to the actual error instead of -1. Make the error message more clear and informative. Signed-off-by:
-
