- 14 Jul, 2004 7 commits
-
-
Jeff Garzik authored
-
Anton Blanchard authored
During receive processing, the tg3 card updates rx_producer (the hardware position in the receive ring) and the opaque cookie. Due to PCI rules the stores happen in order. However the cpu may reorder the reads. In these sort of cases there is usually a data dependency between reading the index and looking up the data (since we use the index to load the data). I think all cpus except alpha guarantee the reads happen in order in this case. However in this particular case we load hw_idx, compare it to sw_idx and then use sw_idx to locate the opaque cookie. There is no data dependency in this case. We need a read memory barrier between the read of rx_producer and the opaque cookie to enforce ordering. Thanks to Olof Johansson, Michael Chan and Broadcom for their assistance in finding this bug. Signed-off-by: Anton Blanchard <anton@samba.org>
-
Andrew Morton authored
From: Bill Nottingham <notting@redhat.com> airo creates /proc/driver/aironet/<device name> on device activation. However, the device can be renamed - then on teardown it tries to remove the wrong directory. The removal of /proc/driver/aironet then runs afoul of the BUG_ON() in remove_proc_entry. This fixes it by keeping a copy of the name of the directory it created. (It doesn't actually solve the problem of the stats directory still being /proc/driver/aironet/eth0 when you rename the device to, say, 'joe'. But that patch would be a little less trivial.) Signed-off-by: Andrew Morton <akpm@osdl.org>
-
Margit Schubert-While authored
2004-07-12 Margit Schubert-While <margitsw@t-online.de> * The OID type for BSSID was incorrectly set to type SSID. It should be type RAW. This lead to interesting reporting by "iwpriv ethX g_bssid". (Which caused garbage output and possibly an out of bound) * Be ultra-cautious in reporting SSID by changing the "%s" to "%.*s" and passing the length. (Prompted by the false type above, whereby length = 0 and a %s on a garbage field)
-
Jeff Garzik authored
It's tulip driver, and tulip driver performs better than dmfe (yet some distro installers pick this driver to use). Requested by ALi.
-
Rusty Russell authored
From: a.othieno@bluewin.ch (Arthur Othieno)
-
Pavel Roskin authored
Here it is. The patch fixes all compile errors and warnings in pci-skeleton.c. The "debug" parameter lacks corresponding variable, so I removed it to avoid a warning on module load. Obsolete pci_power_on() and pci_power_off() have been replaced with the new code using pci_set_power_state(), pci_save_state() and pci_restore_state(). The driver has been tested by compiling it as module and as part of the kernel.
-
- 06 Jul, 2004 1 commit
-
-
Margit Schubert-While authored
2004-07-06 Margit Schubert-While <margitsw@t-online.de> * The frequency to channel conversion is wrong for the 5GHz band * Although the (known) devices don't/can't use it, they do report it. (iwlist ethX freq)
-
- 05 Jul, 2004 1 commit
-
-
- 06 Jul, 2004 3 commits
-
-
Dave Airlie authored
-
Dave Airlie authored
-
Dave Airlie authored
-
- 05 Jul, 2004 28 commits
-
-
Andrew Morton authored
drivers/video/kyro/fbdev.c: In function `kyrofb_probe': drivers/video/kyro/fbdev.c:736: warning: passing arg 1 of `memset' makes pointer from integer without a cast Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Adrian Bunk authored
allowdma0 is gone in 2.6, the patch below removes the mentionings of this option in the documentation. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
William Lee Irwin III authored
As ->vm_private_data is used as a cursor for swapout of VM_NONLINEAR vmas, the check for NULL ->vm_private_data or VM_RESERVED is too strict, and should allow VM_NONLINEAR vmas with non-NULL ->vm_private_data. This fixes an issue on 2.6.7-mm5 where system calls to remap_file_pages() spuriously failed while under memory pressure. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Christoph Hellwig authored
The __bdevname library function is leaking module references due to __bdevname ->get_gendisk ->kobj_lookup ->ata_probe ->get_disk ->try_module_get What we're trying to do in there is too ambitious. Change it to just print the major and minor. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Anton Blanchard authored
gcc 3.5 is warning about unused static variables, add __attribute_unused__ to the 2 places to silence it. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Anton Blanchard authored
gcc 3.5 is warning about static vs non static function declarations. The following patch removes function prototypes in .h files where possible and changes prototypes to be static elsewhere. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
William Lee Irwin III authored
For 32-bit, one quickly discovers that swapon() is not given an fd already opened with O_LARGEFILE to act upon and the forcing of O_LARGEFILE for 64-bit is irrelevant, as the system call's argument is a path. So this patch manually forces it for swapon() and swapoff(). Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Paul Jackson authored
With the following changes, I was able to compile the "sparc" (32 bit) arch, using defconfig and crosstool. There were still plenty of warnings, but nothing else relating to bitops or cpumasks that I noticed. This is working with 2.6.7-mm5. I have no way to boot test this, but these changes seem obvious enough that I'd recommend including them. Signed-off-by: Paul Jackson <pj@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Paul Jackson authored
It looks like someone removed UPF_RESOURCES in remove-upf_resources.patch in parallel with someone adding drivers/firmware/pcdp.c that references UPF_RESOURCES. In any event, trying to build a defconfig ia64 2.6.7-mm5 (which includes CONFIG_SERIAL_8250=y in the .config) fails with: drivers/firmware/pcdp.c: In function `setup_serial_console': drivers/firmware/pcdp.c:100: error: `UPF_RESOURCES' undeclared (first use in this function) Signed-off-by: Paul Jackson <pj@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
David Eger authored
radeonfb: the Stanford lock checker found us double-locking rinfo->reg_lock via sequences like OUTPLL(foo, INPLL(bar) | baz ), as both OUTPLL and INPLL grab the register lock. This should fix the problem. Signed-off-by: David Eger <eger@havoc.gtf.org Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Chris Wright authored
Move inline avc_cache_stats helper functions alongside the statically declared avc_cache_stats array. Signed-off-by: Chris Wright <chrisw@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Chris Wright authored
With gcc-3.5 from CVS: security/selinux/avc.c:76: error: static declaration of 'avc_cache_stats' follows non-static declaration security/selinux/include/avc.h:107: error: previous declaration of 'avc_cache_stats' was here Signed-off-by: Chris Wright <chrisw@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Dave Jones authored
smp_changes_mask is used by generic_set_all() which isn't __init Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Andrew Morton authored
With gcc from CVS: sound/isa/wavefront/wavefront_fx.c:697: error: static declaration of 'page_zero' follows non-static declaration include/sound/yss225.h:4: error: previous declaration of 'page_zero' was here Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Martin J. Bligh authored
At the moment, we initialise physnode_map from the various BIOS tables, which can create problems, as holes inside an node return 1 for pfn_valid, and yet pfn_to_nid is not correct for them. I'd hacked around this in my tree by defaulting the mapping to 0, not -1, but that's not the correct fix ... this is. I consolidated all the code back into 1 place, and use node_start_pfn[] and node_end_pfn[] to walk over it instead - that means it matches up perfectly with lmem_map's as we're using the same data. It also cleans up a lot of the code. Tested on both NUMA-Q and x440 ... and it only affects i386 NUMA boxen. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Mika Kukkonen authored
CHECK fs/udf/dir.c fs/udf/dir.c:240:13: warning: expected lvalue for member dereference [...] CHECK fs/udf/namei.c fs/udf/namei.c:872:6: warning: expected lvalue for member dereference fs/udf/namei.c:916:6: warning: expected lvalue for member dereference fs/udf/namei.c:1189:14: warning: expected lvalue for member dereference fs/udf/namei.c:1234:7: warning: expected lvalue for member dereference Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Andrey Panin authored
This patch moves reboot related workarounds out of dmi_scan.c Please consider applying. Signed-off-by: Andrey Panin <pazke@donpac.ru> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Andrew Morton authored
rmk added a check to vmlinux for undefined symbols in -mm kernels. ppc64 fails due to trying to export an unimplemented symbol from assembly code. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Olaf Hering authored
A native powerpc64-linux gcc can not compile a ppc32 kernel properly. This patch fixes it. It was copied from ppc64. The change to vmlinux.lds.S fixes this error: ld: warning: powerpc:common architecture of input file `init/built-in.o' is incompatible with powerpc:common64 output Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Anton Blanchard authored
Currently our spinlocks can call into the hypervisor on dedicated processor machines. Doing this may slow our locks down, so avoid it where possible. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Anton Blanchard authored
Here are the ppc64 specific gcc 3.5 fixes. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Anton Blanchard authored
gcc 3.5 ICEd on the ppc64 version of __ptep_set_access_flags, but it does look like we want to use *ptep here. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Paul Mackerras authored
From: Linas Vepstas <linas@austin.ibm.com> When an RTAS call returns the "hardware error" code, we need to do another RTAS call to find out what went wrong. Previously we weren't doing that inside the lock that serializes RTAS calls, and thus another cpu could get in and do another RTAS call in the meantime. This patch fixes it. This patch also includes some minor whitespace fixes. Signed-off-by: Linas Vepstas <linas@linas.org> Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Paul Mackerras authored
From: Linas Vepstas <linas@austin.ibm.com> This patch fixes the usage of the slot-error-detail log buffer for the Power5 architecture. The size of the error buffer is variable, and the correct size to use should have been obtained from firmware. Failure to use the correct buffer sizes will result in hard-to-debug system lockups deep in firmware. This patch is based on an earlier patch from Ben Herrenschmidt, which essentially did the same thing. This patch also tweaks some of the subroutine documentation. Signed-off-by: Linas Vepstas <linas@linas.org> Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Paul Mackerras authored
From: Linas Vepstas <linas@austin.ibm.com> This patch allows ppc64 to boot on Power5 machines. The new Power5 PCI bridge design requires EEH (enhanced PCI error handling) to be enabled for all PCI devices, not just some PCI devices. In addition, this patch moves the check for PCI to ISA bridges out of perf critical code, and into initialization code. This also avoids race conditions where the device type might not have been set. Also, some whitespace fixes, and some error-message-printing beautification. Signed-off-by: Linas Vepstas <linas@linas.org> Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Miles Bader authored
Signed-off-by: Miles Bader <miles@gnu.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Miles Bader authored
Otherwise recent versions of gcc seem to optimize away some necessary tests. Signed-off-by: Miles Bader <miles@gnu.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Miles Bader authored
Signed-off-by: Miles Bader <miles@gnu.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-