1. 19 Oct, 2021 2 commits
    • Arnd Bergmann's avatar
      media: i2c: select V4L2_ASYNC where needed · 570a82b9
      Arnd Bergmann authored
      I came across a link failure from randconfig builds:
      
      x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
      ths8200.c:(.text+0x491): undefined reference to `v4l2_async_unregister_subdev'
      x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
      ths8200.c:(.text+0xe49): undefined reference to `v4l2_async_register_subdev'
      x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_remove':
      tw9910.c:(.text+0x467): undefined reference to `v4l2_async_unregister_subdev'
      x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_probe':
      tw9910.c:(.text+0x1123): undefined reference to `v4l2_async_register_subdev'
      
      These clearly lack a 'select' statement, but I don't know why
      this started happening only now. I had a bit of a look around to find
      other configs that have the same problem, but could not come up with
      a reliable way and found nothing else through experimentation.
      It is likely that other symbols like these exist that need an extra
      select.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      570a82b9
    • Hans Verkuil's avatar
      media: vidtv: move kfree(dvb) to vidtv_bridge_dev_release() · 112024a3
      Hans Verkuil authored
      Adding kfree(dvb) to vidtv_bridge_remove() will remove the memory
      too soon: if an application still has an open filehandle to the device
      when the driver is unloaded, then when that filehandle is closed, a
      use-after-free access takes place to the freed memory.
      
      Move the kfree(dvb) to vidtv_bridge_dev_release() instead.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: 76e21bb8 ("media: vidtv: Fix memory leak in remove")
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      112024a3
  2. 18 Oct, 2021 1 commit
  3. 08 Oct, 2021 37 commits