- 07 Dec, 2023 10 commits
-
-
Zhipeng Lu authored
The dma_q->p_left_data alloced by kzalloc should be freed in all the following error handling paths. However, it hasn't been freed in the allocation error paths of dev->video_mode.isoc_ctl.urb and dev->video_mode.isoc_ctl.transfer_buffer. On the other hand, the dma_q->p_left_data did be freed in the error-handling paths after that of dev->video_mode.isoc_ctl.urb and dev->video_mode.isoc_ctl.transfer_buffer, by calling cx231xx_uninit_isoc(dev). So the same free operation should be done in error-handling paths of those two allocation. Fixes: 64fbf444 ("[media] cx231xx: Added support for Carraera, Shelby, RDx_253S and VIDEO_GRABBER") Signed-off-by:
Zhipeng Lu <alexious@zju.edu.cn> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl>
-
Geert Uytterhoeven authored
The StarFive Camera Subsystem is only present on the StarFive JH7110 SoC. Hence add a dependency on ARCH_STARFIVE, to prevent asking the user about this driver when configuring a kernel without StarFive SoC support. Fixes: bba185d1 ("media: staging: media: starfive: camss: Add core driver") Signed-off-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
Changhuang Liang <changhuang.liang@starfivetech.com> Signed-off-by:
-
Geert Uytterhoeven authored
The Chips&Media Wave 5 Series multi-standard codec IP is currently only supported on Texas Instruments K3 architecture. Hence add a dependency on ARCH_K3, to prevent asking the user about this driver when configuring a kernel without Texas Instruments K3 Multicore SoC support. Fixes: 9707a625 ("media: chips-media: wave5: Add the v4l2 layer") Signed-off-by:
Nishanth Menon <nm@ti.com> Signed-off-by:
-
Dan Carpenter authored
These > comparisons should be >=. The formats->fmts[] array is either a pointer to isp_formats_sink[] or isp_formats_source[] respectively. Fixes: e5785462 ("media: staging: media: starfive: camss: Add ISP driver") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by:
-
Michael Grzeschik authored
For dmabuf import users to be able to use the vaddr from another videobuf2-dma-sg source, the exporter needs to set a proper vaddr on vb2_dma_sg_dmabuf_ops_vmap callback. This patch adds vmap on map if buf->vaddr was not set. Cc: stable@kernel.org Fixes: 7938f421 ("dma-buf-map: Rename to iosys-map") Signed-off-by:
Michael Grzeschik <m.grzeschik@pengutronix.de> Acked-by:
Tomasz Figa <tfiga@chromium.org> Signed-off-by:
-
Detlev Casanova authored
Add AV1 information in visl documentation. Reviewed-by:
Daniel Almeida <daniel.almeida@collabora.com> Signed-off-by:
Detlev Casanova <detlev.casanova@collabora.com> Signed-off-by:
-
Detlev Casanova authored
Let the visl test driver accept the AV1 pixel format. Reviewed-by:
-
Lukas Bulwahn authored
Defines prefixed with "CONFIG" should be limited to proper Kconfig options, that are introduced in a Kconfig file. In the driver code, there is a define for CONFIG_VB2_GSC_DMA_CONTIG, but this is not used anywhere in the code. Just remove this unused definition. No functional change. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@gmail.com> Reviewed-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by:
-
AngeloGioacchino Del Regno authored
Instead of walking the entire parent node for something that has the right compatible, use the scp_get() function provided by the MediaTek SCP remoteproc driver to retrieve a handle to mtk_scp through the devicetree "mediatek,scp" (phandle) property. In case of multi-core SCP, this also allows to select a specific core. Reviewed-by:
Chen-Yu Tsai <wenst@chromium.org> Signed-off-by:
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by:
Alexandre Mergnat <amergnat@baylibre.com> Signed-off-by:
-
AngeloGioacchino Del Regno authored
The MDP3 RDMA needs to communicate with the SCP remote processor: allow specifying a phandle to a SCP core. Signed-off-by:
Conor Dooley <conor.dooley@microchip.com> Reviewed-by:
-
- 04 Dec, 2023 30 commits
-
-
Sebastian Reichel authored
v4l2_async_unbind_subdev_one(), which is called in the line following the list_move() operation contains list_move_tail() for the same entry and overrides anything list_move() did. Thus it can be removed. Signed-off-by:
Sebastian Reichel <sre@kernel.org> Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Sebastian Reichel authored
The list deletion call dropped here is already called from the helper function in the line before. Having a second list_del() call results in either a warning (with CONFIG_DEBUG_LIST=y): list_del corruption, c46c8198->next is LIST_POISON1 (00000100) If CONFIG_DEBUG_LIST is disabled the operation results in a kernel error due to NULL pointer dereference. Fixes: 28a12957 ("media: v4l: async: Allow multiple connections between entities") Signed-off-by:
-
Laurent Pinchart authored
Fix a simple indentation issue in the v4l2-subdev.h header. Fixes: f57fa295 ("media: v4l2-subdev: Add new ioctl for client capabilities") Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Sakari Ailus authored
Use V4L2 CCI for accessing device's registers. The 8-bit compatibility read option is removed but this is supported by regmap through other means. Also the CCS register definitions are re-generated with V4L2 CCI definitions. The older SMIA++ register definitions have been manually converted. Signed-off-by:
-
Sakari Ailus authored
Separate CCS static data read-only register access in ccs-reg-access.c by naming them differently. The code in this file generally deals with reading and writing registers where as static data (when it comes to ccs_static_data_read_ro_reg()) contains the read-only register values but no hardware registers are accessed in that case. Signed-off-by:
-
Sakari Ailus authored
Generate register definitions that are fit for use with V4L2 CCI. Signed-off-by:
-
Sakari Ailus authored
Add CCI_REG_WIDTH() macro to obtain register width in bits and similarly, CCI_REG_WIDTH_BYTES() to obtain it in bytes. Also add CCI_REG_ADDR() macro to obtain the address of a register. Use both macros in v4l2-cci.c, too. Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Reviewed-by:
-
Sakari Ailus authored
Provide a few bits for drivers to store private information on register definitions. Signed-off-by:
-
Sakari Ailus authored
linux/bits.h is needed for GENMASK(). Include it. Signed-off-by:
-
Laurent Pinchart authored
The isc_try_fse() function, called from isc_validate(), takes two parameters, an isc_device pointer, and a v4l2_subdev_state pointer. The isc_device is accessed but not modified by the function. The state is modified, including the struct v4l2_subdev_pad_config array it points to, but they are then never used by the caller. Furthermore, the V4L2 subdev operation called by isc_try_fse() doesn't modify the subdev it is called on. The isc_try_fse() function has thus no effect, and can just be dropped. Signed-off-by:
Eugen Hristev <eugen.hristev@collabora.com> Tested-by:
-
Sakari Ailus authored
Document that sub-device initialisation needs to complete before the async sub-device is registered as there is no further driver action needed before the sensor becomes accessible via the UAPI. Signed-off-by:
-
Sakari Ailus authored
As the sensor may be accessible right after its async sub-device is registered, enable runtime PM before doing so. Signed-off-by:
Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by:
-
Sakari Ailus authored
A number of CCS register value limits are in ireal or float format. Also convert them to integers for easier interpretation. Signed-off-by:
-
Bingbu Cao authored
As the sensor device maybe accessible right after its async sub-device is registered, such as ipu-bridge will try to power up sensor by sensor's client device's runtime PM from the async notifier callback, if runtime PM is not enabled, it will fail. So runtime PM should be ready before its async sub-device is registered and accessible by others. Fixes: d3f863a6 ("media: i2c: Add ov9734 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by:
Bingbu Cao <bingbu.cao@intel.com> Signed-off-by:
-
Bingbu Cao authored
As the sensor device maybe accessible right after its async sub-device is registered, such as ipu-bridge will try to power up sensor by sensor's client device's runtime PM from the async notifier callback, if runtime PM is not enabled, it will fail. So runtime PM should be ready before its async sub-device is registered and accessible by others. Fixes: 7ee85054 ("media: Add sensor driver support for the ov13b10 camera.") Cc: stable@vger.kernel.org Signed-off-by:
-
Bingbu Cao authored
As the sensor device maybe accessible right after its async sub-device is registered, such as ipu-bridge will try to power up sensor by sensor's client device's runtime PM from the async notifier callback, if runtime PM is not enabled, it will fail. So runtime PM should be ready before its async sub-device is registered and accessible by others. It also sets the runtime PM status to active as the sensor was turned on by i2c-core. Fixes: 0827b58d ("media: i2c: add ov01a10 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by:
-
Bingbu Cao authored
As the sensor device maybe accessible right after its async sub-device is registered, such as ipu-bridge will try to power up sensor by sensor's client device's runtime PM from the async notifier callback, if runtime PM is not enabled, it will fail. So runtime PM should be ready before its async sub-device is registered and accessible by others. Fixes: df0b5c4a ("media: add imx355 camera sensor driver") Cc: stable@vger.kernel.org Signed-off-by:
-
Hugues Fruchet authored
This V4L2 subdev driver enables Digital Camera Memory Interface Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series. Signed-off-by:
Hugues Fruchet <hugues.fruchet@foss.st.com> Signed-off-by:
Alain Volmat <alain.volmat@foss.st.com> Signed-off-by:
-
Alain Volmat authored
Add the entry related to the STM32 MEDIA DCMIPP driver within the MAINTAINERS file. Add myself as maintainer of the DCMI driver as well. Signed-off-by:
-
Alain Volmat authored
Add the yaml binding for the ST Microelectronics STM32 DCMIPP (Digital Camera Memory Interface Pixel Processor) Signed-off-by:
-
Alain Volmat authored
Allow parsing of the v4l2_fwnode properties from the DT and addition of those properties (such as orientation, rotation). Signed-off-by:
-
Alain Volmat authored
Any V4L2 subdevice that implements controls and declares V4L2_SUBDEV_FL_HAS_DEVNODE should also declare V4L2_SUBDEV_FL_HAS_EVENTS and implement subscribe_event and unsubscribe_event hooks. With that done, v4l2-compliance testing is now ok. Signed-off-by:
-
Alain Volmat authored
Add support of MEDIA_BUS_FMT_Y8_1X8. Signed-off-by:
-
Alain Volmat authored
link_frequency variable within struct mipid02_dev seems to have never been used hence remove it. Signed-off-by:
-
Alain Volmat authored
Use MIPI data-type macros. Signed-off-by:
-
Alain Volmat authored
Store formats information within pad allowing to simplify further more the driver (mutex / format store within the driver structure no more necessary). Signed-off-by:
-
Alain Volmat authored
Use cci_read & cci_write functions for accessing registers. Signed-off-by:
-
Alain Volmat authored
As explained in the following series, subdev do not have to keep track of their streaming status: https://lore.kernel.org/linux-media/20230914181704.4811-1-laurent.pinchart@ideasonboard.com/Signed-off-by:
-
Alain Volmat authored
Use the helper v4l2_get_link_freq instead of performing manually check of the LINK_FREQ or PIXELRATE ctrls. Signed-off-by:
-
Alain Volmat authored
Use a copy of the struct v4l2_subdev_format when propagating format from the sink to source pad in order to avoid impacting the sink format returned to the application. Thanks to Jacopo Mondi for pointing the issue. Fixes: 6c01e6f3 ("media: st-mipid02: Propagate format from sink to source pad") Signed-off-by:
Jacopo Mondi <jacopo.mondi@ideasonboard.com> Reviewed-by:
Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by:
Benjamin Mugnier <benjamin.mugnier@foss.st.com> Signed-off-by:
-
