Skip to content

L
linux
Switch branch/tag
  1. 05 Nov, 2010 5 commits
    • Ian Jeffray's avatar
      USB: musb: blackfin: fix musb_read_txhubport() definition · 5d726f5a
      Ian Jeffray authored 
      The new MUSB power code needs musb_read_txhubport() to
return a value (so stub it as 0 like the other Blackfin
hub funcs).
Signed-off-by: default avatarIan Jeffray <ian@jeffray.co.uk>
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      5d726f5a
    • Ming Lei's avatar
      USB: musb: gadget: fix MUSB_TXMAXP and MUSB_RXMAXP configuration · 31c9909b
      Ming Lei authored 
      Commit 9f445cb2[USB: musb: disable
double buffering for older RTL versions] tries to disable double
buffer mode by writing endpoint hw max packet size to TXMAP/RXMAP.

First the approach can break full speed and cause overflow problems.
We should always set those registers with the actual max packet size
from endpoint descriptor.

Second, the problem describe by commit 9f445cb2
was caused by musb gadget driver; nothing to do with RTL revision as
originaly suspected.

The real fix to the problem is to always use actual max packet
size from endpoint descriptor to config TXMAP/RXMAP registers.

Cc: Cliff Cai <cliff.cai@analog.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Anand Gadiyar <gadiyar@ti.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: stable@kernel.org
Signed-off-by: default avatarMing Lei <tom.leiming@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      31c9909b
    • Grazvydas Ignotas's avatar
      usb: musb: don't leave PHY enabled on shutdown() · 120d074c
      Grazvydas Ignotas authored 
      Some actions like musb_platform_exit are only performed on module
removal and not on shutdown, which results in PHY being left enabled
on reboot at least. This is sometimes causing strange failures after
reboot (observed on OMAP3 pandora board), when DEVCTL does not report
VBUS state correctly due to unknown reasons (possibly because of
communication issues between musb IP and PHY). Running
musb_platform_exit before reset seems to resolve that issue.

Move some exit code from musb_remove() to musb_shutdown() so that it
is performed on both module removal and shutdown/reset. Also convert
the host check so that it doesn't need #ifdef.
Signed-off-by: default avatarGrazvydas Ignotas <notasas@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      120d074c
    • Rahul Ruikar's avatar
      usb: musb: musb_gadget: fix resource leakage in error path · e2c34045
      Rahul Ruikar authored 
      In function musb_gadget_setup() call put_device()
when device_register() fails.
Signed-off-by: default avatarRahul Ruikar <rahul.ruikar@gmail.com>
Acked-by: default avatarMing Lei <tom.leiming@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      e2c34045
    • Ming Lei's avatar
      usb: musb: gadget: fix dma mode 0 in double buffer Rx case · 9001d80d
      Ming Lei authored 
      1, In Rx double buffer case, FIFO may have two packets, so
rxstate should be called to unload fifo if RXPKTRDY is set
even the current request has not been completed.

2, Commit 633ba7876b96ec339ef685357e2f7c60b5a8ce85
introduces autoclear to support double buffer in dma mode 0,
so remove clearing RXPKTRDY manually for dma mode 0.

3, Commit c7af6b29ffeffbeb28caf39e5b2ce29b11807c7d may break
dma mode 1 for non-doublebuffer endpoint, fix it.

With this patch, either usbtest #5 or g_file_storage(writing
file to device in usb host) or g_ether have been tested OK in
double buffer case(using fifo mode 3). Also, this patch has
been verified that single buffer case can't be broken.

Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Anand Gadiyar <gadiyar@ti.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: default avatarMing Lei <tom.leiming@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      9001d80d
  3. 01 Nov, 2010 10 commits
  5. 31 Oct, 2010 14 commits
  7. 30 Oct, 2010 11 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7