- 09 Feb, 2023 24 commits
-
-
Paul Cercueil authored
On JZ4770 and JZ4780, the CLK32K pin is configurable. By default, it is configured as a GPIO in input mode, and its value can be read through GPIO PD14. With this change, clients can now request the 32 kHz clock on the CLK32K pin, through Device Tree. This clock is simply a pass-through of the input oscillator's clock with enable/disable operations. This will permit the WiFi/Bluetooth chip to work on the MIPS CI20 board, which does source one of its clocks from the CLK32K pin. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Link: https://lore.kernel.org/r/20230129120442.22858-5-paul@crapouillou.netSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Paul Cercueil authored
Use dev_err_probe() where it makes sense to simplify a bit the code. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Link: https://lore.kernel.org/r/20230129120442.22858-4-paul@crapouillou.netSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Paul Cercueil authored
Use readl_poll_timeout() from <iopoll.h> instead of using custom poll loops. The timeout settings are different, but that shouldn't be much of a problem. Instead of polling 10000 times in a close loop, it polls for one millisecond. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Link: https://lore.kernel.org/r/20230129120442.22858-3-paul@crapouillou.netSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Paul Cercueil authored
The RTC in the JZ4770 is compatible with the JZ4760, but has an extra register that permits to configure the behaviour of the CLK32K pin. The same goes for the RTC in the JZ4780. With this change, the RTC node is now also a clock provider on these SoCs, so a #clock-cells property is added. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20230129120442.22858-2-paul@crapouillou.netSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Dmitry Torokhov authored
MOXA ART RTC driver has been switched to gpiod API and is now using properly named properties for its gpios (with gpiolib implementing a quirk to recognize legacy names). Change binding document to use proper names as well. Signed-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com> Link: https://lore.kernel.org/r/20230201054815.4112632-2-dmitry.torokhov@gmail.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Dmitry Torokhov authored
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. This makes driver use standard property name for its gpios ("rtc-*-gpios" vs "gpios-rtc-*"), however there is a quirk in gpiolib to also recognize legacy names and keep compatibility with older DTSes: eaf1a296 ("gpiolib: of: add a quirk for legacy names in MOXA ART RTC"). Signed-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com> Link: https://lore.kernel.org/r/20230201054815.4112632-1-dmitry.torokhov@gmail.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
For consistency with the rest of the driver, drop the last two error messages for conditions that should only occur during development, if ever. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20230202155448.6715-16-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Clean up local declarations somewhat by using the reverse xmas style consistently throughout. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-15-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
In preparation for adding support for setting the time by means of an externally stored offset, refactor read_time() by adding a new helper that can be used to retrieve the raw time as stored in the RTC. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20230202155448.6715-14-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
The PMIC RTC registers are 32-bit so explicitly use u32 rather than unsigned long for timestamps to reflect the hardware. This will also help avoid unintentional range extensions when adding support for managing an external offset. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20230202155448.6715-13-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Clean up the driver comments somewhat and remove obsolete, incorrect or redundant ones. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-12-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Clean up the driver somewhat by renaming the driver-data alarm irq variable by dropping the redundant "rtc" prefix. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-11-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Rename the driver-data struct device pointer by dropping the "rtc" prefix which is both redundant and misleading (as this is a pointer to the platform device and not the rtc class device). Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-10-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Clean up the time and alarm callback debugging by using a consistent and succinct human-readable (i.e. non-raw) format. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-9-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Use the unaligned le32 helpers instead of open coding when accessing the time and alarm registers. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-8-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Drop the original register defines which have been unused since commit c8d523a4 ("drivers/rtc/rtc-pm8xxx.c: rework to support pm8941 rtc"). Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-7-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
In the unlikely event that disabling the alarm and clearing the status ever fails, return IRQ_NONE instead of IRQ_HANDLED. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20230202155448.6715-6-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Since commit c8d523a4 ("drivers/rtc/rtc-pm8xxx.c: rework to support pm8941 rtc") which removed the shadow control register there is no need for a driver lock. Specifically, the rtc ops are serialised by rtc core and the interrupt handler only unconditionally disables the alarm using the alarm_ctrl register. Note that since only the alarm enable bit of alarm_ctrl is used after enabling the RTC at probe, the locking was not needed when doing open coded read-modify-write cycles either. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-5-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Switch to using regmap_update_bits() instead of open coding read-modify-write accesses. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-4-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Drop the unnecessary error messages after every spmi regmap access, which are not expected to fail. Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20230202155448.6715-3-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Johan Hovold authored
Make sure to disable the alarm before updating the four alarm time registers to avoid spurious alarms during the update. Note that the disable needs to be done outside of the ctrl_reg_lock section to prevent a racing alarm interrupt from disabling the newly set alarm when the lock is released. Fixes: 9a9a54ad ("drivers/rtc: add support for Qualcomm PMIC8xxx RTC") Cc: stable@vger.kernel.org # 3.1 Signed-off-by:
Johan Hovold <johan+linaro@kernel.org> Reviewed-by:
David Collins <quic_collinsd@quicinc.com> Link: https://lore.kernel.org/r/20230202155448.6715-2-johan+linaro@kernel.orgSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Heiner Kallweit authored
Convert Amlogic Meson vrtc controller binding to yaml. Signed-off-by:
Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/d820d54b-d082-589a-621f-2795d885696a@gmail.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Sascha Hauer authored
RTC core never calls rv8803_set_alarm with an invalid alarm time, so if an invalid alarm time > 0 is set, external factors must have corrupted the RTC's alarm time and possibly other registers. Play it safe by marking the date/time invalid, so all registers are reinitialized on a ->set_time. This may cause existing setups to lose time if they so far set only date/time, but ignored that the alarm registers had an invalid date value, e.g.: rtc rtc0: invalid alarm value: 2020-3-27 7:82:0 These systems will have their ->get_time return -EINVAL till ->set_time initializes the alarm value (and sets a new time). Signed-off-by:
Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by:
Sascha Hauer <s.hauer@pengutronix.de> Link: https://lore.kernel.org/r/20221123095527.2771434-3-s.hauer@pengutronix.deSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Ahmad Fatoum authored
bcd2bin(0x0A) happily returns 10, despite this being an invalid BCD value. RTC drivers converting possibly corrupted BCD timestamps might want to validate their input before calling bcd2bin(). Provide a macro to do so. Unlike bcd2bin and bin2bcd, out-of-line versions are not implemented. Should the macro experience enough use, this can be retrofitted. Signed-off-by:
Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by:
Sascha Hauer <s.hauer@pengutronix.de> Link: https://lore.kernel.org/r/20221123095527.2771434-2-s.hauer@pengutronix.deSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
- 01 Feb, 2023 13 commits
-
-
Uwe Kleine-König authored
rtc-max8907 is a platform driver that doesn't use any symbol provided in <linux/i2c.h>. So drop the include. Signed-off-by:
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20221219081440.1399791-1-u.kleine-koenig@pengutronix.deSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-1-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-12-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-11-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-10-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-9-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-8-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-7-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-6-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-5-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-4-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-3-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Alexandre Belloni authored
Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Link: https://lore.kernel.org/r/20230123200217.1236011-2-alexandre.belloni@bootlin.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
- 25 Jan, 2023 3 commits
-
-
Hugo Villeneuve authored
pca/pcf2129 devices can also have the 'reset-source' property, so remove them from the trivial RTC devices list. Signed-off-by:
Hugo Villeneuve <hvilleneuve@dimonoff.com> Reviewed-by:
Bruno Thomsen <bruno.thomsen@gmail.com> Reviewed-by:
Rob Herring <robh@kernel.org> Acked-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20221220152237.1125178-1-hugo@hugovil.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Doug Berger authored
The wake interrupt only fires when the system is in a suspend state. Fortunately we have another interrupt that fires in a non-suspend state at the L2 controller UPG_AUX_AON. Add support for this interrupt line so we can use the alarm in a non-wake context. Signed-off-by:
Doug Berger <opendmb@gmail.com> Acked-by:
Florian Fainelli <f.fainelli@gmail.com> Link: https://lore.kernel.org/r/20230124201430.2502371-3-opendmb@gmail.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-
Doug Berger authored
A second interrupt can optionally be specified for this device to be used for generating RTC alarm interrupts. Signed-off-by:
Doug Berger <opendmb@gmail.com> Acked-by:
Florian Fainelli <f.fainelli@gmail.com> Reviewed-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20230124201430.2502371-2-opendmb@gmail.comSigned-off-by:
Alexandre Belloni <alexandre.belloni@bootlin.com>
-