1. 18 Jun, 2018 5 commits
    • Sean Wang's avatar
      pinctrl: mt7622: fix a kernel panic when pio don't work as EINT controller · 5f591543
      Sean Wang authored
      The function, external interrupt controller, is made as an optional to
      mt7622 pinctrl. But if we don't want pio behaves as an external interrupt
      controller, it would lead to hw->eint not be created properly and then
      will cause 'kernel NULL pointer' issue when gpiochip try to call .to_irq
      or .set_config. To fix it, check hw->eint before accessing the member.
      
      [    1.339494] Unable to handle kernel NULL pointer dereference at virtual
      	       address 00000010
      [    1.347857] Mem abort info:
      [    1.350742]   ESR = 0x96000005
      [    1.353905]   Exception class = DABT (current EL), IL = 32 bits
      [    1.360024]   SET = 0, FnV = 0
      [    1.363185]   EA = 0, S1PTW = 0
      [    1.366431] Data abort info:
      [    1.369405]   ISV = 0, ISS = 0x00000005
      [    1.373363]   CM = 0, WnR = 0
      [    1.376437] [0000000000000010] user address but active_mm is swapper
      [    1.383005] Internal error: Oops: 96000005 [#1] PREEMPT SMP
      [    1.388748] Modules linked in:
      [    1.391897] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.16.0-rc1+ #344
      [    1.398625] Hardware name: MediaTek MT7622 RFB1 board (DT)
      [    1.404279] pstate: 80000005 (Nzcv daif -PAN -UAO)
      [    1.409221] pc : mtk_eint_find_irq+0x8/0x24
      [    1.413532] lr : mtk_gpio_to_irq+0x20/0x28
      [    1.417749] sp : ffffff800801baf0
      [    1.421161] x29: ffffff800801baf0 x28: ffffff8008792f40
      [    1.426637] x27: ffffff800886b000 x26: ffffff8008615620
      [    1.432113] x25: ffffffc00e4dbdc8 x24: ffffff80087b8000
      [    1.437589] x23: ffffffc00325a000 x22: ffffffc00325a010
      [    1.443066] x21: ffffffc0033dec18 x20: 00000000ffffffea
      [    1.448542] x19: ffffffc00e4db800 x18: 0000000000000130
      [    1.454018] x17: 000000000000000e x16: 0000000000000007
      [    1.459494] x15: ffffff80085ee000 x14: 0000000000000001
      [    1.464970] x13: 0000000000000001 x12: 0000000000000010
      [    1.470446] x11: 0101010101010101 x10: 0000000000000880
      [    1.475922] x9 : ffffff800801b990 x8 : ffffffc0030688e0
      [    1.481399] x7 : ffffff80080c0660 x6 : ffffffc00e4dbbb0
      [    1.486875] x5 : 0000000000000000 x4 : 0000000000000000
      [    1.492351] x3 : ffffff80082a92f4 x2 : 00000000fffffffa
      [    1.497826] x1 : 0000000000000051 x0 : 0000000000000000
      [    1.503305] Process swapper/0 (pid: 1, stack limit = 0x0000000054e053bd)
      [    1.510210] Call trace:
      [    1.512727]  mtk_eint_find_irq+0x8/0x24
      [    1.516677]  mtk_gpio_to_irq+0x20/0x28
      [    1.520539]  gpiod_to_irq+0x48/0x60
      [    1.524135]  mmc_gpiod_request_cd_irq+0x3c/0xc4
      [    1.528804]  mmc_start_host+0x6c/0x8c
      [    1.532575]  mmc_add_host+0x58/0x7c
      [    1.536168]  msdc_drv_probe+0x4fc/0x67c
      [    1.540121]  platform_drv_probe+0x58/0xa4
      [    1.544251]  driver_probe_device+0x204/0x44c
      [    1.548649]  __driver_attach+0x84/0xf8
      [    1.552512]  bus_for_each_dev+0x68/0xa0
      [    1.556461]  driver_attach+0x20/0x28
      [    1.560142]  bus_add_driver+0xec/0x240
      [    1.564002]  driver_register+0x98/0xe4
      [    1.567863]  __platform_driver_register+0x48/0x50
      [    1.572711]  mt_msdc_driver_init+0x18/0x20
      [    1.576932]  do_one_initcall+0x98/0x130
      [    1.580886]  kernel_init_freeable+0x13c/0x1d4
      [    1.585375]  kernel_init+0x10/0xf8
      [    1.588879]  ret_from_fork+0x10/0x18
      [    1.592564] Code: a8c67bfd d65f03c0 a9bf7bfd 910003fd (f9400800)
      [    1.598849] ---[ end trace 4bbcb7bc30e98492 ]---
      [    1.603677] Kernel panic - not syncing: Attempted to kill init!
      	       exitcode=0x0000000b
      [    1.603677]
      
      cc: Kevin Hilman <khilman@baylibre.com>
      Cc: stable@vger.kernel.org
      Fixes: e6dabd38 ("pinctrl: mediatek: add EINT support to MT7622 SoC")
      Signed-off-by: default avatarSean Wang <sean.wang@mediatek.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      5f591543
    • Geert Uytterhoeven's avatar
      pinctrl: actions: Fix uninitialized error in owl_pin_config_set() · 71fd5d07
      Geert Uytterhoeven authored
      With gcc 4.1.2:
      
          drivers/pinctrl/actions/pinctrl-owl.c: In function ‘owl_pin_config_set’:
          drivers/pinctrl/actions/pinctrl-owl.c:336: warning: ‘ret’ may be used uninitialized in this function
      
      Indeed, if num_configs is zero, the uninitialized value will be returned
      as an error code.
      
      Fix this by preinitializing it to zero.
      
      Fixes: 2242ddfb ("pinctrl: actions: Add Actions S900 pinctrl driver")
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Acked-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      71fd5d07
    • Colin Ian King's avatar
      pinctrl: single: Add allocation failure checking of saved_vals · 7f57871f
      Colin Ian King authored
      Currently saved_vals is being allocated and there is no check for
      failed allocation (which is more likely than normal when using
      GFP_ATOMIC).  Fix this by checking for a failed allocation and
      propagating this error return down the the caller chain.
      
      Detected by CoverityScan, CID#1469841 ("Dereference null return value")
      Fixes: 88a1dbde ("pinctrl: pinctrl-single: Add functions to save and restore pinctrl context")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Reviewed-by: default avatarJohan Hovold <johan@kernel.org>
      Acked-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      7f57871f
    • Fabio Estevam's avatar
      pinctrl: devicetree: Fix pctldev pointer overwrite · bc3322bc
      Fabio Estevam authored
      Commit b89405b6 ("pinctrl: devicetree: Fix dt_to_map_one_config
      handling of hogs") causes the pinctrl hog pins to not get initialized
      on i.MX platforms leaving them with the IOMUX settings untouched.
      
      This causes several regressions on i.MX such as:
      
      - OV5640 camera driver can not be probed anymore on imx6qdl-sabresd
      because the camera clock pin is in a pinctrl_hog group and since
      its pinctrl initialization is skipped, the camera clock is kept
      in GPIO functionality instead of CLK_CKO function.
      
      - Audio stopped working on imx6qdl-wandboard and imx53-qsb for
      the same reason.
      
      Richard Fitzgerald explains the problem:
      
      "I see the bug. If the hog node isn't a 1st level child of the pinctrl
      parent node it will go around the for(;;) loop again but on the first
      pass I overwrite pctldev with the result of
      get_pinctrl_dev_from_of_node() so it doesn't point to the pinctrl driver
      any more."
      
      Fix the issue by stashing the original pctldev so it doesn't
      get overwritten.
      
      Fixes:  b89405b6 ("pinctrl: devicetree: Fix dt_to_map_one_config handling of hogs")
      Cc: <stable@vger.kernel.org>
      Reported-by: default avatarMika Penttilä <mika.penttila@nextfour.com>
      Reported-by: default avatarSteve Longerbeam <slongerbeam@gmail.com>
      Suggested-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
      Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
      Reviewed-by: default avatarDong Aisheng <aisheng.dong@nxp.com>
      Reviewed-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      bc3322bc
    • Wei Yongjun's avatar
      pinctrl: mediatek: remove redundant return value check of platform_get_resource() · fb7298e1
      Wei Yongjun authored
      Remove unneeded error handling on the result of a call
      to platform_get_resource() when the value is passed to
      devm_ioremap_resource().
      Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      fb7298e1
  2. 16 Jun, 2018 8 commits
    • Linus Torvalds's avatar
      Linux 4.18-rc1 · ce397d21
      Linus Torvalds authored
      ce397d21
    • Linus Torvalds's avatar
      Merge tag 'for-linus-20180616' of git://git.kernel.dk/linux-block · 265c5596
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
       "A collection of fixes that should go into -rc1. This contains:
      
         - bsg_open vs bsg_unregister race fix (Anatoliy)
      
         - NVMe pull request from Christoph, with fixes for regressions in
           this window, FC connect/reconnect path code unification, and a
           trace point addition.
      
         - timeout fix (Christoph)
      
         - remove a few unused functions (Christoph)
      
         - blk-mq tag_set reinit fix (Roman)"
      
      * tag 'for-linus-20180616' of git://git.kernel.dk/linux-block:
        bsg: fix race of bsg_open and bsg_unregister
        block: remov blk_queue_invalidate_tags
        nvme-fabrics: fix and refine state checks in __nvmf_check_ready
        nvme-fabrics: handle the admin-only case properly in nvmf_check_ready
        nvme-fabrics: refactor queue ready check
        blk-mq: remove blk_mq_tagset_iter
        nvme: remove nvme_reinit_tagset
        nvme-fc: fix nulling of queue data on reconnect
        nvme-fc: remove reinit_request routine
        blk-mq: don't time out requests again that are in the timeout handler
        nvme-fc: change controllers first connect to use reconnect path
        nvme: don't rely on the changed namespace list log
        nvmet: free smart-log buffer after use
        nvme-rdma: fix error flow during mapping request data
        nvme: add bio remapping tracepoint
        nvme: fix NULL pointer dereference in nvme_init_subsystem
        blk-mq: reinit q->tag_set_list entry only after grace period
      265c5596
    • Linus Torvalds's avatar
      Merge tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental · 5e7b9212
      Linus Torvalds authored
      Pull documentation fixes from Mauro Carvalho Chehab:
       "This solves a series of broken links for files under Documentation,
        and improves a script meant to detect such broken links (see
        scripts/documentation-file-ref-check).
      
        The changes on this series are:
      
         - can.rst: fix a footnote reference;
      
         - crypto_engine.rst: Fix two parsing warnings;
      
         - Fix a lot of broken references to Documentation/*;
      
         - improve the scripts/documentation-file-ref-check script, in order
           to help detecting/fixing broken references, preventing
           false-positives.
      
        After this patch series, only 33 broken references to doc files are
        detected by scripts/documentation-file-ref-check"
      
      * tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental: (26 commits)
        fix a series of Documentation/ broken file name references
        Documentation: rstFlatTable.py: fix a broken reference
        ABI: sysfs-devices-system-cpu: remove a broken reference
        devicetree: fix a series of wrong file references
        devicetree: fix name of pinctrl-bindings.txt
        devicetree: fix some bindings file names
        MAINTAINERS: fix location of DT npcm files
        MAINTAINERS: fix location of some display DT bindings
        kernel-parameters.txt: fix pointers to sound parameters
        bindings: nvmem/zii: Fix location of nvmem.txt
        docs: Fix more broken references
        scripts/documentation-file-ref-check: check tools/*/Documentation
        scripts/documentation-file-ref-check: get rid of false-positives
        scripts/documentation-file-ref-check: hint: dash or underline
        scripts/documentation-file-ref-check: add a fix logic for DT
        scripts/documentation-file-ref-check: accept more wildcards at filenames
        scripts/documentation-file-ref-check: fix help message
        media: max2175: fix location of driver's companion documentation
        media: v4l: fix broken video4linux docs locations
        media: dvb: point to the location of the old README.dvb-usb file
        ...
      5e7b9212
    • Linus Torvalds's avatar
      Merge tag 'fsnotify_for_v4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs · dbb2816f
      Linus Torvalds authored
      Pull fsnotify updates from Jan Kara:
       "fsnotify cleanups unifying handling of different watch types.
      
        This is the shortened fsnotify series from Amir with the last five
        patches pulled out. Amir has modified those patches to not change
        struct inode but obviously it's too late for those to go into this
        merge window"
      
      * tag 'fsnotify_for_v4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
        fsnotify: add fsnotify_add_inode_mark() wrappers
        fanotify: generalize fanotify_should_send_event()
        fsnotify: generalize send_to_group()
        fsnotify: generalize iteration of marks by object type
        fsnotify: introduce marks iteration helpers
        fsnotify: remove redundant arguments to handle_event()
        fsnotify: use type id to identify connector object type
      dbb2816f
    • Linus Torvalds's avatar
      Merge tag 'fbdev-v4.18' of git://github.com/bzolnier/linux · 644f2639
      Linus Torvalds authored
      Pull fbdev updates from Bartlomiej Zolnierkiewicz:
       "There is nothing really major here, few small fixes, some cleanups and
        dead drivers removal:
      
         - mark omapfb drivers as orphans in MAINTAINERS file (Tomi Valkeinen)
      
         - add missing module license tags to omap/omapfb driver (Arnd
           Bergmann)
      
         - add missing GPIOLIB dependendy to omap2/omapfb driver (Arnd
           Bergmann)
      
         - convert savagefb, aty128fb & radeonfb drivers to use msleep & co.
           (Jia-Ju Bai)
      
         - allow COMPILE_TEST build for viafb driver (media part was reviewed
           by media subsystem Maintainer)
      
         - remove unused MERAM support from sh_mobile_lcdcfb and shmob-drm
           drivers (drm parts were acked by shmob-drm driver Maintainer)
      
         - remove unused auo_k190xfb drivers
      
         - misc cleanups (Souptick Joarder, Wolfram Sang, Markus Elfring, Andy
           Shevchenko, Colin Ian King)"
      
      * tag 'fbdev-v4.18' of git://github.com/bzolnier/linux: (26 commits)
        fb_omap2: add gpiolib dependency
        video/omap: add module license tags
        MAINTAINERS: make omapfb orphan
        video: fbdev: pxafb: match_string() conversion fixup
        video: fbdev: nvidia: fix spelling mistake: "scaleing" -> "scaling"
        video: fbdev: fix spelling mistake: "frambuffer" -> "framebuffer"
        video: fbdev: pxafb: Convert to use match_string() helper
        video: fbdev: via: allow COMPILE_TEST build
        video: fbdev: remove unused sh_mobile_meram driver
        drm: shmobile: remove unused MERAM support
        video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support
        video: fbdev: remove unused auo_k190xfb drivers
        video: omap: Improve a size determination in omapfb_do_probe()
        video: sm501fb: Improve a size determination in sm501fb_probe()
        video: fbdev-MMP: Improve a size determination in path_init()
        video: fbdev-MMP: Delete an error message for a failed memory allocation in two functions
        video: auo_k190x: Delete an error message for a failed memory allocation in auok190x_common_probe()
        video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two functions
        video: sh_mobile_meram: Delete an error message for a failed memory allocation in sh_mobile_meram_probe()
        video: fbdev: sh_mobile_meram: Drop SUPERH platform dependency
        ...
      644f2639
    • Linus Torvalds's avatar
      Merge branch 'afs-proc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs · 35773c93
      Linus Torvalds authored
      Pull AFS updates from Al Viro:
       "Assorted AFS stuff - ended up in vfs.git since most of that consists
        of David's AFS-related followups to Christoph's procfs series"
      
      * 'afs-proc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
        afs: Optimise callback breaking by not repeating volume lookup
        afs: Display manually added cells in dynamic root mount
        afs: Enable IPv6 DNS lookups
        afs: Show all of a server's addresses in /proc/fs/afs/servers
        afs: Handle CONFIG_PROC_FS=n
        proc: Make inline name size calculation automatic
        afs: Implement network namespacing
        afs: Mark afs_net::ws_cell as __rcu and set using rcu functions
        afs: Fix a Sparse warning in xdr_decode_AFSFetchStatus()
        proc: Add a way to make network proc files writable
        afs: Rearrange fs/afs/proc.c to remove remaining predeclarations.
        afs: Rearrange fs/afs/proc.c to move the show routines up
        afs: Rearrange fs/afs/proc.c by moving fops and open functions down
        afs: Move /proc management functions to the end of the file
      35773c93
    • Linus Torvalds's avatar
      Merge branch 'work.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs · 29d6849d
      Linus Torvalds authored
      Pull compat updates from Al Viro:
       "Some biarch patches - getting rid of assorted (mis)uses of
        compat_alloc_user_space().
      
        Not much in that area this cycle..."
      
      * 'work.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
        orangefs: simplify compat ioctl handling
        signalfd: lift sigmask copyin and size checks to callers of do_signalfd4()
        vmsplice(): lift importing iovec into vmsplice(2) and compat counterpart
      29d6849d
    • Linus Torvalds's avatar
      Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs · a5b729ea
      Linus Torvalds authored
      Pull aio fixes from Al Viro:
       "Assorted AIO followups and fixes"
      
      * 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
        eventpoll: switch to ->poll_mask
        aio: only return events requested in poll_mask() for IOCB_CMD_POLL
        eventfd: only return events requested in poll_mask()
        aio: mark __aio_sigset::sigmask const
      a5b729ea
  3. 15 Jun, 2018 27 commits