- 04 Mar, 2024 8 commits
-
-
Matthew Sakai authored
Signed-off-by:
Matthew Sakai <msakai@redhat.com> Signed-off-by:
Mike Snitzer <snitzer@kernel.org>
-
Chung Chung authored
Ignore scnprintf return status since it is not necessary. Change write_* functions type from int to void since we no longer return any result. Also, clean up any code that checks or uses any scnprintf return results. Check uds_allocate return code which was previous ignored, return and log error when uds_allocate failed. Reported-by:
Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by:
Chung Chung <cchung@redhat.com> Signed-off-by:
-
Mike Snitzer authored
Reported when building on loongarch. Reported-by:
Randy Dunlap <rdunlap@infradead.org> Signed-off-by:
Bruce Johnston <bjohnsto@redhat.com> Signed-off-by:
-
Mike Snitzer authored
Must mutex_lock after dm_bufio_read, before dm_bufio_read error handling, otherwise process_entry error path will return without volume->read_threads_mutex held. This fixes potential double mutex_unlock. Reported-by:
Susan LeGendre-McGhee <slegendr@redhat.com> Signed-off-by:
-
Mike Snitzer authored
Otherwise, error path could result in allocate_flush's subsequent check for flush being non-NULL leading to false positive. Reported-by:
-
Dan Carpenter authored
This is a duplicate check so it can't be true. Delete it. Signed-off-by:
-
Mike Snitzer authored
Signed-off-by:
-
Susan LeGendre-McGhee authored
Signed-off-by:
-
- 01 Mar, 2024 15 commits
-
-
Mike Snitzer authored
Also moved vdo_init()'s call to vdo_initialize_thread_device_registry next to other registry initialization. Signed-off-by:
-
Mike Snitzer authored
Otherwise, uds_ prefix is misleading (vdo_ is the new catch-all for code that is used by vdo-only or _both_ vdo and the indexer code). Signed-off-by:
-
Mike Snitzer authored
Signed-off-by:
-
Mike Snitzer authored
Change thread function prefix from "uds_" to "vdo_" and fix vdo_join_threads() to return void. Signed-off-by:
-
Mike Snitzer authored
Just use mutex_init, mutex_lock and mutex_unlock. Signed-off-by:
-
Mike Snitzer authored
Only used by indexer components. Also return void from uds_init_cond(), remove uds_destroy_cond(), and fix up all callers. Signed-off-by:
-
Mike Snitzer authored
Further cleanup is needed for thread-utils interfaces given many functions should return void or be removed entirely because they amount to obfuscation via wrappers. Signed-off-by:
-
Mike Snitzer authored
Also remove unnecessary include from funnel-queue.c. Signed-off-by:
-
Mike Snitzer authored
Signed-off-by:
-
Mike Snitzer authored
Rename 'barrier' to 'threads_barrier', remove useless uds_destroy_barrier(), return void from remaining methods and clean up uds_make_sparse_cache() accordingly. Also remove uds_ prefix from the 2 remaining threads_barrier functions. Signed-off-by:
-
Mike Snitzer authored
The sparse-cache is the only user of the 'barrier' data structure, so just move it private to it. Signed-off-by:
-
Mike Snitzer authored
The implementation of thread 'barrier' data structure does not require overdone private semaphore wrappers. Also rename the barrier structure's 'mutex' member (a semaphore) to 'lock'. Signed-off-by:
-
Mike Snitzer authored
Signed-off-by:
-
Mike Snitzer authored
Only used for log message, but no need for "UDS_" prefix. Signed-off-by:
-
Harshit Mogalapalli authored
Use "==" instead of "=" in ASSERT() statement. Fixes: ef074a31e88e ("dm vdo: implement the volume index") Signed-off-by:Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Signed-off-by:
-
- 20 Feb, 2024 17 commits
-
-
Mike Snitzer authored
Stops short of actually using DM's various logging macros (e.g. DMERR, DMINFO, etc) because VDO's logger isn't quite compatible with them. Also switch emit_log_message_to_kernel() from open-coding printk with log-level to using corresponding pr_ macro. Signed-off-by:
-
Mike Snitzer authored
Prepare to bring VDO's logging closer to DM's logging by eliminating support for KERN_NOTICE log level (DM hasn't ever had a need for it). Only one message in index-session.c used UDS_LOG_NOTICE, convert it to log with uds_log_info(). Signed-off-by:
-
Mike Snitzer authored
Update uds_join_threads to delay in wait_for_completion_interruptible loop. And cleanup style nits in perform_admin_operation(). Signed-off-by:
-
Mike Snitzer authored
Fix some needless line wrapping (given surrounding context), missing braces and some stale or incorrect references to data structure or function name. Signed-off-by:
-
Mike Snitzer authored
Add missing braces and raise one function arg up a line to eliminate line wrap. Signed-off-by:
-
Mike Snitzer authored
Use /* ... */ rather than /** ... */ if for no other reason than syntax highlighting is improved (at least for me, in emacs: comments are now red, code is yellow. Previously comments were also yellow). Signed-off-by:
-
Mike Snitzer authored
Add a __must_hold sparse annotation to launch_dedupe_state_change that reflects its ASSERTION code comments about locking requirements, add some extra braces and fix a couple typos. Signed-off-by:
-
Mike Snitzer authored
Signed-off-by:
-
Ken Raeburn authored
Signed-off-by:
Ken Raeburn <raeburn@redhat.com> Signed-off-by:
-
Mike Snitzer authored
Avoids unconventional use of 'static const' and enum in headers. Signed-off-by:
-
Susan LeGendre-McGhee authored
Signed-off-by:
-
Matthew Sakai authored
Add details describing the vdo zone and thread model to the documentation comments for major vdo components. Also added some high-level description of the block map structure. Signed-off-by:
-
Matthew Sakai authored
Add more documentation details for most aspects of the data_vio read and write processes. Also correct a few minor errors and rewrite some text for clarity. Signed-off-by:
-
Matthew Sakai authored
Signed-off-by:
-
Mike Snitzer authored
Only one user of WRITE_FLAGS so no need to factor it out in an enum (which causes sparse's 'mixed bitwiseness' warning). Just use the flags in the only consumer. Signed-off-by:
-
Mike Snitzer authored
Annotate both open_index() and close_index() with __must_hold(&zones->lock) to silence these sparse warnings: warning: context imbalance in 'close_index' - unexpected unlock warning: context imbalance in 'open_index' - unexpected unlock Signed-off-by:
-
Mike Snitzer authored
Factor wait_permit() out from acquire_permit() so that the latter always holds the spinlock and the former always releases it. Otherwise sparse complains about locking context imbalances due to conditional spin_unlock in acquire_permit: warning: context imbalance in 'acquire_permit' - different lock contexts for basic block warning: context imbalance in 'vdo_launch_bio' - unexpected unlock Signed-off-by:
-
