- 25 Jan, 2022 31 commits
-
-
Phillip Potter authored
Remove the single DBG_88E macro call from os_dep/osdep_service.c, as it is unreachable anyway. This gets the driver closer to the eventual removal of DBG_88E itself. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220108005550.26264-4-phil@philpotter.co.ukSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Phillip Potter authored
Convert three DBG_88E macro calls in core/rtw_ap.c to use netdev_dbg as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Signed-off-by:
-
Phillip Potter authored
Convert DBG_88E macro calls in core/rtw_ap.c to use netdev_dbg when they may display useful information, and remove erroneous DBG_88E calls entirely. This leaves six empty static functions which only had DBG_88E calls, so just remove them: update_bcn_fixed_ie update_bcn_htcap_ie update_bcn_htinfo_ie update_bcn_rsn_ie update_bcn_wpa_ie update_bcn_wmm_ie also modifying the if blocks/switch cases that invoke them to no longer do so. This goes further towards the goal of removing this non-standard debugging code. Signed-off-by:
-
Michael Straube authored
SetHwReg8188EU() and GetHwReg8188EU() are never called with HW_VAR_APFM_ON_MAC. Remove that case from both functions. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20220107215033.12257-7-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
The field EfuseUsedBytes of struct hal_data_8188e is set but never used. Remove it. Signed-off-by:
-
Michael Straube authored
GetHwReg8188EU() is never called with HW_VAR_EFUSE_BYTES. Remove that case from the function. Signed-off-by:
-
Michael Straube authored
GetHwReg8188EU() is never called with HW_VAR_CURRENT_ANTENNA. Remove that case from the function. Signed-off-by:
-
Michael Straube authored
SetHwReg8188EU() and GetHwReg8188EU() are never called with HW_VAR_TXPAUSE. Remove that case from both functions. Signed-off-by:
-
Michael Straube authored
GetHwReg8188EU() is never called with HW_VAR_BASIC_RATE. Remove that case from the function. Signed-off-by:
-
Michael Straube authored
Move firmware related macros from rtl8188e_hal.h to rtw_fw.h. Signed-off-by:
-
Michael Straube authored
Add spaces around & operator in the macro IS_FW_HEADER_EXIST to improve readability and follow kernel coding style. Signed-off-by:
-
Michael Straube authored
Rename _pFwHdr in the macro IS_FW_HEADER_EXIST to avoid camel case. _pFwHdr -> _fwhdr Signed-off-by:
-
Michael Straube authored
Move the firmware loading functions from rtl8188e_hal_init.c into the new file core/rtw_fw.c. Signed-off-by:
-
Michael Straube authored
Rename the variables pFirmwareBuf and FirmwareLen in rtl8188e_firmware_download() to avoid camel case. pFirmwareBuf -> fw_data FirmwareLen -> fw_size Signed-off-by:
-
Michael Straube authored
Rename the variable pFwHdr in rtl8188e_firmware_download() to avoid camel case. pFwHdr -> fwhdr Signed-off-by:
-
Michael Straube authored
Rename the variable writeFW_retry in rtl8188e_firmware_download() to avoid camel case. writeFW_retry -> write_fw_retry Signed-off-by:
-
Michael Straube authored
Rename FWDL_ChkSum_rpt to avoid camel case. FWDL_ChkSum_rpt -> FWDL_CHKSUM_RPT Signed-off-by:
-
Michael Straube authored
Rename the variable rtStatus in rtl8188e_firmware_download() to avoid camel case. rtStatus -> ret Signed-off-by:
-
Michael Straube authored
Rename the Exit label in rtl8188e_firmware_download() to avoid camel case. Exit -> exit Signed-off-by:
-
Michael Straube authored
Convert the return type of fw_free_to_go() and rtl8188e_firmware_download() from s32 to the more common int. Signed-off-by:
-
Michael Straube authored
Rename the local variable u1bTmp in rtw_reset_8051() to avoid camel case and remove a call to DBG_88E that contains no important information. Signed-off-by:
-
Michael Straube authored
Rename firmware related functions to avoid camel case. rtl8188e_FirmwareDownload -> rtl8188e_firmware_download _FWDownloadEnable -> fw_download_enable _8051Reset88E -> rtw_reset_8051 _FWFreeToGo -> fw_free_to_go _BlockWrite -> block_write _PageWrite -> page_write _WriteFW -> write_fw Signed-off-by:
-
Michael Straube authored
Use kmemdup instead of kzalloc and memcpy in load_firmware(). Signed-off-by:
-
Michael Straube authored
Rename fields of struct rt_firmware to avoid camel case. szFwBuffer -> data ulFwLength -> size Signed-off-by:
-
Michael Straube authored
Rename the parameter pFirmware of load_firmware() to avoid camel case. pFirmware -> rtfw Signed-off-by:
-
Michael Straube authored
The return type of load_firmware() is int. Change the type of the return variable from s32 to int to match the function return type. Signed-off-by:
-
Michael Straube authored
Rename the local variable rtStatus in load_firmware() to avoid camel case. rtStatus -> ret Signed-off-by:
-
Michael Straube authored
Rename Exit label in load_firmware() to avoid camel case. Exit -> exit Signed-off-by:
-
Michael Straube authored
In function load_firmware() release_firmware() is not called if the allocation of pFirmware->szFwBuffer fails or if fw->size is greater than FW_8188E_SIZE. Move the call to release_firmware() to the exit label at the end of the function to fix this. Fixes: 8cd574e6 ("staging: r8188eu: introduce new hal dir for RTL8188eu driver") Signed-off-by:
-
Michael Straube authored
Merge rtl8188e_InitializeFirmwareVars() into rtl8188eu_hal_init() and remove rtl8188e_InitializeFirmwareVars(). Signed-off-by:
-
Michael Straube authored
The fields FirmwareVersion, FirmwareSubVersion and FirmwareSignature of struct hal_data_8188e are only used in the function rtl8188e_FirmwareDownload(). Use local variables in that function and remove the fields from struct hal_data_8188e. FirmwareVersionRev is not used at all, remove it as well. Signed-off-by:
-
- 23 Jan, 2022 6 commits
-
-
Linus Torvalds authored
-
Linus Torvalds authored
Merge tag 'perf-tools-for-v5.17-2022-01-22' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux Pull more perf tools updates from Arnaldo Carvalho de Melo: - Fix printing 'phys_addr' in 'perf script'. - Fix failure to add events with 'perf probe' in ppc64 due to not removing leading dot (ppc64 ABIv1). - Fix cpu_map__item() python binding building. - Support event alias in form foo-bar-baz, add pmu-events and parse-event tests for it. - No need to setup affinities when starting a workload or attaching to a pid. - Use path__join() to compose a path instead of ad-hoc snprintf() equivalent. - Override attr->sample_period for non-libpfm4 events. - Use libperf cpumap APIs instead of accessing the internal state directly. - Sync x86 arch prctl headers and files changed by the new set_mempolicy_home_node syscall with the kernel sources. - Remove duplicate include in cpumap.h. - Remove redundant err variable. * tag 'perf-tools-for-v5.17-2022-01-22' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux: perf tools: Remove redundant err variable perf test: Add parse-events test for aliases with hyphens perf test: Add pmu-events test for aliases with hyphens perf parse-events: Support event alias in form foo-bar-baz perf evsel: Override attr->sample_period for non-libpfm4 events perf cpumap: Remove duplicate include in cpumap.h perf cpumap: Migrate to libperf cpumap api perf python: Fix cpu_map__item() building perf script: Fix printing 'phys_addr' failure issue tools headers UAPI: Sync files changed by new set_mempolicy_home_node syscall tools headers UAPI: Sync x86 arch prctl headers with the kernel sources perf machine: Use path__join() to compose a path instead of snprintf(dir, '/', filename) perf evlist: No need to setup affinities when disabling events for pid targets perf evlist: No need to setup affinities when enabling events for pid targets perf stat: No need to setup affinities when starting a workload perf affinity: Allow passing a NULL arg to affinity__cleanup() perf probe: Fix ppc64 'perf probe add events failed' case
-
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-traceLinus Torvalds authored
Pull ftrace fix from Steven Rostedt: "Fix s390 breakage from sorting mcount tables. The latest merge of the tracing tree sorts the mcount table at build time. But s390 appears to do things differently (like always) and replaces the sorted table back to the original unsorted one. As the ftrace algorithm depends on it being sorted, bad things happen when it is not, and s390 experienced those bad things. Add a new config to tell the boot if the mcount table is sorted or not, and allow s390 to opt out of it" * tag 'trace-v5.17-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: ftrace: Fix assuming build time sort works for s390
-
Steven Rostedt (Google) authored
To speed up the boot process, as mcount_loc needs to be sorted for ftrace to work properly, sorting it at build time is more efficient than boot up and can save milliseconds of time. Unfortunately, this change broke s390 as it will modify the mcount_loc location after the sorting takes place and will put back the unsorted locations. Since the sorting is skipped at boot up if it is believed that it was sorted at run time, ftrace can crash as its algorithms are dependent on the list being sorted. Add a new config BUILDTIME_MCOUNT_SORT that is set when BUILDTIME_TABLE_SORT but not if S390 is set. Use this config to determine if sorting should take place at boot up. Link: https://lore.kernel.org/all/yt9dee51ctfn.fsf@linux.ibm.com/ Fixes: 72b3942a ("scripts: ftrace - move the sort-processing in ftrace_init") Reported-by:
Sven Schnelle <svens@linux.ibm.com> Tested-by:
Heiko Carstens <hca@linux.ibm.com> Signed-off-by:
Steven Rostedt (Google) <rostedt@goodmis.org>
-
Linus Torvalds authored
Merge tag 'kbuild-fixes-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild Pull Kbuild fixes from Masahiro Yamada: - Bring include/uapi/linux/nfc.h into the UAPI compile-test coverage - Revert the workaround of CONFIG_CC_IMPLICIT_FALLTHROUGH - Fix build errors in certs/Makefile * tag 'kbuild-fixes-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild: certs: Fix build error when CONFIG_MODULE_SIG_KEY is empty certs: Fix build error when CONFIG_MODULE_SIG_KEY is PKCS#11 URI Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH" usr/include/Makefile: add linux/nfc.h to the compile-test coverage
-
git://github.com/norov/linuxLinus Torvalds authored
Pull bitmap updates from Yury Norov: - introduce for_each_set_bitrange() - use find_first_*_bit() instead of find_next_*_bit() where possible - unify for_each_bit() macros * tag 'bitmap-5.17-rc1' of git://github.com/norov/linux: vsprintf: rework bitmap_list_string lib: bitmap: add performance test for bitmap_print_to_pagebuf bitmap: unify find_bit operations mm/percpu: micro-optimize pcpu_is_populated() Replace for_each_*_bit_from() with for_each_*_bit() where appropriate find: micro-optimize for_each_{set,clear}_bit() include/linux: move for_each_bit() macros from bitops.h to find.h cpumask: replace cpumask_next_* with cpumask_first_* where appropriate tools: sync tools/bitmap with mother linux all: replace find_next{,_zero}_bit with find_first{,_zero}_bit where appropriate cpumask: use find_first_and_bit() lib: add find_first_and_bit() arch: remove GENERIC_FIND_FIRST_BIT entirely include: move find.h from asm_generic to linux bitops: move find_bit_*_le functions from le.h to find.h bitops: protect find_first_{,zero}_bit properly
-
- 22 Jan, 2022 3 commits
-
-
Minghao Chi authored
Return value from perf_event__process_tracing_data() directly instead of taking this in another redundant variable. Reported-by:
Zeal Robot <zealci@zte.com.cn> Signed-off-by:
Minghao Chi <chi.minghao@zte.com.cn> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lore.kernel.org/lkml/20220112080109.666800-1-chi.minghao@zte.com.cnSigned-off-by:
CGEL ZTE <cgel.zte@gmail.com> Signed-off-by:
Arnaldo Carvalho de Melo <acme@redhat.com>
-
John Garry authored
Add a test which allows us to test parsing an event alias with hyphens. Since these events typically do not exist on most host systems, add the alias to the fake pmu. Function perf_pmu__test_parse_init() has terms added to match known test aliases. Signed-off-by:
John Garry <john.garry@huawei.com> Acked-by:
Ian Rogers <irogers@google.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Kajol Jain <kjain@linux.ibm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Qi Liu <liuqi115@huawei.com> Cc: Shaokun Zhang <zhangshaokun@hisilicon.com> Cc: linuxarm@huawei.com Link: https://lore.kernel.org/r/1642432215-234089-4-git-send-email-john.garry@huawei.comSigned-off-by:
-
John Garry authored
Add a test for aliases with hyphens in the name to ensure that the pmu-events tables are as expects. There should be no reason why these sort of aliases would be treated differently, but no harm in checking. Signed-off-by:
-
