1. 18 Aug, 2014 3 commits
    • Johan Hovold's avatar
      Revert "USB: option,zte_ev: move most ZTE CDMA devices to zte_ev" · 63a901c0
      Johan Hovold authored
      This reverts commit 73228a05 ("USB: option,zte_ev: move most ZTE
      CDMA devices to zte_ev").
      
      Move the IDs of the devices that were previously driven by the option
      driver back to that driver.
      
      As several users have reported, the zte_ev driver is causing random
      disconnects as well as reconnect failures.
      
      A closer analysis of the zte_ev setup code reveals that it consists of
      standard CDC requests (SET/GET_LINE_CODING and SET_CONTROL_LINE_STATE)
      but unfortunately fails to get some of those right. In particular, as
      reported by Liu Lei, it fails to lower DTR/RTS on close. It also appears
      that the control requests lack the interface argument.
      
      Note that the zte_ev driver is based on code (once) distributed by ZTE
      that still appears to originally have been reverse-engineered and bolted
      onto the generic driver.
      
      Since line control is already handled properly by the option driver, and
      the SET/GET_LINE_CODING requests appears to be redundant (amounts to a
      SET 9600 8N1), this is a first step in ultimately removing the redundant
      zte_ev driver.
      
      Note that AC2726 had already been moved back to option, and that some
      IDs were in the device table of both drivers prior to the commit being
      reverted.
      Reported-by: default avatarLei Liu <liu.lei78@zte.com.cn>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      63a901c0
    • Brennan Ashton's avatar
      USB: option: add VIA Telecom CDS7 chipset device id · d7730273
      Brennan Ashton authored
      This VIA Telecom baseband processor is used is used by by u-blox in both the
      FW2770 and FW2760 products and may be used in others as well.
      
      This patch has been tested on both of these modem versions.
      Signed-off-by: default avatarBrennan Ashton <bashton@brennanashton.com>
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      d7730273
    • Johan Hovold's avatar
      USB: option: reduce interrupt-urb logging verbosity · f0e4cba2
      Johan Hovold authored
      Do not log normal interrupt-urb shutdowns as errors.
      
      The option driver has always been logging any nonzero interrupt-urb
      status as an error, including when the urb is killed during normal
      operation.
      
      Commit 9096f1fb ("USB: usb_wwan: fix potential NULL-deref at
      resume") moved the interrupt urb submission from port probe and release
      to open and close, thus potentially increasing the number of these
      false-positive error messages dramatically.
      Reported-by: default avatarEd Butler <ressy66@ausics.net>
      Tested-by: default avatarEd Butler <ressy66@ausics.net>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      f0e4cba2
  2. 16 Aug, 2014 37 commits