Commits · 66cbd3ab35d35580ddf98304c280a6231685aa41 · Kirill Smelkov / linux

08 Oct, 2010 40 commits

Staging: brcm80211: s/uint32/u32/ · 66cbd3ab

Greg Kroah-Hartman authored Oct 08, 2010

Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

66cbd3ab

Staging: bcm: silence off by one warning · 370adc7c

Dan Carpenter authored Oct 08, 2010

"status" is used as an index into the Adapter->PackInfo[] array, which
has NO_OF_QUEUES elements.

This code actually works OK.  The SearchSfid() function always returns
a valid index or it returns NO_OF_QUEUES + 1.  But it looks sloppy and
it makes the static checkers complain.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

370adc7c

Staging: bcm: remove unneeded NULL check · 02339374

Dan Carpenter authored Oct 08, 2010

The error handling here is wrong.  If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.

Since the check isn't needed and I removed it instead of fixing it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

02339374

Staging: bcm: return -EFAULT on copy_to_user() errors · ef5d2056

Dan Carpenter authored Oct 08, 2010

bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ef5d2056

Staging: bcm: dereferencing before checking · acedadfa

Dan Carpenter authored Oct 08, 2010

I moved the check to see if "Adapter" was null in front of the
dereference.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

acedadfa

Staging: bcm: mocro expansion bug · 055a1eda

Dan Carpenter authored Oct 08, 2010

The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like
this:

    if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8)

The multiplication by eight has precedence over the addition so the
macro needs parenthesis to work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

055a1eda

Staging: bcm: make major and minor signed · 785698e3

Dan Carpenter authored Oct 08, 2010

We assume that major is signed in register_control_device_interface().
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

785698e3

Staging: bcm: return -EFAULT on copy_to_user() failures · bf58bd66

Dan Carpenter authored Oct 08, 2010

There were a number of places in the bcm_char_ioctl() which returned the
number of bytes remaining to be copied instead of returning -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

bf58bd66

Staging: speakup: devsynth: file_operations should be const · a1823f2e

Tracey Dent authored Oct 08, 2010

Fixed file_operation struct, so that it is const.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a1823f2e

Staging: speakup: keyhelp: Coding style fix · 1bd15cfd

Tracey Dent authored Oct 08, 2010

Put { on previous line, on line 34. Checkpatch.pl caught this.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1bd15cfd

Staging: speakup: Makefile: Makefile clean up · 0c7023b2

Tracey Dent authored Oct 08, 2010

Replaced <modules>-objs with <modules>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0c7023b2

Staging: batman-adv: Makefile: replace the use of <module>-objs with <module>-y · 8996ba13

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y n Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

8996ba13

Staging: bcm: Makefile: replace the use of <module>-objs with <module>-y · 9a837af5

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

9a837af5

Staging: comedi: Makefile: replace the use of <module>-objs with <module>-y · 23d18860

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

23d18860

Staging: crystalhd: Makefile: replace the use of <module>-objs with <module>-y · 1087020f

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1087020f

Staging: cx25821: Makefile: replace the use of <module>-objs with <module>-y · 88efaabc

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

88efaabc

Staging: easycap: Makefile: replace the use of <module>-objs with <module>-y · 77037b49

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

77037b49

Staging: cxt1e1: Makefile: replace the use of <module>-objs with <module>-y · a4f131f0

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a4f131f0

Staging: go7007: Makefile: makefile cleanup · accca6c2

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile. Also, Replace EXTRA_CFLAGS with ccflags-y
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

accca6c2

Staging: ft1000:ft1000-pcmia: Makefile: replace the use of <module>-objs with <module>-y · bdc1b7bd

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

bdc1b7bd

Staging: et131x: Makefile: replace the use of <module>-objs with <module>-y · 735f48f5

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

735f48f5

Staging: ft1000: ft1000-usb: Makefile: replace the use of <module>-objs with <module>-y · 23b57e4a

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

23b57e4a

Staging: hv: Makefile: replace the use of <module>-objs with <module>-y · cf5901b3

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

cf5901b3

Staging: intel_sst: Makefile: replace the use of <module>-objs with <module>-y · 659bd8c1

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

659bd8c1

Staging: line6: Makefile: replace the use of <module>-objs with <module>-y · 1954cbf0

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1954cbf0

Staging: octeon: Makefile: replace the use of <module>-objs with <module>-y · 0c26876e

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0c26876e

Staging: rt2870: Makefile: replace the use of <module>-objs with <module>-y · b76d011d

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

b76d011d

Staging: rt2860: Makefile: replace the use of <module>-objs with <module>-y · ad528602

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ad528602

Staging: rtl8187se: Makefile: replace the use of <module>-objs with <module>-y · 79ad8cbf

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

79ad8cbf

Staging: rtl8712: Makefile: replace the use of <module>-objs with <module>-y · 4580cd7e

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

4580cd7e

Staging: sbe-2t3e3: Makefile: replace the use of <module>-objs with <module>-y · 32a65d4e

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

32a65d4e

Staging: smbfs: Makefile: Makefile clean up · 50662062

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Also Replace EXTRA_CFLAGS with ccflags-y.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

50662062

Staging: keucr: Makefile: Makefile clean up · a7b1ef25

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Also, Replace EXTRA_CFLAGS with ccflags-y.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a7b1ef25

Staging: solo6x10: Makefile: replace the use of <module>-objs with <module>-y · 783098ea

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

783098ea

Staging: wlan-ng: Makefile: replace the use of <module>-objs with <module>-y · ef3fdeea

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ef3fdeea

Staging: rtl8192u: Makefile: replace the use of <module>-objs with <module>-y · aad6b181

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

aad6b181

Staging: usbip: Makefile: replace the use of <module>-objs with <module>-y · 07790a1f

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

07790a1f

Staging: zram: Makefile: replace the use of <module>-objs with <module>-y · 597716d9

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

597716d9

Staging: xgifb: Makefile: replace the use of <module>-objs with <module>-y · 43dd1d83

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

43dd1d83

Staging: tm6000: Makefile: replace the use of <module>-objs with <module>-y · ea195d1a

Tracey Dent authored Oct 07, 2010

Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ea195d1a