- 25 Jan, 2022 40 commits
-
-
Stefan Wahren authored
The name of this static function is unnecessary longish. So drop the prefix. This gives us the chance to avoid some multi-line statements or fix some indentations later. Reviewed-by:
Nicolas Saenz Julienne <nsaenz@kernel.org> Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1642968143-19281-11-git-send-email-stefan.wahren@i2se.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Stefan Wahren authored
The return statements aren't properly aligned. So fix this by using tabs. Reviewed-by:
-
Stefan Wahren authored
Better use kzalloc to properly init vchiq_service with zero. As a result this saves us all the zero assignments. Reviewed-by:
-
Stefan Wahren authored
The whole vchiq driver uses unsigned int for "localport" except of find_service_by_port(). So fix this and get the rid of this suspicous cast. Reviewed-by:
-
Stefan Wahren authored
Recently Arnd Bergmann noticed that the message handling looks broken to him. So add this point on the TODO list. Reviewed-by:
-
Stefan Wahren authored
This removes all already completed tasks from the TODO file. Reviewed-by:
-
Stefan Wahren authored
Keeping the order of the TODO items is hard and also unnecessary. So convert it to an unordered list. Suggested-by:
-
Stefan Wahren authored
The check for an adjacent block is hard to read. So move it into a separate inline function. Reviewed-by:
-
Stefan Wahren authored
There is no need for this static variable, so use the macro directly. Reviewed-by:
-
Stefan Wahren authored
This align the indentation in the var declaration of vchiq_log_dump_mem to the other code. Reviewed-by:
-
Vihas Mak authored
rtw_init_netdev_name() calls dev_alloc_name() which allocates the name for the device as per the given name format. The name format is specified by the module parameter "ifname". It returns a negative err code if the format is invalid. Handle this error appropriately. Cancel the timers ininitliazed by rtw_init_drv_sw() before calling rtw_free_drv_sw() and then proceed to free the adapter. Also, if register_netdev() fails then goto free_drv_sw instead of goto handle_dualmac. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Vihas Mak <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220123181734.10402-1-makvihas@gmail.comSigned-off-by:
-
Paulo Miguel Almeida authored
As a convention for the pi433 driver, all routines that deals with the rf69 chip are defined in the rf69.c file. There was an exception to the rule in which the uC version verification was being done directly elsewhere. While at it, the Version Register hardcoded value was replaced with a pre-existing constant in the driver. This patch adds rf69_get_version function to rf69.c Signed-off-by:
Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> Link: https://lore.kernel.org/r/20220108212728.GA7784@mail.google.comSigned-off-by:
-
Martin Kaiser authored
rtl8188e_init_dm_priv is the only caller of Init_ODM_ComInfo_88E. Merge the two functions. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220122170547.68378-5-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
The ODM_RF_CALIBRATION flag is set in Init_ODM_ComInfo_88E directly after the driver is probed and it's never cleared. Remove the flag and the code where it's set or checked. Signed-off-by:
-
Martin Kaiser authored
The ODM_RF_TX_PWR_TRACK flag is set in Init_ODM_ComInfo_88E directly after the driver is probed and it's never cleared. Remove the flag and the one place where it's checked. Signed-off-by:
-
Martin Kaiser authored
The variable EntryMaxUndecoratedSmoothedPWDB in struct dm_priv is set but not used. Remove it. Signed-off-by:
-
Marcelo Aloisio da Silva authored
Remove unnecessary braces reported by checkpatch.pl in rtw_xmit.c. Signed-off-by:
Marcelo Aloisio da Silva <marcelo.as@aol.com> Link: https://lore.kernel.org/r/20220119034933.GA29744@snoopySigned-off-by:
-
Martin Kaiser authored
Remove the rtw_netif_stop_queue wrapper function. Call netif_tx_stop_all_queues directly. Signed-off-by:
-
Martin Kaiser authored
Remove the rtw_netif_start_queue wrapper function. Call netif_tx_start_all_queues directly. Signed-off-by:
-
Martin Kaiser authored
Remove the rtw_netif_wake_queue wrapper function. Call netif_tx_wake_all_queues directly. Signed-off-by:
-
Martin Kaiser authored
The _set_timer wrapper function takes a timeout in milliseconds. Call msecs_to_jiffies to convert the timeout to jiffies. Don't do the calculation ourselves. Signed-off-by:
-
Martin Kaiser authored
Remove the _cancel_timer wrapper function and call del_timer_sync directly. None of the callers needs the bcancelled variable that's populated by _cancel_timer, these variables can be removed in the calling functions. rtw_surveydone_event_callback calls _cancel_timer only if it believes that the timer is currently running. We can drop this. It's safe to call del_timer_sync when the timer is not running. The timer in question, scan_to_timer, is used only for the site survey command (the rtw_survey functions) so we won't be stopping it while it's in use by someone else. Signed-off-by:
-
Martin Kaiser authored
Remove the rtw_list_delete wrapper function. Call list_del_init directly. Signed-off-by:
-
Martin Kaiser authored
PATH_LENGTH_MAX in osdep_service.h is not used and can be removed. Signed-off-by:
-
Martin Kaiser authored
The bitshift function from osdep_service.h is not used. Remove it. Signed-off-by:
-
Martin Kaiser authored
Remove some unused macros from osdep_service.h. Signed-off-by:
-
Martin Kaiser authored
Remove a group of external variables which are not used in osdep_service.h or in the files where osdep_service.h is included. Signed-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_sta_mgt.c to use pr_debug, as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. These calls are at points in the call chain where use of dev_dbg or netdev_dbg isn't possible due to lack of device pointer, so plain pr_debug is appropriate here. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220110090020.6800-8-phil@philpotter.co.ukSigned-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_mlme_ext.c to use pr_debug or netdev_dbg appropriately, as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Also remove some commented out or unnecessary DBG_88E calls altogether. Some calls are at points in the call chain where use of dev_dbg or netdev_dbg isn't possible due to lack of device pointer, so plain pr_debug is appropriate here. Signed-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_ioctl_set.c to use netdev_dbg, as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Also remove one unnecessary DBG_88E call which was already commented out. Signed-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_mlme.c to use netdev_dbg, as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Also remove some unnecessary DBG_88E calls altogether as all they do is print the function name. Signed-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_iol.c to use pr_debug or netdev_dbg appropriately, as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Some calls are at points in the call chain where use of dev_dbg or netdev_dbg isn't possible due to lack of device pointer, so plain pr_debug is appropriate here. Signed-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_xmit.c to use pr_debug or netdev_dbg appropriately, as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Also remove some commented out DBG_88E calls altogether. Some calls are at points in the call chain where use of dev_dbg or netdev_dbg isn't possible due to lack of device pointer, so plain pr_debug is appropriate here. Signed-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro calls in core/rtw_ieee80211.c to use pr_debug as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. These calls are at points in the call chain where use of dev_dbg or netdev_dbg isn't possible due to lack of device pointer, so plain pr_debug is appropriate here. Signed-off-by:
-
Jagath Jog J authored
Fix following checkpatch.pl warning by inserting blank line WARNING: Missing a blank line after declarations Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Jagath Jog J <jagathjog1996@gmail.com> Link: https://lore.kernel.org/r/20220124034456.8665-4-jagathjog1996@gmail.comSigned-off-by:
-
Jagath Jog J authored
Fix following checkpatch.pl warning by placing single space between datatype and variable WARNING: please, no space before tabs Reviewed-by:
-
Jagath Jog J authored
Fix following checkpatch.pl error by placing opening { braces in previous line ERROR: that open brace { should be on the previous line Reviewed-by: -
Gaston Gonzalez authored
Remove own module name definition and use KBUILD_MODNAME instead, which is the standard way of getting the module name. While at it, one realignment was made to improve readability. Suggested-by:
Gaston Gonzalez <gascoar@gmail.com> Link: https://lore.kernel.org/r/20220107234620.49900-3-gascoar@gmail.comSigned-off-by:
-
Gaston Gonzalez authored
MODULE_VERSION() is useless for in-tree drivers given that only the kernel version matters. Hence, remove it. While at it, one realignment was made to improve readability. Suggested by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
-
Kees Cook authored
As done for rtl8723bs and r8188eu, drop get_recvframe_data(), as it introduces an impossible value (NULL) for the compiler to check code paths against which could result in nonsensical warnings. Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com> Cc: Ivan Safonov <insafonov@gmail.com> Cc: linux-staging@lists.linux.dev Reviewed-by:
Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20220118193327.2822099-4-keescook@chromium.orgSigned-off-by:
-
