1. 19 Mar, 2023 10 commits
    • Ido Schimmel's avatar
      mlxsw: core_thermal: Fix fan speed in maximum cooling state · 6d206b1e
      Ido Schimmel authored
      The cooling levels array is supposed to prevent the system fans from
      being configured below a 20% duty cycle as otherwise some of them get
      stuck at 0 RPM.
      
      Due to an off-by-one error, the last element in the array was not
      initialized, causing it to be set to zero, which in turn lead to fans
      being configured with a 0% duty cycle in maximum cooling state.
      
      Since commit 332fdf95 ("mlxsw: thermal: Fix out-of-bounds memory
      accesses") the contents of the array are static. Therefore, instead of
      fixing the initialization of the array, simply remove it and adjust
      thermal_cooling_device_ops::set_cur_state() so that the configured duty
      cycle is never set below 20%.
      
      Before:
      
       # cat /sys/class/thermal/thermal_zone0/cdev0/type
       mlxsw_fan
       # echo 10 > /sys/class/thermal/thermal_zone0/cdev0/cur_state
       # cat /sys/class/hwmon/hwmon0/name
       mlxsw
       # cat /sys/class/hwmon/hwmon0/pwm1
       0
      
      After:
      
       # cat /sys/class/thermal/thermal_zone0/cdev0/type
       mlxsw_fan
       # echo 10 > /sys/class/thermal/thermal_zone0/cdev0/cur_state
       # cat /sys/class/hwmon/hwmon0/name
       mlxsw
       # cat /sys/class/hwmon/hwmon0/pwm1
       255
      
      This bug was uncovered when the thermal subsystem repeatedly tried to
      configure the cooling devices to their maximum state due to another
      issue [1]. This resulted in the fans being stuck at 0 RPM, which
      eventually lead to the system undergoing thermal shutdown.
      
      [1] https://lore.kernel.org/netdev/ZA3CFNhU4AbtsP4G@shredder/
      
      Fixes: a421ce08 ("mlxsw: core: Extend cooling device with cooling levels")
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarVadim Pasternak <vadimp@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6d206b1e
    • Russell King (Oracle)'s avatar
      net: sfp: fix state loss when updating state_hw_mask · 04361b8b
      Russell King (Oracle) authored
      Andrew reports that the SFF modules on one of the ZII platforms do not
      indicate link up due to the SFP code believing that LOS indicating that
      there is no signal being received from the remote end, but in fact the
      LOS signal is showing that there is signal.
      
      What makes SFF modules different from SFPs is they typically have an
      inverted LOS, which uncovered this issue. When we read the hardware
      state, we mask it with state_hw_mask so we ignore anything we're not
      interested in. However, we don't re-read when state_hw_mask changes,
      leading to sfp->state being stale.
      
      Arrange for a software poll of the module state after we have parsed
      the EEPROM in sfp_sm_mod_probe() and updated state_*_mask. This will
      generate any necessary events for signal changes for the state
      machine as well as updating sfp->state.
      Reported-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Tested-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Fixes: 8475c4b7 ("net: sfp: re-implement soft state polling setup")
      Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      04361b8b
    • Jochen Henneberg's avatar
      net: stmmac: Fix for mismatched host/device DMA address width · 070246e4
      Jochen Henneberg authored
      Currently DMA address width is either read from a RO device register
      or force set from the platform data. This breaks DMA when the host DMA
      address width is <=32it but the device is >32bit.
      
      Right now the driver may decide to use a 2nd DMA descriptor for
      another buffer (happens in case of TSO xmit) assuming that 32bit
      addressing is used due to platform configuration but the device will
      still use both descriptor addresses as one address.
      
      This can be observed with the Intel EHL platform driver that sets
      32bit for addr64 but the MAC reports 40bit. The TX queue gets stuck in
      case of TCP with iptables NAT configuration on TSO packets.
      
      The logic should be like this: Whatever we do on the host side (memory
      allocation GFP flags) should happen with the host DMA width, whenever
      we decide how to set addresses on the device registers we must use the
      device DMA address width.
      
      This patch renames the platform address width field from addr64 (term
      used in device datasheet) to host_addr and uses this value exclusively
      for host side operations while all chip operations consider the device
      DMA width as read from the device register.
      
      Fixes: 7cfc4486 ("stmmac: intel: Configure EHL PSE0 GbE and PSE1 GbE to 32 bits DMA addressing")
      Signed-off-by: default avatarJochen Henneberg <jh@henneberg-systemdesign.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      070246e4
    • David S. Miller's avatar
      Merge branch 'mdiobus-module-owner' · 543887d7
      David S. Miller authored
      Florian Fainelli says:
      
      ====================
      ACPI/DT mdiobus module owner fixes
      
      This patch series fixes wrong mdiobus module ownership for MDIO buses
      registered from DT or ACPI.
      
      Thanks Maxime for providing the first patch and making me see that ACPI
      also had the same issue.
      
      Changes in v2:
      
      - fixed missing kdoc in the first patch
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      543887d7
    • Florian Fainelli's avatar
      net: mdio: fix owner field for mdio buses registered using ACPI · 30b605b8
      Florian Fainelli authored
      Bus ownership is wrong when using acpi_mdiobus_register() to register an
      mdio bus. That function is not inline, so when it calls
      mdiobus_register() the wrong THIS_MODULE value is captured.
      
      CC: Maxime Bizon <mbizon@freebox.fr>
      Fixes: 803ca24d ("net: mdio: Add ACPI support code for mdio")
      Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      30b605b8
    • Maxime Bizon's avatar
      net: mdio: fix owner field for mdio buses registered using device-tree · 99669259
      Maxime Bizon authored
      Bus ownership is wrong when using of_mdiobus_register() to register an mdio
      bus. That function is not inline, so when it calls mdiobus_register() the wrong
      THIS_MODULE value is captured.
      Signed-off-by: default avatarMaxime Bizon <mbizon@freebox.fr>
      Fixes: 90eff909 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
      [florian: fix kdoc, added Fixes tag]
      Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      99669259
    • Florian Fainelli's avatar
      net: phy: Ensure state transitions are processed from phy_stop() · 4203d840
      Florian Fainelli authored
      In the phy_disconnect() -> phy_stop() path, we will be forcibly setting
      the PHY state machine to PHY_HALTED. This invalidates the old_state !=
      phydev->state condition in phy_state_machine() such that we will neither
      display the state change for debugging, nor will we invoke the
      link_change_notify() callback.
      
      Factor the code by introducing phy_process_state_change(), and ensure
      that we process the state change from phy_stop() as well.
      
      Fixes: 5c5f626b ("net: phy: improve handling link_change_notify callback")
      Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4203d840
    • David S. Miller's avatar
      Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue · 739cb499
      David S. Miller authored
      Tony Nguyen says:
      
      ====================
      Intel Wired LAN Driver Updates 2023-03-16 (igb, igbvf, igc)
      
      This series contains updates to igb, igbvf, and igc drivers.
      
      Lin Ma removes rtnl_lock() when disabling SRIOV on remove which was
      causing deadlock on igb.
      
      Akihiko Odaki delays enabling of SRIOV on igb to prevent early messages
      that could get ignored and clears MAC address when PF returns nack on
      reset; indicating no MAC address was assigned for igbvf.
      
      Gaosheng Cui frees IRQs in error path for igbvf.
      
      Akashi Takahiro fixes logic on checking TAPRIO gate support for igc.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      739cb499
    • Zheng Wang's avatar
      xirc2ps_cs: Fix use after free bug in xirc2ps_detach · e8d20c3d
      Zheng Wang authored
      In xirc2ps_probe, the local->tx_timeout_task was bounded
      with xirc2ps_tx_timeout_task. When timeout occurs,
      it will call xirc_tx_timeout->schedule_work to start the
      work.
      
      When we call xirc2ps_detach to remove the driver, there
      may be a sequence as follows:
      
      Stop responding to timeout tasks and complete scheduled
      tasks before cleanup in xirc2ps_detach, which will fix
      the problem.
      
      CPU0                  CPU1
      
                          |xirc2ps_tx_timeout_task
      xirc2ps_detach      |
        free_netdev       |
          kfree(dev);     |
                          |
                          | do_reset
                          |   //use dev
      
      Fixes: 1da177e4 ("Linux-2.6.12-rc2")
      Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e8d20c3d
    • Daniil Tatianin's avatar
      qed/qed_sriov: guard against NULL derefs from qed_iov_get_vf_info · 25143b6a
      Daniil Tatianin authored
      We have to make sure that the info returned by the helper is valid
      before using it.
      
      Found by Linux Verification Center (linuxtesting.org) with the SVACE
      static analysis tool.
      
      Fixes: f990c82c ("qed*: Add support for ndo_set_vf_trust")
      Fixes: 733def6a ("qed*: IOV link control")
      Signed-off-by: default avatarDaniil Tatianin <d-tatianin@yandex-team.ru>
      Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      25143b6a
  2. 18 Mar, 2023 4 commits
  3. 17 Mar, 2023 26 commits
    • Linus Torvalds's avatar
      Merge tag 'net-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 478a351c
      Linus Torvalds authored
      Pull networking fixes from Jakub Kicinski:
       "Including fixes from netfilter, wifi and ipsec.
      
        A little more changes than usual, but it's pretty normal for us that
        the rc3/rc4 PRs are oversized as people start testing in earnest.
      
        Possibly an extra boost from people deploying the 6.1 LTS but that's
        more of an unscientific hunch.
      
        Current release - regressions:
      
         - phy: mscc: fix deadlock in phy_ethtool_{get,set}_wol()
      
         - virtio: vsock: don't use skbuff state to account credit
      
         - virtio: vsock: don't drop skbuff on copy failure
      
         - virtio_net: fix page_to_skb() miscalculating the memory size
      
        Current release - new code bugs:
      
         - eth: correct xdp_features after device reconfig
      
         - wifi: nl80211: fix the puncturing bitmap policy
      
         - net/mlx5e: flower:
            - fix raw counter initialization
            - fix missing error code
            - fix cloned flow attribute
      
         - ipa:
            - fix some register validity checks
            - fix a surprising number of bad offsets
            - kill FILT_ROUT_CACHE_CFG IPA register
      
        Previous releases - regressions:
      
         - tcp: fix bind() conflict check for dual-stack wildcard address
      
         - veth: fix use after free in XDP_REDIRECT when skb headroom is small
      
         - ipv4: fix incorrect table ID in IOCTL path
      
         - ipvlan: make skb->skb_iif track skb->dev for l3s mode
      
         - mptcp:
            - fix possible deadlock in subflow_error_report
            - fix UaFs when destroying unaccepted and listening sockets
      
         - dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220, 6250, 6290
      
        Previous releases - always broken:
      
         - tcp: tcp_make_synack() can be called from process context, don't
           assume preemption is disabled when updating stats
      
         - netfilter: correct length for loading protocol registers
      
         - virtio_net: add checking sq is full inside xdp xmit
      
         - bonding: restore IFF_MASTER/SLAVE flags on bond enslave Ethertype
           change
      
         - phy: nxp-c45-tja11xx: fix MII_BASIC_CONFIG_REV bit number
      
         - eth: i40e: fix crash during reboot when adapter is in recovery mode
      
         - eth: ice: avoid deadlock on rtnl lock when auxiliary device
           plug/unplug meets bonding
      
         - dsa: mt7530:
            - remove now incorrect comment regarding port 5
            - set PLL frequency and trgmii only when trgmii is used
      
         - eth: mtk_eth_soc: reset PCS state when changing interface types
      
        Misc:
      
         - ynl: another license adjustment
      
         - move the TCA_EXT_WARN_MSG attribute for tc action"
      
      * tag 'net-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (108 commits)
        selftests: bonding: add tests for ether type changes
        bonding: restore bond's IFF_SLAVE flag if a non-eth dev enslave fails
        bonding: restore IFF_MASTER/SLAVE flags on bond enslave ether type change
        net: renesas: rswitch: Fix GWTSDIE register handling
        net: renesas: rswitch: Fix the output value of quote from rswitch_rx()
        ethernet: sun: add check for the mdesc_grab()
        net: ipa: fix some register validity checks
        net: ipa: kill FILT_ROUT_CACHE_CFG IPA register
        net: ipa: add two missing declarations
        net: ipa: reg: include <linux/bug.h>
        net: xdp: don't call notifiers during driver init
        net/sched: act_api: add specific EXT_WARN_MSG for tc action
        Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy"
        net: dsa: microchip: fix RGMII delay configuration on KSZ8765/KSZ8794/KSZ8795
        ynl: make the tooling check the license
        ynl: broaden the license even more
        tools: ynl: make definitions optional again
        hsr: ratelimit only when errors are printed
        qed/qed_mng_tlv: correctly zero out ->min instead of ->hour
        selftests: net: devlink_port_split.py: skip test if no suitable device available
        ...
      478a351c
    • Linus Torvalds's avatar
      Merge tag 'block-6.3-2023-03-16' of git://git.kernel.dk/linux · 8d3c682a
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
       "A bit bigger than usual, as the NVMe pull request missed last weeks
        submission. In detail:
      
         - NVMe pull request via Christoph:
              - Avoid potential UAF in nvmet_req_complete (Damien Le Moal)
              - More quirks (Elmer Miroslav Mosher Golovin, Philipp Geulen)
              - Fix a memory leak in the nvme-pci probe teardown path
                (Irvin Cote)
              - Repair the MAINTAINERS entry (Lukas Bulwahn)
              - Fix handling single range discard request (Ming Lei)
              - Show more opcode names in trace events (Minwoo Im)
              - Fix nvme-tcp timeout reporting (Sagi Grimberg)
      
         - MD pull request via Song:
              - Two fixes for old issues (Neil)
              - Resource leak in device stopping (Xiao)
      
         - Bio based device stats fix (Yu)
      
         - Kill unused CONFIG_BLOCK_COMPAT (Lukas)
      
         - sunvdc missing mdesc_grab() failure check (Liang)
      
         - Fix for reversal of request ordering upon issue for certain cases
           (Jan)
      
         - null_blk timeout fixes (Damien)
      
         - Loop use-after-free fix (Bart)
      
         - blk-mq SRCU fix for BLK_MQ_F_BLOCKING devices (Chris)"
      
      * tag 'block-6.3-2023-03-16' of git://git.kernel.dk/linux:
        block: remove obsolete config BLOCK_COMPAT
        md: select BLOCK_LEGACY_AUTOLOAD
        block: count 'ios' and 'sectors' when io is done for bio-based device
        block: sunvdc: add check for mdesc_grab() returning NULL
        nvmet: avoid potential UAF in nvmet_req_complete()
        nvme-trace: show more opcode names
        nvme-tcp: add nvme-tcp pdu size build protection
        nvme-tcp: fix opcode reporting in the timeout handler
        nvme-pci: add NVME_QUIRK_BOGUS_NID for Lexar NM620
        nvme-pci: add NVME_QUIRK_BOGUS_NID for Netac NV3000
        nvme-pci: fixing memory leak in probe teardown path
        nvme: fix handling single range discard request
        MAINTAINERS: repair malformed T: entries in NVM EXPRESS DRIVERS
        block: null_blk: cleanup null_queue_rq()
        block: null_blk: Fix handling of fake timeout request
        blk-mq: fix "bad unlock balance detected" on q->srcu in __blk_mq_run_dispatch_ops
        loop: Fix use-after-free issues
        block: do not reverse request order when flushing plug list
        md: avoid signed overflow in slot_store()
        md: Free resources in __md_stop
      8d3c682a
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.3-2023-03-16' of git://git.kernel.dk/linux · b7966a5a
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - When PF_NO_SETAFFINITY was removed for io-wq threads, we kind of
         forgot about the SQPOLL thread. Remove it there as well, there's even
         less of a reason to set it there (Michal)
      
       - Fixup a confusing 'ret' setting (Li)
      
       - When MSG_RING is used to send a direct descriptor to another ring,
         it's possible to have it allocate it on the target ring rather than
         provide a specific index for it. If this is done, return the chosen
         value in the CQE, like we would've done locally (Pavel)
      
       - Fix a regression in this series on huge page bvec collapsing (Pavel)
      
      * tag 'io_uring-6.3-2023-03-16' of git://git.kernel.dk/linux:
        io_uring/rsrc: fix folio accounting
        io_uring/msg_ring: let target know allocated index
        io_uring: rsrc: Optimize return value variable 'ret'
        io_uring/sqpoll: Do not set PF_NO_SETAFFINITY on sqpoll threads
      b7966a5a
    • Linus Torvalds's avatar
      Merge tag 'pm-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 02ef7d39
      Linus Torvalds authored
      Pull power management fixes from Rafael Wysocki:
       "These fix an error code path issue in a cpuidle driver and make the
        sleepgraph utility more robust against unexpected input.
      
        Specifics:
      
         - Fix the psci_pd_init_topology() failure path in the PSCI cpuidle
           driver (Shawn Guo)
      
         - Modify the sleepgraph utility so it does not crash on binary data
           in device names (Todd Brandt)"
      
      * tag 'pm-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        pm-graph: sleepgraph: Avoid crashing on binary data in device names
        cpuidle: psci: Iterate backwards over list in psci_pd_remove()
      02ef7d39
    • Linus Torvalds's avatar
      Merge tag 'acpi-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · abb02a82
      Linus Torvalds authored
      Pull ACPI fixes from Rafael Wysocki:
       "These add some new quirks, fix PPTT handling, fix an ACPI utility and
        correct a mistake in the ACPI documentation.
      
        Specifics:
      
         - Fix ACPI PPTT handling to avoid sleep in the atomic context when it
           is not present (Sudeep Holla)
      
         - Add 'backlight=native' DMI quirk for Dell Vostro 15 3535 to the
           ACPI video driver (Chia-Lin Kao)
      
         - Add ACPI quirks for I2C device enumeration on Lenovo Yoga Book X90
           and Acer Iconia One 7 B1-750 (Hans de Goede)
      
         - Fix handling of invalid command line option values in the ACPI
           pfrut utility (Chen Yu)
      
         - Fix references to I2C device data type in the ACPI documentation
           for device enumeration (Andy Shevchenko)"
      
      * tag 'acpi-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPI: tools: pfrut: Check if the input of level and type is in the right numeric range
        ACPI: PPTT: Fix to avoid sleep in the atomic context when PPTT is absent
        ACPI: x86: Add skip i2c clients quirk for Lenovo Yoga Book X90
        ACPI: x86: Add skip i2c clients quirk for Acer Iconia One 7 B1-750
        ACPI: x86: Introduce an acpi_quirk_skip_gpio_event_handlers() helper
        ACPI: video: Add backlight=native DMI quirk for Dell Vostro 15 3535
        ACPI: docs: enumeration: Correct reference to the I²C device data type
      abb02a82
    • Linus Torvalds's avatar
      Merge branch 'turbostat' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux · ba9c7791
      Linus Torvalds authored
      Pull turbostat fweaks and fixes from Len Brown:
       "Leprechaun sized fixes and tweaks touching only turbostat.
      
        'Keeping happy users happy since 2010'"
      
      * 'turbostat' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux:
        tools/power turbostat: version 2023.03.17
        tools/power turbostat: fix decoding of HWP_STATUS
        tools/power turbostat: Introduce support for EMR
        tools/power turbostat: remove stray newlines from warn/warnx strings
        tools/power turbostat: Fix /dev/cpu_dma_latency warnings
        tools/power turbostat: Provide better debug messages for failed capabilities accesses
        tools/power turbostat: update dump of SECONDARY_TURBO_RATIO_LIMIT
      ba9c7791
    • Linus Torvalds's avatar
      Merge tag 'for-linus-6.3-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · 0eb392ec
      Linus Torvalds authored
      Pull xen fixes from Juergen Gross:
      
       - cleanup for xen time handling
      
       - enable the VGA console in a Xen PVH dom0
      
       - cleanup in the xenfs driver
      
      * tag 'for-linus-6.3-rc3-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        xen: remove unnecessary (void*) conversions
        x86/PVH: obtain VGA console info in Dom0
        x86/xen/time: cleanup xen_tsc_safe_clocksource
        xen: update arch/x86/include/asm/xen/cpuid.h
      0eb392ec
    • Linus Torvalds's avatar
      Merge tag 'riscv-for-linus-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · cb80b960
      Linus Torvalds authored
      Pull RISC-V fixes from Palmer Dabbelt:
      
       - fixes to the ASID allocator to avoid leaking stale mappings between
         tasks
      
       - fix the vmalloc fault handler to tolerate huge pages
      
      * tag 'riscv-for-linus-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        RISC-V: mm: Support huge page in vmalloc_fault()
        riscv: asid: Fixup stale TLB entry cause application crash
        Revert "riscv: mm: notify remote harts about mmu cache updates"
      cb80b960
    • Linus Torvalds's avatar
      Merge tag 's390-6.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · e50a8038
      Linus Torvalds authored
      Pull s390 fixes from Vasily Gorbik:
      
       - Update defconfigs
      
       - Fix early boot code by adding missing intersection check to prevent
         potential overwriting of the ipl report
      
       - Fix a use-after-free issue in s390-specific code related to PCI
         resources being retained after hot-unplugging individual functions,
         by removing the resources from the PCI bus's resource list and using
         the zpci_bar_struct's resource pointer directly
      
      * tag 's390-6.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
        s390: update defconfigs
        PCI: s390: Fix use-after-free of PCI resources with per-function hotplug
        s390/ipl: add missing intersection check to ipl_report handling
      e50a8038
    • Linus Torvalds's avatar
      Merge tag 'powerpc-6.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · 17adaeae
      Linus Torvalds authored
      Pull powerpc fixes from Michael Ellerman:
      
       - Fix false detection of read faults, introduced by execute-only
         support
      
       - Fix a build failure when GENERIC_ALLOCATOR is not selected
      
      Thanks to Russell Currey, Randy Dunlap, Michal Suchánek, Nathan Lynch,
      and Benjamin Gray.
      
      * tag 'powerpc-6.3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        powerpc/mm: Fix false detection of read faults
        powerpc/pseries: RTAS work area requires GENERIC_ALLOCATOR
      17adaeae
    • Linus Torvalds's avatar
      Merge tag 'mmc-v6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc · 2c50b0ca
      Linus Torvalds authored
      Pull MMC host fixes from Ulf Hansson:
      
       - dw_mmc-starfive: Fix initialization of the prev_err variable
      
       - sdhci_am654: Lower power-on failed message severity
      
      * tag 'mmc-v6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc:
        mmc: dw_mmc-starfive: Fix initialization of prev_err
        mmc: sdhci_am654: lower power-on failed message severity
      2c50b0ca
    • Linus Torvalds's avatar
      Merge tag 'sound-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · 97eb2d98
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "Nothing surprising, a collection of small device-specific fixes.
      
        The majority of changes are for ASoC Intel stuff, while a few other
        ASoC and HD-audio fixes are found"
      
      * tag 'sound-6.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (31 commits)
        ALSA: hda/ca0132: fixup buffer overrun at tuning_ctl_set()
        ALSA: asihpi: check pao in control_message()
        ASoC: hdmi-codec: only startup/shutdown on supported streams
        ASoC: da7219: Initialize jack_det_mutex
        ALSA: hda: Match only Intel devices with CONTROLLER_IN_GPU()
        ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book2 Pro
        ALSA: hda/realtek: fix speaker, mute/micmute LEDs not work on a HP platform
        ALSA: hda: intel-dsp-config: add MTL PCI id
        ASoC: SOF: IPC4: update gain ipc msg definition to align with fw
        ASoC: SOF: sof-audio: don't squelch errors in WIDGET_SETUP phase
        ASoC: SOF: Intel: hda-ctrl: re-add sleep after entering and exiting reset
        ASoC: SOF: Intel: hda-dsp: harden D0i3 programming sequence
        ASoC: SOF: ipc4-topology: set dmic dai index from copier
        ASoC: SOF: sof-audio: Fix broken early bclk feature for SSP
        ASoC: SOF: Intel: pci-tng: revert invalid bar size setting
        ASoC: SOF: topology: Fix error handling in sof_widget_ready()
        ASoC: Intel: soc-acpi: fix copy-paste issue in topology names
        ASoC: SOF: ipc4-topology: Fix incorrect sample rate print unit
        ASoC: SOF: ipc3: Check for upper size limit for the received message
        ASOC: SOF: Intel: pci-tgl: Fix device description
        ...
      97eb2d98
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2023-03-17' of git://anongit.freedesktop.org/drm/drm · 2cf5a401
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Seems like a pretty regular rc3, i915 and amdgpu with the usual
        selection of fixes, then a scattering of fixes across misc drivers and
        other areas:
      
        accel:
         - build fix for accel
      
        edid:
         - fix info leak in edid
      
        ttm:
         - fix NULL ptr deref
         - reference counting fix
      
        i915:
         - Fix hwmon PL1 power limit enabling
         - Fix audio ELD handling for DP MST
         - Fix PSR io and wake line calculations
         - Fix DG2 HDMI modes with 267.30 and 319.89 MHz pixel clocks
         - Fix SSEU subslice out-of-bounds access
         - Fix misuse of non-idle barriers as fence trackers
      
        amdgpu:
         - SMU 13 update
         - RDNA2 suspend/resume fix when overclocking is enabled
         - SRIOV VCN fixes
         - HDCP suspend/resume fix
         - Fix drm polling splat regression
         - Fix dirty rectangle tracking for PSR
         - Fix vangogh regression on certain BIOSes
         - Misc display fixes
         - Suspend/resume IOMMU regression fix
      
        amdkfd:
         - Fix BO offset for multi-VMA page migration
         - Fix a possible double free
         - Fix potential use after free
         - Fix process cleanup on module exit
      
        bridge:
         - fix returned array size name documentation
      
        fbdev:
         - ref-counting fix for fbdev deferred I/O
      
        virtio:
         - dma sync fix
      
        shmem-helper:
         - error path fix
      
        msm:
         - shrinker blocking fix
      
        panfrost:
         - shrinker rpm fix
      
        chipsfb:
         - fix error code
      
        meson:
         - fix 1px pink line
         - fix regulator interaction
      
        sun4i:
         - fix missing component unbind"
      
      * tag 'drm-fixes-2023-03-17' of git://anongit.freedesktop.org/drm/drm: (38 commits)
        drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs
        drm/amdgpu: Don't resume IOMMU after incomplete init
        drm/amdkfd: Fixed kfd_process cleanup on module exit.
        drm/amd/display: disconnect MPCC only on OTG change
        drm/amd/display: Fix DP MST sinks removal issue
        drm/amd/display: Do not set DRR on pipe Commit
        drm/amd/display: Remove OTG DIV register write for Virtual signals.
        drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again
        drm/bridge: Fix returned array size name for atomic_get_input_bus_fmts kdoc
        drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes
        drm/amdgpu/nv: fix codec array for SR_IOV
        drm/amd/display: Write to correct dirty_rect
        drm/amdgpu: move poll enabled/disable into non DC path
        drm/amd/display: Fix HDCP failing to enable after suspend
        drm/amdkfd: fix potential kgd_mem UAFs
        drm/amdgpu/vcn: custom video info caps for sriov
        drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume
        drm/amd/pm: bump SMU 13.0.4 driver_if header version
        drm/amdkfd: fix a potential double free in pqm_create_queue
        drm/amdkfd: Get prange->offset after svm_range_vram_node_new
        ...
      2cf5a401
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 7622976c
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "Ten patches, eight in drivers and two in the core, which correct a
        regression from directory removal and add a no VPD size quirk also to
        fix a regression. All pretty small"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: ufs: mcq: Use active_reqs to check busy in clock scaling
        scsi: core: Fix a procfs host directory removal regression
        scsi: core: Add BLIST_NO_VPD_SIZE for some VDASD
        scsi: mpi3mr: Fix expander node leak in mpi3mr_remove()
        scsi: mpi3mr: Fix memory leaks in mpi3mr_init_ioc()
        scsi: mpi3mr: Fix sas_hba.phy memory leak in mpi3mr_remove()
        scsi: mpi3mr: Fix mpi3mr_hba_port memory leak in mpi3mr_remove()
        scsi: mpi3mr: Fix config page DMA memory leak
        scsi: mpi3mr: Fix throttle_groups memory leak
        scsi: mpt3sas: Fix NULL pointer access in mpt3sas_transport_port_add()
      7622976c
    • Rafael J. Wysocki's avatar
      Merge branch 'pm-cpuidle' · 1fa9d47b
      Rafael J. Wysocki authored
      Merge a PSCI cpuidle driver fix for 6.3-rc1:
      
       - Fix the psci_pd_init_topology() failure path in the PSCI cpuidle
         driver (Shawn Guo).
      
      * pm-cpuidle:
        cpuidle: psci: Iterate backwards over list in psci_pd_remove()
      1fa9d47b
    • Rafael J. Wysocki's avatar
      Merge branches 'acpi-video', 'acpi-x86', 'acpi-tools' and 'acpi-docs' · f36cc6cd
      Rafael J. Wysocki authored
      Merge a new ACPI backlight quirk, new ACPI quirks for I2C device
      enumeration on some platforms, a pfrut utility fix and an ACPI
      documentation fix for 6.3-rc3:
      
       - Add backlight=native DMI quirk for Dell Vostro 15 3535 to the ACPI
         video driver (Chia-Lin Kao).
      
       - Add ACPI quirks for I2C devices enumeration on Lenovo Yoga Book X90
         and Acer Iconia One 7 B1-750 (Hans de Goede).
      
       - Fix handling of invalid command line option values in the ACPI pfrut
         utility (Chen Yu).
      
       - Fix references to I2C device data type in the ACPI documentation for
         device enumeration (Andy Shevchenko).
      
      * acpi-video:
        ACPI: video: Add backlight=native DMI quirk for Dell Vostro 15 3535
      
      * acpi-x86:
        ACPI: x86: Add skip i2c clients quirk for Lenovo Yoga Book X90
        ACPI: x86: Add skip i2c clients quirk for Acer Iconia One 7 B1-750
        ACPI: x86: Introduce an acpi_quirk_skip_gpio_event_handlers() helper
      
      * acpi-tools:
        ACPI: tools: pfrut: Check if the input of level and type is in the right numeric range
      
      * acpi-docs:
        ACPI: docs: enumeration: Correct reference to the I²C device data type
      f36cc6cd
    • Len Brown's avatar
      tools/power turbostat: version 2023.03.17 · de7839ee
      Len Brown authored
      Happy St. Patrick's Day!
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      de7839ee
    • Antti Laakso's avatar
      tools/power turbostat: fix decoding of HWP_STATUS · 92c25393
      Antti Laakso authored
      The "excursion to minimum" information is in bit2
      in HWP_STATUS MSR. Fix the bitmask used for
      decoding the register.
      Signed-off-by: default avatarAntti Laakso <antti.laakso@intel.com>
      Reviewed-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      92c25393
    • Zhang Rui's avatar
      93cac415
    • Len Brown's avatar
      tools/power turbostat: remove stray newlines from warn/warnx strings · 6cbfedc7
      Len Brown authored
      warn(3) terminates strings with newlines
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      6cbfedc7
    • Prarit Bhargava's avatar
      tools/power turbostat: Fix /dev/cpu_dma_latency warnings · 40aafc7d
      Prarit Bhargava authored
      When running as non-root the following error is seen in turbostat:
      
      turbostat: fopen /dev/cpu_dma_latency
      : Permission denied
      
      turbostat and the man page have information on how to avoid other
      permission errors, so these can be fixed the same way.
      
      Provide better /dev/cpu_dma_latency warnings that provide instructions on
      how to avoid the error, and update the man page.
      Signed-off-by: default avatarPrarit Bhargava <prarit@redhat.com>
      Cc: linux-pm@vger.kernel.org
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      40aafc7d
    • Prarit Bhargava's avatar
      tools/power turbostat: Provide better debug messages for failed capabilities accesses · 9c085817
      Prarit Bhargava authored
      turbostat reports some capabilities access errors and not others.  Provide
      the same debug message for all errors.
      
      [lenb: remove extra quotes]
      
      Cc: David Arcari <darcari@redhat.com>
      Signed-off-by: default avatarPrarit Bhargava <prarit@redhat.com>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      9c085817
    • Len Brown's avatar
      tools/power turbostat: update dump of SECONDARY_TURBO_RATIO_LIMIT · 884a1f95
      Len Brown authored
      cosmetic only (but useful if you copy/paste)
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      884a1f95
    • David S. Miller's avatar
      Merge branch 'bonding-fixes' · f5e305e6
      David S. Miller authored
      Nikolay Aleksandrov says:
      
      ====================
      bonding: properly restore flags when bond changes ether type
      
      A bug was reported by syzbot[1] that causes a warning and a myriad of
      other potential issues if a bond, that is also a slave, fails to enslave a
      non-eth device. While fixing that bug I found that we have the same
      issues when such enslave passes and after that the bond changes back to
      ARPHRD_ETHER (again due to ether_setup). This set fixes all issues by
      extracting the ether_setup() sequence in a helper which does the right
      thing about bond flags when it needs to change back to ARPHRD_ETHER. It
      also adds selftests for these cases.
      
      Patch 01 adds the new bond_ether_setup helper and fixes the issues when a
      bond device changes its ether type due to successful enslave. Patch 02
      fixes the issues when it changes its ether type due to an unsuccessful
      enslave. Note we need two patches because the bugs were introduced by
      different commits. Patch 03 adds the new selftests.
      
      Due to the comment adjustment and squash, could you please review
      patch 01 again? I've kept the other acks since there were no code
      changes.
      
      v3: squash the helper patch and the first fix, adjust the comment above
          it to be explicit about the bond device, no code changes
      v2: new set, all patches are new due to new approach of fixing these bugs
      
      [1] https://syzkaller.appspot.com/bug?id=391c7b1f6522182899efba27d891f1743e8eb3ef
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f5e305e6
    • Nikolay Aleksandrov's avatar
      selftests: bonding: add tests for ether type changes · 222c94ec
      Nikolay Aleksandrov authored
      Add new network selftests for the bonding device which exercise the ether
      type changing call paths. They also test for the recent syzbot bug[1] which
      causes a warning and results in wrong device flags (IFF_SLAVE missing).
      The test adds three bond devices and a nlmon device, enslaves one of the
      bond devices to the other and then uses the nlmon device for successful
      and unsuccesful enslaves both of which change the bond ether type. Thus
      we can test for both MASTER and SLAVE flags at the same time.
      
      If the flags are properly restored we get:
      TEST: Change ether type of an enslaved bond device with unsuccessful enslave   [ OK ]
      TEST: Change ether type of an enslaved bond device with successful enslave   [ OK ]
      
      [1] https://syzkaller.appspot.com/bug?id=391c7b1f6522182899efba27d891f1743e8eb3efSigned-off-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
      Reviewed-by: default avatarMichal Kubiak <michal.kubiak@intel.com>
      Acked-by: default avatarJonathan Toppins <jtoppins@redhat.com>
      Acked-by: default avatarJay Vosburgh <jay.vosburgh@canonical.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      222c94ec
    • Nikolay Aleksandrov's avatar
      bonding: restore bond's IFF_SLAVE flag if a non-eth dev enslave fails · e667d469
      Nikolay Aleksandrov authored
      syzbot reported a warning[1] where the bond device itself is a slave and
      we try to enslave a non-ethernet device as the first slave which fails
      but then in the error path when ether_setup() restores the bond device
      it also clears all flags. In my previous fix[2] I restored the
      IFF_MASTER flag, but I didn't consider the case that the bond device
      itself might also be a slave with IFF_SLAVE set, so we need to restore
      that flag as well. Use the bond_ether_setup helper which does the right
      thing and restores the bond's flags properly.
      
      Steps to reproduce using a nlmon dev:
       $ ip l add nlmon0 type nlmon
       $ ip l add bond1 type bond
       $ ip l add bond2 type bond
       $ ip l set bond1 master bond2
       $ ip l set dev nlmon0 master bond1
       $ ip -d l sh dev bond1
       22: bond1: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noqueue master bond2 state DOWN mode DEFAULT group default qlen 1000
       (now bond1's IFF_SLAVE flag is gone and we'll hit a warning[3] if we
        try to delete it)
      
      [1] https://syzkaller.appspot.com/bug?id=391c7b1f6522182899efba27d891f1743e8eb3ef
      [2] commit 7d5cd2ce ("bonding: correctly handle bonding type change on enslave failure")
      [3] example warning:
       [   27.008664] bond1: (slave nlmon0): The slave device specified does not support setting the MAC address
       [   27.008692] bond1: (slave nlmon0): Error -95 calling set_mac_address
       [   32.464639] bond1 (unregistering): Released all slaves
       [   32.464685] ------------[ cut here ]------------
       [   32.464686] WARNING: CPU: 1 PID: 2004 at net/core/dev.c:10829 unregister_netdevice_many+0x72a/0x780
       [   32.464694] Modules linked in: br_netfilter bridge bonding virtio_net
       [   32.464699] CPU: 1 PID: 2004 Comm: ip Kdump: loaded Not tainted 5.18.0-rc3+ #47
       [   32.464703] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.1-2.fc37 04/01/2014
       [   32.464704] RIP: 0010:unregister_netdevice_many+0x72a/0x780
       [   32.464707] Code: 99 fd ff ff ba 90 1a 00 00 48 c7 c6 f4 02 66 96 48 c7 c7 20 4d 35 96 c6 05 fa c7 2b 02 01 e8 be 6f 4a 00 0f 0b e9 73 fd ff ff <0f> 0b e9 5f fd ff ff 80 3d e3 c7 2b 02 00 0f 85 3b fd ff ff ba 59
       [   32.464710] RSP: 0018:ffffa006422d7820 EFLAGS: 00010206
       [   32.464712] RAX: ffff8f6e077140a0 RBX: ffffa006422d7888 RCX: 0000000000000000
       [   32.464714] RDX: ffff8f6e12edbe58 RSI: 0000000000000296 RDI: ffffffff96d4a520
       [   32.464716] RBP: ffff8f6e07714000 R08: ffffffff96d63600 R09: ffffa006422d7728
       [   32.464717] R10: 0000000000000ec0 R11: ffffffff9698c988 R12: ffff8f6e12edb140
       [   32.464719] R13: dead000000000122 R14: dead000000000100 R15: ffff8f6e12edb140
       [   32.464723] FS:  00007f297c2f1740(0000) GS:ffff8f6e5d900000(0000) knlGS:0000000000000000
       [   32.464725] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
       [   32.464726] CR2: 00007f297bf1c800 CR3: 00000000115e8000 CR4: 0000000000350ee0
       [   32.464730] Call Trace:
       [   32.464763]  <TASK>
       [   32.464767]  rtnl_dellink+0x13e/0x380
       [   32.464776]  ? cred_has_capability.isra.0+0x68/0x100
       [   32.464780]  ? __rtnl_unlock+0x33/0x60
       [   32.464783]  ? bpf_lsm_capset+0x10/0x10
       [   32.464786]  ? security_capable+0x36/0x50
       [   32.464790]  rtnetlink_rcv_msg+0x14e/0x3b0
       [   32.464792]  ? _copy_to_iter+0xb1/0x790
       [   32.464796]  ? post_alloc_hook+0xa0/0x160
       [   32.464799]  ? rtnl_calcit.isra.0+0x110/0x110
       [   32.464802]  netlink_rcv_skb+0x50/0xf0
       [   32.464806]  netlink_unicast+0x216/0x340
       [   32.464809]  netlink_sendmsg+0x23f/0x480
       [   32.464812]  sock_sendmsg+0x5e/0x60
       [   32.464815]  ____sys_sendmsg+0x22c/0x270
       [   32.464818]  ? import_iovec+0x17/0x20
       [   32.464821]  ? sendmsg_copy_msghdr+0x59/0x90
       [   32.464823]  ? do_set_pte+0xa0/0xe0
       [   32.464828]  ___sys_sendmsg+0x81/0xc0
       [   32.464832]  ? mod_objcg_state+0xc6/0x300
       [   32.464835]  ? refill_obj_stock+0xa9/0x160
       [   32.464838]  ? memcg_slab_free_hook+0x1a5/0x1f0
       [   32.464842]  __sys_sendmsg+0x49/0x80
       [   32.464847]  do_syscall_64+0x3b/0x90
       [   32.464851]  entry_SYSCALL_64_after_hwframe+0x44/0xae
       [   32.464865] RIP: 0033:0x7f297bf2e5e7
       [   32.464868] Code: 64 89 02 48 c7 c0 ff ff ff ff eb bb 0f 1f 80 00 00 00 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 89 54 24 1c 48 89 74 24 10
       [   32.464869] RSP: 002b:00007ffd96c824c8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
       [   32.464872] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f297bf2e5e7
       [   32.464874] RDX: 0000000000000000 RSI: 00007ffd96c82540 RDI: 0000000000000003
       [   32.464875] RBP: 00000000640f19de R08: 0000000000000001 R09: 000000000000007c
       [   32.464876] R10: 00007f297bffabe0 R11: 0000000000000246 R12: 0000000000000001
       [   32.464877] R13: 00007ffd96c82d20 R14: 00007ffd96c82610 R15: 000055bfe38a7020
       [   32.464881]  </TASK>
       [   32.464882] ---[ end trace 0000000000000000 ]---
      
      Fixes: 7d5cd2ce ("bonding: correctly handle bonding type change on enslave failure")
      Reported-by: syzbot+9dfc3f3348729cc82277@syzkaller.appspotmail.com
      Link: https://syzkaller.appspot.com/bug?id=391c7b1f6522182899efba27d891f1743e8eb3efSigned-off-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
      Reviewed-by: default avatarMichal Kubiak <michal.kubiak@intel.com>
      Acked-by: default avatarJonathan Toppins <jtoppins@redhat.com>
      Acked-by: default avatarJay Vosburgh <jay.vosburgh@canonical.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e667d469