1. 09 Jul, 2020 40 commits
    • Lee Jones's avatar
      usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI · 6dba06ce
      Lee Jones authored
      Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI,
      struct ehci_acpi_match becomes defined by unused.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/ehci-platform.c:478:36: warning: ‘ehci_acpi_match’ defined but not used [-Wunused-const-variable=]
       478 | static const struct acpi_device_id ehci_acpi_match[] = {
       | ^~~~~~~~~~~~~~~
      
      Cc: Tony Prisk <linux@prisktech.co.nz>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: Steven Brown <sbrown@cortland.com>
      Cc: Hauke Mehrtens <hauke@hauke-m.de>
      Cc: de Goede <hdegoede@redhat.com>
      Cc: Michael Buesch <m@bues.ch>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-29-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6dba06ce
    • Lee Jones's avatar
      usb: early: xhci-dbc: File headers are not good candidates for kerneldoc · 02ec8a09
      Lee Jones authored
      Demote xhci-dbc's file header to a standard comment block.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/early/xhci-dbc.c:10: warning: Function parameter or member 'fmt' not described in 'pr_fmt'
      
      Cc: Lu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-28-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      02ec8a09
    • Lee Jones's avatar
      usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile · f0f705fc
      Lee Jones authored
      If the header file containing a function's prototype isn't included by
      the sourcefile containing the associated function, the build system
      complains of missing prototypes.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
       drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
       915 | int chunk, ret;
       | ^~~
       drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for ‘early_xdbc_parse_parameter’ [-Wmissing-prototypes]
       600 | int __init early_xdbc_parse_parameter(char *s)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for ‘early_xdbc_setup_hardware’ [-Wmissing-prototypes]
       653 | int __init early_xdbc_setup_hardware(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for ‘early_xdbc_register_console’ [-Wmissing-prototypes]
       910 | void __init early_xdbc_register_console(void)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Cc: Lu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarJann Horn <jannh@google.com>
      Link: https://lore.kernel.org/r/20200706133341.476881-27-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f0f705fc
    • Lee Jones's avatar
      usb: early: ehci-dbgp: Remove set but never checked variable 'ret' · beb368a4
      Lee Jones authored
      'ret' hasn't  been checked since the driver's inception in 2009.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
       drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
       915 | int chunk, ret;
       | ^~~
      
      Cc: Sumit Garg <sumit.garg@linaro.org>
      Cc: Daniel Thompson <daniel.thompson@linaro.org>
      Cc: Douglas Anderson <dianders@chromium.org>
      Cc: Petr Mladek <pmladek@suse.com>
      Cc: Yinghai Lu <yhlu.kernel@gmail.com>
      Cc: Jason Wessel <jason.wessel@windriver.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
      Link: https://lore.kernel.org/r/20200706133341.476881-26-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      beb368a4
    • Lee Jones's avatar
      usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init() · e6b073de
      Lee Jones authored
      It isn't called from anywhere outside of ucsi.c.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/ucsi/ucsi.c:1005:5: warning: no previous prototype for ‘ucsi_init’ [-Wmissing-prototypes]
       1005 | int ucsi_init(struct ucsi *ucsi)
       | ^~~~~~~~~
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-25-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e6b073de
    • Lee Jones's avatar
      usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' · 1a4f38a6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’:
       drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable]
       626 | u8 addr;
       | ^~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarJassi Brar <jaswinder.singh@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-24-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1a4f38a6
    • Lee Jones's avatar
      usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc' · 8834f60d
      Lee Jones authored
      Looks like it's never been used.  Driver was mainlined in 2014.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/mv_u3d_core.c:35:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=]
       35 | static const char driver_desc[] = DRIVER_DESC;
       | ^~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Jason Yan <yanaijie@huawei.com>
      Cc: Yu Xu <yuxu@marvell.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-23-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8834f60d
    • Lee Jones's avatar
      usb: host: fotg210-hcd: Demote obvious misuse of kerneldoc to standard comment blocks · 15ee5d03
      Lee Jones authored
      Only 2 functions attempted to use kerneldoc in this massive file.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’:
       drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable]
       drivers/usb/host/fotg210-hcd.c:5569: warning: Function parameter or member 'pdev' not described in 'fotg210_hcd_probe'
       drivers/usb/host/fotg210-hcd.c:5666: warning: Function parameter or member 'pdev' not described in 'fotg210_hcd_remove'
       drivers/usb/host/fotg210-hcd.c:5666: warning: Excess function parameter 'dev' description in 'fotg210_hcd_remove'
      
      Cc: Yuan-Hsin Chen <yhchen@faraday-tech.com>
      Cc: Feng-Hsin Chiang <john453@faraday-tech.com>
      Cc: Po-Yu Chuang <ratbert.chuang@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-22-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      15ee5d03
    • Lee Jones's avatar
      usb: host: bcma-hcd: Demote obvious misuse of kerneldoc to standard comment blocks · edd93579
      Lee Jones authored
      No attempt has been made to document either of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/bcma-hcd.c:180: warning: Function parameter or member 'usb_dev' not described in 'bcma_hcd_usb20_old_arm_init'
       drivers/usb/host/bcma-hcd.c:268: warning: Function parameter or member 'bcma_hcd' not described in 'bcma_hcd_usb20_ns_init'
      
      Cc: Chuhong Yuan <hslester96@gmail.com>
      Cc: Hauke Mehrtens <hauke@hauke-m.de>
      Cc: Felix Fietkau <nbd@openwrt.org>
      Cc: Michael Buesch <m@bues.ch>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-21-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      edd93579
    • Lee Jones's avatar
      usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks · b612b0fa
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set'
       drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set'
       drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params'
       drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback'
       drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback'
       drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback'
       drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev'
       drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev'
       drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup'
       drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Bryan Wu <cooloney@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-20-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b612b0fa
    • Lee Jones's avatar
      usb: host: fotg210-hcd: Remove unused variable 'hcc_params' · 522514e5
      Lee Jones authored
      The result is actually read into fotg210->caps->hcc_params.  No
      need to popuate an unused varible with the unchecked return value
      from fotg210_readl().
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’:
       drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable]
       5013 | u32 hcc_params;
       | ^~~~~~~~~~
      
      Cc: Yuan-Hsin Chen <yhchen@faraday-tech.com>
      Cc: Feng-Hsin Chiang <john453@faraday-tech.com>
      Cc: Po-Yu Chuang <ratbert.chuang@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-19-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      522514e5
    • Lee Jones's avatar
      usb: host: ehci-fsl: Fix incorrectly named function argument · 1a896833
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/ehci-fsl.c:694: warning: Function parameter or member 'pdev' not described in 'fsl_ehci_drv_remove'
       drivers/usb/host/ehci-fsl.c:694: warning: Excess function parameter 'dev' description in 'fsl_ehci_drv_remove'
      
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Randy Vinson <rvinson@mvista.com>
      Cc: Dave Liu <daveliu@freescale.com>
      Cc: Jerry Huang <Chang-Ming.Huang@freescale.com>
      Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-18-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1a896833
    • Lee Jones's avatar
      usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc · 709ba38e
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'imx21' not described in 'copy_to_dmem'
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'dmem_offset' not described in 'copy_to_dmem'
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'src' not described in 'copy_to_dmem'
       drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'count' not described in 'copy_to_dmem'
      
      Cc: Shawn Guo <shawnguo@kernel.org>
      Cc: Sascha Hauer <s.hauer@pengutronix.de>
      Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
      Cc: Fabio Estevam <festevam@gmail.com>
      Cc: NXP Linux Team <linux-imx@nxp.com>
      Cc: Stephen Boyd <swboyd@chromium.org>
      Cc: Jay Monkman <jtm@lopingdog.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-17-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      709ba38e
    • Lee Jones's avatar
      usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues · 4ef2dfbd
      Lee Jones authored
      Ranging from missing descriptions and formatting mishaps to over-documenting
      of missing arguments, likely due to bitrot.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/pch_udc.c:239: warning: Function parameter or member 'request' not described in 'pch_udc_stp_dma_desc'
       drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_fall' not described in 'pch_vbus_gpio_data'
       drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_rise' not described in 'pch_vbus_gpio_data'
       drivers/usb/gadget/udc/pch_udc.c:482: warning: Function parameter or member 'ep' not described in 'pch_udc_write_csr'
       drivers/usb/gadget/udc/pch_udc.c:482: warning: Excess function parameter 'addr' description in 'pch_udc_write_csr'
       drivers/usb/gadget/udc/pch_udc.c:498: warning: Function parameter or member 'ep' not described in 'pch_udc_read_csr'
       drivers/usb/gadget/udc/pch_udc.c:498: warning: Excess function parameter 'addr' description in 'pch_udc_read_csr'
       drivers/usb/gadget/udc/pch_udc.c:662: warning: Function parameter or member 'ep_in' not described in 'pch_udc_ep_set_bufsz'
       drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_enable'
       drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'cfg' not described in 'pch_udc_ep_enable'
       drivers/usb/gadget/udc/pch_udc.c:977: warning: Excess function parameter 'regs' description in 'pch_udc_ep_enable'
       drivers/usb/gadget/udc/pch_udc.c:1010: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_disable'
       drivers/usb/gadget/udc/pch_udc.c:1010: warning: Excess function parameter 'regs' description in 'pch_udc_ep_disable'
       drivers/usb/gadget/udc/pch_udc.c:1030: warning: Function parameter or member 'ep' not described in 'pch_udc_wait_ep_stall'
       drivers/usb/gadget/udc/pch_udc.c:1030: warning: Excess function parameter 'dev' description in 'pch_udc_wait_ep_stall'
       drivers/usb/gadget/udc/pch_udc.c:1341: warning: Function parameter or member 'data' not described in 'pch_vbus_gpio_irq'
       drivers/usb/gadget/udc/pch_udc.c:1341: warning: Excess function parameter 'dev' description in 'pch_vbus_gpio_irq'
       drivers/usb/gadget/udc/pch_udc.c:1365: warning: Function parameter or member 'vbus_gpio_port' not described in 'pch_vbus_gpio_init'
       drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'dev' not described in 'pch_udc_free_dma_chain'
       drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'req' not described in 'pch_udc_free_dma_chain'
       drivers/usb/gadget/udc/pch_udc.c:1717: warning: Function parameter or member 'usbep' not described in 'pch_udc_pcd_ep_disable'
       drivers/usb/gadget/udc/pch_udc.c:2006: warning: Excess function parameter 'halt' description in 'pch_udc_pcd_set_wedge'
       drivers/usb/gadget/udc/pch_udc.c:2756: warning: Function parameter or member 'pdev' not described in 'pch_udc_isr'
       drivers/usb/gadget/udc/pch_udc.c:2756: warning: Excess function parameter 'dev' description in 'pch_udc_isr'
       drivers/usb/gadget/udc/pch_udc.c:2906: warning: Function parameter or member 'dev' not described in 'init_dma_pools'
       drivers/usb/gadget/udc/pch_udc.c:2906: warning: Excess function parameter 'pdev' description in 'init_dma_pools'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Chuhong Yuan <hslester96@gmail.com>
      Cc: LAPIS Semiconductor <tomoya-linux@dsn.lapis-semi.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-16-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4ef2dfbd
    • Lee Jones's avatar
      usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' · 6327bf75
      Lee Jones authored
      Looks as though it's never been used.  Driver was introduced in 2014.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/mv_udc_core.c:56:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=]
       56 | static const char driver_desc[] = DRIVER_DESC;
       | ^~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Chao Xie <chao.xie@marvell.com>
      Cc: Neil Zhang <zhangwm@marvell.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-15-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6327bf75
    • Lee Jones's avatar
      usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' · 33a4eeb1
      Lee Jones authored
      Looks like it's been this way since the driver's inception in 2007.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’:
       drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
       478 | u16 tmp;
       | ^~~
      
      Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-14-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      33a4eeb1
    • Lee Jones's avatar
      usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions · 120d91da
      Lee Jones authored
      These are not used outside of this sourcefile, so make them static.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/lpc32xx_udc.c:1929:6: warning: no previous prototype for ‘udc_send_in_zlp’ [-Wmissing-prototypes]
       1929 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
       | ^~~~~~~~~~~~~~~
       drivers/usb/gadget/udc/lpc32xx_udc.c:1943:6: warning: no previous prototype for ‘udc_handle_eps’ [-Wmissing-prototypes]
       1943 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
       | ^~~~~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Sylvain Lemieux <slemieux.tyco@gmail.com>
      Cc: Kevin Wells <kevin.wells@nxp.com>
      Cc: Roland Stigge <stigge@antcom.de>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Link: https://lore.kernel.org/r/20200706133341.476881-13-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      120d91da
    • Lee Jones's avatar
      usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc · 8f9a0e10
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'type' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'h' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'data' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'len' not described in '__ffs_data_do_os_desc'
       drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'priv' not described in '__ffs_data_do_os_desc'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: David Howells <dhowells@redhat.com>
      Cc: Michal Nazarewicz <mina86@mina86.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-12-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8f9a0e10
    • Lee Jones's avatar
      usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' · 5d1d4818
      Lee Jones authored
      Looks as though it's never been used.  Driver was introduced in 2010.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/legacy/nokia.c:65:19: warning: ‘product_nokia’ defined but not used [-Wunused-const-variable=]
       65 | static const char product_nokia[] = NOKIA_LONG_NAME;
       | ^~~~~~~~~~~~~
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Al Borchers <alborchers@steinerpoint.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-11-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5d1d4818
    • Lee Jones's avatar
      usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' · 14602c55
      Lee Jones authored
      Commit e78355b5 ("usb: gadget: udc: atmel: Don't use DT to
      configure end point") pulled out all functionality dealing with 'pp'.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘atmel_udc_of_init’:
       drivers/usb/gadget/udc/atmel_usba_udc.c:2106:22: warning: variable ‘pp’ set but not used [-Wunused-but-set-variable]
       2106 | struct device_node *pp;
       | ^~
      
      Cc: Cristian Birsan <cristian.birsan@microchip.com>
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-10-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      14602c55
    • Lee Jones's avatar
      usb: misc: legousbtower: Demote function header which is clearly not kerneldoc · 4ac2c460
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data'
      
      Cc: Juergen Stuber <starblue@users.sourceforge.net>
      Cc: David Glance <davidgsf@sourceforge.net>
      Cc: david <david@csse.uwa.edu.au>
      Cc: legousb-devel@lists.sourceforge.net
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-8-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4ac2c460
    • Lee Jones's avatar
      usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues · 4ee383c7
      Lee Jones authored
      Mostly bitrotted argument descriptions/names.  Also the removal
      of a blank line in the middle of a kerneldoc header, which is
      not allowed.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Function parameter or member 'ep' not described in 'ep_write_UDCCSR'
       drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Excess function parameter 'udc' description in 'ep_write_UDCCSR'
       drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Function parameter or member 'udc' not described in 'set_ep0state'
       drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Excess function parameter 'dev' description in 'set_ep0state'
       drivers/usb/gadget/udc/pxa27x_udc.c:506: warning: Excess function parameter 'req' description in 'inc_ep_stats_reqs'
       drivers/usb/gadget/udc/pxa27x_udc.c:1476: warning: bad line:
       drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Function parameter or member 'udc' not described in 'udc_enable'
       drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Excess function parameter 'dev' description in 'udc_enable'
       drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Function parameter or member 'g' not described in 'pxa27x_udc_start'
       drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Excess function parameter 'bind' description in 'pxa27x_udc_start'
       drivers/usb/gadget/udc/pxa27x_udc.c:1784: warning: Excess function parameter 'driver' description in 'stop_activity'
       drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Function parameter or member 'g' not described in 'pxa27x_udc_stop'
       drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Excess function parameter 'driver' description in 'pxa27x_udc_stop'
       drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Function parameter or member 'pdev' not described in 'pxa_udc_probe'
       drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Excess function parameter '_dev' description in 'pxa_udc_probe'
      
      Cc: Daniel Mack <daniel@zonque.org>
      Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
      Cc: Robert Jarzmik <robert.jarzmik@free.fr>
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-7-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4ee383c7
    • Lee Jones's avatar
      usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark · b1e4d550
      Lee Jones authored
      Kerneldoc expects all function arguments to be documented.  If any
      are missed it will complain.  Downgrade one header with 3 missing
      argument descriptions and one which makes no attempt.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'dev_addr' not described in 'gether_setup_name'
       drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'host_addr' not described in 'gether_setup_name'
       drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'qmult' not described in 'gether_setup_name'
       drivers/usb/gadget/function/u_ether.c:1022: warning: Function parameter or member 'dev' not described in 'gether_cleanup'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-6-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b1e4d550
    • Lee Jones's avatar
      usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' · 53070115
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/amd5536udc_pci.c:52:19: warning: ‘mod_desc’ defined but not used [-Wunused-const-variable=]
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-5-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      53070115
    • Lee Jones's avatar
      usb: gadget: legacy: printer: Remove unused variable 'driver_desc' · 89dd9a8c
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/legacy/printer.c:24:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=]
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-4-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      89dd9a8c
    • Lee Jones's avatar
      usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format · f2db5f20
      Lee Jones authored
      No attempt has been made to document any of the structure's properties here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/ci_hdrc_pci.c:132: warning: cannot understand function prototype: 'const struct pci_device_id ci_hdrc_pci_id_table[] = '
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Cc: David Lopo <dlopo@chipidea.mips.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-3-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f2db5f20
    • Lee Jones's avatar
      usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks · 464b7d0e
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data'
       drivers/usb/misc/legousbtower.c:290: warning: Function parameter or member 'dev' not described in 'tower_delete'
       drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'inode' not described in 'tower_open'
       drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'file' not described in 'tower_open'
       drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'inode' not described in 'tower_release'
       drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'file' not described in 'tower_release'
       drivers/usb/misc/legousbtower.c:452: warning: Function parameter or member 'dev' not described in 'tower_check_for_read_packet'
       drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'file' not described in 'tower_poll'
       drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'wait' not described in 'tower_poll'
       drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'file' not described in 'tower_llseek'
       drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'off' not described in 'tower_llseek'
       drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'whence' not described in 'tower_llseek'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'file' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'buffer' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'count' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'ppos' not described in 'tower_read'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'file' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'buffer' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'count' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'ppos' not described in 'tower_write'
       drivers/usb/misc/legousbtower.c:669: warning: Function parameter or member 'urb' not described in 'tower_interrupt_in_callback'
       drivers/usb/misc/legousbtower.c:724: warning: Function parameter or member 'urb' not described in 'tower_interrupt_out_callback'
       drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'interface' not described in 'tower_probe'
       drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'id' not described in 'tower_probe'
       drivers/usb/misc/legousbtower.c:863: warning: Function parameter or member 'interface' not described in 'tower_disconnect'
      
      Cc: Juergen Stuber <starblue@users.sourceforge.net>
      Cc: David Glance <davidgsf@sourceforge.net>
      Cc: david <david@csse.uwa.edu.au>
      Cc: legousb-devel@lists.sourceforge.net
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200706133341.476881-2-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      464b7d0e
    • Lee Jones's avatar
      usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' · 66f84901
      Lee Jones authored
      An attempt was made to document the functions in 'dummy_hcd',
      but a simple spelling mistake was made.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/udc/dummy_hcd.c:1597: warning: Function parameter or member 'dum_hcd' not described in 'handle_control_request'
       drivers/usb/gadget/udc/dummy_hcd.c:1597: warning: Excess function parameter 'dum' description in 'handle_control_request'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: Andrey Konovalov <andreyknvl@gmail.com>
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-31-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      66f84901
    • Lee Jones's avatar
      usb: musb: musb_dsps: Demote obvious misuse of kerneldoc to standard comment blocks · 09e03a89
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/musb/musb_dsps.c:44: warning: cannot understand function prototype: 'struct dsps_musb_wrapper '
       drivers/usb/musb/musb_dsps.c:102: warning: cannot understand function prototype: 'struct dsps_glue '
       drivers/usb/musb/musb_dsps.c:169: warning: Function parameter or member 'musb' not described in 'dsps_musb_enable'
       drivers/usb/musb/musb_dsps.c:195: warning: Function parameter or member 'musb' not described in 'dsps_musb_disable'
      
      Cc: Bin Liu <b-liu@ti.com>
      Cc: Ravi B <ravibabu@ti.com>
      Cc: Kumar Gupta <ajay.gupta@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-29-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      09e03a89
    • Lee Jones's avatar
      usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks · 7e8455b1
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/ldusb.c:192: warning: Function parameter or member 'dev' not described in 'ld_usb_abort_transfers'
       drivers/usb/misc/ldusb.c:206: warning: Function parameter or member 'dev' not described in 'ld_usb_delete'
       drivers/usb/misc/ldusb.c:220: warning: Function parameter or member 'urb' not described in 'ld_usb_interrupt_in_callback'
       drivers/usb/misc/ldusb.c:281: warning: Function parameter or member 'urb' not described in 'ld_usb_interrupt_out_callback'
       drivers/usb/misc/ldusb.c:301: warning: Function parameter or member 'inode' not described in 'ld_usb_open'
       drivers/usb/misc/ldusb.c:301: warning: Function parameter or member 'file' not described in 'ld_usb_open'
       drivers/usb/misc/ldusb.c:372: warning: Function parameter or member 'inode' not described in 'ld_usb_release'
       drivers/usb/misc/ldusb.c:372: warning: Function parameter or member 'file' not described in 'ld_usb_release'
       drivers/usb/misc/ldusb.c:414: warning: Function parameter or member 'file' not described in 'ld_usb_poll'
       drivers/usb/misc/ldusb.c:414: warning: Function parameter or member 'wait' not described in 'ld_usb_poll'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'file' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'buffer' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'count' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:439: warning: Function parameter or member 'ppos' not described in 'ld_usb_read'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'file' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'buffer' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'count' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:526: warning: Function parameter or member 'ppos' not described in 'ld_usb_write'
       drivers/usb/misc/ldusb.c:651: warning: Function parameter or member 'intf' not described in 'ld_usb_probe'
       drivers/usb/misc/ldusb.c:651: warning: Function parameter or member 'id' not described in 'ld_usb_probe'
       drivers/usb/misc/ldusb.c:754: warning: Function parameter or member 'intf' not described in 'ld_usb_disconnect'
      
      Cc: Johan Hovold <johan@kernel.org>
      Cc: Michael Hund <mhund@ld-didactic.de>
      Cc: David Glance <advidgsf@sourceforge.net>
      Cc: Juergen Stuber <starblue@users.sourceforge.net>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-28-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7e8455b1
    • Lee Jones's avatar
      usb: gadget: function: u_serial: Repair misdocumented function argument · 1ba1f141
      Lee Jones authored
      Looks as though this has been an issue since the driver's
      inception back in 2014.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/gadget/function/u_serial.c:538: warning: Function parameter or member 'port' not described in 'gs_start_io'
       drivers/usb/gadget/function/u_serial.c:538: warning: Excess function parameter 'dev' description in 'gs_start_io'
      
      Cc: Felipe Balbi <balbi@kernel.org>
      Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
      Cc: Al Borchers <alborchers@steinerpoint.com>
      Cc: Peter Berger <pberger@brimson.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-27-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1ba1f141
    • Lee Jones's avatar
      usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks · c16700ed
      Lee Jones authored
      No attempt has been made to document any of the demoted functions here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/misc/iowarrior.c:251: warning: Function parameter or member 'dev' not described in 'iowarrior_delete'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'file' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'buffer' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'count' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:279: warning: Function parameter or member 'ppos' not described in 'iowarrior_read'
       drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'file' not described in 'iowarrior_ioctl'
       drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'cmd' not described in 'iowarrior_ioctl'
       drivers/usb/misc/iowarrior.c:483: warning: Function parameter or member 'arg' not described in 'iowarrior_ioctl'
       drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'inode' not described in 'iowarrior_open'
       drivers/usb/misc/iowarrior.c:599: warning: Function parameter or member 'file' not described in 'iowarrior_open'
       drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'inode' not described in 'iowarrior_release'
       drivers/usb/misc/iowarrior.c:647: warning: Function parameter or member 'file' not described in 'iowarrior_release'
       drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'interface' not described in 'iowarrior_probe'
       drivers/usb/misc/iowarrior.c:753: warning: Function parameter or member 'id' not described in 'iowarrior_probe'
       drivers/usb/misc/iowarrior.c:879: warning: Function parameter or member 'interface' not described in 'iowarrior_disconnect'
      
      Cc: Johan Hovold <johan@kernel.org>
      Cc: Christian Lucht <lucht@codemercs.com>
      Cc: Stephane Dalton <sdalton@videotron.ca>
      Cc: Stephane Doyon <s.doyon@videotron.ca>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-26-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c16700ed
    • Lee Jones's avatar
      usb: misc: iowarrior: Fix odd corruption issue in the file header · 2ba277a0
      Lee Jones authored
      Looks although Stephane's name was corrupted somehow.
      
      Cc: Johan Hovold <johan@kernel.org>
      Cc: Christian Lucht <lucht@codemercs.com>
      Cc: Stephane Dalton <sdalton@videotron.ca>
      Cc: Stephane Doyon <s.doyon@videotron.ca>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-25-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2ba277a0
    • Lee Jones's avatar
      usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block · 20f81da9
      Lee Jones authored
      No attempt has been made to document the demoted function here.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/usbmisc_imx.c:801: warning: Function parameter or member 'data' not described in 'imx7d_charger_detection'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Cc: Shawn Guo <shawnguo@kernel.org>
      Cc: Sascha Hauer <s.hauer@pengutronix.de>
      Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
      Cc: Fabio Estevam <festevam@gmail.com>
      Cc: NXP Linux Team <linux-imx@nxp.com>
      Cc: Richard Zhao <richard.zhao@freescale.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-24-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      20f81da9
    • Lee Jones's avatar
      usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation · 71be1a8a
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/tcpm/fusb302.c: In function ‘fusb302_log’:
       drivers/usb/typec/tcpm/fusb302.c:186:2: warning: function ‘fusb302_log’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
       186 | _fusb302_log(chip, fmt, args);
       | ^~~~~~~~~~~~
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Cc: Yueyao Zhu <yueyao.zhu@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Link: https://lore.kernel.org/r/20200703174148.2749969-23-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      71be1a8a
    • Lee Jones's avatar
      usb: typec: altmodes: displayport: Supply missing displayport.h include file · 318ebed2
      Lee Jones authored
      If the header file containing a function's prototype isn't included by
      the sourcefile containing the associated function, the build system
      complains of missing prototypes.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/altmodes/displayport.c:511:5: warning: no previous prototype for ‘dp_altmode_probe’ [-Wmissing-prototypes]
       drivers/usb/typec/altmodes/displayport.c:551:6: warning: no previous prototype for ‘dp_altmode_remove’ [-Wmissing-prototypes]
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-22-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      318ebed2
    • Lee Jones's avatar
      usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc · 50c9bd05
      Lee Jones authored
      Demote displayport's file header to a standard comment block.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/typec/altmodes/displayport.c:18: warning: Function parameter or member '_dp' not described in 'DP_HEADER'
       drivers/usb/typec/altmodes/displayport.c:18: warning: Function parameter or member 'cmd' not described in 'DP_HEADER'
      
      Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-21-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      50c9bd05
    • Lee Jones's avatar
      usb: storage: alauda: Remove set but unchecked variable · 7565fce1
      Lee Jones authored
      The return value of alauda_get_media_status() hasn't been checked
      since the driver's inception back in 2005.  If nothing have gone
      wrong/been detected until this point, it's probably safe to just
      remove the variable.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/storage/alauda.c: In function ‘alauda_check_media’:
       drivers/usb/storage/alauda.c:456:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
       456 | int rc;
       | ^~
      
      Cc: Alan Stern <stern@rowland.harvard.edu>
      Cc: Daniel Drake <dsd@gentoo.org>
      Cc: usb-storage@lists.one-eyed-alien.net
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-20-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7565fce1
    • Lee Jones's avatar
      usb: host: xhci-debugfs: Use 'gnu_printf' format notation · 142c8bb6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/host/xhci-debugfs.c:128:2: warning: function ‘xhci_debugfs_regset’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
       128 | vsnprintf(rgs->name, sizeof(rgs->name), fmt, args);
       | ^~~~~~~~~
      
      Cc: Mathias Nyman <mathias.nyman@intel.com>
      Cc: Lu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-19-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      142c8bb6
    • Lee Jones's avatar
      usb: chipidea: udc: Fix a few kerneldoc issues · f2926dd5
      Lee Jones authored
      Descriptions were missing for 'ci' almost throughout.  There was
      one instance of over-documenting.  Finally one function argument
      was incorrectly documented (probably down to bitrot).
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/usb/chipidea/udc.c:245: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed'
       drivers/usb/chipidea/udc.c:271: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active'
       drivers/usb/chipidea/udc.c:285: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard'
       drivers/usb/chipidea/udc.c:296: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard'
       drivers/usb/chipidea/udc.c:321: warning: Function parameter or member 'ci' not described in 'hw_usb_reset'
       drivers/usb/chipidea/udc.c:628: warning: Excess function parameter 'ci' description in 'free_pending_td'
       drivers/usb/chipidea/udc.c:655: warning: Function parameter or member 'hwep' not described in '_hardware_dequeue'
       drivers/usb/chipidea/udc.c:655: warning: Excess function parameter 'gadget' description in '_hardware_dequeue'
      
      Cc: Peter Chen <Peter.Chen@nxp.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20200703174148.2749969-18-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f2926dd5