- 20 Feb, 2016 40 commits
-
-
Aaro Koskinen authored
Some if branches are missing braces as required by coding style. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Aaro Koskinen authored
Delete redundant blank lines. Signed-off-by:
-
Bhaktipriya Shridhar authored
Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @@ type T; constant C; expression e; identifier i; @@ T i - = C ; i = e; Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
In this file, the values returned by rtllib_priv() are unnecessarily cast into a pointer type in some assignment statements. Remove the cast as it is unneeded. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
With cmwq, use of dedicated workqueues can be replaced by system_wq. Removed the dedicated workqueue and used system_wq instead. Since the work items in the workqueues do not need to be ordered, increase of concurrency by switching to system_wq should not break anything. All work items are sync canceled so it is guaranteed that no work is running when driver is detached. Signed-off-by:
-
Bhumika Goyal authored
Replace long if-else block with switch-case to make it more readable and compact. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Anchal Jain authored
Add the required leading * on subsequent lines as well as move the */ on a separate line. Checkpatch found this issue. Signed-off-by:
Anchal Jain <anchalj109@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch removes braces for single statement blocks. The warning was detected using checkpatch.pl. Coccinelle was used to make the change. @@ expression e,e1; @@ - if (e) { + if (e) e1; - } Signed-off-by: -
Andrew Bradford authored
RTL8188EE has a maximum of 2 RF paths (chains) so paths C and D are not needed to support this part. Signed-off-by:
Andrew Bradford <andrew@bradfordembedded.com> Signed-off-by:
-
Colin Vidal authored
Jump a new line after and operator of the test. It avoids to exceed 80 chars line, and remove a checkpatch warning. Signed-off-by:
Colin Vidal <colin@cvidal.org> Signed-off-by:
-
Colin Vidal authored
Remove a checkpatch warning, putting constant operant on right of two tests. Signed-off-by:
-
Colin Vidal authored
And a space after include keyword, making the preprocessor more readable, and remove an unexpected space between a type and variable name. Signed-off-by:
-
Colin Vidal authored
As FSF address changed in the past, and can change in the future, remove the address paragraph in the comment header, and avoid a warning of checkpatch. Signed-off-by:
-
Amitoj Kaur Chawla authored
Introduce the use of function put_unaligned_le16. This is done using the following Coccinelle semantic patch: //<smpl> @@ identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ...+> ? tmp = e @@ type T; identifier tmp; @@ - T tmp; ...when != tmp //</smpl> Corresponding header file has been added too. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
The function vfree tests whether the argument is NULL and returns immediately. So NULL test is not needed before vfree. Also remove blank line between function calls. Signed-off-by:
-
Bhumika Goyal authored
The function vfree tests whether the argument is NULL and returns immediately. So NULL test before vfree is not needed. Also remove braces around if branch as they are no longer needed. Signed-off-by:
-
Bhaktipriya Shridhar authored
The macro ARRAY_SIZE is more concise to use instead of dividing size of the array by the size of its type. Changes were made using Coccinelle. @@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) Signed-off-by:
-
Janani Ravichandran authored
Remove unnecessary else when there is a return statement in the corresponding if block. Coccinelle patch used: @rule1@ expression e1; @@ if (e1) { ... return ...; } - else{ ... - } @rule2@ expression e2; statement s1; @@ if(e2) { ... return ...; } - else s1 Signed-off-by: -
Geliang Tang authored
This patch cleans whitespaces and blank lines involved with previous two patchs in this patch set. Signed-off-by:
Geliang Tang <geliangtang@163.com> Acked-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Geliang Tang authored
There are some useless codes in rtw_free_recvframe23a_queue() and recvframe_defrag(), so remove them. Signed-off-by:
-
Geliang Tang authored
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by:
-
Bhumika Goyal authored
The macros PlatformProcessHCICommands and PlatformTxBTQueuedPackets are not used anywhere in the kernel so remove them. Signed-off-by:
-
Amitoj Kaur Chawla authored
With concurrency managed workqueues, use of dedicated workqueues can be replaced by using system_wq. Drop schedule_usb_work by using system_wq. Since there is only one work item per buf_anchor and most_dev and they do not need to be ordered, increase of concurrency by switching to system_wq should not break anything. Both work items are sync canceled before the driver can be unregistered, to ensure no work item is pending or executing on any CPU by the time exit path is in flight. Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace pr_err with dev_err when a appropriate device structure is present. Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace request_irq with devm_request_irq to get the interrupt for device which is automatically freed on exit. Remove corresponding free_irq from probe and remove functions of a platform device. Also, remove an unnecessary label. Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace request_mem_region and ioremap with devm_ioremap_resource and remove corresponding freeing functions release_mem_region and iounmap from probe and remove functions of a platform device. Also, an unnecessary platform_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. Lastly, unnecessary labels have been removed. Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace kzalloc with devm_kzalloc and remove corresponding kfrees from probe and remove functions of a platform device. Also, an unnecessary label has been removed. Signed-off-by:
-
Laura Garcia Liebana authored
Return a ZERO_SIZE_PTR in the xlr_config_spill function if the kmalloc returns an invalid value. This change prevents a possible segmentation fault as the invalid pointer is fed into PTR_ALIGN macro. Signed-off-by:
Laura Garcia Liebana <nevola@gmail.com> Signed-off-by:
-
Laura Garcia Liebana authored
Insert code indent for conditional statements. Checkpatch detected this issue. Signed-off-by:
-
Laura Garcia Liebana authored
Spaces preferred around that '/' (ctx:VxV). Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of comparison to NULL, use !<variable> instead. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of CamelCase for constants. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of multiple assignments in a single line. Checkpatch found this issue. Signed-off-by:
-
Laura Garcia Liebana authored
Remove uneeded blank spaces after a cast. Checkpatch found these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Align arguments with the open parenthesis. Checkpatch found these issues. Signed-off-by:
-
Thaissa Falbo authored
Remove ret variable in functions that used it to determine the return. Simplified the return logic for these functions. Found with Coccinelle script: @@ local idexpression ret; expression c,d; identifier label; @@ switch ( ... ) { case label : ... - ret = c; - break; + return c; ... default: ... - ret = d; + return d; ... } ... when != ret - return ret; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:Thaissa Falbo <thaissa.falbo@gmail.com> Signed-off-by:
-
Thaissa Falbo authored
Simplified return of funcions by removing assignment of ret variable. Coccinelle script used: @@ local idexpression ret; expression e; @@ - ret = e; - if(ret) - return ret; + if(e) + return e; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ local idexpression ret; expression e; @@ - ret = e; - if(ret){ + if(e){ ... when != ret - return ret; + return e; } @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: -
Thaissa Falbo authored
Fix "line over 80 characters" checkpatch warnings WARNING: line over 80 characters Signed-off-by:
-
Thaissa Falbo authored
Fixed code indentation warning as detected by checkpatch. WARNING: suspect code indent for conditional statements (24, 40) #1672: FILE: drivers/staging/media/davinci_vpfe/dm365_resizer.c:1672: Signed-off-by:
-
Thaissa Falbo authored
WARNING: Comparisons should place the constant on the right side of the test Fixed warnings by moving the constants to the right side of the comparisons. Signed-off-by:
-
