1. 06 Apr, 2021 13 commits
    • Lee Jones's avatar
      block: drbd: drbd_receiver: Demote less than half complete kernel-doc header · 6ec2a0f2
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/drbd/drbd_receiver.c:1641: warning: Function parameter or member 'op' not described in 'drbd_submit_peer_request'
       drivers/block/drbd/drbd_receiver.c:1641: warning: Function parameter or member 'op_flags' not described in 'drbd_submit_peer_request'
       drivers/block/drbd/drbd_receiver.c:1641: warning: Function parameter or member 'fault_type' not described in 'drbd_submit_peer_request'
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-10-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      6ec2a0f2
    • Lee Jones's avatar
      block: drbd: drbd_main: Fix a bunch of function documentation discrepancies · 584164c8
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/drbd/drbd_main.c:278: warning: Function parameter or member 'connection' not described in 'tl_clear'
       drivers/block/drbd/drbd_main.c:278: warning: Excess function parameter 'device' description in 'tl_clear'
       drivers/block/drbd/drbd_main.c:489: warning: Function parameter or member 'cpu_mask' not described in 'drbd_calc_cpu_mask'
       drivers/block/drbd/drbd_main.c:528: warning: Excess function parameter 'device' description in 'drbd_thread_current_set_cpu'
       drivers/block/drbd/drbd_main.c:549: warning: Function parameter or member 'connection' not described in 'drbd_header_size'
       drivers/block/drbd/drbd_main.c:1204: warning: Function parameter or member 'device' not described in 'send_bitmap_rle_or_plain'
       drivers/block/drbd/drbd_main.c:1204: warning: Function parameter or member 'c' not described in 'send_bitmap_rle_or_plain'
       drivers/block/drbd/drbd_main.c:1335: warning: Function parameter or member 'peer_device' not described in '_drbd_send_ack'
       drivers/block/drbd/drbd_main.c:1335: warning: Excess function parameter 'device' description in '_drbd_send_ack'
       drivers/block/drbd/drbd_main.c:1379: warning: Function parameter or member 'peer_device' not described in 'drbd_send_ack'
       drivers/block/drbd/drbd_main.c:1379: warning: Excess function parameter 'device' description in 'drbd_send_ack'
       drivers/block/drbd/drbd_main.c:1892: warning: Function parameter or member 'connection' not described in 'drbd_send_all'
       drivers/block/drbd/drbd_main.c:1892: warning: Function parameter or member 'sock' not described in 'drbd_send_all'
       drivers/block/drbd/drbd_main.c:1892: warning: Function parameter or member 'buffer' not described in 'drbd_send_all'
       drivers/block/drbd/drbd_main.c:1892: warning: Function parameter or member 'size' not described in 'drbd_send_all'
       drivers/block/drbd/drbd_main.c:1892: warning: Function parameter or member 'msg_flags' not described in 'drbd_send_all'
       drivers/block/drbd/drbd_main.c:3525: warning: Function parameter or member 'flags' not described in 'drbd_queue_bitmap_io'
       drivers/block/drbd/drbd_main.c:3563: warning: Function parameter or member 'flags' not described in 'drbd_bitmap_io'
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-9-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      584164c8
    • Lee Jones's avatar
      block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit · 1f1e87b4
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       from drivers/block/drbd/drbd_nl.c:24:
       drivers/block/drbd/drbd_nl.c: In function ‘drbd_adm_set_role’:
       drivers/block/drbd/drbd_nl.c:793:11: warning: implicit conversion from ‘enum drbd_state_rv’ to ‘enum drbd_ret_code’ [-Wenum-conversion]
       drivers/block/drbd/drbd_nl.c:795:11: warning: implicit conversion from ‘enum drbd_state_rv’ to ‘enum drbd_ret_code’ [-Wenum-conversion]
       drivers/block/drbd/drbd_nl.c: In function ‘drbd_adm_attach’:
       drivers/block/drbd/drbd_nl.c:1965:10: warning: implicit conversion from ‘enum drbd_state_rv’ to ‘enum drbd_ret_code’ [-Wenum-conversion]
       drivers/block/drbd/drbd_nl.c: In function ‘drbd_adm_connect’:
       drivers/block/drbd/drbd_nl.c:2690:10: warning: implicit conversion from ‘enum drbd_state_rv’ to ‘enum drbd_ret_code’ [-Wenum-conversion]
       drivers/block/drbd/drbd_nl.c: In function ‘drbd_adm_disconnect’:
       drivers/block/drbd/drbd_nl.c:2803:11: warning: implicit conversion from ‘enum drbd_state_rv’ to ‘enum drbd_ret_code’ [-Wenum-conversion]
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-8-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      1f1e87b4
    • Lee Jones's avatar
      block: drbd: drbd_main: Remove duplicate field initialisation · f58a0d18
      Lee Jones authored
      [P_RETRY_WRITE] is initialised more than once.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/drbd/drbd_main.c: In function ‘cmdname’:
       drivers/block/drbd/drbd_main.c:3660:22: warning: initialized field overwritten [-Woverride-init]
       drivers/block/drbd/drbd_main.c:3660:22: note: (near initialization for ‘cmdnames[44]’)
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-7-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      f58a0d18
    • Lee Jones's avatar
      block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers · 9b48ff07
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/drbd/drbd_receiver.c:265: warning: Function parameter or member 'peer_device' not described in 'drbd_alloc_pages'
       drivers/block/drbd/drbd_receiver.c:265: warning: Excess function parameter 'device' description in 'drbd_alloc_pages'
       drivers/block/drbd/drbd_receiver.c:1362: warning: Function parameter or member 'connection' not described in 'drbd_may_finish_epoch'
       drivers/block/drbd/drbd_receiver.c:1362: warning: Excess function parameter 'device' description in 'drbd_may_finish_epoch'
       drivers/block/drbd/drbd_receiver.c:1451: warning: Function parameter or member 'resource' not described in 'drbd_bump_write_ordering'
       drivers/block/drbd/drbd_receiver.c:1451: warning: Function parameter or member 'bdev' not described in 'drbd_bump_write_ordering'
       drivers/block/drbd/drbd_receiver.c:1451: warning: Excess function parameter 'connection' description in 'drbd_bump_write_ordering'
       drivers/block/drbd/drbd_receiver.c:1643: warning: Function parameter or member 'op' not described in 'drbd_submit_peer_request'
       drivers/block/drbd/drbd_receiver.c:1643: warning: Function parameter or member 'op_flags' not described in 'drbd_submit_peer_request'
       drivers/block/drbd/drbd_receiver.c:1643: warning: Function parameter or member 'fault_type' not described in 'drbd_submit_peer_request'
       drivers/block/drbd/drbd_receiver.c:1643: warning: Excess function parameter 'rw' description in 'drbd_submit_peer_request'
       drivers/block/drbd/drbd_receiver.c:3055: warning: Function parameter or member 'peer_device' not described in 'drbd_asb_recover_0p'
       drivers/block/drbd/drbd_receiver.c:3138: warning: Function parameter or member 'peer_device' not described in 'drbd_asb_recover_1p'
       drivers/block/drbd/drbd_receiver.c:3195: warning: Function parameter or member 'peer_device' not described in 'drbd_asb_recover_2p'
       drivers/block/drbd/drbd_receiver.c:4684: warning: Function parameter or member 'peer_device' not described in 'receive_bitmap_plain'
       drivers/block/drbd/drbd_receiver.c:4684: warning: Function parameter or member 'size' not described in 'receive_bitmap_plain'
       drivers/block/drbd/drbd_receiver.c:4684: warning: Function parameter or member 'p' not described in 'receive_bitmap_plain'
       drivers/block/drbd/drbd_receiver.c:4684: warning: Function parameter or member 'c' not described in 'receive_bitmap_plain'
       drivers/block/drbd/drbd_receiver.c:4738: warning: Function parameter or member 'peer_device' not described in 'recv_bm_rle_bits'
       drivers/block/drbd/drbd_receiver.c:4738: warning: Function parameter or member 'p' not described in 'recv_bm_rle_bits'
       drivers/block/drbd/drbd_receiver.c:4738: warning: Function parameter or member 'c' not described in 'recv_bm_rle_bits'
       drivers/block/drbd/drbd_receiver.c:4738: warning: Function parameter or member 'len' not described in 'recv_bm_rle_bits'
       drivers/block/drbd/drbd_receiver.c:4807: warning: Function parameter or member 'peer_device' not described in 'decode_bitmap_c'
       drivers/block/drbd/drbd_receiver.c:4807: warning: Function parameter or member 'p' not described in 'decode_bitmap_c'
       drivers/block/drbd/drbd_receiver.c:4807: warning: Function parameter or member 'c' not described in 'decode_bitmap_c'
       drivers/block/drbd/drbd_receiver.c:4807: warning: Function parameter or member 'len' not described in 'decode_bitmap_c'
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-6-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      9b48ff07
    • Lee Jones's avatar
      block: drbd: drbd_state: Fix some function documentation issues · 49ece311
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/drbd/drbd_state.c:913: warning: Function parameter or member 'connection' not described in 'is_valid_soft_transition'
       drivers/block/drbd/drbd_state.c:913: warning: Excess function parameter 'device' description in 'is_valid_soft_transition'
       drivers/block/drbd/drbd_state.c:1054: warning: Function parameter or member 'warn' not described in 'sanitize_state'
       drivers/block/drbd/drbd_state.c:1054: warning: Excess function parameter 'warn_sync_abort' description in 'sanitize_state'
       drivers/block/drbd/drbd_state.c:1703: warning: Function parameter or member 'state_change' not described in 'after_state_ch'
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-5-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      49ece311
    • Lee Jones's avatar
      block: mtip32xx: mtip32xx: Mark debugging variable 'start' as __maybe_unused · d0e0cb97
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_standby_immediate’:
       drivers/block/mtip32xx/mtip32xx.c:1216:16: warning: variable ‘start’ set but not used [-Wunused-but-set-variable]
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-4-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      d0e0cb97
    • Lee Jones's avatar
      block: drbd: drbd_interval: Demote some kernel-doc abuses and fix another header · b8b87103
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/block/drbd/drbd_interval.c:11: warning: Function parameter or member 'node' not described in 'interval_end'
       drivers/block/drbd/drbd_interval.c:26: warning: Function parameter or member 'root' not described in 'drbd_insert_interval'
       drivers/block/drbd/drbd_interval.c:26: warning: Function parameter or member 'this' not described in 'drbd_insert_interval'
       drivers/block/drbd/drbd_interval.c:70: warning: Function parameter or member 'root' not described in 'drbd_contains_interval'
       drivers/block/drbd/drbd_interval.c:96: warning: Function parameter or member 'root' not described in 'drbd_remove_interval'
       drivers/block/drbd/drbd_interval.c:96: warning: Function parameter or member 'this' not described in 'drbd_remove_interval'
       drivers/block/drbd/drbd_interval.c:113: warning: Function parameter or member 'root' not described in 'drbd_find_overlap'
      
      Cc: Philipp Reisner <philipp.reisner@linbit.com>
      Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: drbd-dev@lists.linbit.com
      Cc: linux-block@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Link: https://lore.kernel.org/r/20210312105530.2219008-3-lee.jones@linaro.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      b8b87103
    • Jens Axboe's avatar
      Merge tag 'nvme-5.13-2021-04-06' of git://git.infradead.org/nvme into for-5.13/drivers · 762d6bd2
      Jens Axboe authored
      Pull NVMe updates from Christoph:
      
      "nvme updates for Linux 5.13
      
       - fix handling of very large MDTS values (Bart Van Assche)
       - retrigger ANA log update if group descriptor isn't found
         (Hannes Reinecke)
       - fix locking contexts in nvme-tcp and nvmet-tcp (Sagi Grimberg)
       - return proper error code from discovery ctrl (Hou Pu)
       - verify the SGLS field in nvmet-tcp and nvmet-fc (Max Gurtovoy)
       - disallow passthru cmd from targeting a nsid != nsid of the block dev
         (Niklas Cassel)
       - do not allow model_number exceed 40 bytes in nvmet (Noam Gottlieb)
       - enable optional queue idle period tracking in nvmet-tcp
         (Mark Wunderlich)
       - various cleanups and optimizations (Chaitanya Kulkarni, Kanchan Joshi)
       - expose fast_io_fail_tmo in sysfs (Daniel Wagner)
       - implement non-MDTS command limits (Keith Busch)
       - reduce warnings for unhandled command effects (Keith Busch)
       - allocate storage for the SQE as part of the nvme_request (Keith Busch)"
      
      * tag 'nvme-5.13-2021-04-06' of git://git.infradead.org/nvme: (33 commits)
        nvme: fix handling of large MDTS values
        nvme: implement non-mdts command limits
        nvme: disallow passthru cmd from targeting a nsid != nsid of the block dev
        nvme: retrigger ANA log update if group descriptor isn't found
        nvme: export fast_io_fail_tmo to sysfs
        nvme: remove superfluous else in nvme_ctrl_loss_tmo_store
        nvme: use sysfs_emit instead of sprintf
        nvme-fc: check sgl supported by target
        nvme-tcp: check sgl supported by target
        nvmet-tcp: enable optional queue idle period tracking
        nvmet-tcp: fix incorrect locking in state_change sk callback
        nvme-tcp: block BH in sk state_change sk callback
        nvmet: return proper error code from discovery ctrl
        nvme: warn of unhandled effects only once
        nvme: use driver pdu command for passthrough
        nvme-pci: allocate nvme_command within driver pdu
        nvmet: do not allow model_number exceed 40 bytes
        nvmet: remove unnecessary ctrl parameter
        nvmet-fc: update function documentation
        nvme-fc: fix the function documentation comment
        ...
      762d6bd2
    • Bart Van Assche's avatar
      nvme: fix handling of large MDTS values · 8609c63f
      Bart Van Assche authored
      Instead of triggering an integer overflow and undefined behavior if MDTS is
      large, set max_hw_sectors to UINT_MAX.
      Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
      Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
      [hch: rebased to account for the new nvme_mps_to_sectors helper]
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      8609c63f
    • Keith Busch's avatar
      nvme: implement non-mdts command limits · 5befc7c2
      Keith Busch authored
      Commands that access LBA contents without a data transfer between the
      host historically have not had a spec defined upper limit. The driver
      set the queue constraints for such commands to the max data transfer
      size just to be safe, but this artificial constraint frequently limits
      devices below their capabilities.
      
      The NVMe Workgroup ratified TP4040 defines how a controller may
      advertise their non-MDTS limits. Use these if provided and default to
      the current constraints if not. Since the Dataset Management command
      limits are defined in logical blocks, but without a namespace to tell us
      the logical block size, the code defaults to the safe 512b size.
      Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      5befc7c2
    • Niklas Cassel's avatar
      nvme: disallow passthru cmd from targeting a nsid != nsid of the block dev · c881a23f
      Niklas Cassel authored
      When a passthru command targets a specific namespace, the ns parameter to
      nvme_user_cmd()/nvme_user_cmd64() is set. However, there is currently no
      validation that the nsid specified in the passthru command targets the
      namespace/nsid represented by the block device that the ioctl was
      performed on.
      
      Add a check that validates that the nsid in the passthru command matches
      that of the supplied namespace.
      Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
      Reviewed-by: default avatarJavier González <javier@javigon.com>
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      c881a23f
    • Hannes Reinecke's avatar
      nvme: retrigger ANA log update if group descriptor isn't found · dd8f7fa9
      Hannes Reinecke authored
      If ANA is enabled but no ANA group descriptor is found when creating
      a new namespace the ANA log is most likely out of date, so trigger
      a re-read. The namespace will be tagged with the NS_ANA_PENDING flag
      to exclude it from path selection until the ANA log has been re-read.
      
      Fixes: 32acab31 ("nvme: implement multipath access to nvme subsystems")
      Reported-by: default avatarMartin George <marting@netapp.com>
      Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
      Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
      Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      dd8f7fa9
  2. 02 Apr, 2021 27 commits