- 08 Jul, 2022 40 commits
-
-
Laurent Pinchart authored
None of the shared helpers are used anymore. Make this official by dropping inclusion of imx-media.h. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by:
Rui Miguel Silva <rmfrfs@gmail.com> Tested-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@kernel.org>
-
Laurent Pinchart authored
The only event that the driver allows subscribing to, V4L2_EVENT_IMX_FRAME_INTERVAL_ERROR, is never generated. Drop events support. Signed-off-by:
-
Laurent Pinchart authored
Inline the imx7_csi_enum_pixel_formats() function in its only caller. Signed-off-by:
-
Laurent Pinchart authored
The driver won't accept unsupported pixel formats, there's thus no need to validate it in imx7_csi_pad_link_validate(). Signed-off-by:
-
Laurent Pinchart authored
The device supports 14-bit greyscale formats the same way it supports 14-bit Bayer formats. Signed-off-by:
-
Laurent Pinchart authored
The list of supported formats comes from helpers shared with the i.MX6 IPUv3 and is incorrect in multiple regards: - 10-, 12- and 14-bit Bayer formats are stored in memory as SBGGR10, SBGGR12 and SBGGR14 respectively (plus components permutations), not SBGGR16. Same thing for greyscale formats. - 16-bit RAW formats are not supported by the hardware. Fix the supported formats table. Signed-off-by:
-
Laurent Pinchart authored
When trying a format on the video node, if the requested pixel format isn't supported, fallback to the default with a simpler logic. Signed-off-by:
-
Laurent Pinchart authored
Inline the imx7_csi_init_mbus_fmt() function in its only caller. This allows simplifying the code. Signed-off-by:
-
Laurent Pinchart authored
The imx7_csi_pixfmt cycles field is never used nor set, the bayer field is never used, and the planar field is never set. Drop them. Signed-off-by:
-
Laurent Pinchart authored
All the format lookup functions are called with a ANY selector, drop selector support. Signed-off-by:
-
Laurent Pinchart authored
When trying a format on the subdev sink pad, if the requested media bus code isn't supported, fallback to the default with a simpler logic. Signed-off-by:
-
Laurent Pinchart authored
Define a macro for the default media bus code and use it through the driver to replace a hardcoded value and a dynamic query from the pixel_formats table. Signed-off-by:
-
Laurent Pinchart authored
Use the same default image width and height for both the CSI subdev and the video node to achieve a consistent default through the driver. Signed-off-by:
-
Laurent Pinchart authored
A large number of formats defined in the pixel_formats array are not supported, as shown by the switch-case check in imx7_csi_pad_link_validate(). Drop them. Signed-off-by:
-
Laurent Pinchart authored
The formats specific to the IPUv3 are not supported by the CSI bridge. Drop them, along with the related code. Signed-off-by:
-
Laurent Pinchart authored
The imx7_csi_try_colorimetry() function supports the unrelated image converter hardware as it originates from shared helpers. Drop that. Signed-off-by:
-
Laurent Pinchart authored
Replace the enum ipu_color_space cs field in struct imx7_csi_pixfmt with a bool yuv field. This decouples the driver from the unrelated IPUv3 headers. Signed-off-by:
-
Laurent Pinchart authored
To prepare for code refactoring, copy the format helpers used by this driver from imx-media-utils.c. Rename structures and functions to avoid name clashes, no functional change intended. Signed-off-by:
-
Laurent Pinchart authored
The kernel memory allocators already complain loudly to the log when allocation fails. There's no need for an additional message. Signed-off-by:
-
Laurent Pinchart authored
Decouple from the IMX7_CSI_VIDEO_DEF_PIX_WIDTH, IMX7_CSI_VIDEO_DEF_PIX_HEIGHT and IMX_MEDIA_EOF_TIMEOUT macros defined in shared helpers by duplicating them in the imx7-media-csi driver, with a rename to avoid name clashes. No functional change intended. Signed-off-by:
-
Laurent Pinchart authored
Decouple from the imx_media_dma_buf structure defined in shared helpers by duplicating it in the imx7-media-csi driver, along with the two small alloc and free functions. No functional change intended. Signed-off-by:
-
Laurent Pinchart authored
Replace the subdev pointer stored in platform drv data with the imx7_csi pointer. Drop a now redundant dev_set_drvdata() call. Signed-off-by:
-
Laurent Pinchart authored
Now that the driver doesn't use any helper that relies on the imx_media_video_dev structure anymore, merge its fields directly in the imx7_csi structure. Update all the users accordingly, and drop the list field that isn't used by the driver. Signed-off-by:
-
Laurent Pinchart authored
Decouple from the imx_media_buffer structure defined in shared helpers by duplicating it in the imx7-media-csi driver. No functional change intended. Signed-off-by:
-
Laurent Pinchart authored
Now that the driver doesn't use any helper that relies on the imx_media_dev structure anymore, merge the three fields of the imx_media_dev structure directly in the imx7_csi structure. Update all the users accordingly. Signed-off-by:
-
Laurent Pinchart authored
The imx7_csi_media_pipeline_set_stream() function has separate branches for the start and stop paths, surrounded by mutex lock/unlock. That is very little shared code, inline the locking and corresponding branch in each of the two callers. Signed-off-by:
-
Laurent Pinchart authored
Simplify the imx7_csi_media_pipeline_set_stream() function by passing it the imx7_csi pointer, which avoids going from subdev to entity and back to subdev. Signed-off-by:
-
Laurent Pinchart authored
To prepare for code refactoring, copy the imx_media_pipeline_set_stream() helper used by this driver from imx-media-utils.c. Rename the function to avoid name clashes, no functional change intended. Signed-off-by:
-
Laurent Pinchart authored
Inline the imx_media_pipeline_pad() helper, dropping all the code unused by the imx7-media-csi driver. Signed-off-by:
-
Laurent Pinchart authored
The imx_media_dev structure contains three fields that are not used by this driver or any helper code that it calls. Don't initialize them. Signed-off-by:
-
Laurent Pinchart authored
There's no need to call imx_media_add_video_device() anymore, as the video devices list it manages is only used by the control inheritance mechanism in the helpers, which this driver doesn't use. Signed-off-by:
-
Laurent Pinchart authored
There's no need anymore to allocate the imx_media_dev structure separately from imx7_csi. Embed it. Signed-off-by:
-
Laurent Pinchart authored
To prepare for code refactoring, copy the imx_media_dev_init() helper used by this driver from imx-media-dev-common.c. Rename the function to avoid name clashes, and leave the v4l2_device notify handler out as it only serves to implement control inheritance, which this driver doesn't use. No functional change intended. Signed-off-by:
-
Laurent Pinchart authored
The subdev group id isn't used by any of the remaining helpers used by this driver, don't set it. Signed-off-by:
-
Laurent Pinchart authored
Rename all the functions and macros imported from imx-media-capture.c with a consistent imx7_csi_video_ prefix. No functional change intended. Signed-off-by:
-
Laurent Pinchart authored
Merge the capture_priv fields in the imx7_csi structure as there's no more need to have two separate structures. Update all the users accordingly. Signed-off-by:
-
Laurent Pinchart authored
The struct imx7_csi fields are in a random order, reorganize them logically to prepare for adding new fields. Signed-off-by:
-
Laurent Pinchart authored
Drop the unused control handler from the driver. Signed-off-by:
-
Laurent Pinchart authored
Drop all the code related to the unused (by this driver) legacy video device support. Signed-off-by:
-
Laurent Pinchart authored
To prepare for code refactoring, copy the video device helper code used by this driver verbatim from imx-media-capture. Rename some functions to avoid name clashes, and leave the legacy ioctls out as they're not used by the imx7-media-csi driver. No functional change included. Signed-off-by:
-
