1. 14 Nov, 2022 16 commits
  2. 12 Nov, 2022 16 commits
  3. 26 Oct, 2022 1 commit
    • Nathan Chancellor's avatar
      fs/ntfs3: Don't use uni1 uninitialized in ntfs_d_compare() · 0d6d7c61
      Nathan Chancellor authored
      Clang warns:
      
        fs/ntfs3/namei.c:445:7: error: variable 'uni1' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                        if (toupper(c1) != toupper(c2)) {
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
        ./include/linux/ctype.h:64:20: note: expanded from macro 'toupper'
        #define toupper(c) __toupper(c)
                          ^
        fs/ntfs3/namei.c:487:12: note: uninitialized use occurs here
                __putname(uni1);
                          ^~~~
        ./include/linux/fs.h:2789:65: note: expanded from macro '__putname'
        #define __putname(name)         kmem_cache_free(names_cachep, (void *)(name))
                                                                              ^~~~
        fs/ntfs3/namei.c:445:3: note: remove the 'if' if its condition is always false
                        if (toupper(c1) != toupper(c2)) {
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        fs/ntfs3/namei.c:434:7: error: variable 'uni1' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                        if (!lm--) {
                            ^~~~~
        fs/ntfs3/namei.c:487:12: note: uninitialized use occurs here
                __putname(uni1);
                          ^~~~
        ./include/linux/fs.h:2789:65: note: expanded from macro '__putname'
        #define __putname(name)         kmem_cache_free(names_cachep, (void *)(name))
                                                                              ^~~~
        fs/ntfs3/namei.c:434:3: note: remove the 'if' if its condition is always false
                        if (!lm--) {
                        ^~~~~~~~~~~~
        fs/ntfs3/namei.c:430:22: note: initialize the variable 'uni1' to silence this warning
                struct cpu_str *uni1, *uni2;
                                    ^
                                    = NULL
        2 errors generated.
      
      There is no point in calling __putname() in these particular error
      paths, as there has been no corresponding __getname() call yet. Just
      return directly in these blocks to clear up the warning.
      
      Fixes: a3a956c7 ("fs/ntfs3: Add option "nocase"")
      Link: https://github.com/ClangBuiltLinux/linux/issues/1729Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      0d6d7c61
  4. 30 Sep, 2022 7 commits
    • Yuan Can's avatar
      fs/ntfs3: Use strcmp to determine attribute type · d45da67c
      Yuan Can authored
      The way of determin attribute type is just matching
      name with the predefined string, do this with strcmp
      to simplify the code.
      Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      d45da67c
    • Hawkins Jiawei's avatar
      fs/ntfs3: Fix slab-out-of-bounds read in run_unpack · 887bfc54
      Hawkins Jiawei authored
      Syzkaller reports slab-out-of-bounds bug as follows:
      ==================================================================
      BUG: KASAN: slab-out-of-bounds in run_unpack+0x8b7/0x970 fs/ntfs3/run.c:944
      Read of size 1 at addr ffff88801bbdff02 by task syz-executor131/3611
      
      [...]
      Call Trace:
       <TASK>
       __dump_stack lib/dump_stack.c:88 [inline]
       dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
       print_address_description mm/kasan/report.c:317 [inline]
       print_report.cold+0x2ba/0x719 mm/kasan/report.c:433
       kasan_report+0xb1/0x1e0 mm/kasan/report.c:495
       run_unpack+0x8b7/0x970 fs/ntfs3/run.c:944
       run_unpack_ex+0xb0/0x7c0 fs/ntfs3/run.c:1057
       ntfs_read_mft fs/ntfs3/inode.c:368 [inline]
       ntfs_iget5+0xc20/0x3280 fs/ntfs3/inode.c:501
       ntfs_loadlog_and_replay+0x124/0x5d0 fs/ntfs3/fsntfs.c:272
       ntfs_fill_super+0x1eff/0x37f0 fs/ntfs3/super.c:1018
       get_tree_bdev+0x440/0x760 fs/super.c:1323
       vfs_get_tree+0x89/0x2f0 fs/super.c:1530
       do_new_mount fs/namespace.c:3040 [inline]
       path_mount+0x1326/0x1e20 fs/namespace.c:3370
       do_mount fs/namespace.c:3383 [inline]
       __do_sys_mount fs/namespace.c:3591 [inline]
       __se_sys_mount fs/namespace.c:3568 [inline]
       __x64_sys_mount+0x27f/0x300 fs/namespace.c:3568
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd
       [...]
       </TASK>
      
      The buggy address belongs to the physical page:
      page:ffffea00006ef600 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1bbd8
      head:ffffea00006ef600 order:3 compound_mapcount:0 compound_pincount:0
      flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
      page dumped because: kasan: bad access detected
      
      Memory state around the buggy address:
       ffff88801bbdfe00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
       ffff88801bbdfe80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      >ffff88801bbdff00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
                         ^
       ffff88801bbdff80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
       ffff88801bbe0000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
      ==================================================================
      
      Kernel will tries to read record and parse MFT from disk in
      ntfs_read_mft().
      
      Yet the problem is that during enumerating attributes in record,
      kernel doesn't check whether run_off field loading from the disk
      is a valid value.
      
      To be more specific, if attr->nres.run_off is larger than attr->size,
      kernel will passes an invalid argument run_buf_size in
      run_unpack_ex(), which having an integer overflow. Then this invalid
      argument will triggers the slab-out-of-bounds Read bug as above.
      
      This patch solves it by adding the sanity check between
      the offset to packed runs and attribute size.
      
      link: https://lore.kernel.org/all/0000000000009145fc05e94bd5c3@google.com/#t
      Reported-and-tested-by: syzbot+8d6fbb27a6aded64b25b@syzkaller.appspotmail.com
      Signed-off-by: default avatarHawkins Jiawei <yin31149@gmail.com>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      887bfc54
    • Edward Lo's avatar
      fs/ntfs3: Validate resident attribute name · 54e45702
      Edward Lo authored
      Though we already have some sanity checks while enumerating attributes,
      resident attribute names aren't included. This patch checks the resident
      attribute names are in the valid ranges.
      
      [  259.209031] BUG: KASAN: slab-out-of-bounds in ni_create_attr_list+0x1e1/0x850
      [  259.210770] Write of size 426 at addr ffff88800632f2b2 by task exp/255
      [  259.211551]
      [  259.212035] CPU: 0 PID: 255 Comm: exp Not tainted 6.0.0-rc6 #37
      [  259.212955] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
      [  259.214387] Call Trace:
      [  259.214640]  <TASK>
      [  259.214895]  dump_stack_lvl+0x49/0x63
      [  259.215284]  print_report.cold+0xf5/0x689
      [  259.215565]  ? kasan_poison+0x3c/0x50
      [  259.215778]  ? kasan_unpoison+0x28/0x60
      [  259.215991]  ? ni_create_attr_list+0x1e1/0x850
      [  259.216270]  kasan_report+0xa7/0x130
      [  259.216481]  ? ni_create_attr_list+0x1e1/0x850
      [  259.216719]  kasan_check_range+0x15a/0x1d0
      [  259.216939]  memcpy+0x3c/0x70
      [  259.217136]  ni_create_attr_list+0x1e1/0x850
      [  259.217945]  ? __rcu_read_unlock+0x5b/0x280
      [  259.218384]  ? ni_remove_attr+0x2e0/0x2e0
      [  259.218712]  ? kernel_text_address+0xcf/0xe0
      [  259.219064]  ? __kernel_text_address+0x12/0x40
      [  259.219434]  ? arch_stack_walk+0x9e/0xf0
      [  259.219668]  ? __this_cpu_preempt_check+0x13/0x20
      [  259.219904]  ? sysvec_apic_timer_interrupt+0x57/0xc0
      [  259.220140]  ? asm_sysvec_apic_timer_interrupt+0x1b/0x20
      [  259.220561]  ni_ins_attr_ext+0x52c/0x5c0
      [  259.220984]  ? ni_create_attr_list+0x850/0x850
      [  259.221532]  ? run_deallocate+0x120/0x120
      [  259.221972]  ? vfs_setxattr+0x128/0x300
      [  259.222688]  ? setxattr+0x126/0x140
      [  259.222921]  ? path_setxattr+0x164/0x180
      [  259.223431]  ? __x64_sys_setxattr+0x6d/0x80
      [  259.223828]  ? entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  259.224417]  ? mi_find_attr+0x3c/0xf0
      [  259.224772]  ni_insert_attr+0x1ba/0x420
      [  259.225216]  ? ni_ins_attr_ext+0x5c0/0x5c0
      [  259.225504]  ? ntfs_read_ea+0x119/0x450
      [  259.225775]  ni_insert_resident+0xc0/0x1c0
      [  259.226316]  ? ni_insert_nonresident+0x400/0x400
      [  259.227001]  ? __kasan_kmalloc+0x88/0xb0
      [  259.227468]  ? __kmalloc+0x192/0x320
      [  259.227773]  ntfs_set_ea+0x6bf/0xb30
      [  259.228216]  ? ftrace_graph_ret_addr+0x2a/0xb0
      [  259.228494]  ? entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  259.228838]  ? ntfs_read_ea+0x450/0x450
      [  259.229098]  ? is_bpf_text_address+0x24/0x40
      [  259.229418]  ? kernel_text_address+0xcf/0xe0
      [  259.229681]  ? __kernel_text_address+0x12/0x40
      [  259.229948]  ? unwind_get_return_address+0x3a/0x60
      [  259.230271]  ? write_profile+0x270/0x270
      [  259.230537]  ? arch_stack_walk+0x9e/0xf0
      [  259.230836]  ntfs_setxattr+0x114/0x5c0
      [  259.231099]  ? ntfs_set_acl_ex+0x2e0/0x2e0
      [  259.231529]  ? evm_protected_xattr_common+0x6d/0x100
      [  259.231817]  ? posix_xattr_acl+0x13/0x80
      [  259.232073]  ? evm_protect_xattr+0x1f7/0x440
      [  259.232351]  __vfs_setxattr+0xda/0x120
      [  259.232635]  ? xattr_resolve_name+0x180/0x180
      [  259.232912]  __vfs_setxattr_noperm+0x93/0x300
      [  259.233219]  __vfs_setxattr_locked+0x141/0x160
      [  259.233492]  ? kasan_poison+0x3c/0x50
      [  259.233744]  vfs_setxattr+0x128/0x300
      [  259.234002]  ? __vfs_setxattr_locked+0x160/0x160
      [  259.234837]  do_setxattr+0xb8/0x170
      [  259.235567]  ? vmemdup_user+0x53/0x90
      [  259.236212]  setxattr+0x126/0x140
      [  259.236491]  ? do_setxattr+0x170/0x170
      [  259.236791]  ? debug_smp_processor_id+0x17/0x20
      [  259.237232]  ? kasan_quarantine_put+0x57/0x180
      [  259.237605]  ? putname+0x80/0xa0
      [  259.237870]  ? __kasan_slab_free+0x11c/0x1b0
      [  259.238234]  ? putname+0x80/0xa0
      [  259.238500]  ? preempt_count_sub+0x18/0xc0
      [  259.238775]  ? __mnt_want_write+0xaa/0x100
      [  259.238990]  ? mnt_want_write+0x8b/0x150
      [  259.239290]  path_setxattr+0x164/0x180
      [  259.239605]  ? setxattr+0x140/0x140
      [  259.239849]  ? debug_smp_processor_id+0x17/0x20
      [  259.240174]  ? fpregs_assert_state_consistent+0x67/0x80
      [  259.240411]  __x64_sys_setxattr+0x6d/0x80
      [  259.240715]  do_syscall_64+0x3b/0x90
      [  259.240934]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  259.241697] RIP: 0033:0x7fc6b26e4469
      [  259.242647] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 088
      [  259.244512] RSP: 002b:00007ffc3c7841f8 EFLAGS: 00000217 ORIG_RAX: 00000000000000bc
      [  259.245086] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fc6b26e4469
      [  259.246025] RDX: 00007ffc3c784380 RSI: 00007ffc3c7842e0 RDI: 00007ffc3c784238
      [  259.246961] RBP: 00007ffc3c788410 R08: 0000000000000001 R09: 00007ffc3c7884f8
      [  259.247775] R10: 000000000000007f R11: 0000000000000217 R12: 00000000004004e0
      [  259.248534] R13: 00007ffc3c7884f0 R14: 0000000000000000 R15: 0000000000000000
      [  259.249368]  </TASK>
      [  259.249644]
      [  259.249888] Allocated by task 255:
      [  259.250283]  kasan_save_stack+0x26/0x50
      [  259.250957]  __kasan_kmalloc+0x88/0xb0
      [  259.251826]  __kmalloc+0x192/0x320
      [  259.252745]  ni_create_attr_list+0x11e/0x850
      [  259.253298]  ni_ins_attr_ext+0x52c/0x5c0
      [  259.253685]  ni_insert_attr+0x1ba/0x420
      [  259.253974]  ni_insert_resident+0xc0/0x1c0
      [  259.254311]  ntfs_set_ea+0x6bf/0xb30
      [  259.254629]  ntfs_setxattr+0x114/0x5c0
      [  259.254859]  __vfs_setxattr+0xda/0x120
      [  259.255155]  __vfs_setxattr_noperm+0x93/0x300
      [  259.255445]  __vfs_setxattr_locked+0x141/0x160
      [  259.255862]  vfs_setxattr+0x128/0x300
      [  259.256251]  do_setxattr+0xb8/0x170
      [  259.256522]  setxattr+0x126/0x140
      [  259.256911]  path_setxattr+0x164/0x180
      [  259.257308]  __x64_sys_setxattr+0x6d/0x80
      [  259.257637]  do_syscall_64+0x3b/0x90
      [  259.257970]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  259.258550]
      [  259.258772] The buggy address belongs to the object at ffff88800632f000
      [  259.258772]  which belongs to the cache kmalloc-1k of size 1024
      [  259.260190] The buggy address is located 690 bytes inside of
      [  259.260190]  1024-byte region [ffff88800632f000, ffff88800632f400)
      [  259.261412]
      [  259.261743] The buggy address belongs to the physical page:
      [  259.262354] page:0000000081e8cac9 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x632c
      [  259.263722] head:0000000081e8cac9 order:2 compound_mapcount:0 compound_pincount:0
      [  259.264284] flags: 0xfffffc0010200(slab|head|node=0|zone=1|lastcpupid=0x1fffff)
      [  259.265312] raw: 000fffffc0010200 ffffea0000060d00 dead000000000004 ffff888001041dc0
      [  259.265772] raw: 0000000000000000 0000000080080008 00000001ffffffff 0000000000000000
      [  259.266305] page dumped because: kasan: bad access detected
      [  259.266588]
      [  259.266728] Memory state around the buggy address:
      [  259.267225]  ffff88800632f300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      [  259.267841]  ffff88800632f380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      [  259.269111] >ffff88800632f400: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      [  259.269626]                    ^
      [  259.270162]  ffff88800632f480: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      [  259.270810]  ffff88800632f500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      Signed-off-by: default avatarEdward Lo <edward.lo@ambergroup.io>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      54e45702
    • Edward Lo's avatar
      fs/ntfs3: Validate buffer length while parsing index · 4d42ecda
      Edward Lo authored
      indx_read is called when we have some NTFS directory operations that
      need more information from the index buffers. This adds a sanity check
      to make sure the returned index buffer length is legit, or we may have
      some out-of-bound memory accesses.
      
      [  560.897595] BUG: KASAN: slab-out-of-bounds in hdr_find_e.isra.0+0x10c/0x320
      [  560.898321] Read of size 2 at addr ffff888009497238 by task exp/245
      [  560.898760]
      [  560.899129] CPU: 0 PID: 245 Comm: exp Not tainted 6.0.0-rc6 #37
      [  560.899505] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
      [  560.900170] Call Trace:
      [  560.900407]  <TASK>
      [  560.900732]  dump_stack_lvl+0x49/0x63
      [  560.901108]  print_report.cold+0xf5/0x689
      [  560.901395]  ? hdr_find_e.isra.0+0x10c/0x320
      [  560.901716]  kasan_report+0xa7/0x130
      [  560.901950]  ? hdr_find_e.isra.0+0x10c/0x320
      [  560.902208]  __asan_load2+0x68/0x90
      [  560.902427]  hdr_find_e.isra.0+0x10c/0x320
      [  560.902846]  ? cmp_uints+0xe0/0xe0
      [  560.903363]  ? cmp_sdh+0x90/0x90
      [  560.903883]  ? ntfs_bread_run+0x190/0x190
      [  560.904196]  ? rwsem_down_read_slowpath+0x750/0x750
      [  560.904969]  ? ntfs_fix_post_read+0xe0/0x130
      [  560.905259]  ? __kasan_check_write+0x14/0x20
      [  560.905599]  ? up_read+0x1a/0x90
      [  560.905853]  ? indx_read+0x22c/0x380
      [  560.906096]  indx_find+0x2ef/0x470
      [  560.906352]  ? indx_find_buffer+0x2d0/0x2d0
      [  560.906692]  ? __kasan_kmalloc+0x88/0xb0
      [  560.906977]  dir_search_u+0x196/0x2f0
      [  560.907220]  ? ntfs_nls_to_utf16+0x450/0x450
      [  560.907464]  ? __kasan_check_write+0x14/0x20
      [  560.907747]  ? mutex_lock+0x8f/0xe0
      [  560.907970]  ? __mutex_lock_slowpath+0x20/0x20
      [  560.908214]  ? kmem_cache_alloc+0x143/0x4b0
      [  560.908459]  ntfs_lookup+0xe0/0x100
      [  560.908788]  __lookup_slow+0x116/0x220
      [  560.909050]  ? lookup_fast+0x1b0/0x1b0
      [  560.909309]  ? lookup_fast+0x13f/0x1b0
      [  560.909601]  walk_component+0x187/0x230
      [  560.909944]  link_path_walk.part.0+0x3f0/0x660
      [  560.910285]  ? handle_lookup_down+0x90/0x90
      [  560.910618]  ? path_init+0x642/0x6e0
      [  560.911084]  ? percpu_counter_add_batch+0x6e/0xf0
      [  560.912559]  ? __alloc_file+0x114/0x170
      [  560.913008]  path_openat+0x19c/0x1d10
      [  560.913419]  ? getname_flags+0x73/0x2b0
      [  560.913815]  ? kasan_save_stack+0x3a/0x50
      [  560.914125]  ? kasan_save_stack+0x26/0x50
      [  560.914542]  ? __kasan_slab_alloc+0x6d/0x90
      [  560.914924]  ? kmem_cache_alloc+0x143/0x4b0
      [  560.915339]  ? getname_flags+0x73/0x2b0
      [  560.915647]  ? getname+0x12/0x20
      [  560.916114]  ? __x64_sys_open+0x4c/0x60
      [  560.916460]  ? path_lookupat.isra.0+0x230/0x230
      [  560.916867]  ? __isolate_free_page+0x2e0/0x2e0
      [  560.917194]  do_filp_open+0x15c/0x1f0
      [  560.917448]  ? may_open_dev+0x60/0x60
      [  560.917696]  ? expand_files+0xa4/0x3a0
      [  560.917923]  ? __kasan_check_write+0x14/0x20
      [  560.918185]  ? _raw_spin_lock+0x88/0xdb
      [  560.918409]  ? _raw_spin_lock_irqsave+0x100/0x100
      [  560.918783]  ? _find_next_bit+0x4a/0x130
      [  560.919026]  ? _raw_spin_unlock+0x19/0x40
      [  560.919276]  ? alloc_fd+0x14b/0x2d0
      [  560.919635]  do_sys_openat2+0x32a/0x4b0
      [  560.920035]  ? file_open_root+0x230/0x230
      [  560.920336]  ? __rcu_read_unlock+0x5b/0x280
      [  560.920813]  do_sys_open+0x99/0xf0
      [  560.921208]  ? filp_open+0x60/0x60
      [  560.921482]  ? exit_to_user_mode_prepare+0x49/0x180
      [  560.921867]  __x64_sys_open+0x4c/0x60
      [  560.922128]  do_syscall_64+0x3b/0x90
      [  560.922369]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  560.923030] RIP: 0033:0x7f7dff2e4469
      [  560.923681] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 088
      [  560.924451] RSP: 002b:00007ffd41a210b8 EFLAGS: 00000206 ORIG_RAX: 0000000000000002
      [  560.925168] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f7dff2e4469
      [  560.925655] RDX: 0000000000000000 RSI: 0000000000000002 RDI: 00007ffd41a211f0
      [  560.926085] RBP: 00007ffd41a252a0 R08: 00007f7dff60fba0 R09: 00007ffd41a25388
      [  560.926405] R10: 0000000000400b80 R11: 0000000000000206 R12: 00000000004004e0
      [  560.926867] R13: 00007ffd41a25380 R14: 0000000000000000 R15: 0000000000000000
      [  560.927241]  </TASK>
      [  560.927491]
      [  560.927755] Allocated by task 245:
      [  560.928409]  kasan_save_stack+0x26/0x50
      [  560.929271]  __kasan_kmalloc+0x88/0xb0
      [  560.929778]  __kmalloc+0x192/0x320
      [  560.930023]  indx_read+0x249/0x380
      [  560.930224]  indx_find+0x2a2/0x470
      [  560.930695]  dir_search_u+0x196/0x2f0
      [  560.930892]  ntfs_lookup+0xe0/0x100
      [  560.931115]  __lookup_slow+0x116/0x220
      [  560.931323]  walk_component+0x187/0x230
      [  560.931570]  link_path_walk.part.0+0x3f0/0x660
      [  560.931791]  path_openat+0x19c/0x1d10
      [  560.932008]  do_filp_open+0x15c/0x1f0
      [  560.932226]  do_sys_openat2+0x32a/0x4b0
      [  560.932413]  do_sys_open+0x99/0xf0
      [  560.932709]  __x64_sys_open+0x4c/0x60
      [  560.933417]  do_syscall_64+0x3b/0x90
      [  560.933776]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  560.934235]
      [  560.934486] The buggy address belongs to the object at ffff888009497000
      [  560.934486]  which belongs to the cache kmalloc-512 of size 512
      [  560.935239] The buggy address is located 56 bytes to the right of
      [  560.935239]  512-byte region [ffff888009497000, ffff888009497200)
      [  560.936153]
      [  560.937326] The buggy address belongs to the physical page:
      [  560.938228] page:0000000062a3dfae refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x9496
      [  560.939616] head:0000000062a3dfae order:1 compound_mapcount:0 compound_pincount:0
      [  560.940219] flags: 0xfffffc0010200(slab|head|node=0|zone=1|lastcpupid=0x1fffff)
      [  560.942702] raw: 000fffffc0010200 ffffea0000164f80 dead000000000005 ffff888001041c80
      [  560.943932] raw: 0000000000000000 0000000080080008 00000001ffffffff 0000000000000000
      [  560.944568] page dumped because: kasan: bad access detected
      [  560.945735]
      [  560.946112] Memory state around the buggy address:
      [  560.946870]  ffff888009497100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      [  560.947242]  ffff888009497180: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      [  560.947611] >ffff888009497200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      [  560.947915]                                         ^
      [  560.948249]  ffff888009497280: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      [  560.948687]  ffff888009497300: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
      Signed-off-by: default avatarEdward Lo <edward.lo@ambergroup.io>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      4d42ecda
    • Dan Carpenter's avatar
      fs/ntfs3: Harden against integer overflows · e001e608
      Dan Carpenter authored
      Smatch complains that the "add_bytes" is not to be trusted.  Use
      size_add() to prevent an integer overflow.
      
      Fixes: be71b5cb ("fs/ntfs3: Add attrib operations")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      e001e608
    • Edward Lo's avatar
      fs/ntfs3: Validate attribute name offset · 4f1dc7d9
      Edward Lo authored
      Although the attribute name length is checked before comparing it to
      some common names (e.g., $I30), the offset isn't. This adds a sanity
      check for the attribute name offset, guarantee the validity and prevent
      possible out-of-bound memory accesses.
      
      [  191.720056] BUG: unable to handle page fault for address: ffffebde00000008
      [  191.721060] #PF: supervisor read access in kernel mode
      [  191.721586] #PF: error_code(0x0000) - not-present page
      [  191.722079] PGD 0 P4D 0
      [  191.722571] Oops: 0000 [#1] PREEMPT SMP KASAN NOPTI
      [  191.723179] CPU: 0 PID: 244 Comm: mount Not tainted 6.0.0-rc4 #28
      [  191.723749] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
      [  191.724832] RIP: 0010:kfree+0x56/0x3b0
      [  191.725870] Code: 80 48 01 d8 0f 82 65 03 00 00 48 c7 c2 00 00 00 80 48 2b 15 2c 06 dd 01 48 01 d0 48 c1 e8 0c 48 c1 e0 06 48 03 05 0a 069
      [  191.727375] RSP: 0018:ffff8880076f7878 EFLAGS: 00000286
      [  191.727897] RAX: ffffebde00000000 RBX: 0000000000000040 RCX: ffffffff8528d5b9
      [  191.728531] RDX: 0000777f80000000 RSI: ffffffff8522d49c RDI: 0000000000000040
      [  191.729183] RBP: ffff8880076f78a0 R08: 0000000000000000 R09: 0000000000000000
      [  191.729628] R10: ffff888008949fd8 R11: ffffed10011293fd R12: 0000000000000040
      [  191.730158] R13: ffff888008949f98 R14: ffff888008949ec0 R15: ffff888008949fb0
      [  191.730645] FS:  00007f3520cd7e40(0000) GS:ffff88805ba00000(0000) knlGS:0000000000000000
      [  191.731328] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  191.731667] CR2: ffffebde00000008 CR3: 0000000009704000 CR4: 00000000000006f0
      [  191.732568] Call Trace:
      [  191.733231]  <TASK>
      [  191.733860]  kvfree+0x2c/0x40
      [  191.734632]  ni_clear+0x180/0x290
      [  191.735085]  ntfs_evict_inode+0x45/0x70
      [  191.735495]  evict+0x199/0x280
      [  191.735996]  iput.part.0+0x286/0x320
      [  191.736438]  iput+0x32/0x50
      [  191.736811]  iget_failed+0x23/0x30
      [  191.737270]  ntfs_iget5+0x337/0x1890
      [  191.737629]  ? ntfs_clear_mft_tail+0x20/0x260
      [  191.738201]  ? ntfs_get_block_bmap+0x70/0x70
      [  191.738482]  ? ntfs_objid_init+0xf6/0x140
      [  191.738779]  ? ntfs_reparse_init+0x140/0x140
      [  191.739266]  ntfs_fill_super+0x121b/0x1b50
      [  191.739623]  ? put_ntfs+0x1d0/0x1d0
      [  191.739984]  ? asm_sysvec_apic_timer_interrupt+0x1b/0x20
      [  191.740466]  ? put_ntfs+0x1d0/0x1d0
      [  191.740787]  ? sb_set_blocksize+0x6a/0x80
      [  191.741272]  get_tree_bdev+0x232/0x370
      [  191.741829]  ? put_ntfs+0x1d0/0x1d0
      [  191.742669]  ntfs_fs_get_tree+0x15/0x20
      [  191.743132]  vfs_get_tree+0x4c/0x130
      [  191.743457]  path_mount+0x654/0xfe0
      [  191.743938]  ? putname+0x80/0xa0
      [  191.744271]  ? finish_automount+0x2e0/0x2e0
      [  191.744582]  ? putname+0x80/0xa0
      [  191.745053]  ? kmem_cache_free+0x1c4/0x440
      [  191.745403]  ? putname+0x80/0xa0
      [  191.745616]  do_mount+0xd6/0xf0
      [  191.745887]  ? path_mount+0xfe0/0xfe0
      [  191.746287]  ? __kasan_check_write+0x14/0x20
      [  191.746582]  __x64_sys_mount+0xca/0x110
      [  191.746850]  do_syscall_64+0x3b/0x90
      [  191.747122]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  191.747517] RIP: 0033:0x7f351fee948a
      [  191.748332] Code: 48 8b 0d 11 fa 2a 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 a5 00 00 008
      [  191.749341] RSP: 002b:00007ffd51cf3af8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5
      [  191.749960] RAX: ffffffffffffffda RBX: 000055b903733060 RCX: 00007f351fee948a
      [  191.750589] RDX: 000055b903733260 RSI: 000055b9037332e0 RDI: 000055b90373bce0
      [  191.751115] RBP: 0000000000000000 R08: 000055b903733280 R09: 0000000000000020
      [  191.751537] R10: 00000000c0ed0000 R11: 0000000000000202 R12: 000055b90373bce0
      [  191.751946] R13: 000055b903733260 R14: 0000000000000000 R15: 00000000ffffffff
      [  191.752519]  </TASK>
      [  191.752782] Modules linked in:
      [  191.753785] CR2: ffffebde00000008
      [  191.754937] ---[ end trace 0000000000000000 ]---
      [  191.755429] RIP: 0010:kfree+0x56/0x3b0
      [  191.755725] Code: 80 48 01 d8 0f 82 65 03 00 00 48 c7 c2 00 00 00 80 48 2b 15 2c 06 dd 01 48 01 d0 48 c1 e8 0c 48 c1 e0 06 48 03 05 0a 069
      [  191.756744] RSP: 0018:ffff8880076f7878 EFLAGS: 00000286
      [  191.757218] RAX: ffffebde00000000 RBX: 0000000000000040 RCX: ffffffff8528d5b9
      [  191.757580] RDX: 0000777f80000000 RSI: ffffffff8522d49c RDI: 0000000000000040
      [  191.758016] RBP: ffff8880076f78a0 R08: 0000000000000000 R09: 0000000000000000
      [  191.758570] R10: ffff888008949fd8 R11: ffffed10011293fd R12: 0000000000000040
      [  191.758957] R13: ffff888008949f98 R14: ffff888008949ec0 R15: ffff888008949fb0
      [  191.759317] FS:  00007f3520cd7e40(0000) GS:ffff88805ba00000(0000) knlGS:0000000000000000
      [  191.759711] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  191.760118] CR2: ffffebde00000008 CR3: 0000000009704000 CR4: 00000000000006f0
      Signed-off-by: default avatarEdward Lo <edward.lo@ambergroup.io>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      4f1dc7d9
    • Edward Lo's avatar
      fs/ntfs3: Add null pointer check for inode operations · c1ca8ef0
      Edward Lo authored
      This adds a sanity check for the i_op pointer of the inode which is
      returned after reading Root directory MFT record. We should check the
      i_op is valid before trying to create the root dentry, otherwise we may
      encounter a NPD while mounting a image with a funny Root directory MFT
      record.
      
      [  114.484325] BUG: kernel NULL pointer dereference, address: 0000000000000008
      [  114.484811] #PF: supervisor read access in kernel mode
      [  114.485084] #PF: error_code(0x0000) - not-present page
      [  114.485606] PGD 0 P4D 0
      [  114.485975] Oops: 0000 [#1] PREEMPT SMP KASAN NOPTI
      [  114.486570] CPU: 0 PID: 237 Comm: mount Tainted: G    B              6.0.0-rc4 #28
      [  114.486977] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
      [  114.488169] RIP: 0010:d_flags_for_inode+0xe0/0x110
      [  114.488816] Code: 24 f7 ff 49 83 3e 00 74 41 41 83 cd 02 66 44 89 6b 02 eb 92 48 8d 7b 20 e8 6d 24 f7 ff 4c 8b 73 20 49 8d 7e 08 e8 60 241
      [  114.490326] RSP: 0018:ffff8880065e7aa8 EFLAGS: 00000296
      [  114.490695] RAX: 0000000000000001 RBX: ffff888008ccd750 RCX: ffffffff84af2aea
      [  114.490986] RDX: 0000000000000001 RSI: 0000000000000008 RDI: ffffffff87abd020
      [  114.491364] RBP: ffff8880065e7ac8 R08: 0000000000000001 R09: fffffbfff0f57a05
      [  114.491675] R10: ffffffff87abd027 R11: fffffbfff0f57a04 R12: 0000000000000000
      [  114.491954] R13: 0000000000000008 R14: 0000000000000000 R15: ffff888008ccd750
      [  114.492397] FS:  00007fdc8a627e40(0000) GS:ffff888058200000(0000) knlGS:0000000000000000
      [  114.492797] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  114.493150] CR2: 0000000000000008 CR3: 00000000013ba000 CR4: 00000000000006f0
      [  114.493671] Call Trace:
      [  114.493890]  <TASK>
      [  114.494075]  __d_instantiate+0x24/0x1c0
      [  114.494505]  d_instantiate.part.0+0x35/0x50
      [  114.494754]  d_make_root+0x53/0x80
      [  114.494998]  ntfs_fill_super+0x1232/0x1b50
      [  114.495260]  ? put_ntfs+0x1d0/0x1d0
      [  114.495499]  ? vsprintf+0x20/0x20
      [  114.495723]  ? set_blocksize+0x95/0x150
      [  114.495964]  get_tree_bdev+0x232/0x370
      [  114.496272]  ? put_ntfs+0x1d0/0x1d0
      [  114.496502]  ntfs_fs_get_tree+0x15/0x20
      [  114.496859]  vfs_get_tree+0x4c/0x130
      [  114.497099]  path_mount+0x654/0xfe0
      [  114.497507]  ? putname+0x80/0xa0
      [  114.497933]  ? finish_automount+0x2e0/0x2e0
      [  114.498362]  ? putname+0x80/0xa0
      [  114.498571]  ? kmem_cache_free+0x1c4/0x440
      [  114.498819]  ? putname+0x80/0xa0
      [  114.499069]  do_mount+0xd6/0xf0
      [  114.499343]  ? path_mount+0xfe0/0xfe0
      [  114.499683]  ? __kasan_check_write+0x14/0x20
      [  114.500133]  __x64_sys_mount+0xca/0x110
      [  114.500592]  do_syscall_64+0x3b/0x90
      [  114.500930]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
      [  114.501294] RIP: 0033:0x7fdc898e948a
      [  114.501542] Code: 48 8b 0d 11 fa 2a 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 a5 00 00 008
      [  114.502716] RSP: 002b:00007ffd793e58f8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5
      [  114.503175] RAX: ffffffffffffffda RBX: 0000564b2228f060 RCX: 00007fdc898e948a
      [  114.503588] RDX: 0000564b2228f260 RSI: 0000564b2228f2e0 RDI: 0000564b22297ce0
      [  114.504925] RBP: 0000000000000000 R08: 0000564b2228f280 R09: 0000000000000020
      [  114.505484] R10: 00000000c0ed0000 R11: 0000000000000202 R12: 0000564b22297ce0
      [  114.505823] R13: 0000564b2228f260 R14: 0000000000000000 R15: 00000000ffffffff
      [  114.506562]  </TASK>
      [  114.506887] Modules linked in:
      [  114.507648] CR2: 0000000000000008
      [  114.508884] ---[ end trace 0000000000000000 ]---
      [  114.509675] RIP: 0010:d_flags_for_inode+0xe0/0x110
      [  114.510140] Code: 24 f7 ff 49 83 3e 00 74 41 41 83 cd 02 66 44 89 6b 02 eb 92 48 8d 7b 20 e8 6d 24 f7 ff 4c 8b 73 20 49 8d 7e 08 e8 60 241
      [  114.511762] RSP: 0018:ffff8880065e7aa8 EFLAGS: 00000296
      [  114.512401] RAX: 0000000000000001 RBX: ffff888008ccd750 RCX: ffffffff84af2aea
      [  114.513103] RDX: 0000000000000001 RSI: 0000000000000008 RDI: ffffffff87abd020
      [  114.513512] RBP: ffff8880065e7ac8 R08: 0000000000000001 R09: fffffbfff0f57a05
      [  114.513831] R10: ffffffff87abd027 R11: fffffbfff0f57a04 R12: 0000000000000000
      [  114.514757] R13: 0000000000000008 R14: 0000000000000000 R15: ffff888008ccd750
      [  114.515411] FS:  00007fdc8a627e40(0000) GS:ffff888058200000(0000) knlGS:0000000000000000
      [  114.515794] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  114.516208] CR2: 0000000000000008 CR3: 00000000013ba000 CR4: 00000000000006f0
      Signed-off-by: default avatarEdward Lo <edward.lo@ambergroup.io>
      Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
      c1ca8ef0