- 12 Mar, 2017 2 commits
-
-
Tobin C. Harding authored
TODO file requests fix up of error handling. Audit dgnc_mgmt.c and fix all return paths to be uniform and inline with kernel coding style. Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tobin C. Harding authored
TODO file requests fix up of error handling. Audit dgnc_driver.c and fix all return paths to be uniform and inline with kernel coding style. Signed-off-by:
-
- 10 Mar, 2017 14 commits
-
-
Michael Zoran authored
ARM64 for core vchiq which is the core of vc04_services should now be work complete. The driver compiles without any errors or warnings, and works just as well as 32 bit mode. The necessary compatibility wrappers for the 32 bit ioctls have been written and merged. Since no more ARM64 specific changes should be needed, perhaps it's best to remove it from the TODO list. Signed-off-by:
Michael Zoran <mzoran@crowfest.net> Signed-off-by:
-
Aishwarya Pant authored
This patch replaces NULL error values with error pointer values. Signed-off-by:
Aishwarya Pant <aishpant@gmail.com> Signed-off-by:
-
Aishwarya Pant authored
This patch replaces kmalloc and memset with kzalloc Signed-off-by:
-
Aishwarya Pant authored
This patch adds checks after memory allocation to avoid possible null pointer dereferences. Signed-off-by:
-
Michael Zoran authored
Since all the arm64 specific issues have been fixed now and the camera is working fine with a arm64 kernel, the depends on ARM can be removed from Kconfig. Signed-off-by:
-
Michael Zoran authored
In debug logging code, the compiler is warning about imposible situations and size of constants not matching the format specifier. This change fixes all three instances of this. Signed-off-by:
-
Michael Zoran authored
The code that queries properties on the camera has a check for buffer overruns if the firmware sends too much data. This check is incorrect, and during testing I was seeing stack corruption. I believe this error can actually happen in normal use, just for some reason it doesn't appear on 32 bit as often. So perhaps it's best for the check to be fixed. Signed-off-by:
-
Michael Zoran authored
The handle mapping code that converts context pointers to handles uses a spinlock. Since the btree implementation can sleep while allocating memory, turning on several kernel debugging options will result in errors in the log. Since this code path is never called in atomic context, perhaps it's better to just use a mutex. Signed-off-by:
-
Michael Zoran authored
The struct mmal_buffer_header has multiple fields used for informational and debugging purposes. These are safe to convert to u32. Signed-off-by:
-
Michael Zoran authored
The struct mmal_port has a few informational fields. Convert these to u32. Signed-off-by:
-
Michael Zoran authored
The client_context field is passed around which is really just a pointer to a msg_context. A lookup table mechanism for msg_context was added previously, so convert this field to a handle as well. The firmware never interperates the client_context, just passed it back. Signed-off-by:
-
Michael Zoran authored
A delayed buffer field is passed between the firmware and the kernel. This field is never used either so it's safe to change it to a u32. Signed-off-by:
-
Michael Zoran authored
In the messages passed back and forth between the camera and the firmware, a client_component field is passed. This is a pointer to a structure that represents part of the camera. Luckly, it's only used for debug logging, so simply convert it to a u32. Signed-off-by:
-
Michael Zoran authored
The struct struct mmal_es_format is passed between the firmware which has pointers. A local version of mmal_es_format is also used. Luckly, the two versions are always memberwise copied from each other so simply have different structures for the local and msg versions. Signed-off-by:
-
- 09 Mar, 2017 24 commits
-
-
Michael Sartain authored
Also convert the fw_update_type and fw_timeout variables to unsigned and update the printf specifier to %u. The FW_MGMT_IOC_SET_TIMEOUT_MS ioctl takes an unsigned int and checkpatch was complaining about not checking the sscanf return values. Signed-off-by:
Michael Sartain <mikesart@fastmail.com> Acked-by: Viresh Kumar <viresh.kumar at linaro.org> Signed-off-by:
-
Michael Sartain authored
Fixes checkpatch warning: type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order Signed-off-by:
-
Michael Sartain authored
Fixes checkpatch warning: braces {} are not necessary for any arm of this statement Signed-off-by: -
Michael Sartain authored
Fixes checkpatch warning: macros should not use a trailing semicolon Signed-off-by:
-
Narcisa Ana Maria Vasile authored
Refactor conditionals to reduce one level of indentation and improve code readability. Signed-off-by:
Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com> Signed-off-by:
-
Narcisa Ana Maria Vasile authored
Remove 'Out of memory' message because kmalloc already prints a message in case of error. Signed-off-by:
-
Arushi Singhal authored
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by:
-
Varsha Rao authored
Variable dac_data is already declared as of type u8. Again explicit type casting of dac_data to u8, is not required. Hence this patch removes it by using the following coccinelle script. @@ type T; T *ptr; T p; @@ ( - (T *)(&p) + &p | - (T *)ptr + ptr | - (T *)(ptr) + ptr | - (T)(p) + p ) Signed-off-by:
Varsha Rao <rvarsha016@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Gargi Sharma authored
Use ARRAY_SIZE to calculate the size of an array. The semantic patch used can be found here: https://github.com/coccinelle/coccinellery/blob/master/arraysize/array.cocciSigned-off-by:
Gargi Sharma <gs051095@gmail.com> Signed-off-by:
-
Aapo Vienamo authored
Fixes the following sparse warnings around line 3514 in hfa384x_usb.c: warning: incorrect type in assignment (different base types) expected unsigned int [unsigned] [usertype] version got restricted __be32 [usertype] <noident> Signed-off-by:
Aapo Vienamo <aapo.vienamo@iki.fi> Signed-off-by:
-
Stefan Wahren authored
There is no need to include types.h and vmalloc.h twice. This issue has been found by make includecheck. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
simran singhal authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
simran singhal <singhalsimran0@gmail.com> Acked-by:
-
Varsha Rao authored
Removed parentheses on the right hand side of assignment, as they are not required. The following coccinelle script was used to fix this issue: @@ local idexpression id; expression e; @@ id = -( e -) Signed-off-by:
-
simran singhal authored
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by:
-
Gargi Sharma authored
Use macro min() to get the minimum of two values for brevity and readability. The macro MUX_TX_MAX_SIZE has a value of 2048 which is well within the integer limits. This check was done manually. Found using Coccinelle: @@ type T; T x; T y; @@ ( - x < y ? x : y + min(x,y) | - x > y ? x : y + max(x,y) ) Signed-off-by:
-
Matthieu Simon authored
Fix these warnings: drivers/staging//rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted __le16 drivers/staging//rtl8192u/r8192U_dm.c:2308:44: warning: cast from restricted __le16 drivers/staging//rtl8192u/r8192U_dm.c:2309:44: warning: cast from restricted __le16 Signed-off-by:
Matthieu Simon <gmatthsim@gmail.com> Signed-off-by:
-
Sebastian Haas authored
Rename macro definition and usage to represent correct spelling of DEFAULT: ODM_REG_RX_DEFUALT_A_11N => ODM_REG_RX_DEFAULT_A_11N ODM_REG_RX_DEFUALT_B_11N => ODM_REG_RX_DEFAULT_B_11N Signed-off-by:
Sebastian Haas <sehaas@deebas.com> Signed-off-by:
-
Sebastian Haas authored
Fix typos reported by checkpatch.pl Signed-off-by:
-
simran singhal authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Elia Geretto authored
This patch fixes two coding style errors, reported by the checkpatch script. Signed-off-by:
Elia Geretto <elia.f.geretto@gmail.com> Signed-off-by:
-
Georgiana Rodica Chelu authored
Indent the code in order to follow the rules and to increase the readability of the code. Signed-off-by:
Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by:
-
Gargi Sharma authored
Some type conversions like casting a pointer/non-pointer to a pointer of same type, casting to the original type using addressof(&) operator, etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by:
-
Tamara Diaconita authored
Removed redundant code marked with #if 0 to fix the following checkpath.pl issue: CHECK: if this code is redundant consider removing it. Signed-off-by:
Tamara Diaconita <diaconita.tamara@gmail.com> Reviewed-by:
Daniel Baluta <daniel.baluta@gmail.com> Signed-off-by:
-
Tamara Diaconita authored
Changed the structure tag 'struct cxd' with the variable '*ci' to fix the following checkpath.pl issue: CHECK: Prefer kzalloc(sizeof(*ci)...) over kzalloc(sizeof(struct cxd)). Signed-off-by:
-
