- 16 Nov, 2016 5 commits
-
-
Markus Elfring authored
A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@s-opensource.com>
-
Markus Elfring authored
Use space characters at some source code places according to the Linux coding style convention. Signed-off-by:
-
Markus Elfring authored
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:
-
Markus Elfring authored
Adjust a jump label according to the Linux coding style convention. Signed-off-by:
-
Markus Elfring authored
A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by:
-
- 24 Oct, 2016 35 commits
-
-
Mauro Carvalho Chehab authored
commit 079933db ("[media] v4l: flash led class: Fix of_node release in probe() error path") removed the need of an ancillary var at the release function, as reported by smatch: drivers/media/v4l2-core/v4l2-flash-led-class.c: In function 'v4l2_flash_release': drivers/media/v4l2-core/v4l2-flash-led-class.c:678:23: warning: variable 'led_cdev' set but not used [-Wunused-but-set-variable] struct led_classdev *led_cdev; ^~~~~~~~ Get rid of it. Fixes: commit 079933db ("[media] v4l: flash led class: Fix of_node release in probe() error path") Signed-off-by:
-
Sakari Ailus authored
The sub-device's OF node was used (of_node_get()) if it was set, but device's OF node was always put. Fix this. Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
-
Fabio Estevam authored
In the case of coda_firmware_request() failure, we should release the prevously acquired resources. Signed-off-by:
Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by:
-
Enrico Mioso authored
This patch derives from previous one(s) by CrazyCat. I used the commit adding rev.3 to mainline Linux kernel as an example, so credits go to its author(s). The hardware seems to scan and tune OK. Signed-off-by:
Enrico Mioso <mrkiko.rs@gmail.com> Signed-off-by:
-
Wayne Porter authored
FSF address changes, checkpatch recommends removing it Signed-off-by:
Wayne Porter <wporter82@gmail.com> Signed-off-by:
-
Heiner Kallweit authored
Simplify the remove function and the error path in the probe function by using the managed versions of rc_allocate_device and rc_register_device. Signed-off-by:
Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by:
-
Heiner Kallweit authored
Introduce managed versions of both functions. They allows to simplify the error path in the probe function of rc drivers, and usually also to simplify the remove function. New element managed_alloc in struct rc_dev is needed to correctly handle mixed use, e.g. managed version of rc_register_device and normal version of rc_allocate_device. In addition devm_rc_allocate_device sets rc->dev.parent as having a reference to the parent device might be useful for future extensions. Signed-off-by:
-
Wei Yongjun authored
Remove including <linux/version.h> that don't need it. Signed-off-by:
Wei Yongjun <weiyongjun1@huawei.com> Acked-by:
Benjamin Gaignard <benjamin.gaignard@linaro.org> Signed-off-by:
-
Songjun Wu authored
If a new vb buf is added to vb queue, the queue is empty and steaming, dma should be started. Signed-off-by:
Songjun Wu <songjun.wu@microchip.com> Signed-off-by:
-
Heiner Kallweit authored
Changing available_protocols to atomic64_t allows to get rid of the mutex protecting access to the variable. This helps to simplify the code. Signed-off-by:
-
Christophe JAILLET authored
If 'dma_alloc_coherent()' returns NULL, 'vpu_alloc_ext_mem()' will return 0 which means success. Return -ENOMEM instead. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
-
Robert Jarzmik authored
During sensors binding, there is a window where the sensor is switched off, while there is a call it to set a new format, which can end up in an access to the sensor, especially an I2C based sensor. Remove this window by activating the sensor. Signed-off-by:
Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by:
-
Andrey Utkin authored
Previously, width of 720 was used, but it gives 16-pixel wide black bar at right side of encoded picture. Signed-off-by:
Andrey Utkin <andrey.utkin@corp.bluecherry.net> Signed-off-by:
-
Wei Yongjun authored
Fix to return error code -ENODEV from the error handling case instead of 0(err maybe overwrited to 0 in the for loop), as done elsewhere in this function. [mchehab@s-opensource.com: remove a now uneeded set for err = -ENODEV] Signed-off-by:
-
Wei Yongjun authored
Fix to return error code -EINVAL from the platform_get_resource() error handling case instead of 0, as done elsewhere in this function. Signed-off-by:
Fabien Dessenne <fabien.dessenne@st.com> Signed-off-by:
-
Wei Yongjun authored
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: 7aae6e2d ("[media] Add GS1662 driver, a video serializer") Signed-off-by:
-
Wei Yongjun authored
Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by:
-
Arnd Bergmann authored
Moving the pxa_camera driver from soc_camera lots the implied VIDEO_V4L2 Kconfig dependency, and building the driver without V4L2 results in a kernel that cannot link: drivers/media/platform/pxa_camera.o: In function `pxa_camera_remove': pxa_camera.c:(.text.pxa_camera_remove+0x10): undefined reference to `v4l2_clk_unregister' pxa_camera.c:(.text.pxa_camera_remove+0x18): undefined reference to `v4l2_device_unregister' drivers/media/platform/pxa_camera.o: In function `pxa_camera_probe': pxa_camera.c:(.text.pxa_camera_probe+0x458): undefined reference to `v4l2_of_parse_endpoint' drivers/media/v4l2-core/videobuf2-core.o: In function `__enqueue_in_driver': drivers/media/v4l2-core/videobuf2-core.o: In function `vb2_core_streamon': videobuf2-core.c:(.text.vb2_core_streamon+0x1b4): undefined reference to `v4l_vb2q_enable_media_source' drivers/media/v4l2-core/videobuf2-v4l2.o: In function `vb2_ioctl_reqbufs': videobuf2-v4l2.c:(.text.vb2_ioctl_reqbufs+0xc): undefined reference to `video_devdata' This adds back an explicit dependency. Fixes: 3050b998 ("[media] media: platform: pxa_camera: move pxa_camera out of soc_camera") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Acked-by:
-
Daniel Wagner authored
There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). While we are at it, we do a small optimization with the reinitialization of the completion before we use it. The usage pattern of the completion is: waiter context waker context send_packet() reinit_completion() usb_sumbit_urb() wait_for_completion_interruptible() usb_tx_callback() complete() imon_disconnect() complete() Signed-off-by:Daniel Wagner <daniel.wagner@bmw-carit.de> Signed-off-by:
-
Daniel Wagner authored
There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). While we are at it, we do a small optimization with the reinitialization of the completion before we use it. The usage pattern of the completion is: waiter context waker context send_packet() init_completion() usb_submit_urb() wait_for_completion_interruptible() usb_tx_callback() complete() imon_disonnect() complete() Signed-off-by: -
Sakari Ailus authored
Use a type with explicit endianness in machine to big endian conversion. Signed-off-by:
-
Ulrich Hecht authored
Documentation states that the "default-input" property should reside directly in the node of the device. This adjusts the parsing to make the implementation consistent with the documentation. Based on patch by William Towle <william.towle@codethink.co.uk>. Signed-off-by:
Ulrich Hecht <ulrich.hecht+renesas@gmail.com> Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Ulrich Hecht authored
The text states that default-input is an endpoint property, but in the example it is a device property. The default input is a property of the chip, not of a particular port, so the example makes more sense. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Benoit Parrot authored
The advertised V4L2 pixel format and Media Bus code don't match. The current media bud code advertised is MEDIA_BUS_FMT_YUYV8_2X8 which does not reflect what the encoder actually outputs. This encoder generate MEDIA_BUS_FMT_UYVY8_2X8 so advertise as such. Signed-off-by:
Benoit Parrot <bparrot@ti.com> Signed-off-by:
-
Nicolas Iooss authored
Function ite_set_carrier_params() uses variable use_demodulator after having initialized it to false in some if branches, but this variable is never set to true otherwise. This bug has been found using clang -Wsometimes-uninitialized warning flag. Fixes: 620a32bb ("[media] rc: New rc-based ite-cir driver for several ITE CIRs") Signed-off-by:
Nicolas Iooss <nicolas.iooss_linux@m4x.org> Signed-off-by:
-
Nicolas Iooss authored
In mb86a20s_read_status_and_stats(), when mb86a20s_read_status() fails, the function returns the value in variable rc without initializing it first. Fix this by propagating the error code from variable status_nr. This bug has been found using clang and -Wsometimes-uninitialized warning flag. Signed-off-by:
-
Olli Salonen authored
TechnoTrend TT-connect S2-4650 CI seems to be a variation of the DVBSky S960CI device. Signed-off-by:
Olli Salonen <olli.salonen@iki.fi> Signed-off-by:
-
Colin Ian King authored
The variable name is always assigned to a literal string in the proceeding switch statement, so it is never null and hence the null check is redundant. Remove null the check. Signed-off-by:Colin Ian King <colin.king@canonical.com>
-
Baoyou Xie authored
We get 1 warning when building kernel with W=1: drivers/media/platform/coda/coda-h264.c:22:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes] In fact, this function is declared in coda.h, so this patch add missing header dependencies. Signed-off-by:
Baoyou Xie <baoyou.xie@linaro.org> Acked-by:
Philipp Zabel <p.zabel@pengutronix.de>
-
Colin Ian King authored
cx24120_set_frontend currently allows invalid delivery system types other than SYS_DVBS2 and SYS_DVBS. Fix this by returning -EINVAL for invalid values. Signed-off-by:
Jemma Denson <jdenson@gmail.com>
-
CIJOML CIJOMLovic authored
Add a new USB ID for EVOLVEO XtraTV stick. [mchehab@s-opensource.org: fix patch and make checkpatch happy] Cc: Antti Palosaari <crope@iki.fi> Signed-off-by: -
Henrik Ingo authored
Some devices have invalid baSourceID references, causing uvc_scan_chain() to fail, but if we just take the entities we can find and put them together in the most sensible chain we can think of, turns out they do work anyway. Note: This heuristic assumes there is a single chain. At the time of writing, devices known to have such a broken chain are - Acer Integrated Camera (5986:055a) - Realtek rtl157a7 (0bda:57a7) Signed-off-by:
Henrik Ingo <henrik.ingo@avoinelama.fi> Signed-off-by:
-
Mauro Carvalho Chehab authored
Instead of using codeblock for the cardlists, use tables, in order to improve their visual when presenting them. Signed-off-by: -
Mauro Carvalho Chehab authored
For those cameras that were missing descriptions, update using some web research: https://cateee.net/lkddb/web-lkddb/USB_GSPCA_STV0680.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_ZC3XX.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_KINECT.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_SPCA561.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_VICAM.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_DTCS033.html https://bugs.launchpad.net/ubuntu/+source/linux/+bug/564979 https://cateee.net/lkddb/web-lkddb/USB_GSPCA_PAC7302.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_SONIXB.html https://cateee.net/lkddb/web-lkddb/USB_GSPCA_SONIXJ.htmlSigned-off-by:
-
Mauro Carvalho Chehab authored
There are several missing USB IDs that are defined on gspca drivers. Add them. The missing entries were found/created using the following script: <script> use strict; use File::Find; my $src = "drivers/media/usb/gspca/"; my $table = 0; my %data; my $id; my $len = 0; open IN, "Documentation/media/v4l-drivers/gspca-cardlist.rst"; while (<IN>) { if (m/^=+\s+=+\s+=+$/) { $table++; next; } next if ($table != 2); if (m/^(\S+)\s+(\S+)\s+(.*)/) { $id = "$1_$2"; $data{$id}->{driver} = $1; $data{$id}->{usb_id} = $2; $data{$id}->{name} = $3; $data{$id}->{valid} = 0; $len = length($3) if (length($3) > $len); } } close IN; sub parse_dir { my $file = $File::Find::name; open IN, $file; my $driver = $file; $driver =~ s,($src),,; $driver =~ s,/.*,,; $driver =~ s,\.c$,,; while (<IN>) { next if (m,/\*.*USB_DEVICE,); if (m/USB_DEVICE[^\(]*\(\s*0x(\S+)\s*\,\s*0x(\S+)\)(.*)/) { my $n = "$1:$2"; my $o = $3; $id = "${driver}_$n"; $data{$id}->{valid} = 1; next if (defined $data{$id}->{driver}); $data{$id}->{driver} = $driver; $data{$id}->{usb_id} = $n; if ($o =~ m,\/\*\s*(.*)\*\/,) { $n = $1; $n =~ s/\s+//; $data{$id}->{name} = $n; } else { $data{$id}->{name} = ""; } } } close IN; } find({wanted => \&parse_dir, no_chdir => 1}, $src); print "The gspca cards list\n"; print "====================\n\n"; print "The modules for the gspca webcam drivers are:\n\n"; print "- gspca_main: main driver\n"; print "- gspca\\_\\ *driver*: subdriver module with *driver* as follows\n\n"; print "========= ========= " . "=" x $len . "\n"; print "*driver* vend:prod Device\n"; print "========= ========= " . "=" x $len . "\n"; foreach my $id (sort { $data{$a}->{usb_id} . $data{$a}->{driver} cmp $data{$b}->{usb_id} . $data{$b}->{driver} } keys %data) { next if (!$data{$id}->{valid}); my $s = sprintf "%-15s %s\t%s\n", $data{$id}->{driver}, $data{$id}->{usb_id}, $data{$id}->{name}; # Replace tabs by spaces $s =~ s/[ \t]+$//; $s =~ s<^ {8}> <\t>; $s =~ s<^ {1,7}\t> <\t>; $s =~ s< {1,7}\t> <\t>; printf $s; } print "========= ========= " . "=" x $len . "\n"; </script> Signed-off-by:
-
