1. 27 Oct, 2017 11 commits
    • Joe Perches's avatar
      bcma: Use bcma_debug and not pr_cont in MIPS driver · 758f7e06
      Joe Perches authored
      Commit 66cc0442 ("bcma: use bcma_debug and pr_cont in MIPS driver")
      converted a printk(KERN_DEBUG to bcma_debug.
      
      bcma_debug is guarded by a #define DEBUG via pr_debug.
      
      This means that the bcma_debug will generally not be emitted
      but any pr_cont following the bcma_debug will be emitted.
      
      Correct this by removing the uses of pr_cont by using a temporary.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      758f7e06
    • Arnd Bergmann's avatar
      brcmsmac: reindent split functions · ad1987d6
      Arnd Bergmann authored
      In the previous commit I left the indentation alone to help reviewing
      the patch, this one now runs the three new functions through 'indent -kr -8'
      with some manual fixups to avoid silliness.
      
      No changes other than whitespace are intended here.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      ad1987d6
    • Arnd Bergmann's avatar
      brcmsmac: split up wlc_phy_workarounds_nphy · 0425f079
      Arnd Bergmann authored
      The stack consumption in this driver is still relatively high, with one
      remaining warning if the warning level is lowered to 1536 bytes:
      
      drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: the frame size of 1880 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
      
      The affected function is actually a collection of three separate implementations,
      and each of them is fairly large by itself. Splitting them up is done easily
      and improves readability at the same time.
      
      I'm leaving the original indentation to make the review easier.
      Acked-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      0425f079
    • Kees Cook's avatar
      libertas: Convert timers to use timer_setup() · 78ce6a90
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Johannes Berg <johannes.berg@intel.com>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Andrew Zaborowski <andrew.zaborowski@intel.com>
      Cc: libertas-dev@lists.infradead.org
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      78ce6a90
    • Kees Cook's avatar
      mwifiex: Convert timers to use timer_setup() · 08c2eb8e
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Amitkumar Karwar <amitkarwar@gmail.com>
      Cc: Nishant Sarmukadam <nishants@marvell.com>
      Cc: Ganapathi Bhat <gbhat@marvell.com>
      Cc: Xinming Hu <huxm@marvell.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Johannes Berg <johannes.berg@intel.com>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Andrew Zaborowski <andrew.zaborowski@intel.com>
      Cc: libertas-dev@lists.infradead.org
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      08c2eb8e
    • Kees Cook's avatar
      drivers/wireless: rsi: Convert timers to use timer_setup() · dfefb9f8
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>
      Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
      Cc: Pavani Muthyala <pavani.muthyala@redpinesignals.com>
      Cc: Karun Eagalapati <karun256@gmail.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      dfefb9f8
    • Kees Cook's avatar
      cw1200: Convert timers to use timer_setup() · e3dcf8bb
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Solomon Peachy <pizza@shaftnet.org>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      e3dcf8bb
    • Kees Cook's avatar
      atmel: Convert timers to use timer_setup() · 3e79202b
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Simon Kelley <simon@thekelleys.org.uk>
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      3e79202b
    • Kees Cook's avatar
      iwlegacy: Convert timers to use timer_setup() · 2b77839b
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Stanislaw Gruszka <sgruszka@redhat.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      2b77839b
    • Kees Cook's avatar
      qtnfmac: Convert timers to use timer_setup() · 7e916caf
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Igor Mitsyanko <imitsyanko@quantenna.com>
      Cc: Avinash Patil <avinashp@quantenna.com>
      Cc: Sergey Matyukevich <smatyukevich@quantenna.com>
      Cc: Kamlesh Rath <krath@quantenna.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      7e916caf
    • Kees Cook's avatar
      rtlwifi: Convert timers to use timer_setup() · 7c51d17c
      Kees Cook authored
      In preparation for unconditionally passing the struct timer_list pointer to
      all timer callbacks, switch to using the new timer_setup() and from_timer()
      to pass the timer pointer explicitly.
      
      Cc: Kalle Valo <kvalo@codeaurora.org>
      Cc: Larry Finger <Larry.Finger@lwfinger.net>
      Cc: Chaoming Li <chaoming_li@realsil.com.cn>
      Cc: Ping-Ke Shih <pkshih@realtek.com>
      Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: Souptick Joarder <jrdr.linux@gmail.com>
      Cc: linux-wireless@vger.kernel.org
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
      7c51d17c
  2. 20 Oct, 2017 29 commits