1. 21 Apr, 2023 1 commit
    • Alexander Aring's avatar
      fs: dlm: stop unnecessarily filling zero ms_extra bytes · 7a40f1f1
      Alexander Aring authored
      Commit 7175e131 ("fs: dlm: fix invalid derefence of sb_lvbptr")
      fixes an issue when the lkb->lkb_lvbptr set to an dangled pointer and an
      followed memcpy() would fail. It was fixed by an additional check of
      DLM_LKF_VALBLK flag. The mentioned commit forgot to add an additional check
      if DLM_LKF_VALBLK is set for the additional amount of LVB data allocated
      in a dlm message. This patch is changing the message allocation to check
      additionally if DLM_LKF_VALBLK is set otherwise a dangled lkb->lkb_lvbptr
      pointer would allocated zero LVB message data which not gets filled with
      actual data.
      
      This patch is however only a cleanup to reduce the amount of zero bytes
      transmitted over network as receive_lvb() will only evaluates message LVB
      data if DLM_LKF_VALBLK is set.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      7a40f1f1
  2. 06 Mar, 2023 11 commits
    • Alexander Aring's avatar
      fs: dlm: switch lkb_sbflags to atomic ops · 1361737f
      Alexander Aring authored
      This patch moves lkb_sbflags handling to atomic bits ops. This should
      prepare for a possible manipulating of lkb_sbflags flags at the same
      time by concurrent execution.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      1361737f
    • Alexander Aring's avatar
      fs: dlm: rsb hash table flag value to atomic ops · 46d6e722
      Alexander Aring authored
      This patch moves the rsb hash table handling to atomic flag operations.
      The flag operations for DLM_RTF_SHRINK are protected by
      ls->ls_rsbtbl[b].lock. However we switch to atomic ops if new possible
      flags will be used in a different way and don't assume such lock
      dependencies.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      46d6e722
    • Alexander Aring's avatar
      fs: dlm: move internal flags to atomic ops · e1af8728
      Alexander Aring authored
      This patch will move the lkb_flags value to the recently introduced
      lkb_iflags value. For lkb_iflags we use atomic bit operations because
      some flags like DLM_IFL_CB_PENDING are used while non rsb lock is held
      to avoid issues with other flag manipulations which might run at the
      same time we switch to atomic bit operations. Snapshot the bit values to
      an uint32_t value is only used for debugging/logging use cases and don't
      need to be 100% correct.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      e1af8728
    • Alexander Aring's avatar
      fs: dlm: change dflags to use atomic bits · 8a39dcd9
      Alexander Aring authored
      Currently manipulating lkb_dflags assumes to held the rsb lock assigned
      to the lkb. This is held by dlm message processing after certain
      time to lookup the right rsb from the received lkb message id. For user
      space locks flags, which is currently the only use case for lkb_dflags,
      flags are also being set during dlm character device handling without
      holding the rsb lock. To minimize the risk that bit operations are
      getting corrupted we switch to atomic bit operations. This patch will
      also introduce helpers to snapshot atomic bit values in an non atomic
      way. There might be still issues with the flag handling e.g. running in
      case of manipulating bit ops and snapshot them at the same time, but this
      patch minimize them and will start to use atomic bit operations.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      8a39dcd9
    • Alexander Aring's avatar
      fs: dlm: store lkb distributed flags into own value · 8c11ba64
      Alexander Aring authored
      This patch stores lkb distributed flags value in an separate value
      instead of sharing internal and distributed flags in lkb->lkb_flags value.
      This has the advantage to not mask/write back flag values in
      receive_flags() functionality. The dlm debug_fs does not provide the
      distributed flags anymore, those can be added in future.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      8c11ba64
    • Alexander Aring's avatar
      fs: dlm: remove DLM_IFL_LOCAL_MS flag · 9f48eead
      Alexander Aring authored
      The DLM_IFL_LOCAL_MS flag is an internal non shared flag but used in
      m_flags of dlm messages. It is not shared because it is only used for
      local messaging. Instead using DLM_IFL_LOCAL_MS in dlm messages we pass a
      parameter around to signal local messaging or not. This patch is adding
      the local parameter to signal local messaging.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      9f48eead
    • Alexander Aring's avatar
      fs: dlm: rename stub to local message flag · a7e7ffac
      Alexander Aring authored
      This patch renames DLM_IFL_STUB_MS to DLM_IFL_LOCAL_MS flag. The
      DLM_IFL_STUB_MS flag is somewhat misnamed, it means the dlm message is
      used for local message transfer only. It is used by recovery to resolve
      lock states if a node got fenced.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      a7e7ffac
    • Alexander Aring's avatar
      fs: dlm: remove deprecated code parts · 01c7a597
      Alexander Aring authored
      This patch removes code parts which was declared deprecated by
      commit 6b0afc0c ("fs: dlm: don't use deprecated timeout features by
      default"). This contains the following dlm functionality:
      
      - start a cancel of a dlm request did not complete after certain timeout:
        The current way how dlm cancellation works and interfering with other
        dlm requests triggered by the user can end in an overlapping and
        returning in -EBUSY. The most user don't handle this case and are
        unaware that DLM can return such errno in such situation. Due the
        timeout the user are mostly unaware when this happens.
      - start a netlink warning messages for user space if dlm requests did
        not complete after certain timeout:
        This feature was never being built in the only known dlm user space side.
        As we are to remove the timeout cancellation feature we can directly
        remove this feature as well.
      
      There might be the possibility to bring the timeout cancellation feature
      back. However the current way of handling the -EBUSY case which is only
      a software limitation and not a hardware limitation should be changed.
      We minimize the current code base in DLM cancellation feature to not have
      to deal with those existing features while solving the DLM cancellation
      feature in general.
      
      UAPI define DLM_LSFL_TIMEWARN is commented as deprecated and reserved
      value. We should avoid at first to give it a new meaning but let
      possible users still compile by keeping this define. In far future we
      can give this flag a new meaning. The same for the DLM_LKF_TIMEOUT lock
      request flag.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      01c7a597
    • Edwin Török's avatar
      DLM: increase socket backlog to avoid hangs with 16 nodes · 7386457a
      Edwin Török authored
      On a 16 node virtual cluster with e1000 NICs joining the 12th node prints
      SYN flood warnings for the DLM port:
      Dec 21 01:46:41 localhost kernel: [ 2146.516664] TCP: request_sock_TCP: Possible SYN flooding on port 21064. Sending cookies.  Check SNMP counters.
      
      And then joining a DLM lockspace hangs:
      ```
      Dec 21 01:49:00 localhost kernel: [ 2285.780913] INFO: task xapi-clusterd:17638 blocked for more than 120 seconds.
      Dec 21 01:49:00 localhost kernel: [ 2285.786476]       Not tainted 4.4.0+10 #1
      Dec 21 01:49:00 localhost kernel: [ 2285.789043] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
      Dec 21 01:49:00 localhost kernel: [ 2285.794611] xapi-clusterd   D ffff88001930bc58     0 17638      1 0x00000000
      Dec 21 01:49:00 localhost kernel: [ 2285.794615]  ffff88001930bc58 ffff880025593800 ffff880022433800 ffff88001930c000
      Dec 21 01:49:00 localhost kernel: [ 2285.794617]  ffff88000ef4a660 ffff88000ef4a658 ffff880022433800 ffff88000ef4a000
      Dec 21 01:49:00 localhost kernel: [ 2285.794619]  ffff88001930bc70 ffffffff8159f6b4 7fffffffffffffff ffff88001930bd10
      Dec 21 01:49:00 localhost kernel: [ 2285.794644]  [<ffffffff811570fe>] ? printk+0x4d/0x4f
      Dec 21 01:49:00 localhost kernel: [ 2285.794647]  [<ffffffff810b1741>] ? __raw_callee_save___pv_queued_spin_unlock+0x11/0x20
      Dec 21 01:49:00 localhost kernel: [ 2285.794649]  [<ffffffff815a085d>] wait_for_completion+0x9d/0x110
      Dec 21 01:49:00 localhost kernel: [ 2285.794653]  [<ffffffff810979e0>] ? wake_up_q+0x80/0x80
      Dec 21 01:49:00 localhost kernel: [ 2285.794661]  [<ffffffffa03fa4b8>] dlm_new_lockspace+0x908/0xac0 [dlm]
      Dec 21 01:49:00 localhost kernel: [ 2285.794665]  [<ffffffff810aaa60>] ? prepare_to_wait_event+0x100/0x100
      Dec 21 01:49:00 localhost kernel: [ 2285.794670]  [<ffffffffa0402e37>] device_write+0x497/0x6b0 [dlm]
      Dec 21 01:49:00 localhost kernel: [ 2285.794673]  [<ffffffff811834f0>] ? handle_mm_fault+0x7f0/0x13b0
      Dec 21 01:49:00 localhost kernel: [ 2285.794677]  [<ffffffff811b4438>] __vfs_write+0x28/0xd0
      Dec 21 01:49:00 localhost kernel: [ 2285.794679]  [<ffffffff811b4b7f>] ? rw_verify_area+0x6f/0xd0
      Dec 21 01:49:00 localhost kernel: [ 2285.794681]  [<ffffffff811b4dc1>] vfs_write+0xb1/0x190
      Dec 21 01:49:00 localhost kernel: [ 2285.794686]  [<ffffffff8105ffc2>] ? __do_page_fault+0x302/0x420
      Dec 21 01:49:00 localhost kernel: [ 2285.794688]  [<ffffffff811b5986>] SyS_write+0x46/0xa0
      Dec 21 01:49:00 localhost kernel: [ 2285.794690]  [<ffffffff815a31ae>] entry_SYSCALL_64_fastpath+0x12/0x71
      ```
      
      The previous limit of 5 seems like an arbitrary number, that doesn't match any
      known DLM cluster size upper bound limit.
      Signed-off-by: default avatarEdwin Török <edvin.torok@citrix.com>
      Cc: Christine Caulfield <ccaulfie@redhat.com>
      Cc: David Teigland <teigland@redhat.com>
      Cc: cluster-devel@redhat.com
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      7386457a
    • Alexander Aring's avatar
      fs: dlm: add unbound flag to dlm_io workqueue · 00f30c05
      Alexander Aring authored
      This patch will add the WQ_UNBOUND flag to the lowcomms dlm_io workqueue
      which handles socket io handling to send and receive dlm messages.
      The amount of sockets will be 2 for a 3 node cluster. Each socket has
      two different workers for doing send and receive work by calling socket
      API functionality. Each worker will do their task in order to send dlm
      messages in a ordered stream based socket communication. On receive
      side the receive buffer will be queued up for an ordered dlm_process
      workqueue to parse received dlm messages. The parsing need to be done
      currently in an ordered synchronized way because the dlm message processing
      is not being made to parse parallel.
      
      After explaining all those workqueue behaviours in lowcomms, the dlm_io
      workqueue is only being used for socket handling. Each socket handling
      has 2 workers (send and receive). In a 3 cluster node we will end up
      with 4 workers. Without the WQ_UNBOUND flag the workers are tight to a
      CPU and can never switch, this could be an advantage because local CPU
      execution. However with dlm_locktorture testcase I expierenced not all
      workers are always in use and my assumption is that some workers are
      bound to the same CPU. We should always send or receive when we are
      ready to do so, one reason why we disable nigel algorithm on sockets.
      We should be safe to do the socket io handling on any CPU which can be
      switched during runtime. There is no assumption that the worker stays on
      the same CPU. There is no need to respect any workqueue concurrency
      model that each worker can only run on one CPU. Lowcomms queue_work()
      mechanism has an higher level flag to be sure that it can't schedule
      work if the previous worker did not signal it to keep ordered socket
      handling. Therefore this patch sets the WQ_UNBOUND flag to allow workers
      being executed by any available CPU.
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      00f30c05
    • Alexander Aring's avatar
      fs: dlm: fix DLM_IFL_CB_PENDING gets overwritten · a034c137
      Alexander Aring authored
      This patch introduce a new internal flag per lkb value to handle
      internal flags which are handled not on wire. The current lkb internal
      flags stored as lkb->lkb_flags are split in upper and lower bits, the
      lower bits are used to share internal flags over wire for other cluster
      wide lkb copies on other nodes.
      
      In commit 61bed0ba ("fs: dlm: use a non-static queue for callbacks")
      we introduced a new internal flag for pending callbacks for the dlm
      callback queue. This flag is protected by the lkb->lkb_cb_lock lock.
      This patch overlooked that on dlm receive path and the mentioned upper
      and lower bits, that dlm will read the flags, mask it and write it
      back. As example receive_flags() in fs/dlm/lock.c. This flag
      manipulation is not done atomically and is not protected by
      lkb->lkb_cb_lock. This has unknown side effects of the current callback
      handling.
      
      In future we should move to set/clear/test bit functionality and avoid
      read, mask and writing back flag values. In later patches we will move
      the upper parts to the new introduced internal lkb flags which are not
      shared between other cluster nodes to the new non shared internal flag
      field to avoid similar issues.
      
      Cc: stable@vger.kernel.org
      Fixes: 61bed0ba ("fs: dlm: use a non-static queue for callbacks")
      Reported-by: default avatarBob Peterson <rpeterso@redhat.com>
      Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
      Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
      a034c137
  3. 05 Mar, 2023 9 commits
    • Linus Torvalds's avatar
      Linux 6.3-rc1 · fe15c26e
      Linus Torvalds authored
      fe15c26e
    • Linus Torvalds's avatar
      cpumask: re-introduce constant-sized cpumask optimizations · 596ff4a0
      Linus Torvalds authored
      Commit aa47a7c2 ("lib/cpumask: deprecate nr_cpumask_bits") resulted
      in the cpumask operations potentially becoming hugely less efficient,
      because suddenly the cpumask was always considered to be variable-sized.
      
      The optimization was then later added back in a limited form by commit
      6f9c07be ("lib/cpumask: add FORCE_NR_CPUS config option"), but that
      FORCE_NR_CPUS option is not useful in a generic kernel and more of a
      special case for embedded situations with fixed hardware.
      
      Instead, just re-introduce the optimization, with some changes.
      
      Instead of depending on CPUMASK_OFFSTACK being false, and then always
      using the full constant cpumask width, this introduces three different
      cpumask "sizes":
      
       - the exact size (nr_cpumask_bits) remains identical to nr_cpu_ids.
      
         This is used for situations where we should use the exact size.
      
       - the "small" size (small_cpumask_bits) is the NR_CPUS constant if it
         fits in a single word and the bitmap operations thus end up able
         to trigger the "small_const_nbits()" optimizations.
      
         This is used for the operations that have optimized single-word
         cases that get inlined, notably the bit find and scanning functions.
      
       - the "large" size (large_cpumask_bits) is the NR_CPUS constant if it
         is an sufficiently small constant that makes simple "copy" and
         "clear" operations more efficient.
      
         This is arbitrarily set at four words or less.
      
      As a an example of this situation, without this fixed size optimization,
      cpumask_clear() will generate code like
      
              movl    nr_cpu_ids(%rip), %edx
              addq    $63, %rdx
              shrq    $3, %rdx
              andl    $-8, %edx
              callq   memset@PLT
      
      on x86-64, because it would calculate the "exact" number of longwords
      that need to be cleared.
      
      In contrast, with this patch, using a MAX_CPU of 64 (which is quite a
      reasonable value to use), the above becomes a single
      
      	movq $0,cpumask
      
      instruction instead, because instead of caring to figure out exactly how
      many CPU's the system has, it just knows that the cpumask will be a
      single word and can just clear it all.
      
      Note that this does end up tightening the rules a bit from the original
      version in another way: operations that set bits in the cpumask are now
      limited to the actual nr_cpu_ids limit, whereas we used to do the
      nr_cpumask_bits thing almost everywhere in the cpumask code.
      
      But if you just clear bits, or scan for bits, we can use the simpler
      compile-time constants.
      
      In the process, remove 'cpumask_complement()' and 'for_each_cpu_not()'
      which were not useful, and which fundamentally have to be limited to
      'nr_cpu_ids'.  Better remove them now than have somebody introduce use
      of them later.
      
      Of course, on x86-64 with MAXSMP there is no sane small compile-time
      constant for the cpumask sizes, and we end up using the actual CPU bits,
      and will generate the above kind of horrors regardless.  Please don't
      use MAXSMP unless you really expect to have machines with thousands of
      cores.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      596ff4a0
    • Linus Torvalds's avatar
      Merge tag 'v6.3-p2' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 · f915322f
      Linus Torvalds authored
      Pull crypto fix from Herbert Xu:
       "Fix a regression in the caam driver"
      
      * tag 'v6.3-p2' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
        crypto: caam - Fix edesc/iv ordering mixup
      f915322f
    • Linus Torvalds's avatar
      Merge tag 'x86-urgent-2023-03-05' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 7f9ec7d8
      Linus Torvalds authored
      Pull x86 updates from Thomas Gleixner:
       "A small set of updates for x86:
      
         - Return -EIO instead of success when the certificate buffer for SEV
           guests is not large enough
      
         - Allow STIPB to be enabled with legacy IBSR. Legacy IBRS is cleared
           on return to userspace for performance reasons, but the leaves user
           space vulnerable to cross-thread attacks which STIBP prevents.
           Update the documentation accordingly"
      
      * tag 'x86-urgent-2023-03-05' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        virt/sev-guest: Return -EIO if certificate buffer is not large enough
        Documentation/hw-vuln: Document the interaction between IBRS and STIBP
        x86/speculation: Allow enabling STIBP with legacy IBRS
      7f9ec7d8
    • Linus Torvalds's avatar
      Merge tag 'irq-urgent-2023-03-05' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 4e9c542c
      Linus Torvalds authored
      Pull irq updates from Thomas Gleixner:
       "A set of updates for the interrupt susbsystem:
      
         - Prevent possible NULL pointer derefences in
           irq_data_get_affinity_mask() and irq_domain_create_hierarchy()
      
         - Take the per device MSI lock before invoking code which relies on
           it being hold
      
         - Make sure that MSI descriptors are unreferenced before freeing
           them. This was overlooked when the platform MSI code was converted
           to use core infrastructure and results in a fals positive warning
      
         - Remove dead code in the MSI subsystem
      
         - Clarify the documentation for pci_msix_free_irq()
      
         - More kobj_type constification"
      
      * tag 'irq-urgent-2023-03-05' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        genirq/msi, platform-msi: Ensure that MSI descriptors are unreferenced
        genirq/msi: Drop dead domain name assignment
        irqdomain: Add missing NULL pointer check in irq_domain_create_hierarchy()
        genirq/irqdesc: Make kobj_type structures constant
        PCI/MSI: Clarify usage of pci_msix_free_irq()
        genirq/msi: Take the per-device MSI lock before validating the control structure
        genirq/ipi: Fix NULL pointer deref in irq_data_get_affinity_mask()
      4e9c542c
    • Linus Torvalds's avatar
      Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs · 1a90673e
      Linus Torvalds authored
      Pull vfs update from Al Viro:
       "Adding Christian Brauner as VFS co-maintainer"
      
      * tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
        Adding VFS co-maintainer
      1a90673e
    • Linus Torvalds's avatar
      Merge tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs · 1a8d05a7
      Linus Torvalds authored
      Pull VM_FAULT_RETRY fixes from Al Viro:
       "Some of the page fault handlers do not deal with the following case
        correctly:
      
         - handle_mm_fault() has returned VM_FAULT_RETRY
      
         - there is a pending fatal signal
      
         - fault had happened in kernel mode
      
        Correct action in such case is not "return unconditionally" - fatal
        signals are handled only upon return to userland and something like
        copy_to_user() would end up retrying the faulting instruction and
        triggering the same fault again and again.
      
        What we need to do in such case is to make the caller to treat that as
        failed uaccess attempt - handle exception if there is an exception
        handler for faulting instruction or oops if there isn't one.
      
        Over the years some architectures had been fixed and now are handling
        that case properly; some still do not. This series should fix the
        remaining ones.
      
        Status:
      
         - m68k, riscv, hexagon, parisc: tested/acked by maintainers.
      
         - alpha, sparc32, sparc64: tested locally - bug has been reproduced
           on the unpatched kernel and verified to be fixed by this series.
      
         - ia64, microblaze, nios2, openrisc: build, but otherwise completely
           untested"
      
      * tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
        openrisc: fix livelock in uaccess
        nios2: fix livelock in uaccess
        microblaze: fix livelock in uaccess
        ia64: fix livelock in uaccess
        sparc: fix livelock in uaccess
        alpha: fix livelock in uaccess
        parisc: fix livelock in uaccess
        hexagon: fix livelock in uaccess
        riscv: fix livelock in uaccess
        m68k: fix livelock in uaccess
      1a8d05a7
    • Masahiro Yamada's avatar
      Remove Intel compiler support · 95207db8
      Masahiro Yamada authored
      include/linux/compiler-intel.h had no update in the past 3 years.
      
      We often forget about the third C compiler to build the kernel.
      
      For example, commit a0a12c3e ("asm goto: eradicate CC_HAS_ASM_GOTO")
      only mentioned GCC and Clang.
      
      init/Kconfig defines CC_IS_GCC and CC_IS_CLANG but not CC_IS_ICC,
      and nobody has reported any issue.
      
      I guess the Intel Compiler support is broken, and nobody is caring
      about it.
      
      Harald Arnesen pointed out ICC (classic Intel C/C++ compiler) is
      deprecated:
      
          $ icc -v
          icc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is
          deprecated and will be removed from product release in the second half
          of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended
          compiler moving forward. Please transition to use this compiler. Use
          '-diag-disable=10441' to disable this message.
          icc version 2021.7.0 (gcc version 12.1.0 compatibility)
      
      Arnd Bergmann provided a link to the article, "Intel C/C++ compilers
      complete adoption of LLVM".
      
      lib/zstd/common/compiler.h and lib/zstd/compress/zstd_fast.c were kept
      untouched for better sync with https://github.com/facebook/zstd
      
      Link: https://www.intel.com/content/www/us/en/developer/articles/technical/adoption-of-llvm-complete-icx.htmlSigned-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
      Reviewed-by: default avatarMiguel Ojeda <ojeda@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      95207db8
    • Al Viro's avatar
      Adding VFS co-maintainer · 3304f18b
      Al Viro authored
      Acked-by: default avatarChristian Brauner <brauner@kernel.org>
      Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      3304f18b
  4. 04 Mar, 2023 8 commits
    • Linus Torvalds's avatar
      Merge tag 'i2c-for-6.3-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · b01fe98d
      Linus Torvalds authored
      Pull more i2c updates from Wolfram Sang:
       "Some improvements/fixes for the newly added GXP driver and a Kconfig
        dependency fix"
      
      * tag 'i2c-for-6.3-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        i2c: gxp: fix an error code in probe
        i2c: gxp: return proper error on address NACK
        i2c: gxp: remove "empty" switch statement
        i2c: Disable I2C_APPLE when I2C_PASEMI is a builtin
      b01fe98d
    • Linus Torvalds's avatar
      mm: avoid gcc complaint about pointer casting · e77d587a
      Linus Torvalds authored
      The migration code ends up temporarily stashing information of the wrong
      type in unused fields of the newly allocated destination folio.  That
      all works fine, but gcc does complain about the pointer type mis-use:
      
          mm/migrate.c: In function ‘__migrate_folio_extract’:
          mm/migrate.c:1050:20: note: randstruct: casting between randomized structure pointer types (ssa): ‘struct anon_vma’ and ‘struct address_space’
      
           1050 |         *anon_vmap = (void *)dst->mapping;
                |         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
      
      and gcc is actually right to complain since it really doesn't understand
      that this is a very temporary special case where this is ok.
      
      This could be fixed in different ways by just obfuscating the assignment
      sufficiently that gcc doesn't see what is going on, but the truly
      "proper C" way to do this is by explicitly using a union.
      
      Using unions for type conversions like this is normally hugely ugly and
      syntactically nasty, but this really is one of the few cases where we
      want to make it clear that we're not doing type conversion, we're really
      re-using the value bit-for-bit just using another type.
      
      IOW, this should not become a common pattern, but in this one case using
      that odd union is probably the best way to document to the compiler what
      is conceptually going on here.
      
      [ Side note: there are valid cases where we convert pointers to other
        pointer types, notably the whole "folio vs page" situation, where the
        types actually have fundamental commonalities.
      
        The fact that the gcc note is limited to just randomized structures
        means that we don't see equivalent warnings for those cases, but it
        migth also mean that we miss other cases where we do play these kinds
        of dodgy games, and this kind of explicit conversion might be a good
        idea. ]
      
      I verified that at least for an allmodconfig build on x86-64, this
      generates the exact same code, apart from line numbers and assembler
      comment changes.
      
      Fixes: 64c8902e ("migrate_pages: split unmap_and_move() to _unmap() and _move()")
      Cc: Huang, Ying <ying.huang@intel.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      e77d587a
    • Linus Torvalds's avatar
      Merge tag 'mm-hotfixes-stable-2023-03-04-13-12' of... · 20fdfd55
      Linus Torvalds authored
      Merge tag 'mm-hotfixes-stable-2023-03-04-13-12' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
      
      Pull misc fixes from Andrew Morton:
       "17 hotfixes.
      
        Eight are for MM and seven are for other parts of the kernel. Seven
        are cc:stable and eight address post-6.3 issues or were judged
        unsuitable for -stable backporting"
      
      * tag 'mm-hotfixes-stable-2023-03-04-13-12' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm:
        mailmap: map Dikshita Agarwal's old address to his current one
        mailmap: map Vikash Garodia's old address to his current one
        fs/cramfs/inode.c: initialize file_ra_state
        fs: hfsplus: fix UAF issue in hfsplus_put_super
        panic: fix the panic_print NMI backtrace setting
        lib: parser: update documentation for match_NUMBER functions
        kasan, x86: don't rename memintrinsics in uninstrumented files
        kasan: test: fix test for new meminstrinsic instrumentation
        kasan: treat meminstrinsic as builtins in uninstrumented files
        kasan: emit different calls for instrumentable memintrinsics
        ocfs2: fix non-auto defrag path not working issue
        ocfs2: fix defrag path triggering jbd2 ASSERT
        mailmap: map Georgi Djakov's old Linaro address to his current one
        mm/hwpoison: convert TTU_IGNORE_HWPOISON to TTU_HWPOISON
        lib/zlib: DFLTCC deflate does not write all available bits for Z_NO_FLUSH
        mm/damon/paddr: fix missing folio_put()
        mm/mremap: fix dup_anon_vma() in vma_merge() case 4
      20fdfd55
    • Linus Torvalds's avatar
      Merge tag 'powerpc-6.3-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · c29214bc
      Linus Torvalds authored
      Pull powerpc fixes from Michael Ellerman:
      
       - Drop orphaned VAS MAINTAINERS entry
      
       - Fix build errors with clang and KCSAN
      
       - Avoid build errors seen with LD_DEAD_CODE_DATA_ELIMINATION together
         with recordmcount
      
      Thanks to Nathan Chancellor.
      
      * tag 'powerpc-6.3-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        powerpc: Avoid dead code/data elimination when using recordmcount
        powerpc/vmlinux.lds: Add .text.asan/tsan sections
        powerpc: Drop orphaned VAS MAINTAINERS entry
      c29214bc
    • Linus Torvalds's avatar
      Merge tag 'sound-fix-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · d172859e
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "A collection of various small fixes that have been gathered since the
        last PR.
      
        The majority of changes are for ASoC, and there is a small change in
        ASoC PCM core, but the rest are all for driver- specific fixes /
        quirks / updates"
      
      * tag 'sound-fix-6.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (32 commits)
        ALSA: ice1712: Delete unreachable code in aureon_add_controls()
        ALSA: ice1712: Do not left ice->gpio_mutex locked in aureon_add_controls()
        ALSA: hda/realtek: Add quirk for HP EliteDesk 800 G6 Tower PC
        ALSA: hda/realtek: Improve support for Dell Precision 3260
        ASoC: mediatek: mt8195: add missing initialization
        ASoC: mediatek: mt8188: add missing initialization
        ASoC: amd: yc: Add DMI entries to support HP OMEN 16-n0xxx (8A43)
        ASoC: zl38060 add gpiolib dependency
        ASoC: sam9g20ek: Disable capture unless building with microphone input
        ASoC: mt8192: Fix range for sidetone positive gain
        ASoC: mt8192: Report an error if when an invalid sidetone gain is written
        ASoC: mt8192: Fix event generation for controls
        ASoC: mt8192: Remove spammy log messages
        ASoC: mchp-pdmc: fix poc noise at capture startup
        ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding
        ASoC: soc-pcm: add option to start DMA after DAI
        ASoC: mt8183: Fix event generation for I2S DAI operations
        ASoC: mt8183: Remove spammy logging from I2S DAI driver
        ASoC: mt6358: Remove undefined HPx Mux enumeration values
        ASoC: mt6358: Validate Wake on Voice 2 writes
        ...
      d172859e
    • Linus Torvalds's avatar
      Merge tag 'for-v6.3-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply · 0988a0ea
      Linus Torvalds authored
      Pull more power supply updates from Sebastian Reichel:
      
       - Fix DT binding for Richtek RT9467
      
       - Fix a NULL pointer check in the power-supply core
      
       - Document meaning of absent "present" property
      
      * tag 'for-v6.3-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply:
        dt-bindings: power: supply: Revise Richtek RT9467 compatible name
        ABI: testing: sysfs-class-power: Document absence of "present" property
        power: supply: fix null pointer check order in __power_supply_register
      0988a0ea
    • Linus Torvalds's avatar
      Merge tag '6.3-rc-smb3-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6 · 3162745a
      Linus Torvalds authored
      Pull more cifs updates from Steve French:
      
       - xfstest generic/208 fix (memory leak)
      
       - minor netfs fix (to address smatch warning)
      
       - a DFS fix for stable
      
       - a reconnect race fix
      
       - two multichannel fixes
      
       - RDMA (smbdirect) fix
      
       - two additional writeback fixes from David
      
      * tag '6.3-rc-smb3-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: Fix memory leak in direct I/O
        cifs: prevent data race in cifs_reconnect_tcon()
        cifs: improve checking of DFS links over STATUS_OBJECT_NAME_INVALID
        iov: Fix netfs_extract_user_to_sg()
        cifs: Fix cifs_write_back_from_locked_folio()
        cifs: reuse cifs_match_ipaddr for comparison of dstaddr too
        cifs: match even the scope id for ipv6 addresses
        cifs: Fix an uninitialised variable
        cifs: Add some missing xas_retry() calls
      3162745a
    • Linus Torvalds's avatar
      umh: simplify the capability pointer logic · e7783615
      Linus Torvalds authored
      The usermodehelper code uses two fake pointers for the two capability
      cases: CAP_BSET for reading and writing 'usermodehelper_bset', and
      CAP_PI to read and write 'usermodehelper_inheritable'.
      
      This seems to be a completely unnecessary indirection, since we could
      instead just use the pointers themselves, and never have to do any "if
      this then that" kind of logic.
      
      So just get rid of the fake pointer values, and use the real pointer
      values instead.
      Reviewed-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
      Cc: Eric Biederman <ebiederm@xmission.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Kees Cook <keescook@chromium.org>
      Cc: Iurii Zaikin <yzaikin@google.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      e7783615
  5. 03 Mar, 2023 11 commits
    • Linus Torvalds's avatar
      Merge tag 'cocci-for-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux · fb35342f
      Linus Torvalds authored
      Pull coccinelle updates from Julia Lawall:
       "Changes in make coccicheck and improve a semantic patch
      
        This makes a couple of changes in make coccicheck related to shell
        commands.
      
        It also updates the api/atomic_as_refcounter semantic patch to include
        WARNING in the output message, as done in other cases"
      
      * tag 'cocci-for-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux:
        scripts: coccicheck: Use /usr/bin/env
        scripts: coccicheck: Avoid warning about spurious escape
        coccinelle: api/atomic_as_refcounter: include message type in output
      fb35342f
    • Linus Torvalds's avatar
      Merge tag 'rust-fixes-6.3-rc1' of https://github.com/Rust-for-Linux/linux · 34c108a0
      Linus Torvalds authored
      Pull Rust fix from Miguel Ojeda:
       "A single build error fix: there was a change during the merge window
        to a C header parsed by the Rust bindings generator, introducing a
        type that it does not handle well.
      
        The fix tells the generator to treat the type as opaque (for now)"
      
      * tag 'rust-fixes-6.3-rc1' of https://github.com/Rust-for-Linux/linux:
        rust: bindgen: Add `alt_instr` as opaque type
      34c108a0
    • Linus Torvalds's avatar
      Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 06caa751
      Linus Torvalds authored
      Pull more SCSI updates from James Bottomley:
       "Updates that missed the first pull, mostly because of needing more
        soak time.
      
        Driver updates (zfcp, ufs, mpi3mr, plus two ipr bug fixes), an
        enclosure services (ses) update (mostly bug fixes) and other minor bug
        fixes and changes"
      
      * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (32 commits)
        scsi: zfcp: Trace when request remove fails after qdio send fails
        scsi: zfcp: Change the type of all fsf request id fields and variables to u64
        scsi: zfcp: Make the type for accessing request hashtable buckets size_t
        scsi: ufs: core: Simplify ufshcd_execute_start_stop()
        scsi: ufs: core: Rely on the block layer for setting RQF_PM
        scsi: core: Extend struct scsi_exec_args
        scsi: lpfc: Fix double word in comments
        scsi: core: Remove the /proc/scsi/${proc_name} directory earlier
        scsi: core: Fix a source code comment
        scsi: cxgbi: Remove unneeded version.h include
        scsi: qedi: Remove unneeded version.h include
        scsi: mpi3mr: Remove unneeded version.h include
        scsi: mpi3mr: Fix missing mrioc->evtack_cmds initialization
        scsi: mpi3mr: Use number of bits to manage bitmap sizes
        scsi: mpi3mr: Remove unnecessary memcpy() to alltgt_info->dmi
        scsi: mpi3mr: Fix issues in mpi3mr_get_all_tgt_info()
        scsi: mpi3mr: Fix an issue found by KASAN
        scsi: mpi3mr: Replace 1-element array with flex-array
        scsi: ipr: Work around fortify-string warning
        scsi: ipr: Make ipr_probe_ioa_part2() return void
        ...
      06caa751
    • Dan Carpenter's avatar
      i2c: gxp: fix an error code in probe · 65609d32
      Dan Carpenter authored
      This is passing IS_ERR() instead of PTR_ERR() so instead of an error
      code it prints and returns the number 1.
      
      Fixes: 4a55ed6f ("i2c: Add GXP SoC I2C Controller")
      Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
      Reviewed-by: default avatarNick Hawkins <nick.hawkins@hpe.com>
      Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
      65609d32
    • Wolfram Sang's avatar
      i2c: gxp: return proper error on address NACK · 4b3dfb0e
      Wolfram Sang authored
      According to Documentation/i2c/fault-codes.rst, NACK after sending an
      address should be -ENXIO.
      Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
      4b3dfb0e
    • Wolfram Sang's avatar
      i2c: gxp: remove "empty" switch statement · 1d092308
      Wolfram Sang authored
      There used to be error messages which had to go. Now, it only consists
      of 'break's, so it can go.
      Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
      1d092308
    • Benjamin Gray's avatar
      i2c: Disable I2C_APPLE when I2C_PASEMI is a builtin · a76d19e6
      Benjamin Gray authored
      The ppc64le_allmodconfig sets I2C_PASEMI=y and leaves COMPILE_TEST to
      default to y and I2C_APPLE to default to m, running into a known
      incompatible configuration that breaks the build [1]. Specifically,
      a common dependency (i2c-pasemi-core.o in this case) cannot be used by
      both builtin and module consumers.
      
      Disable I2C_APPLE when I2C_PASEMI is a builtin to prevent this.
      
      [1]: https://lore.kernel.org/all/202112061809.XT99aPrf-lkp@intel.comSuggested-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarBenjamin Gray <bgray@linux.ibm.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: default avatarSven Peter <sven@svenpeter.dev>
      Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
      a76d19e6
    • Linus Torvalds's avatar
      Merge tag 'thermal-6.3-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 0a3f9a6b
      Linus Torvalds authored
      Pull more thermal control updates from Rafael Wysocki:
       "These fix two issues in the Intel thermal control drivers.
      
        Specifics:
      
         - Fix an error pointer dereference in the quark_dts Intel thermal
           driver (Dan Carpenter)
      
         - Fix the intel_bxt_pmic_thermal driver Kconfig entry to select
           REGMAP which is not user-visible instead of depending on it (Randy
           Dunlap)"
      
      * tag 'thermal-6.3-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
        thermal: intel: quark_dts: fix error pointer dereference
      0a3f9a6b
    • Linus Torvalds's avatar
      Merge tag 'acpi-6.3-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 44b6f565
      Linus Torvalds authored
      Pull more ACPI updates from Rafael Wysocki:
       "These update ACPI quirks for some x86 platforms and add an IRQ
        override quirk for one more system.
      
        Specifics:
      
         - Add an ACPI IRQ override quirk for Asus Expertbook B2402FBA
           (Vojtech Hejsek)
      
         - Drop a suspend-to-idle quirk for HP Elitebook G9 that is not needed
           any more after a firmware update (Mario Limonciello)
      
         - Add all Cezanne systems to the list for forcing StorageD3Enable,
           because they all need the same quirk (Mario Limonciello)"
      
      * tag 'acpi-6.3-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPI: x86: utils: Add Cezanne to the list for forcing StorageD3Enable
        ACPI: x86: Drop quirk for HP Elitebook
        ACPI: resource: Skip IRQ override on Asus Expertbook B2402FBA
      44b6f565
    • Linus Torvalds's avatar
      Merge tag 'pm-6.3-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · c8b4accf
      Linus Torvalds authored
      Pull more power management updates from Rafael Wysocki:
       "These update power capping (new hardware support and cleanup) and
        cpufreq (bug fixes, cleanups and intel_pstate adjustment for a new
        platform).
      
        Specifics:
      
         - Fix error handling in the apple-soc cpufreq driver (Dan Carpenter)
      
         - Change the log level of a message in the amd-pstate cpufreq driver
           so it is more visible to users (Kai-Heng Feng)
      
         - Adjust the balance_performance EPP value for Sapphire Rapids in the
           intel_pstate cpufreq driver (Srinivas Pandruvada)
      
         - Remove MODULE_LICENSE from 3 pieces of non-modular code (Nick
           Alcock)
      
         - Make a read-only kobj_type structure in the schedutil cpufreq
           governor constant (Thomas Weißschuh)
      
         - Add Add Power Limit4 support for Meteor Lake SoC to the Intel RAPL
           power capping driver (Sumeet Pawnikar)"
      
      * tag 'pm-6.3-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        cpufreq: apple-soc: Fix an IS_ERR() vs NULL check
        powercap: remove MODULE_LICENSE in non-modules
        cpufreq: intel_pstate: remove MODULE_LICENSE in non-modules
        powercap: RAPL: Add Power Limit4 support for Meteor Lake SoC
        cpufreq: amd-pstate: remove MODULE_LICENSE in non-modules
        cpufreq: schedutil: make kobj_type structure constant
        cpufreq: amd-pstate: Let user know amd-pstate is disabled
        cpufreq: intel_pstate: Adjust balance_performance EPP for Sapphire Rapids
      c8b4accf
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.3-2023-03-03' of git://git.kernel.dk/linux · 53ae7e11
      Linus Torvalds authored
      Pull more io_uring updates from Jens Axboe:
       "Here's a set of fixes/changes that didn't make the first cut, either
        because they got queued before I sent the early merge request, or
        fixes that came in afterwards. In detail:
      
         - Don't set MSG_NOSIGNAL on recv/recvmsg opcodes, as AF_PACKET will
           error out (David)
      
         - Fix for spurious poll wakeups (me)
      
         - Fix for a file leak for buffered reads in certain conditions
           (Joseph)
      
         - Don't allow registered buffers of mixed types (Pavel)
      
         - Improve handling of huge pages for registered buffers (Pavel)
      
         - Provided buffer ring size calculation fix (Wojciech)
      
         - Minor cleanups (me)"
      
      * tag 'io_uring-6.3-2023-03-03' of git://git.kernel.dk/linux:
        io_uring/poll: don't pass in wake func to io_init_poll_iocb()
        io_uring: fix fget leak when fs don't support nowait buffered read
        io_uring/poll: allow some retries for poll triggering spuriously
        io_uring: remove MSG_NOSIGNAL from recvmsg
        io_uring/rsrc: always initialize 'folio' to NULL
        io_uring/rsrc: optimise registered huge pages
        io_uring/rsrc: optimise single entry advance
        io_uring/rsrc: disallow multi-source reg buffers
        io_uring: remove unused wq_list_merge
        io_uring: fix size calculation when registering buf ring
        io_uring/rsrc: fix a comment in io_import_fixed()
        io_uring: rename 'in_idle' to 'in_cancel'
        io_uring: consolidate the put_ref-and-return section of adding work
      53ae7e11