- 25 Sep, 2016 2 commits
-
-
Georgiana Rodica Chelu authored
Remove the return statement from the end of a void function to clean up the code. Issue found by checkpatch.pl script. Signed-off-by:
Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Georgiana Rodica Chelu authored
Remove unneeded code in order to make clear that the function returns 0(success) in all cases. Done using returnvar.cocci script. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
- 23 Sep, 2016 15 commits
-
-
Baoyou Xie authored
We get 1 warning when building kernel with W=1: drivers/staging/ks7010/ks_wlan_net.c:3520:5: warning: no previous prototype for 'ks_wlan_reset' [-Wmissing-prototypes] In fact, these functions are unused in ks_wlan_net.c, but should be removed. So this patch removes the unused function. Signed-off-by:
Baoyou Xie <baoyou.xie@linaro.org> Signed-off-by:
-
Baoyou Xie authored
We get 2 warnings when building kernel with W=1: drivers/staging/rtl8192u/r8192U_core.c:925:12: warning: no previous declaration for 'ieeerate2rtlrate' [-Wmissing-declarations] drivers/staging/rtl8192u/r8192U_core.c:958:12: warning: no previous declaration for 'rtl8192_rate2rate' [-Wmissing-declarations] drivers/staging/rtl8192u/r8192U_core.c:1322:11: warning: no previous declaration for 'rtl8192_IsWirelessBMode' [-Wmissing-declarations] In fact, these functions are unused in r8192U_core.c, but should be removed. So this patch removes the unused functions. Signed-off-by:
-
Baoyou Xie authored
We get 5 warnings when building kernel with W=1: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:287:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:323:24: warning: no previous declaration for 'ieee80211_probe_req' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:643:24: warning: no previous declaration for 'ieee80211_authentication_req' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:981:24: warning: no previous declaration for 'ieee80211_association_req' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:3094:24: warning: no previous declaration for 'ieee80211_disassociate_skb' [-Wmissing-declarations] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by:
-
Baoyou Xie authored
We get 4 warnings when building kernel with W=1: drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous prototype for 'ion_carveout_allocate' [-Wmissing-prototypes] drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no previous prototype for 'ion_carveout_free' [-Wmissing-prototypes] drivers/staging/android/ion/ion_of.c:28:5: warning: no previous prototype for 'ion_parse_dt_heap_common' [-Wmissing-prototypes] drivers/staging/android/ion/ion_of.c:54:5: warning: no previous prototype for 'ion_setup_heap_common' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by:
-
Christian Gromm authored
This patch allows to call the write() function for synchronous and isochronous channels with buffers of any size. The AIM simply waits for data to fill up the MOST buffer object according to the network interface controller specification for streaming channels, before it submits the buffer to the HDM. The new behavior is backward compatible to the old applications, since all known applications needed to fill the buffer completely anyway. Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
-
sayli karnik authored
This patch uses setup_timer function instead of initializing timer with the function and data fields. Signed-off-by:
sayli karnik <karniksayli1995@gmail.com> Signed-off-by:
-
Jannik Becher authored
Fixed a coding style issue by removing unnecessary spaces before casts. Signed-off-by:
Jannik Becher <Becher.Jannik@gmail.com> Signed-off-by:
-
Johan Svensson authored
Fixes warnings found by checkpatch Missing a blank line after declarations Signed-off-by:
Johan Svensson <johan.svensson692@gmail.com> Signed-off-by:
-
Ivan Safonov authored
rf_type is always equal to ODM_1T1R. So, only RF PATH A exists for r8188eu device... Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Ivan Safonov authored
rf_type is always equal to RF_1T1R. Signed-off-by:
-
Georgiana Rodica Chelu authored
The checkpatch.pl found the warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Checked if the the Ethernet addresses are __aligned(2) by using pahole tool. The type of pwlanhdr is struct ieee80211_hdr and pahole shows that addr1, addr2, and addr3 are aligned to u16. struct ieee80211_hdr { __le16 frame_control; /* 0 2 */ __le16 duration_id; /* 2 2 */ u8 addr1[6]; /* 4 6 */ u8 addr2[6]; /* 10 6 */ u8 addr3[6]; /* 16 6 */ __le16 seq_ctrl; /* 22 2 */ u8 addr4[6]; /* 24 6 */ /* size: 30, cachelines: 1, members: 7 */ /* last cacheline: 30 bytes */ }; Both eeprompriv from struct adapter and MacAddress from struct wlan_bssid_ex have the offset multiple of sizeof(u16). Also, the array bc_addr and the pointers: StaAddr, mac, and bssid, start from an even offset. Signed-off-by: -
Juliana Rodrigues authored
Removed variables used only for return purposes and replaced them for the return value itself. Found using Coccinelle's semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by:
-
Juliana Rodrigues authored
Removed an unecessary blank line after open brace, fixing a checkpatch issue. Signed-off-by:
-
Eva Rachel Retuya authored
Declare the 'arche_apb_ctrl_of_match' array as const. This array is only stored in the .of_match_table field of a device_driver structure, which is declared as const. This addresses the checkpatch warning: WARNING: struct of_device_id should be normally const Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Declare the arrays 'arche_platform_of_match' and 'arche_combined_id' as const. 'arche_platform_of_match' is only stored in the .of_match_table field of a device_driver structure, which is declared as const. 'arche_combined_id' is passed to MODULE_DEVICE_TABLE. This macro does not modify the array and therefore the array can be declared as const. Checkpatch pointed out both issues. WARNING: struct of_device_id should be normally const Signed-off-by:
-
- 22 Sep, 2016 23 commits
-
-
Sandhya Bankar authored
This issue was found by checkpatch. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
This patch was found by checkpatch. Signed-off-by:
-
Rehas Sachdeva authored
Move the test to check if a variable is NULL, to right after it is being assigned, rather than some statements later. Signed-off-by:
Rehas Sachdeva <aquannie@gmail.com> Signed-off-by:
-
sayli karnik authored
This patch removes an unnecessary variable used to store return values in order to reduce memory usage. Done using coccinelle: @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret return - ret + C ; Signed-off-by:
-
Rehas Sachdeva authored
Remove 'x=a;' from a consecutive double assignment of the form 'x=a; x=b;'. Issue detected by the semantic patch found here: https://github.com/coccinelle/coccinellery/blob/master/write2/write2.cocciSigned-off-by:
-
Yannis Damigos authored
This patch fixes multiple black lines issue found by checkpatch.pl Signed-off-by:
Yannis Damigos <giannis.damigos@gmail.com> Signed-off-by:
-
Rehas Sachdeva authored
Remove unnecessary parentheses from right side of an assignment. Issue detected by the following Coccinelle semantic patch: @r@ identifier x; expression e1, e2; @@ - x = (e1 << e2); + x = e1 << e2; Signed-off-by:
-
Rehas Sachdeva authored
Replaces left shift operation (1 << d) by BIT(x) macro. Signed-off-by:
-
Rehas Sachdeva authored
Setting the variable 'refresh_rate = 60;' has no use to the rest of the function. Hence the if statement setting it and the variable itself can be removed. This was detected using the following Coccinelle semantic patch: @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by:
-
Katie Dunne authored
Issue found by checkpatch. Signed-off-by:
Katie Dunne <kdunne@mail.ccsf.edu> Signed-off-by:
-
David Lin authored
Add myself as greybus uart and log protocol driver maintainer. Signed-off-by:
David Lin <dtwlin@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
Fixes checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
Fixes checkpatch.pl warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by:
-
Richard Groux authored
Minor error spotted by checkpatch.pl in greybus code indent should use tabs where possible Signed-off-by:
Richard Groux <rgroux@sauron-mordor.net> Reviewed-by:
Alex Elder <elder@linaro.org> Signed-off-by:
-
Richard Groux authored
Minor error spotted by checkpatch.pl in greybus space required before the open brace '{' Signed-off-by: -
Eva Rachel Retuya authored
Modify return statement to use the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e; local idexpression ret; @@ -ret = +return e; -return ret; Signed-off-by:
-
Eva Rachel Retuya authored
Eliminate unneeded parentheses around the right hand side of an assignment. Coccinelle semantic patch used: @@ expression e1, e2; identifier v; @@ ( v = (e1 == e2) | v = (e1 != e2) | v = (e1 <= e2) | v = (e1 >= e2) | v = - ( e1 - ) ) Signed-off-by:
-
Eva Rachel Retuya authored
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(...); if ( ( + ! x - == NULL | + ! - NULL == x ) ) Z Signed-off-by:
-
Andrey Shvetsov authored
This patch replaces the enum value MOST_CH_ISOC_AVP with the more appropriate MOST_CH_ISOC. Signed-off-by:
Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by:
-
Christian Gromm authored
This patch adds the strings 'rx', 'tx' and 'isoc' to the list of accepted identifiers when setting up a channel configuration. To keep consistency it removes the prefix "dir_" from strings returned by the attributes set_direction and available_directions and it removes the suffix "_avp" from the string "isoc_avp" returned by the attributes set_datatype and available_datatypes. Signed-off-by:
-
Andrey Shvetsov authored
This patch removes trailing zeros from the strings returned by the attributes available_datatypes and available_directions. Signed-off-by:
-
Christian Gromm authored
Function most_submit_mbo() causes an exception only if either the pointer mbo or mbo->context equals NULL. From the underlying architecture's point of view both cases must _not_ come true and would happen only, if something has tampered with the pointers. This would render runtime code unable to recover anyway. So, instead trying to hide that things are already critically out of control we're better off with a WARN_ON() assertion. This patch replaces the return type of the function most_submit_mbo() with 'void' and adds a WARN_ONCE() assertion. Additionally, code calling the function is adapted accordingly. Signed-off-by:
-
Juliana Rodrigues authored
This patch fixes a checkpatch warning in a block comment by adapting it to the community preferred coding style. Signed-off-by:
-
