- 19 Jun, 2009 40 commits
-
-
Pekka Enberg authored
Impact: cleanup The contact details in MODULE_AUTHOR do not reflect current state of affairs so remove it. Acked-by:
Pavel Machek <pavel@ucw.cz> Signed-off-by:
Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Pekka Enberg authored
Impact: cleanup Use scripts/Lindent on the file and clean up the rest by hand. Acked-by:
-
Pekka Enberg authored
Impact: cleanup The hal_set_phy_type() is called in wb35_hw_init() only so inline the function there. Also remove a redundant assignment of ->phy_type to RF_WB_242_1. Acked-by:
-
Pekka Enberg authored
Impact: cleanup Remove some useless comments and clean up others. Acked-by:
-
Pekka Enberg authored
Impact: cleanup Now that hal_halt() is called from wb35_hw_halt() only where ->InitialResource is always set to 4, we can simplify hal_init_hardware() and hal_halt(). Acked-by:
-
Pekka Enberg authored
Impact: fix, cleanup If initialization in hal_init_hardware() fails, we call hal_halt() to clean up and release resource. However, hal_halt() will attempt to call del_timer_sync() on ->LEDTimer on "stage 3" although it's not initialized at that point. Fix that up by simplifying error handling logic in hal_init_hardware() with gotos. Acked-by:
-
Pekka Enberg authored
Impact: cleanup Use gotos to simplify the deep if-statement nesting in hal_init_hardware(). Acked-by:
-
Pekka Enberg authored
Impact: cleanup Change hal_init_hardware() to return an error code rather than a boolean to simplify error handling in wb35_hw_init(). Acked-by:
-
Pekka Enberg authored
Impact: cleanup The hal_init_hardware() and hal_halt() functions are only used in wbusb.c so move them there. Acked-by:
-
Pekka Enberg authored
Impact: cleanup This patch replaces the switch-based error handling in wb35_hw_init() with regular gotos. Acked-by:
-
Pekka Enberg authored
We don't initialize hardware multicast filter in the driver nor do we know how to do that. Therefore, remove some code that isn't actually used from wbsoft_configure_filter(). Cc: Pavel Machek <pavel@ucw.cz> Signed-off-by:
-
Diego Liziero authored
The semantic patch that makes this change is: (http://www.emn.fr/x-info/coccinelle/) @@ expression E; constant C; @@ ( - !E == C + E != C ) Signed-off-by:
Diego Liziero <diegoliz@gmail.com> Signed-off-by:
-
Roel Kluin authored
Do not go beyond ARRAY_SIZE of wd->ap.wds.encryMode Signed-off-by:
Roel Kluin <roel.kluin@gmail.com> Signed-off-by:
-
Dragoslav Zaric authored
Signed-off-by:
Dragoslav Zaric <dragoslav.zaric.kd@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
In the near future, the driver core is going to not allow direct access to the driver_data pointer in struct device. Instead, the functions dev_get_drvdata() and dev_set_drvdata() should be used. These functions have been around since the beginning, so are backwards compatible with all older kernel versions. Cc: Leon Woestenberg <leon@sidebranch.com> Signed-off-by: -
Roel Kluin authored
`!' has a higher precedence than `&' and `|' has a higher precedence than `?' Signed-off-by:
-
Alexander Beregalov authored
Signed-off-by:
Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by:
-
Huang Weiyi authored
Remove unused #include <linux/version.h>'s. Signed-off-by:
Huang Weiyi <weiyi.huang@gmail.com> Signed-off-by:
-
Huang Weiyi authored
Remove dupilcated #include in drivers/staging/rt3070/rt_linux.h. Signed-off-by:
-
Roel Kluin authored
wmm_param[1].ac_aci_acm_aifsn was tested twice, the second should have been wmm_param[3].ac_aci_acm_aifsn. Signed-off-by:
-
Alexander Beregalov authored
Signed-off-by:
David S. Miller <davem@davemloft.net> Signed-off-by:
-
Jean Delvare authored
Use the recently added to_delayed_work() helper function. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Anders Kaseorg authored
The use of sprintf() to append to a buffer, as in sprintf(buf, "%sEntry: %d\n", buf, i) is not valid according to C99 ("If copying takes place between objects that overlap, the behavior is undefined."). It breaks at least in userspace under gcc -D_FORTIFY_SOURCE. Replace this construct with sprintf(buf + strlen(buf), "Entry: %d\n", i) This patch was automatically generated using perl -0pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3$4/g' perl -0pe 's/(snprintf\s*\(\s*([^,]*))(\s*,[^,]*?)(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3 - strlen($2)$4$5/g' Signed-off-by:Anders Kaseorg <andersk@mit.edu> Signed-off-by:
-
Anders Kaseorg authored
The use of sprintf() to append to a buffer, as in sprintf(buf, "%sEntry: %d\n", buf, i) is not valid according to C99 ("If copying takes place between objects that overlap, the behavior is undefined."). It breaks at least in userspace under gcc -D_FORTIFY_SOURCE. Replace this construct with sprintf(buf + strlen(buf), "Entry: %d\n", i) This patch was automatically generated using perl -0pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3$4/g' perl -0pe 's/(snprintf\s*\(\s*([^,]*))(\s*,[^,]*?)(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3 - strlen($2)$4$5/g' Signed-off-by: -
Alessio Igor Bogani authored
__FUNCTION__ is gcc-specific, use __func__ Signed-off-by:
Alessio Igor Bogani <abogani@texware.it> Signed-off-by:
-
Jean Delvare authored
The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by:
-
Alessio Igor Bogani authored
__FUNCTION__ is gcc-specific, use __func__ Signed-off-by:
-
Greg Kroah-Hartman authored
This fixes some build warnings in the meilhaus driver. Signed-off-by: -
Robert P. J. Day authored
Signed-off-by:
Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by:
-
Jiri Slaby authored
Remove pci and usb tables from the header and place them directly in the code. While at it, use PCI_VDEVICE() to shorten the code. Signed-off-by:
Jiri Slaby <jirislaby@gmail.com> Cc: David Kiliani <mail@davidkiliani.de> Signed-off-by:
-
Jiri Slaby authored
Add __devinit and __devexit to pci probe/remove. Also make pci_driver static. Signed-off-by:
-
Jiri Slaby authored
There is no need to occupy one major number because of one device. Switch to misc device, which also emits uevent, so that the dev node is also created by udev. Signed-off-by:
-
Greg Kroah-Hartman authored
This fixes some build warnings in the agnx driver. Signed-off-by: -
Alexander Beregalov authored
Signed-off-by:
-
Jiri Slaby authored
conf->bssid is const. Propagate const to not get compiler warnings: agnx/pci.c: In function ‘agnx_config_interface’: agnx/pci.c:319: warning: passing argument 2 of ‘agnx_set_bssid’ discards qualifiers from pointer target type agnx/pci.c:321: warning: passing argument 2 of ‘hash_write’ discards qualifiers from pointer target type Signed-off-by:
-
Jiri Slaby authored
Return error on fail paths instead of 0. Signed-off-by:
-
Jiri Slaby authored
Pass 0 to pci_iomap instead. It will cope with that per se. Signed-off-by:
-
Jiri Slaby authored
- switch printks to dev_* - remove useless comments - remove useless prints (for info we can obtain from lspci or /sys) Signed-off-by:
-
Randy Dunlap authored
comedi driver(s) use udelay() so they need to #include delay.h. drivers/staging/comedi/drivers/adq12b.c: In function 'adq12b_ai_rinsn': drivers/staging/comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay' Signed-off-by:
Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by:
-
Gerard Lledo authored
spin_lock_irqsave expects flags to be unsigned long, not unsigned int. Signed-off-by:
Gerard Lledo <gerard.lledo@gmail.com> Signed-off-by:
-
