- 16 Sep, 2011 40 commits
-
-
Arend van Spriel authored
Several global variables that were set but never initialized have been removed. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Arend van Spriel authored
The source file contained some static global variables that were needed per device handled by the driver. They have moved to the struct brcmf_sdio_dev for that reason. Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Arend van Spriel authored
The macro was only used once in the code and has been removed for clarity reading the code. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Arend van Spriel authored
The brcmfmac had a module parameter which could be used to override the name of the wireless net device name and it defaults to 'wlan'. This is considered rather useless, because what is in a name. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Use macro to replace global variable for ARP offload configuration Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
_brcmf_sysioc_thread is handling deferred jobs from 4 callers. Use work queue to handle set_mac_address/set_multicast_list requests. brcmf_add_if/brcmf_del_if never run in atomic context and can call brcmf_op_if directly. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Structure that is sent to the dongle has been annotated. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Structure that is sent to the dongle has been annotated. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Structures that are sent to the dongle have been annotated. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Three structures that are sent to the dongle have been annotated for correct endianness: struct brcmf_iscan_params, brcmf_scan_params, brcmf_cfg80211_scan_req. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
brcmf_dev_ioctl() does not provide a user space buffer to brcmf_netdev_ioctl_priv. Hence these calls are not necessary. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Roland Vossen authored
Removed a function parameter since it was redundant. Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Remove unnecessary global variable Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Remove unnecessary global variable Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Use constant values for packet filter configuration Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Remove brcmf_deferred_tx as it should be always 1 Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Replaced the global variable with macro. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Franky Lin authored
Dead code removal. Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Julia Lawall authored
Sizeof a pointer-typed expression returns the size of the pointer, not that of the pointed data. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression *e; type T; identifier f; @@ f(...,(T)e,..., -sizeof(e) +sizeof(*e) ,...) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix long function prototypes and line up arguments nicely. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Fix indent of function arguments. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Line up integer constant with others. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Replace :? operator by equivalent if-else statement where in improves readability. Don't add else branch if it is not needed. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Delete braces around single statements. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-
Leonid V. Fedorenchik authored
Change indent with spaces to tabs. Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-