- 04 Oct, 2015 35 commits
-
-
Shraddha Barke authored
Use module_platform_driver for drivers whose init and exit functions only register and unregister, respectively. Thus remove some boilerplate code. A simplified version of Coccinelle patch - @A@ identifier f, x; @@ -static f(...) { return platform_driver_register(&x); } @b depends on a@ identifier e, a.x; @@ -static e(...) { platform_driver_unregister(&x); } @c depends on a && b@ identifier a.f; declarer name module_init; @@ -module_init(f); @d depends on a && b && c@ identifier b.e, a.x; declarer name module_exit; declarer name module_platform_driver; @@ -module_exit(e); +module_platform_driver(x); Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Aybuke Ozdemir authored
Use ! operating instead of NULL checks. Addresses "CHECK: Comparison to NULL" from checkpatch.pl. Signed-off-by:
Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
-
Ksenija Stanojevic authored
Struct timespec will overflow in year 2038, here it will not cause an overflow because it is used with timespec_sub, but still has to be removed as part of y2038 changes. Replace it with ktime_t. Also use monotonic instead of real-time by replacing functions getnstimeofday with ktime_get. Signed-off-by:
-
Salah Triki authored
Reads of dgnc_poll_tick are protected by dgnc_poll_lock spinlock, but the write to dgnc_poll_tick is not. It could theoretically race. Signed-off-by:
Salah Triki <salah.triki@acm.org> Signed-off-by:
-
Sudip Mukherjee authored
The dgnc_init_globals() function is only initializing the timer so initialize it directly and remove dgnc_init_globals() and change the comment appropriately. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Sudip Mukherjee authored
globals variable will be initialied to 0 and the global pointers will be to NULL. No need to initialize them separately. Signed-off-by:
-
Sudip Mukherjee authored
This NULL test is not required as iounmap will validate the argument. Signed-off-by:
-
Sudip Mukherjee authored
Change the NULL comparison style as warned by checkpatch. Signed-off-by:
-
Sudip Mukherjee authored
These variables were only assigned some values but were never used. Signed-off-by:
-
Cristina Moraru authored
Fix 'line over 80 characters' checkpatch warning Signed-off-by:
Cristina Moraru <cristina.moraru09@gmail.com> Signed-off-by:
-
Cristina Moraru authored
Fix 'No description found for parameter' kernel-doc warnings Signed-off-by:
-
Shraddha Barke authored
Remove dump_exports and print_export_data as they are defined but not used anywhere. Signed-off-by:
-
Rocco Folino authored
This patch fixes the warning generated by sparse: "symbol 'nrs_policy_get_info_locked' was not declared. Should it be static?" by declaring the function static. Signed-off-by:
Rocco Folino <rocco@devzen.net> Reviewed-by:
-
Shraddha Barke authored
Declare class_resolve_dev_name as static it is not used anywhere apart from this particular file.Also remove the declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare class_get_type and class_search_type as static since they are used only in this particular file. Also remove the declaration from header files. Signed-off-by:
-
Shraddha Barke authored
Declare class_add_conn, class_add_profile, class_cleanup, class_config_parse_rec, class_del_conn, class_detach, class_match_param, class_attach, class_setup as static since they are used only in this particular file. Also remove the corresponding declarations from header files. Signed-off-by:
-
Shraddha Barke authored
Declare cl_lock_intransit and cl_lock_extransit as static since they are used only in this particular file. Signed-off-by:
-
Shraddha Barke authored
Declare cl_page_list_assume, cl_io_cancel, cl_io_rw_advance, cl_page_list_del, cl_page_list_discard, cl_page_list_fini as static since they are used only in this particular file. Also remove them from corresponding header files Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_parse_rule as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_req_replace_dead_ctx as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_rule_set_choose as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_rule_set_expand as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_rule_set_free as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_rule_set_merge as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
Cristina Moraru authored
Fix 'cannot understand function prototype' and 'No description found for parameter' kernel-doc warnings by replacing /** with /* in regular comments Signed-off-by:
-
Cristina Moraru authored
Fix 'No description found for parameter 'prot_mask'' and 'Excess struct/union/enum/typedef member 'prot_masks' description in 'ashmem_area'' warnings by removing typo Signed-off-by:
-
Hugo Camboulive authored
This patch to ad7746.c makes the comment block end with a */ on a separate line. Signed-off-by:
Hugo Camboulive <hugo.camboulive@gmail.com> Signed-off-by:
-
Ioana Ciornei authored
Use devm_iio_device_register instead of iio_device_register when the remove function is only used to call iio_device_unregister in order to ease the error path. Since resource managed functions implicitly call unregister at driver detach also remove iio_device_unregister Signed-off-by:
Ioana Ciornei <ciorneiioana@gmail.com> Signed-off-by:
-
Ioana Ciornei authored
Replace iio_device_register with resource managed devm_iio_device_register in order to ease the error path. Also delete the remove function since there is no need after this change. Signed-off-by:
-
Ioana Ciornei authored
Replace iio_device_register with resource managed devm_iio_device_register in order to ease the error path. Also delete de remove function since there is no need after this change. Signed-off-by:
-
Maciek Borzecki authored
Replace memcmp() with ether_addr_equal(). In every location where the replacement was done, the addresses accessed are __aligned(2). Structures accessed either stack or heap allocated, no direct memory casts to possibly unaligned structs are used. Involved structures: typedef struct hfa384x_authenticateStation_data { u8 address[ETH_ALEN]; /* 0 offset */ ... } __packed hfa384x_authenticateStation_data_t; struct prism2sta_authlist { unsigned int cnt; u8 addr[WLAN_AUTH_MAX][ETH_ALEN]; /* 4 bytes offset, addresses start at u16 boundary */ u8 assoc[WLAN_AUTH_MAX]; }; struct prism2sta_accesslist { unsigned int modify; unsigned int cnt; u8 addr[WLAN_ACCESS_MAX][ETH_ALEN]; /* 8 bytes offset, multiple of u16 */ ... u8 addr1[WLAN_ACCESS_MAX][ETH_ALEN]; /* starts at u32 boundary, struct not packed */ }; typedef struct hfa384x_AssocStatus { u16 assocstatus; u8 sta_addr[ETH_ALEN]; /* 2 bytes offset, struct is packed */ u8 old_ap_addr[ETH_ALEN]; /* 8 bytes offset */ ... } __packed hfa384x_AssocStatus_t; The patch resolves the following checkpatch warnings: WARNING: Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() Signed-off-by:Maciek Borzecki <maciek.borzecki@gmail.com> Signed-off-by:
-
- 02 Oct, 2015 5 commits
-
-
Chaehyun Lim authored
This patch replaces u8CurrChannel with curr_channel to avoid camelcase. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch replaces s32Error with result to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch changes data type of s32Error variable from s32 to int because return type of this function is int. Signed-off-by:
-
Chaehyun Lim authored
This patch removes blank line after open brace '{' found by checkpatch.pl CHECK: Blank lines aren't necessary after an open brace '{' drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:664: Signed-off-by: -
Chaehyun Lim authored
This patch replaces int8_t with int. The int8_t should be int. It's used as an index into an array or -1 for not found. Suggested-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
