- 09 Mar, 2017 40 commits
-
-
Samuel Thibault authored
This extends the synth buffer slots to 16bit, so as to hold 16bit unicode characters. synth_buffer_getc and synth_buffer_peek now return 16bit characters. Speech synthesizers which do not support characters beyond latin1 can use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1 characters before getting or peeking. All synthesizers are made to use it for now. This makes synth_buffer_add take a 16bit character. For simplicity for now, synth_printf is left to using latin1 formats and strings. synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are however added to put 16bit characters and strings. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Reviewed-by:
Chris Brannon <chris@the-brannons.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Gargi Sharma authored
module.h contains a call to moduleparam.h making the call to it redundant and useless. @ includesmodule @ @@ #include <linux/module.h> @ depends on includesmodule @ @@ - #include <linux/moduleparam.h> Signed-off-by:
Gargi Sharma <gs051095@gmail.com> Signed-off-by:
-
Varsha Rao authored
Variable ip_addr is already declared as pointer to u8. Again explicit type casting of ip_addr to u8, is not required. Hence this patch removes it by using the following coccinelle script. @@ type T; T *ptr,p; @@ ( - (T *)(&p) + &p | - (T *)ptr + ptr | - (T *)(ptr) + ptr | - (T)(p) + p ) Signed-off-by:
Varsha Rao <rvarsha016@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Tahia Khan authored
Removing 6 continue statements from a while loop. The continue statements are redundant here since control already returns to the beginning of the loop upon exit of any of the conditional blocks. Found using Coccinelle. Signed-off-by:
Tahia Khan <tahia.khan@gmail.com> Acked-by:
-
Tahia Khan authored
Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_gnrl_info_received. Signed-off-by:
-
Tahia Khan authored
Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_network_info_received. Signed-off-by:
-
Tahia Khan authored
Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_scan_complete_received. Signed-off-by:
-
Georgios Emmanouil authored
Added blank line after function and modified comment style. Signed-off-by:
Georgios Emmanouil <geo.emmnl@gmail.com> Reviewed-by:
Julian Calaby <julian.calaby@gmail.com> Signed-off-by:
-
Georgios Emmanouil authored
Fixed spelling error. 'unkmown' to 'unknown'. Signed-off-by:
-
Georgios Emmanouil authored
Fixed comment style to the preferred kernel comment style. Signed-off-by:
-
Georgios Emmanouil authored
Modified comment style to preferred kernel comment style. Signed-off-by:
-
Georgios Emmanouil authored
Removed unnecessary 'if' statement and integrated the condition to the previous 'if' statement. Signed-off-by:
-
Georgios Emmanouil authored
Removed unnecessary blank line. Signed-off-by:
-
Sreya Mittal authored
Fix the checkpatch issue: Alignment should match open parenthesis Signed-off-by:
Sreya Mittal <sreyamittal5@gmail.com> Signed-off-by:
-
Tamara Diaconita authored
Comparison to NULL is not necessary because 'if' statement tests if 'synth' is NULL anyway. Delete comparison in 'if' structure to fix the checkpath.pl issue : CHECK: Comparison to NULL could be written 'synth'. Signed-off-by:
Tamara Diaconita <diaconita.tamara@gmail.com> Signed-off-by:
-
Tamara Diaconita authored
Put a part from the headers of some functions in a new line to have less than 80 characters. Fixed the checkpath.pl issue: CHECK: line over 80 characters. Signed-off-by:
-
Tamara Diaconita authored
Fixed the checkpath.pl issue: CHECK: Aligment should match open paranthesis. Added and deleted spaces and tabs to align the code. Signed-off-by:
-
Tamara Diaconita authored
Delet the blank line after an open brace '{' to fix the checkpath.pl issue: CHECK: Blank lines aren't necessary after an open brace '{'. Signed-off-by: -
Tamara Diaconita authored
Added a space after multiple casts to fix the checkpath.pl issue: CHECK: No space is necessary after a cast. Signed-off-by:
-
simran singhal authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
simran singhal <singhalsimran0@gmail.com> Acked-by:
-
Tamara Diaconita authored
Fixed the following checkpath.pl issue: CHECK: alignment should match open paranthesis. Deleted a tab and added spaces to align open paranthesis. Signed-off-by:
-
Tuomo Rinne authored
Fixed indentation to use tabs and aligned all the fields to same level. Signed-off-by:
Tuomo Rinne <tuomo.rinne@gmail.com> Signed-off-by:
-
Joe Perches authored
Using __printf allows the compiler to verify formats and arguments. Use it and fix the single misuse found. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Arushi Singhal authored
Indentation should always use tabs and never spaces. Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by:
-
Varsha Rao authored
Members of nbu2ss_udc structure can change device state, maintain completion state and control driver. Also provide access to read and write to register. Hence, exclusive access to nbu2ss_udc is required. The lock variable of type spinlock_t guarantees the exclusive access and protects it. In this patch, comment is added for spinlock_t definition, to fix the following checkpatch issue: CHECK: spinlock_t definition without comment Signed-off-by:
-
Arushi Singhal authored
New variable is added to make the code more readable. Signed-off-by:
-
Gargi Sharma authored
Declare ieee80211_qos_parameters structure constant it is only passed as src parameter to the function memcpy. The fields of def_qos_parameters structure are never modified and hence it can be declared as const. Coccinelle Script: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct ieee80211_qos_parameters i@p ={...}; @ok1@ identifier r1.i; position p; expression e1,e2; @@ memcpy(e1,&i@p,e2) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct ieee80211_qos_parameters i={...}; Signed-off-by: -
Ian Abbott authored
The `device_ids[]` passed to `MODULE_DEVICE_TABLE()` should be `const`. When the "ni_atmio" driver is built-in, gcc warns about `device_ids` being defined but ununsed. Make it `const`. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
There is no particular reason why comedi has to be built as kernel modules. Remove the `depends on m` from the Kconfig file to allow it to be built-in. Signed-off-by:
-
Cheah Kok Cheong authored
Change to unsigned to allow removal of negative value check in init section. Use smaller data type since the max possible value currently is 48. Signed-off-by:
Cheah Kok Cheong <thrust73@gmail.com> Reviewed-by:
-
Tobin C. Harding authored
Comment contains misspelled work 'Adress'. Correct spelling: Adress -> Address Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits WARNING: Comparisons should place the constant on the right side of the test. Move comparison constant to the right side of the test. Signed-off-by:
-
Tobin C. Harding authored
Checkpatch emits various warnings/errors pointing to misplaced spaces. - trailing whitespace - please, no spaces at the start of a line - please, no space before tabs - Unnecessary space before function pointer arguments - unnecessary whitespace before a quoted newline - code indent should use tabs where possible Remove all undesirable whitespace. Signed-off-by:
-
Tamara Diaconita authored
Split lines to have less than 80 characters. Fix the checkpatch.pl warning: WARNING: line over 80 characters. Signed-off-by:
-
Arushi Singhal authored
Unnecessary parentheses are removed as reported by checkpatch.pl to make coder nicer and to improve readability. Also coding style is improved as it's often nicer to read if &(foo[0]) is converted to foo like: memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by:
-
Michal Hocko authored
Lowmemory killer is sitting in the staging tree since 2008 without any serious interest for fixing issues brought up by the MM folks. The main objection is that the implementation is basically broken by design: - it hooks into slab shrinker API which is not suitable for this purpose. lowmem_count implementation just shows this nicely. There is no scaling based on the memory pressure and no feedback to the generic shrinker infrastructure. Moreover lowmem_scan is called way too often for the heavy work it performs. - it is not reclaim context aware - no NUMA and/or memcg awareness. As the code stands right now it just adds a maintenance overhead when core MM changes have to update lowmemorykiller.c as well. It also seems that the alternative LMK implementation will be solely in the userspace so this code has no perspective it seems. The staging tree is supposed to be for a code which needs to be put in shape before it can be merged which is not the case here obviously. Signed-off-by:
Michal Hocko <mhocko@suse.com> Signed-off-by:
-
Michael Zoran authored
vc04_services has an ioctl interface to dump arbitrary memory to a custom debug log. This is typically only needed by diagnostic tools, and can potentially be a security issue if the devtmpfs node doesn't have adequate permissions set. Since the ability to dump memory still has debugging value, create a new build configuration and disable the feature by default. Signed-off-by:
Michael Zoran <mzoran@crowfest.net> Signed-off-by:
-
Michael Zoran authored
This patch adds compatibility wrappers for the ioctls exposed by vchiq/vc04_services. The compat ioctls are completely implemented on top of the native ioctls. No existing lines are modified. While the ideal approach would be to cleanup the existing code, this path is simplier and easier to review. While it does have a small runtime performance penality vs seperating the existing code into wrapper+worker functions, the penality is small since only the metadata is copied back onto the 32 bit user mode stack. The on top of approach is the approach used by several existing performance critical subsystems of Linux such as the DRM 3D graphics subsystem. Testing: 1. A 32 bit chroot was created on a RPI 3 and vchiq_test was built for armhf. The usual tests were run such as vchiq_test -f 10 and vchiq_test -p. 2. This patch was copied onto the shipping version of the Linux kernel used for the RPI and that kernel was built for arm64. That kernel was used to boot Raspbian. Many of the builtin features are now functional such as the "hello_pi" examples, and minecraft_pi. Signed-off-by:
-
Michael Zoran authored
The camera driver passes messages back and forth between the firmware with requests and replies. One of the fields of the message header called context is a pointer so the size changes between 32 bit and 64 bit. The context field is used to pair reply messages from the firmware with request messages from the kernel. The simple solution would be to use the padding field for the upper 32 bits of pointers, but this would rely on the firmware always copying the pad field. So instead handles are generated that are 32 bit numbers and a mapping stored in a btree as implemented by the btree library in the kernel lib directory. The mapping pairs the handle with the pointer to the actual data. The btree library was chosen since it's very easy to use and red black trees would be overkill. The camera driver also now forces in the btree library if the camera is included in the build. The btree library is a hidden configuration option. Signed-off-by:
-
Michael Zoran authored
The camera driver passes messages back and forth between the firmware with requests and replies. One of the fields of the message header called control_service is a pointer so the size changes between 32 bit and 64 bit. Luckly, the field is not interperated by the driver, so it can be changed to a u32 which has a fixed size. Signed-off-by:
-
