- 10 Jun, 2019 9 commits
-
-
Hariprasad Kelam authored
This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf" + if (pxmitbuf->pallocated_buf == NULL) Signed-off-by:
Hariprasad Kelam <hariprasad.kelam@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Hariprasad Kelam authored
In halbtc8723b2ant_TdmaDurationAdjust function,below piece of code is repeated many times. halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val); pCoexDm->psTdmaDuAdjType = val; So replace the same with "HAL_BTC8723B2ANT_DMA_DURATION_ADJUST" MACRO. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
Simon Sandström <simon@nikanor.nu> Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Naoto Kobayashi authored
Since whitespace should not appear between asterisk and variable name in a declaration statement, remove it and fix checkpatch.pl error "foo * bar" should be "foo *bar". Signed-off-by:
Naoto Kobayashi <naoto.kobayashi4c@gmail.com> Signed-off-by:
-
YueHaibing authored
Fix gcc build error while CONFIG_REGMAP_MMIO is not set drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe': arcx-anybus.c: undefined reference to `__devm_regmap_init_mmio_clk' Select REGMAP_MMIO to fix it. Reported-by:
Hulk Robot <hulkci@huawei.com> Fixes: 2411a336 ("staging: fieldbus: arcx-anybus: change custom -> mmio regmap") Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Reviewed-by:
Sven Van Asbroeck <TheSven73@gmail.com> Signed-off-by:
-
- 09 Jun, 2019 15 commits
-
-
Harold André authored
Fixed a coding style issue. Signed-off-by:
Harold André <harold.andre@gmx.fr> Signed-off-by:
-
Hao Xu authored
add space after , for #define outb_p(d,a) writeq(d,(void *)a) Signed-off-by:
Hao Xu <haoxu.linuxkernel@gmail.com> Signed-off-by:
-
Hao Xu authored
modify void* to void * for #define inb_p(a) readq((void*)a) and #define outb_p(d,a) writeq(d,(void*)a) Signed-off-by:
-
Hariprasad Kelam authored
DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. replace BUG_ON with DBG_BUGON. Signed-off-by:
Gao Xiang <gaoxiang25@huawei.com> Signed-off-by:
-
Hariprasad Kelam authored
fix below warnings reported by coccicheck drivers/staging/erofs/unzip_vle.c:332:11-18: WARNING: Comparison to bool Signed-off-by:
-
Colin Ian King authored
In the default event case switchdev_work is being leaked because nothing is queued for work. Fix this by kfree'ing switchdev_work before returning NOTIFY_DONE. Addresses-Coverity: ("Resource leak") Fixes: 44baaa43 ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove function rtw_free_network_nolock, as all it does is call _rtw_free_network_nolock, and rename _rtw_free_network_nolock to rtw_free_network_nolock. Keep the new rtw_free_network_nolock a static function and remove the old version from the header file. Signed-off-by:
Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove leading 'p' from the names of the following pointer variables: - padapter - precvbuf - pintfhdl - pregistrypriv - precvpriv. Issue found with Coccinelle. Signed-off-by: -
Nishka Dasgupta authored
Remove leading 'p' from the names of the following pointer variables: - pintfhdl - pintf_hdl (renamed to intfhdl in keeping with the convention in other functions) - poption - pops - pintfpriv. Issue found with Coccinelle. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading p from the names of the following pointer variables: - padapter - pxmitpriv - pnetdev - pxmitframe. Issue found with Coccinelle. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading p from the following pointer variable names: - padapter - pmlmepriv - precv_frame - precvpriv - pfree_recv_queue - pattrib. Issue found with Coccinelle Signed-off-by:
-
Nishka Dasgupta authored
Remove the leading p from the following pointer variable names: - padapter - pusb_intf - ppmappedfw - praw - pfwpriv - pdvobj - pregpriv - pmappedfw (not in the same scope as ppmappedfw) - ptmpchar - ppayload - ptx_desc Issue found with Coccinelle. Signed-off-by:
-
Shobhit Kukreti authored
coccicheck reported Unneeded variable ret at rtl8723bs/core/rtw_ap.c:1400. Function "rtw_acl_remove_sta" always returns 0. Modified return type of the function to void. Signed-off-by:
Shobhit Kukreti <shobhitkukreti@gmail.com> Reviewed-by:
Bastien Nocera <hadess@hadess.net> Signed-off-by:
-
Shobhit Kukreti authored
Cleaned up the code to remove the error "(foo*)" should be "(foo *)" reported by checkpatch from the file rtl8723bs/os_dep/ioctl_linux.c Signed-off-by:
-
Maxime Desroches authored
Remove braces in a single line if statement in the vchiq_core.c file Signed-off-by:
Maxime Desroches <desroches.maxime@gmail.com> Signed-off-by:
-
- 06 Jun, 2019 16 commits
-
-
Geordan Neukum authored
The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void *) when invoking readq and writeq which both take a (void __iomem *) arg. There is no need for this cast, and it actually harms us by discarding the sparse cookie, __iomem. Make the driver stop performing this casting operation. Signed-off-by:
Geordan Neukum <gneukum1@gmail.com> Signed-off-by:
-
Geordan Neukum authored
The kpc_spi driver stashes off an unsigned long representation of the i/o mapping returned by devm_ioremap_nocache(). This is unnecessary, as the only use of the unsigned long repr is to eventually be re-cast to an (u64 __iomem *). Instead of casting the (void __iomem *) to an (unsigned long) then a (u64 __iomem *), just remove this intermediate step. As this intermediary is no longer used, also remove it from its structure. Signed-off-by:
-
Geordan Neukum authored
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named chip_select which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by:
-
Geordan Neukum authored
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named word_len which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by:
-
Geordan Neukum authored
The structure kpc_spi, defined in in the kpc2000_spi driver, contains a member named pin_dir which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by:
-
Geordan Neukum authored
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named phys which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by:
-
Fabio Estevam authored
In order to print a 'size_t' type the '%zu' specifier needs to be used. Change it accordingly in order to fix the following build warning: drivers/staging/kpc2000/kpc_dma/fileops.c:57:35: warning: format '%ld' expects argument of type 'long int', but argument 8 has type 'size_t {aka unsigned int}' [-Wformat=] Reported-by:Build bot for Mark Brown <broonie@kernel.org> Signed-off-by:
Fabio Estevam <festevam@gmail.com> Signed-off-by:
-
Fabio Estevam authored
In order to print a 'long long int' type the 'llx' specifier needs to be used. Change it accordingly in order to fix the following build warning: drivers/staging/kpc2000/kpc2000/core.c:245:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'long long int' [-Wformat=] Reported-by:
-
Valerio Genovese authored
This was reported by sparse: drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:39:7: warning: symbol 'kpc_dma_add_device ' was not declared. Should it be static? Signed-off-by:
Valerio Genovese <valerio.click@gmail.com> Signed-off-by:
-
George G. Davis authored
Fix the following typos: "comoponent" -> "component" "communiction" -> "communication" Cc: Jiri Kosina <trivial@kernel.org> Signed-off-by:
George G. Davis <george_davis@mentor.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove function r8712_free_network_queue, as it does nothing but call _free_network queue; rename _free_network_queue to r8712_free_network_queue to enable continued functionality; change the type of r8712_free_network_queue (formerly _free_network_queue) from static to non-static to match the type of the old r8712_free_network_queue. Signed-off-by:
-
Nishka Dasgupta authored
Remove initialisation of return variable as it is never used. Issue found with Coccinelle. Signed-off-by:
-
Hariprasad Kelam authored
this patch fixes below Errors reported by checkpatch ERROR: do not initialise globals to 0 +u8 g_fwdl_chksum_fail = 0; ERROR: do not initialise globals to 0 +u8 g_fwdl_wintint_rdy_fail = 0; Signed-off-by:
-
Simon Sandström authored
Step 11 was removed from kp2000_pcie_probe in a previous commit but the comment was not changed to reflect this, so do it now. Signed-off-by:
-
Simon Sandström authored
Fixes checkpatch.pl warning "Prefer kzalloc(sizeof(*pcard)...) over kzalloc(sizeof(struct kp2000_device)...)". Signed-off-by:
-
Simon Sandström authored
Fixes checkpatch.pl warning "Use #include <linux/io.h> instead of <asm/io.h>". Signed-off-by:
-
