- 04 Feb, 2022 15 commits
-
-
Christoph Hellwig authored
Replace open coded bio_clone_fast implementations with the actual helper. Note that the bio allocated as part of the dm_io structure in alloc_io will only actually be used later in alloc_tio, making this earlier cloning of the information safe. Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
Mike Snitzer <snitzer@redhat.com> Link: https://lore.kernel.org/r/20220202160109.108149-12-hch@lst.deSigned-off-by:
Jens Axboe <axboe@kernel.dk>
-
Christoph Hellwig authored
__bio_clone_fast should also clone integrity and crypto data, as a clone without those is incomplete. Right now the only caller that can actually support crypto and integrity data (dm) does it manually for the one callchain that supports these, but we better do it properly in the core. Note that all callers except for the above mentioned one also don't need to handle failure at all, given that the integrity and crypto clones are based on mempool allocations that won't fail for sleeping allocations. Signed-off-by:
-
Christoph Hellwig authored
Fold __remap_to_origin_clear_discard into the two callers to prepare for bio cloning refactoring. Signed-off-by:
-
Christoph Hellwig authored
Most targets just need a single flush bio. Open code that case in __send_duplicate_bios without the need to add the bio to a list. Signed-off-by:
-
Christoph Hellwig authored
Return the clone bio embedded into the tio as that is what the callers actually want. Similar for the free side. Signed-off-by:
-
Christoph Hellwig authored
This simplifies the callers a bit. Signed-off-by:
-
Christoph Hellwig authored
Move the call to __bio_clone_fast and the assignment of ->len_ptr from the callers into alloc_tio to prepare for changes to the bio clone API. Signed-off-by:
-
Christoph Hellwig authored
Fold __send_duplicate_bios into its only caller to prepare for refactoring. Signed-off-by:
-
Christoph Hellwig authored
Fold clone_bio into its only caller to prepare for refactoring. Signed-off-by:
-
Christoph Hellwig authored
Add a helper to stop open coding the container_of operations to get from the clone bio to the tio structure. Signed-off-by:
-
Christoph Hellwig authored
Make sure the newly allocated bio has the correct bi_bdev set from the start. Signed-off-by:
-
Christoph Hellwig authored
Call bio_associate_blkg just like bio_set_dev did in the callers before the conversion to set the block device in bio_reset. Fixes: a7c50c94 ("block: pass a block_device and opf to bio_reset") Reported-by: syzbot+2b3f18414c37b42dcc94@syzkaller.appspotmail.com Tested-by: syzbot+2b3f18414c37b42dcc94@syzkaller.appspotmail.com Signed-off-by:
Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by:
-
Song Liu authored
The new error message for such case looks like [ 172.809565] device offline error, dev sda, sector 3138208 ... which will not be confused with regular I/O error (BLK_STS_IOERR). Reviewed-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
Song Liu <song@kernel.org> Reviewed-by:
Martin K. Petersen <martin.petersen@oracle.com> Link: https://lore.kernel.org/r/20220203192827.1370270-4-song@kernel.orgSigned-off-by:
-
Song Liu authored
Change the user visible return value for BLK_STS_OFFLINE to -ENODEV, which is more descriptive than existing -EIO. Signed-off-by:
-
Song Liu authored
Currently, drivers reports BLK_STS_IOERR for devices that are not full online or being removed. This behavior could cause confusion for users, as they are not really I/O errors from the device. Solve this issue with a new state BLK_STS_OFFLINE, which reports "device offline error" in dmesg instead of "I/O error". EIO is intentionally kept to not change user visible return value. Signed-off-by:
-
- 02 Feb, 2022 25 commits
-
-
Dan Carpenter authored
This code triggers a Smatch warning: fs/ntfs3/fsntfs.c:1606 ntfs_bio_fill_1() warn: variable dereferenced before check 'bio' (see line 1591) The "bio" pointer cannot be NULL so there is no need to check. Originally there was more extensive NULL checking but it was removed because bio_alloc() will never fail if it is allowed to sleep. Remove this check as well. Fixes: 39146b6f ("ntfs3: remove ntfs_alloc_bio") Signed-off-by:Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
-
Jiapeng Chong authored
Return statements in functions returning bool should use true/false instead of 1/0. ./block/bio.c:1081:9-10: WARNING: return of 0/1 in function 'bio_add_folio' with return type bool. Reported-by:
Abaci Robot <abaci@linux.alibaba.com> Signed-off-by:
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by:
-
Christoph Hellwig authored
bio.h is part of the block layer, so list it in the MAINTAINERS file as such. Signed-off-by:
-
Christoph Hellwig authored
Document the actually existing parameter name. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
Christoph Hellwig authored
Rename blk_flush_plug to __blk_flush_plug and add a wrapper that includes the NULL check instead of open coding that check everywhere. Signed-off-by:
-
Christoph Hellwig authored
blk_needs_flush_plug fails to account for the cb_list, which needs flushing as well. Remove it and just check if there is a plug instead of poking into the internals of the plug structure. Signed-off-by:
-
Christoph Hellwig authored
Pass the block_device that we plan to use this bio for and the operation to bio_reset to optimize the assigment. A NULL block_device can be passed, both for the passthrough case on a raw request_queue and to temporarily avoid refactoring some nasty code. Signed-off-by:
-
Christoph Hellwig authored
Pass the block_device that we plan to use this bio for and the operation to bio_init to optimize the assignment. A NULL block_device can be passed, both for the passthrough case on a raw request_queue and to temporarily avoid refactoring some nasty code. Signed-off-by:
-
Christoph Hellwig authored
Pass the block_device and operation that we plan to use this bio for to bio_alloc to optimize the assignment. NULL/0 can be passed, both for the passthrough case on a raw request_queue and to temporarily avoid refactoring some nasty code. Also move the gfp_mask argument after the nr_vecs argument for a much more logical calling convention matching what most of the kernel does. Signed-off-by:
-
Christoph Hellwig authored
Pass the block_device and operation that we plan to use this bio for to bio_alloc_kiocb to optimize the assigment. Signed-off-by:
-
Christoph Hellwig authored
Pass the block_device and operation that we plan to use this bio for to bio_alloc_bioset to optimize the assigment. NULL/0 can be passed, both for the passthrough case on a raw request_queue and to temporarily avoid refactoring some nasty code. Also move the gfp_mask argument after the nr_vecs argument for a much more logical calling convention matching what most of the kernel does. Signed-off-by:
-
Chaitanya Kulkarni authored
All callers need to set the block_device and operation, so lift that into the common code. Signed-off-by:
-
Christoph Hellwig authored
Keep blk_next_bio next to the core bio infrastructure. Signed-off-by:
-
Christoph Hellwig authored
Remove handling of NULL returns from sleeping bio_alloc calls given that those can't fail. Signed-off-by:
-
Christoph Hellwig authored
Only the priv field of rnbd_dev_blk_io is used, so store the value of that in bio->bi_private directly and remove the entire bio_set overhead. Signed-off-by:
Jack Wang <jinpu.wang@ionos.com> Link: https://lore.kernel.org/r/20220124091107.642561-12-hch@lst.deSigned-off-by:
-
Christoph Hellwig authored
The memory mapped in process_rdma is contiguous, so there is no need to loop over bio_add_page. Remove rnbd_bio_map_kern and just open code the bio allocation and mapping in the caller. Signed-off-by:
Jack Wang <jinpu.wang@ionons.com> Tested-by:
-
Christoph Hellwig authored
Remove handling of NULL returns from sleeping bio_alloc calls given that those can't fail. Signed-off-by:
-
Christoph Hellwig authored
Use blkdev_issue_flush, which uses an on-stack bio instead of an opencoded version with a bio embedded into struct pool. Signed-off-by:
-
Christoph Hellwig authored
Use blkdev_issue_flush, which uses an on-stack bio instead of an opencoded version with a bio embedded into struct dm_snapshot. Signed-off-by:
-
Christoph Hellwig authored
Just open code it next to the bio allocations, which saves a few lines of code, prepares for future changes and allows to remove the duplicate bi_opf assignment for the bio_clone_fast case in kcryptd_io_read. Signed-off-by:
-
Christoph Hellwig authored
Remove handling of NULL returns from sleeping bio_alloc calls given that those can't fail. Signed-off-by:
-
Christoph Hellwig authored
bio_alloc will never fail if it is allowed to sleep, so there is no need for this loop. Also remove the __GFP_HIGH specifier as it doesn't make sense here given that we'll always fall back to the mempool anyway. Signed-off-by:
-
Christoph Hellwig authored
bio_alloc will never fail when it can sleep. Remove the now simple bl_alloc_init_bio helper and open code it in the only caller. Signed-off-by:
-
Christoph Hellwig authored
bio_alloc will never fail when it can sleep. Remove the now simple nilfs_alloc_seg_bio helper and open code it in the only caller. Signed-off-by:
-
Christoph Hellwig authored
open code mpage_alloc in it's two callers and simplify the results because of the context: - __mpage_writepage always passes GFP_NOFS and can thus always sleep and will never get a NULL return from bio_alloc at all. - do_mpage_readpage can only get a non-sleeping context for readahead which never sets PF_MEMALLOC and thus doesn't need the retry loop either. Both cases will never have __GFP_HIGH set. Signed-off-by:
-
