- 26 Jan, 2022 7 commits
-
-
Gustavo A. R. Silva authored
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows. Also, address the following sparse warnings: drivers/staging/unisys/visorinput/visorinput.c:409:27: warning: using sizeof on a flexible structure Link: https://github.com/KSPP/linux/issues/174Signed-off-by:
Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20220125223443.GA76937@embeddedorSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Arınç ÜNAL authored
Add pinctrl properties with rgmii1 & mdio pins under ethernet node which was wrongfully put under an external phy node. GMAC1 will start working with this fix. Link: https://lore.kernel.org/netdev/02ecce91-7aad-4392-c9d7-f45ca1b31e0b@arinc9.com/T/ Move GB-PC2 specific phy_external node to its own device tree. Reviewed-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
Arınç ÜNAL <arinc.unal@arinc9.com> Link: https://lore.kernel.org/r/20220125153903.1469-5-arinc.unal@arinc9.comSigned-off-by:
-
Arınç ÜNAL authored
Change phy-mode of gmac0 to trgmii to match the other side, port@6. Flow control needs to be enabled on both sides to work. It is already enabled on gmac0, enable it on port@6 too. Reviewed-by:
-
Arınç ÜNAL authored
Remove reg property from ports node to fix this warning: Warning (unit_address_vs_reg): /ethernet@1e100000/mdio-bus/switch0@0/ports: node has a reg or ranges property, but no unit name Another warning surfaces afterwards. Remove #address-cells and #size-cells from switch0@0 node to fix this warning: Warning (avoid_unnecessary_addr_size): /ethernet@1e100000/mdio-bus/switch0@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Reviewed-by:
-
Arınç ÜNAL authored
Fix formatting on mt7621.dtsi. Reviewed-by:
-
Paulo Miguel Almeida authored
add missing register constants present in RFM69 and/or RFM69HW so that we don't need to hardcode values when referencing them. this patch adds REG_TESTLNA, REG_TESTAFC constants Signed-off-by:
Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> Link: https://lore.kernel.org/r/20220124042636.GA7962@mail.google.comSigned-off-by:
-
Paulo Miguel Almeida authored
this driver relies on exposing a char device to userspace to tx messages. Every message can be sent using different trasmitter settings such so the tx_cfg must be written before sending any messages. Failing to do so will cause the message to fail silently depending on printk/dynamic_debug settings which makes it hard to troubleshoot. This patch add a control variable that will get initialized once tx_cfg is set for the fd used when interacting with the char device. Signed-off-by:
-
- 25 Jan, 2022 33 commits
-
-
Uwe Kleine-König authored
The two macros FBTFT_REGISTER_DRIVER and FBTFT_REGISTER_SPI_DRIVER contain quite some duplication: Both define an spi driver and an of device table and the differences are quite subtle. So create two new macros and use both twice. Signed-off-by:
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20220118181338.207943-2-u.kleine-koenig@pengutronix.deSigned-off-by:
-
Paulo Miguel Almeida authored
Max bit rate is dependent on which modulation is used. Previous validation routine only took into consideration min bit rate which can lead a misconfiguration of the rf69 chip causing the packets not to be sent/read. This patch enhances that input check in set_bit_rate to account for modulation values and their respective max bit rate Acked-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Paulo Miguel Almeida authored
There is an explicit dependency between modulation and bit rate configurations. To ensure proper validation of input value for the set_bit_rate routine, we must ensure that modulation has been set before. This patch ensures that set_modulation is always called before set_bit_rate for both RX and TX routines Acked-by:
-
Paulo Miguel Almeida authored
rf69 datasheets establishes that the minimum supported bit rate is 1.2 kbps regardless of modulation. this patch replaces the errouneous validation with the correct value Acked-by:
-
Stefan Wahren authored
There is no need to allocate the user service in case there is a VCHIQ connection required, but not available. So simply check the error conditions before doing an expensive memory allocation. Reviewed-by:
Nicolas Saenz Julienne <nsaenz@kernel.org> Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1642968143-19281-19-git-send-email-stefan.wahren@i2se.comSigned-off-by:
-
Stefan Wahren authored
In case of an invalid handle the function find_servive_by_handle returns NULL. So take care of this and avoid a NULL pointer dereference. Reviewed-by:
-
Stefan Wahren authored
vchiq_get_state() can return a NULL pointer. So handle this cases and avoid a NULL pointer derefence in vchiq_dump_platform_instances. Reviewed-by:
-
Stefan Wahren authored
Make vchiq_get_state return early with NULL and improve the readability. Reviewed-by:
-
Stefan Wahren authored
Don't try to open code min_t(). Reviewed-by:
-
Stefan Wahren authored
There is already a check for service->sync, so use this instead of a separate ternary operator to update the service state. Reviewed-by:
-
Stefan Wahren authored
This fixes some alignment found by checkpatch.pl. Reviewed-by:
-
Stefan Wahren authored
In order to improvement readability try to reduce the multi-line statements. Reviewed-by:
-
Stefan Wahren authored
The name of this static function is unnecessary longish. So drop the prefix. This gives us the chance to avoid some multi-line statements or fix some indentations later. Reviewed-by:
-
Stefan Wahren authored
The return statements aren't properly aligned. So fix this by using tabs. Reviewed-by:
-
Stefan Wahren authored
Better use kzalloc to properly init vchiq_service with zero. As a result this saves us all the zero assignments. Reviewed-by:
-
Stefan Wahren authored
The whole vchiq driver uses unsigned int for "localport" except of find_service_by_port(). So fix this and get the rid of this suspicous cast. Reviewed-by:
-
Stefan Wahren authored
Recently Arnd Bergmann noticed that the message handling looks broken to him. So add this point on the TODO list. Reviewed-by:
-
Stefan Wahren authored
This removes all already completed tasks from the TODO file. Reviewed-by:
-
Stefan Wahren authored
Keeping the order of the TODO items is hard and also unnecessary. So convert it to an unordered list. Suggested-by:
-
Stefan Wahren authored
The check for an adjacent block is hard to read. So move it into a separate inline function. Reviewed-by:
-
Stefan Wahren authored
There is no need for this static variable, so use the macro directly. Reviewed-by:
-
Stefan Wahren authored
This align the indentation in the var declaration of vchiq_log_dump_mem to the other code. Reviewed-by:
-
Vihas Mak authored
rtw_init_netdev_name() calls dev_alloc_name() which allocates the name for the device as per the given name format. The name format is specified by the module parameter "ifname". It returns a negative err code if the format is invalid. Handle this error appropriately. Cancel the timers ininitliazed by rtw_init_drv_sw() before calling rtw_free_drv_sw() and then proceed to free the adapter. Also, if register_netdev() fails then goto free_drv_sw instead of goto handle_dualmac. Reviewed-by:
Vihas Mak <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220123181734.10402-1-makvihas@gmail.comSigned-off-by:
-
Paulo Miguel Almeida authored
As a convention for the pi433 driver, all routines that deals with the rf69 chip are defined in the rf69.c file. There was an exception to the rule in which the uC version verification was being done directly elsewhere. While at it, the Version Register hardcoded value was replaced with a pre-existing constant in the driver. This patch adds rf69_get_version function to rf69.c Signed-off-by:
-
Martin Kaiser authored
rtl8188e_init_dm_priv is the only caller of Init_ODM_ComInfo_88E. Merge the two functions. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220122170547.68378-5-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
The ODM_RF_CALIBRATION flag is set in Init_ODM_ComInfo_88E directly after the driver is probed and it's never cleared. Remove the flag and the code where it's set or checked. Signed-off-by:
-
Martin Kaiser authored
The ODM_RF_TX_PWR_TRACK flag is set in Init_ODM_ComInfo_88E directly after the driver is probed and it's never cleared. Remove the flag and the one place where it's checked. Signed-off-by:
-
Martin Kaiser authored
The variable EntryMaxUndecoratedSmoothedPWDB in struct dm_priv is set but not used. Remove it. Signed-off-by:
-
Marcelo Aloisio da Silva authored
Remove unnecessary braces reported by checkpatch.pl in rtw_xmit.c. Signed-off-by:
Marcelo Aloisio da Silva <marcelo.as@aol.com> Link: https://lore.kernel.org/r/20220119034933.GA29744@snoopySigned-off-by:
-
Martin Kaiser authored
Remove the rtw_netif_stop_queue wrapper function. Call netif_tx_stop_all_queues directly. Signed-off-by:
-
Martin Kaiser authored
Remove the rtw_netif_start_queue wrapper function. Call netif_tx_start_all_queues directly. Signed-off-by:
-
Martin Kaiser authored
Remove the rtw_netif_wake_queue wrapper function. Call netif_tx_wake_all_queues directly. Signed-off-by:
-
Martin Kaiser authored
The _set_timer wrapper function takes a timeout in milliseconds. Call msecs_to_jiffies to convert the timeout to jiffies. Don't do the calculation ourselves. Signed-off-by:
-
