Commits · 94b080bc7005ad7be2519040410fdfef7345eb9d · Kirill Smelkov / linux

14 Apr, 2014 40 commits

staging: rtl8723au: Simplify retrieving the ether_type in portctrl() · 94b080bc

Jes Sorensen authored Apr 09, 2014

This renders the last element in include/ethernet.h unnecessary, so
remove it as well.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

94b080bc

staging: rtl8723au: Calling rtw_get_stainfo() with a NULL sta_addr will return NULL · 7d0d2b15

Jes Sorensen authored Apr 09, 2014

This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.

This bug seems to be present in multiple drivers provided by Realtek.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7d0d2b15

staging: rtl8723au: Fix case where ethtype was never obtained and always be checked against 0 · 514c485c

Jes Sorensen authored Apr 09, 2014

Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

514c485c

staging: rtl8723au: Use proper ETH_P_* types in rtw_recv.c · 7dd1e720

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7dd1e720

staging: rtl8723au: Call do_div() directly and get rid of unnecessary wrapper functions · f4337aa3
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f4337aa3

staging: rtl8723au: Fix build error due to bad commit 6c89f82 · 88cdc943

Larry Finger authored Apr 09, 2014

Two routines are missing includes of a necessary header.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

88cdc943

staging: rtl8723au: Remove unused bitshift() function · 6484767b

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6484767b

staging: rtl8723au: Remove a couple of unused prototypes · 9cd81fa6

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9cd81fa6

staging: rtl8723au: No need to include header files for unused circ_buf and old iwpriv bits · 8000d1c4
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8000d1c4
staging: rtl8723au: Remove unnecessary forward struct declarations from xmit_osdep.h · 458dc039
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
458dc039

staging: rtl8723au: Remove ugly pktfile interface · 4c9c5700

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4c9c5700

staging: rtl8723au: Don't use pktfile interface in rtw_xmitframe_coalesce23a() · 3e689a9f

Jes Sorensen authored Apr 09, 2014

The pktfil interface is horrible, no idea where it came from, but not
using it is a win.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3e689a9f

staging: rtl8723au: Make rtw_xmitframe_coalesce23a() more readable · 69a0f974

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

69a0f974

staging: rtl8723au: Fix update_attrib() and set_qos() to not use pktfile nonsense · e59cb424
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
e59cb424
staging: rtl8723au: Use proper ETH_P_* types instead of hard coded constants in rtw_xmit.c · 3483b8ae
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
3483b8ae
staging: rtl8723au: Fold rtw_remainder_len23a() into _rtw_open_pktfile23a() · f4f1cb92
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f4f1cb92

staging: rtl8723au: Remove last remnants of CONFIG_BR_EXT · 41ed2cb9

Jes Sorensen authored Apr 09, 2014

Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

41ed2cb9

staging: rtl8723au: rtw_report_sec_ie23a() is only called from rtw_mlme.c · 814a1d90

Jes Sorensen authored Apr 09, 2014

Move it there and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

814a1d90

staging: rtl8723au: Remove unused functions rtw_indicate_sta_{dis,}assoc_event23a() · 1eb66322
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
1eb66322
staging: rtl8723au: Fix hopeless brackets for declaring a variable mid-function · 90102edc
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
90102edc
staging: rtl8723au: Remove unnecessary memset() followed by a memcpy() into the same space · b319c6a3
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
b319c6a3
staging: rtl8723au: rtw_os_indicate_connect23a() is only called from one place - fold it in · 483557be
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
483557be

staging: rtl8723au: Don't wrap kill_pid() in an unnecessary macro · ce16d2f1

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ce16d2f1

staging: rtl8723au: Remove two layers of wrappers around rtw_cfg80211_indicate_scan_done() · 810c832f
Jes Sorensen authored Apr 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
810c832f

staging: rtl8723au: Remove #ifdef CONFIG_DEBUG_CFG80211 · 141bd353

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

141bd353

staging: rtl8723au: Remove unused is_boot_from_eeprom() macro · 3f58bf2e

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3f58bf2e

staging: rtl8723au: Remove obsolete HW_VARIABLES enum · ec21da46

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ec21da46

staging: rtl8723au: Kill off ugly GetHwReg*() interface · 0a449910

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0a449910

staging: rtl8723au: Eliminate HW_WAR_CHK_HI_QUEUE_EMPTY usage · 8d3fd614

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8d3fd614

staging: rtl8723au: Eliminate HW_VAR_FWLPS_RF_ON usage · 0cee8101

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0cee8101

staging: rtl8723au: Eliminate HW_VAR_RF_TYPE usage · c2370e83

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c2370e83

staging: rtl8723au: Improve some bad switch() formatting · b54e8804

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b54e8804

staging: rtl8723au: Remove empty function rtw_stassoc_hw_rpt23a() · f0758706

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f0758706

staging: rtl8723au: Remove SetHwReg*() related code · 891d3dec

Jes Sorensen authored Apr 09, 2014

Remove all references to this odd mux/demux pseudo hw register
handling code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

891d3dec

staging: rtl8723au: Remove calls to HW_VAR_H2C_MEDIA_STATUS · 3d577f60

Jes Sorensen authored Apr 09, 2014

This call was unhandled, so these calls were effectively a no-op
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3d577f60

staging: rtl8723au: Eliminate unused HW_VAR_TRIGGER_GPIO_0 · 4b03eb73

Jes Sorensen authored Apr 09, 2014

... and related functions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4b03eb73

staging: rtl8723au: Remove HW_VAR_TXPAUSE · aafb8684

Jes Sorensen authored Apr 09, 2014

This wasn't used at all
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

aafb8684

staging: rtl8723au: Remove HW_VAR_EFUSE_{BT_,}BYTES · a2342292

Jes Sorensen authored Apr 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a2342292

staging: rtl8723au: Remove HW_VAR_APFM_ON_MAC · 441ffea7

Jes Sorensen authored Apr 09, 2014

None of this was ever used, so pull it out together with related variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

441ffea7

staging: rtl8723au: Eliminate HW_VAR_DM_FLAG · df09df24

Jes Sorensen authored Apr 09, 2014

Both the read and write calls were never used
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

df09df24