- 12 Aug, 2021 1 commit
-
-
Dee-Jay Anthony Logozzo authored
Place the macro arguments within parentheses to avoid precedence issues. This solves the following checkpatch.pl warnings CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues +#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN) CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues +#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN) Signed-off-by:
Dee-Jay Anthony Logozzo <dj@djl.id.au> Link: https://lore.kernel.org/r/20210811134132.5240-1-dj@djl.id.auSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 11 Aug, 2021 12 commits
-
-
Tuo Li authored
The variable dev is checked in: if (dev) This indicates that it can be NULL. If so, a null-pointer dereference will occur: priv = rtllib_priv(dev); However, the value of priv is not used in the remaining part of this function. Thus the else-branch can be removed to fix this posible null-pointer dereference. Reported-by:
TOTE Robot <oslab@tsinghua.edu.cn> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Tuo Li <islituo@gmail.com> Link: https://lore.kernel.org/r/20210811031135.4110-1-islituo@gmail.comSigned-off-by:
-
Nathan Chancellor authored
After commit 71f09c5a ("staging: r8188eu: Remove wrapper around vfree"), the driver fails to build on Hexagon due to an implicit declaration in several different files: drivers/staging/r8188eu/core/rtw_mlme.c:129:3: error: implicit declaration of function 'vfree' [-Werror,-Wimplicit-function-declaration] vfree(pmlmepriv->free_bss_buf); ^ 1 error generated. Previously, vfree() was only called in osdep_service.c, which includes vmalloc.h for vmalloc() and vfree(). Now, the driver relies on vfree() getting implicitly included from another file. Hoist the vmalloc.h include from osdep_service.c to osdep_service.h so that the driver continues to build fine on all architectures. Fixes: 71f09c5a ("staging: r8188eu: Remove wrapper around vfree") Acked-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/r/20210811005505.3953122-1-nathan@kernel.orgSigned-off-by:
-
Yang Yingliang authored
A spin lock is taken in __nat25_db_network_insert() and update_BCNTIM() is called under spin lock so we should use GFP_ATOMIC in both place. Fixes: 15865124 ("staging: r8188eu: introduce new core dir for RTL8188eu driver") Reported-by:
Hulk Robot <hulkci@huawei.com> Reviewed-by:
Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20210810125314.2182112-1-yangyingliang@huawei.comSigned-off-by:
-
Larry Finger authored
The driver uses BITn instead of BIT(n). All such usage is converted. Note that this patch does not address any warnings that checkpatch will find. These include missing space around operators and lines that are too long. These problems will be addressed in a separate patch. Acked-by:
Phillip Potter <phil@philpotter.co.uk> Signed-off-by:
-
Phillip Potter authored
Remove the several lines from the Makefile that append EXTRA_CFLAGS options to silence build warnings about unused variables, unused functions and such like. This will enable cleanup of missed warnings, and easier spotting of future such problems. Acked-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Phillip Potter authored
Remove unused variable from rtw_init_recv_timer function in os_dep/recv_linux.c Acked-by:
-
Phillip Potter authored
Remove unused variable from rtw_init_drv_sw function in os_dep/os_intfs.c Acked-by:
-
Phillip Potter authored
Remove unused variable from the rtl8188e_init_dm_priv function in hal/rtl8188e_dm.c Acked-by:
-
Phillip Potter authored
Remove rtw_mfree_sta_priv_lock function from rtw_sta_mgt.c, as it does nothing and contains an unused variable. Acked-by:
-
Phillip Potter authored
Remove unused goto label from recv_indicatepkt_reorder function in core/rtw_recv.c Acked-by:
-
Phillip Potter authored
Remove unused oid_null_function function from include/rtw_ioctl.h Acked-by:
-
Phillip Potter authored
Remove unused functions that are now no longer called as a result of the removal of rtw_ioctl in a previous patch. This includes functions not directly called from rtw_ioctl, but anything in that specific call-chain. Acked-by:
-
- 10 Aug, 2021 27 commits
-
-
Phillip Potter authored
Remove rtw_ioctl function from os_dep/ioctl_linux.c, its declaration in include/osdep_intf.h, and finally its inclusion as the value of the .ndo_do_ioctl member of struct net_device_ops rtw_netdev_ops in os_dep/os_intfs.c. The e-mail from Arnd Bergmann at: https://lore.kernel.org/linux-next/CAK8P3a0WRMNmBmBDerZ0nWPdFZKALnxrj-uUFBkTP-MOtv48vg@mail.gmail.com explains the justification for this approach. Essentially, changes from net-next make the existing function and its use of SIOCDEVPRIVATE ioctls unworkable without changes. Functions called from rtw_ioctl that are now no longer accessible will be cleaned up in further patches. Additionally, once these changes have made their way downstream to the staging branch, we can modify and reconnect rtw_android_priv_cmd via ndo_siocdevprivate in struct net_device_ops. Suggested-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Michael Straube authored
Remove remaining unnecessary parentheses in core dir reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_cmd.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_ioctl_set.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_io.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_pwrctrl.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_recv.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_sta_mgt.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_xmit.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_mlme.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Clean up some comparsions to true/false to clear chackpatch warnings. WARNING: Unnecessary parentheses - maybe == should be = ? Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_p2p.c. Most of them reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_led.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_wlan_util.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_ap.c reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in core/rtw_mlme_ext.c. Most of them reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in the hal directory reported by checkpatch. Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in the os_dep directory reported by checkpatch. Signed-off-by:
-
Saurav Girepunje authored
Remove below unused static variable from os_intfs.c rtw_enusbss rtw_hwpdn_mode rtw_hwpwrp_detect Signed-off-by:
Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/20210807102232.6674-5-saurav.girepunje@gmail.comSigned-off-by:
-
Saurav Girepunje authored
Remove unused global variable channels from rtl_core.c Signed-off-by:
-
Martin Kaiser authored
We've deleted all RT_TRACE calls. The macro itself can now be removed as well. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210807153636.11712-13-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
The DEBUG_OID macro is not used and can be removed. Signed-off-by:
-
Martin Kaiser authored
Use the IW_HANDLER macro to declare the handler functions for wext ioctls. We don't have to skip unused ioctl numbers manually. The same modification was applied to the deprecated rtl8188eu driver in commit af249fce ("staging: rtl8188eu: use IW_HANDLER to declare wext handlers"). Signed-off-by:
-
Martin Kaiser authored
We should use the standard mechanism for debug prints. Remove the prints that use driver-specific macros. Signed-off-by:
-
Martin Kaiser authored
We should use the standard mechanism for debug prints. Remove the prints that use driver-specific macros. Signed-off-by:
-
Martin Kaiser authored
We should use the standard mechanism for debug prints. Remove a print that uses a driver-specific macro. Signed-off-by:
-
Martin Kaiser authored
We should use the standard mechanism for debug prints. Remove the prints that use driver-specific macros. Handle errors from dev_alloc_name in one place instead of showing a debug print. Signed-off-by:
-
