1. 02 Apr, 2021 16 commits
  2. 26 Mar, 2021 24 commits
    • Aditya Srivastava's avatar
      crypto: nx - fix incorrect kernel-doc comment syntax in files · 10cb823b
      Aditya Srivastava authored
      The opening comment mark '/**' is used for highlighting the beginning of
      kernel-doc comments.
      There are certain files in drivers/crypto/nx, which follow this syntax,
      but the content inside does not comply with kernel-doc.
      Such lines were probably not meant for kernel-doc parsing, but are parsed
      due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
      causes unexpected warnings from kernel-doc.
      
      E.g., presence of kernel-doc like comment in the header lines for
      drivers/crypto/nx/nx-sha256.c at header causes these warnings:
      "warning: Function parameter or member 'tfm' not described in 'nx_crypto_ctx_sha256_init'"
      "warning: expecting prototype for SHA(). Prototype was for nx_crypto_ctx_sha256_init() instead"
      
      Similarly for other files too.
      
      Provide a simple fix by replacing such occurrences with general comment
      format, i.e. '/*', to prevent kernel-doc from parsing it.
      Signed-off-by: default avatarAditya Srivastava <yashsri421@gmail.com>
      Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      10cb823b
    • Aditya Srivastava's avatar
      crypto: ux500 - fix incorrect kernel-doc comment syntax · ce668da5
      Aditya Srivastava authored
      The opening comment mark '/**' is used for highlighting the beginning of
      kernel-doc comments.
      There are certain files in drivers/crypto/ux500, which follow this syntax,
      but the content inside does not comply with kernel-doc.
      Such lines were probably not meant for kernel-doc parsing, but are parsed
      due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
      causes unexpected warnings from kernel-doc.
      
      E.g., presence of kernel-doc like comment in the header lines for
      drivers/crypto/ux500/cryp/cryp.h at header causes this warning:
      
      "warning: expecting prototype for ST(). Prototype was for _CRYP_H_() instead"
      
      Similarly for other files too.
      
      Provide a simple fix by replacing such occurrences with general comment
      format, i.e. '/*', to prevent kernel-doc from parsing it.
      Signed-off-by: default avatarAditya Srivastava <yashsri421@gmail.com>
      Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      ce668da5
    • Aditya Srivastava's avatar
      crypto: amcc - fix incorrect kernel-doc comment syntax in files · 73f04d3d
      Aditya Srivastava authored
      The opening comment mark '/**' is used for highlighting the beginning of
      kernel-doc comments.
      There are certain files in drivers/crypto/amcc, which follow this syntax,
      but the content inside does not comply with kernel-doc.
      Such lines were probably not meant for kernel-doc parsing, but are parsed
      due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
      causes unexpected warnings from kernel-doc.
      
      E.g., presence of kernel-doc like comment in
      drivers/crypto/amcc/crypto4xx_alg.c at header, and some other lines,
      causes these warnings by kernel-doc:
      
      "warning: expecting prototype for AMCC SoC PPC4xx Crypto Driver(). Prototype was for set_dynamic_sa_command_0() instead"
      "warning: Function parameter or member 'dir' not described in 'set_dynamic_sa_command_0'"
      etc..
      
      Provide a simple fix by replacing such occurrences with general comment
      format, i.e. '/*', to prevent kernel-doc from parsing it.
      Signed-off-by: default avatarAditya Srivastava <yashsri421@gmail.com>
      Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      73f04d3d
    • Aditya Srivastava's avatar
      crypto: vmx - fix incorrect kernel-doc comment syntax in files · dbb153c0
      Aditya Srivastava authored
      The opening comment mark '/**' is used for highlighting the beginning of
      kernel-doc comments.
      There are certain files in drivers/crypto/vmx, which follow this syntax,
      but the content inside does not comply with kernel-doc.
      Such lines were probably not meant for kernel-doc parsing, but are parsed
      due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
      causes unexpected warnings from kernel-doc.
      
      E.g., presence of kernel-doc like comment in the header line for
      drivers/crypto/vmx/vmx.c causes this warning by kernel-doc:
      
      "warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead"
      
      Similarly for other files too.
      
      Provide a simple fix by replacing such occurrences with general comment
      format, i.e. '/*', to prevent kernel-doc from parsing it.
      Signed-off-by: default avatarAditya Srivastava <yashsri421@gmail.com>
      Reviewed-by: default avatarDaniel Axtens <dja@axtens.net>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      dbb153c0
    • Weili Qian's avatar
      crypto: hisilicon/qm - add queue isolation support for Kunpeng930 · 8bbecfb4
      Weili Qian authored
      Kunpeng930 supports doorbell isolation to ensure that each queue
      has an independent doorbell address space.
      Signed-off-by: default avatarWeili Qian <qianweili@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      8bbecfb4
    • Weili Qian's avatar
      crypto: hisilicon/qm - set the number of queues for function · 6250383a
      Weili Qian authored
      Kunpeng930 supports queue doorbell isolation.
      When doorbell isolation is enabled, it supports to obtain the
      maximum number of queues of one function from hardware register.
      Otherwise, the 'max_qp_num' is the total number of queues.
      
      When assigning queues to VF, it is necessary to ensure that the number
      of VF queues does not exceed 'max_qp_num'.
      Signed-off-by: default avatarWeili Qian <qianweili@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      6250383a
    • Weili Qian's avatar
      crypto: hisilicon/qm - move 'CURRENT_QM' code to qm.c · c4392b46
      Weili Qian authored
      Since the code related to 'CURRENT_QM' debugfs is exactly same in
      sec/hpre/zip driver, move 'CURRENT_QM' to qm.c to reduce duplicate code.
      Signed-off-by: default avatarWeili Qian <qianweili@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      c4392b46
    • Weili Qian's avatar
      crypto: hisilicon/qm - set the total number of queues · 45bb26d9
      Weili Qian authored
      Move the configuration of the total number of queues 'ctrl_qp_num'
      from sec2/hpre/zip to qm.c. And get the total number of queues
      from the hardware register for Kunpeng930.
      Signed-off-by: default avatarWeili Qian <qianweili@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      45bb26d9
    • Hui Tang's avatar
      crypto: hisilicon/hpre - fix Kconfig · 7d156979
      Hui Tang authored
      hpre select 'CRYPTO_ECDH' and 'CRYPTO_CURVE25519'.
      Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      7d156979
    • Hui Tang's avatar
      crypto: hisilicon/hpre - fix "hpre_ctx_init" resource leak · 670fefb9
      Hui Tang authored
      When calling "hpre_ctx_set" fails, stop and put qp,
      otherwise will leak qp resource.
      Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      670fefb9
    • Hui Tang's avatar
      crypto: hisilicon - fix the check on dma address · a9214b0b
      Hui Tang authored
      System may be able to get physical address of zero if not reserved by
      firmware.
      
      The dma address obtained by 'dma_alloc_coherent' is valid, since already
      checking cpu va before, so do not check again.
      Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      a9214b0b
    • Hui Tang's avatar
      crypto: hisilicon/hpre - optimise 'hpre_algs_register' error path · ed48466d
      Hui Tang authored
      There is redundant code especially when registing new algorithms
      in the future.
      Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      ed48466d
    • Hui Tang's avatar
      crypto: hisilicon/hpre - delete wrap of 'CONFIG_CRYPTO_DH' · bbe6c4ba
      Hui Tang authored
      'CRYPTO_DH' has selected in 'Kconfig', so delete 'CONFIG_CRYPTO_DH'.
      Signed-off-by: default avatarHui Tang <tanghui20@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      bbe6c4ba
    • Meng Yu's avatar
      crypto: ecc - Correct an error in the comments · 0193b32f
      Meng Yu authored
      Remove repeated word 'bit' in comments.
      Signed-off-by: default avatarMeng Yu <yumeng18@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      0193b32f
    • Tong Zhang's avatar
      crypto: qat - ADF_STATUS_PF_RUNNING should be set after adf_dev_init · 8609f5cf
      Tong Zhang authored
      ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown()
      before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the
      vf2pf_lock is initialized in adf_dev_init(), which can fail and when it
      fail, the vf2pf_lock is either not initialized or destroyed, a subsequent
      use of vf2pf_lock will cause issue.
      To fix this issue, only set this flag if adf_dev_init() returns 0.
      
      [    7.178404] BUG: KASAN: user-memory-access in __mutex_lock.isra.0+0x1ac/0x7c0
      [    7.180345] Call Trace:
      [    7.182576]  mutex_lock+0xc9/0xd0
      [    7.183257]  adf_iov_putmsg+0x118/0x1a0 [intel_qat]
      [    7.183541]  adf_vf2pf_shutdown+0x4d/0x7b [intel_qat]
      [    7.183834]  adf_dev_shutdown+0x172/0x2b0 [intel_qat]
      [    7.184127]  adf_probe+0x5e9/0x600 [qat_dh895xccvf]
      Signed-off-by: default avatarTong Zhang <ztong0001@gmail.com>
      Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
      Fixes: 25c6ffb2 ("crypto: qat - check if PF is running")
      Acked-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      8609f5cf
    • Tong Zhang's avatar
      crypto: qat - don't release uninitialized resources · b66accaa
      Tong Zhang authored
      adf_vf_isr_resource_alloc() is not unwinding correctly when error
      happens and it want to release uninitialized resources.
      To fix this, only release initialized resources.
      
      [    1.792845] Trying to free already-free IRQ 11
      [    1.793091] WARNING: CPU: 0 PID: 182 at kernel/irq/manage.c:1821 free_irq+0x202/0x380
      [    1.801340] Call Trace:
      [    1.801477]  adf_vf_isr_resource_free+0x32/0xb0 [intel_qat]
      [    1.801785]  adf_vf_isr_resource_alloc+0x14d/0x150 [intel_qat]
      [    1.802105]  adf_dev_init+0xba/0x140 [intel_qat]
      Signed-off-by: default avatarTong Zhang <ztong0001@gmail.com>
      Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
      Fixes: dd0f3683 ("crypto: qat - Add qat dh895xcc VF driver")
      Acked-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      b66accaa
    • Lee Jones's avatar
      crypto: nitrox - Demote non-compliant kernel-doc headers · 5b0ef799
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/cavium/nitrox/nitrox_isr.c:17: warning: expecting prototype for One vector for each type of ring(). Prototype was for NR_RING_VECTORS() instead
       drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'irq' not described in 'nps_core_int_isr'
       drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'data' not described in 'nps_core_int_isr'
      
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      5b0ef799
    • Lee Jones's avatar
      crypto: nx - Repair some kernel-doc problems · d007bac1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key'
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key'
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key'
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead
       drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init'
       drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead
       drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format:  * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure
       drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync'
       drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync'
       drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync'
       drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead
       drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list'
      
      Cc: "Breno Leitão" <leitao@debian.org>
      Cc: Nayna Jain <nayna@linux.ibm.com>
      Cc: Paulo Flabiano Smorigo <pfsmorigo@gmail.com>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Kent Yoder <yoder1@us.ibm.com>
      Cc: linux-crypto@vger.kernel.org
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      d007bac1
    • Lee Jones's avatar
      crypto: vmx - Source headers are not good kernel-doc candidates · 32c2e6dd
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead
      
      Cc: "Breno Leitão" <leitao@debian.org>
      Cc: Nayna Jain <nayna@linux.ibm.com>
      Cc: Paulo Flabiano Smorigo <pfsmorigo@gmail.com>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Henrique Cerri <mhcerri@br.ibm.com>
      Cc: linux-crypto@vger.kernel.org
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      32c2e6dd
    • Lee Jones's avatar
      crypto: caam - Provide the name of the function and provide missing descriptions · 0beb2b60
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead
       drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx'
       drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx'
      
      Cc: "Horia Geantă" <horia.geanta@nxp.com>
      Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarHoria Geantă <horia.geanta@nxp.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      0beb2b60
    • Lee Jones's avatar
      crypto: atmel-ecc - Struct headers need to start with keyword 'struct' · 71057841
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/atmel-ecc.c:41: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx '
      
      Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Cc: linux-crypto@vger.kernel.org
      Cc: linux-arm-kernel@lists.infradead.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      71057841
    • Lee Jones's avatar
      crypto: keembay - Fix incorrectly named functions/structs · e2dcca6a
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
       drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead
       drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
       drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead
      
      Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
      Cc: Declan Murphy <declan.murphy@intel.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarDaniele Alessandrelli <daniele.alessandrelli@intel.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      e2dcca6a
    • Lee Jones's avatar
      crypto: ux500/hash - Fix worthy kernel-doc headers and remove others · 0368853e
      Lee Jones authored
      The ones remove here not only fail to conform to kernel-doc, but also
      provide no value, so let's remove them completely in this case.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/ux500/hash/hash_core.c:368: warning: Function parameter or member 'ctx' not described in 'hash_get_device_data'
       drivers/crypto/ux500/hash/hash_core.c:368: warning: Excess function parameter 'hash_ctx' description in 'hash_get_device_data'
       drivers/crypto/ux500/hash/hash_core.c:551: warning: expecting prototype for hash_init(). Prototype was for ux500_hash_init() instead
       drivers/crypto/ux500/hash/hash_core.c:592: warning: Function parameter or member 'length' not described in 'hash_processblock'
       drivers/crypto/ux500/hash/hash_core.c:1302: warning: expecting prototype for hash_update(). Prototype was for ahash_update() instead
       drivers/crypto/ux500/hash/hash_core.c:1322: warning: expecting prototype for hash_final(). Prototype was for ahash_final() instead
       drivers/crypto/ux500/hash/hash_core.c:1622: warning: Function parameter or member 'device_data' not described in 'ahash_algs_register_all'
       drivers/crypto/ux500/hash/hash_core.c:1622: warning: expecting prototype for hash_algs_register_all(). Prototype was for ahash_algs_register_all() instead
       drivers/crypto/ux500/hash/hash_core.c:1647: warning: Function parameter or member 'device_data' not described in 'ahash_algs_unregister_all'
       drivers/crypto/ux500/hash/hash_core.c:1647: warning: expecting prototype for hash_algs_unregister_all(). Prototype was for ahash_algs_unregister_all() instead
       drivers/crypto/ux500/cryp/cryp.c:19: warning: Incorrect use of kernel-doc format:  * cryp_wait_until_done - wait until the device logic is not busy
       drivers/crypto/ux500/cryp/cryp.c:22: warning: Function parameter or member 'device_data' not described in 'cryp_wait_until_done'
       drivers/crypto/ux500/cryp/cryp.c:22: warning: expecting prototype for ST(). Prototype was for cryp_wait_until_done() instead
       drivers/crypto/ux500/cryp/cryp.c:292: warning: Function parameter or member 'cryp_mode' not described in 'cryp_save_device_context'
       drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'device_data' not described in 'cryp_enable_irq_src'
       drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'irq_src' not described in 'cryp_enable_irq_src'
       drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: expecting prototype for ST(). Prototype was for cryp_enable_irq_src() instead
       drivers/crypto/ux500/cryp/cryp_core.c:42: warning: expecting prototype for ST(). Prototype was for CRYP_MAX_KEY_SIZE() instead
       drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'key' not described in 'cryp_ctx'
       drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'session_id' not described in 'cryp_ctx'
      
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Shujuan Chen <shujuan.chen@stericsson.com>
      Cc: Joakim Bech <joakim.xx.bech@stericsson.com>
      Cc: Berne Hebark <berne.herbark@stericsson.com>
      Cc: Niklas Hernaeus <niklas.hernaeus@stericsson.com>
      Cc: Jonas Linde <jonas.linde@stericsson.com>
      Cc: Andreas Westin <andreas.westin@stericsson.com>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      0368853e
    • Lee Jones's avatar
      crypto: chelsio - Fix some kernel-doc issues · 29e5b878
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/chelsio/chcr_core.c:2: warning: wrong kernel-doc identifier on line:
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Function parameter or member 'wrparam' not described in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'req' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'ctx' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'qid' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'op_type' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'req' not described in 'create_hash_wr'
       drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'param' not described in 'create_hash_wr'
      
      Cc: Ayush Sawal <ayush.sawal@chelsio.com>
      Cc: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
      Cc: Rohit Maheshwari <rohitm@chelsio.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Manoj Malviya <manojmalviya@chelsio.com>
      Cc: Atul Gupta <atul.gupta@chelsio.com>
      Cc: Jitendra Lulla <jlulla@chelsio.com>
      Cc: M R Gowda <yeshaswi@chelsio.com>
      Cc: Harsh Jain <harsh@chelsio.com>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      29e5b878