Commits · 9cb08ff32c386cda497f83635817cd328478a308 · Kirill Smelkov / linux

18 Jun, 2014 40 commits

staging: rtl8723au: cfg80211_rtw_connect(): Simplify ssid preparation · 9cb08ff3

Jes Sorensen authored Jun 09, 2014

Since we just matched sme->{ssid,ssid_len} to
pnetwork->network.Ssid.{ssid,ssid_len} we can simplify the copy and
move it to just before the call to rtw_set_ssid().
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9cb08ff3

staging: rtl8723au: cfg80211_rtw_connect(): Remove obfuscating pointers · 9ab98d42

Jes Sorensen authored Jun 09, 2014

dst_ssid and dst_bssid were just obfuscating that we were in fact
looking at pnetwork.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9ab98d42

staging: rtl8723au: cfg80211_rtw_connect(): Clean up various bits · c5178b0b

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c5178b0b

staging: rtl8723au: Move rtw_set_802_11_ssid23a() to ioctl_cfg80211.c · 97c4361d

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

97c4361d

staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect() · 39dbc446
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
39dbc446

staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from... · 7c0e0636

Jes Sorensen authored Jun 09, 2014

staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7c0e0636

staging: rtl8723au: Make rtw_is_same_ibss23a() return bool · ec36ce29

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ec36ce29

staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE · 7b2e06a1

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7b2e06a1

staging: rtl8723au: OnAuth23a(): Use ether_addr_copy() · ded7a20f

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ded7a20f

staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset() · 1ae17bf1
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
1ae17bf1

staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a() · 46805acb

Jes Sorensen authored Jun 09, 2014

Use _rtw_free_network23() so elements are freed in one place.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

46805acb

staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d · 8d7fb1b8
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8d7fb1b8
staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info() · 1bebe756
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
1bebe756

staging: rtl8723au: Do not embed struct wlan_bssid_ex in struct survey_event · 24687964

Jes Sorensen authored Jun 09, 2014

Instead allocate it separately and reference it from survey_event.
This will allow for us to pass it on later without having to copy it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

24687964

staging: rtl8723au: rtw_survey_event_cb23a(): Use the correct types for the received arguments · 7195dc0e
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
7195dc0e

staging: rtl8723au: Declare rtw_update_scanned_network() static · 8ab7bdba

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

8ab7bdba

staging: rtl8723au: rtw_check_bcn_info23a(): Don't search for WPA/WPA2 info twice · bbf5fdbd
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
bbf5fdbd

staging: rtl8723au: rtw_check_bcn_info23a(): Don't make a local copy of beacon just to parse it · 17b19396

Jes Sorensen authored Jun 09, 2014

In addition be consistent with return values and parsing them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

17b19396

staging: rtl8723au: rtw_check_bcn_info23a(): Use ether_addr_equal() to check BSSID · 0c45e617
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
0c45e617

staging: rtl8723au: Remove some unused 80211 header parsing macros · 51dacaa7

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

51dacaa7

staging: rtl8723au: Remove unused #defines WEP_KEY_LEN and MGMT_QUEUE_NUM · e0ea5c8e
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
e0ea5c8e
staging: rtl8723au: Remove duplicate defines of IEEE80211_HT_PARAM_CHA_SEC_* · bf51cb67
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
bf51cb67

staging: rtl8723au: Remove obsolete rtw_set_fixed_ie23a() · 2a907fe4

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2a907fe4

staging: rtl8723au: issue_action_BA23a(): Use struct ieee80211_mgmt to build action frames · a491548d
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
a491548d
staging: rtl8723au: ioctl_cfg80211.c: Use struct ieee80211_mgmt to build mgmt frame · cc531f61
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
cc531f61

staging: rtl8723au: Let cfg80211 handle public action management frames · 2e74d336

Jes Sorensen authored Jun 09, 2014

The driver shouldn't be dealing with public action management frames.
Let these go directly to the cfg80211 layer which can defer them to
userland if needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2e74d336

staging: rtl8723au: Do not xmit BSS Coexistence management action frames · 372713a9

Jes Sorensen authored Jun 09, 2014

The driver should not be issuing BSS Coexistence management action
frames when scanning. This isn't required by the spec, and if needed,
these should come from wpa_s instead.

Recommended by Johannes Berg.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

372713a9

staging: rtl8723au: issue_action_BSSCoexistPacket(): Use struct ieee80211_mgmt · 85d5120d

Jes Sorensen authored Jun 09, 2014

This gets rid of the rtw_set_fixed_ie23a() usage here. Note that this
abuses ieee80211_mgmt.u.action.u.chan_switch for now, since the
correct defines are currently missing, and this one matches.

Need to fix up the definitions in ieee80211.h and afterwards fix it up
here.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

85d5120d

staging: rtl8723au: issue_action_spct_ch_switch23a(): Use struct ieee80211_mgmt · 7ed61b5b
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
7ed61b5b
staging: rtl8723au: _issue_deauth(): Use struct ieee80211_mgmt to build frame · f89547b6
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
f89547b6
staging: rtl8723au: issue_assocrsp(): Use struct ieee80211_mgmt instead of rtw_set_fixed_ie23a() · c144c3bb
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
c144c3bb

staging: rtl8723au: issue_auth(): Convert to using struct ieee80211_mgmt · 88e06f02

Jes Sorensen authored Jun 09, 2014

This reduces the dependency of rtw_set_fixed_ie23a() which is
scheduled to go away.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

88e06f02

staging: rtl8723au: Make struct htpriv.ampdu_enable a bool · 47e5d2f2

Jes Sorensen authored Jun 09, 2014

Be consistent in parsing it's value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

47e5d2f2

staging: rtl8723au: Be consistent in how htpriv.ht_option is checked · 6a5f657d

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6a5f657d

staging: rtl8723au: Make struct ht_priv.ht_option a bool · 6f765c20

Jes Sorensen authored Jun 09, 2014

Match the return type of rtw_restructure_ht_ie23a() accordingly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6f765c20

staging: rtl8723au: Remove WMM_ defines · c9324c88

Jes Sorensen authored Jun 09, 2014

Only one is used, and only describes the size of an array defined in a
local function. Use sizeof() in the local function to deobfuscate it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c9324c88

staging: rtl8723au: OnAssocRsp23a(): Use cfg80211_* to parse IEs · e1d143b4

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e1d143b4

staging: rtl8723au: Make WMM_param_handler23a() and HT_caps_handler23a() take a const u8 * · 3cdf2773
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
3cdf2773

staging: rtl8723au: Declare rtw_get_wpa{2, }_cipher_suite() static · 0cac3f9e

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0cac3f9e

staging: rtl8723au: Remove obsolete rtw_get_sec_ie23a() · 0b548a5c

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0b548a5c