- 25 Apr, 2017 3 commits
-
-
Trond Myklebust authored
If the server has already returned a fatal write error that the user has not yet received on this file, then don't write back the other pages. Instead, act as if they have been sent, and have returned with the same error. Signed-off-by:Trond Myklebust <trond.myklebust@primarydata.com>
-
Trond Myklebust authored
The assumption should be that if the caller returns PNFS_ATTEMPTED, then hdr has been consumed, and so we should not be testing hdr->task.tk_status. If the caller returns PNFS_TRY_AGAIN, then we need to recoalesce and free hdr. Signed-off-by: -
Trond Myklebust authored
If we have a layout segment cached in pgio->pg_lseg, we should check it for validity before reusing it in a new RPC request. Otherwise, if we recoalesce, we can end up looping forever. Signed-off-by:
-
- 21 Apr, 2017 6 commits
-
-
Benjamin Coddington authored
NFS attempts to wait for read and write completion before unlocking in order to ensure that the data returned was protected by the lock. When this waiting is interrupted by a signal, the unlock may be skipped, and messages similar to the following are seen in the kernel ring buffer: [20.167876] Leaked locks on dev=0x0:0x2b ino=0x8dd4c3: [20.168286] POSIX: fl_owner=ffff880078b06940 fl_flags=0x1 fl_type=0x0 fl_pid=20183 [20.168727] POSIX: fl_owner=ffff880078b06680 fl_flags=0x1 fl_type=0x0 fl_pid=20185 For NFSv3, the missing unlock will cause the server to refuse conflicting locks indefinitely. For NFSv4, the leftover lock will be removed by the server after the lease timeout. This patch fixes this issue by skipping the usual wait in nfs_iocounter_wait if the FL_CLOSE flag is set when signaled. Instead, the wait happens in the unlock RPC task on the NFS UOC rpc_waitqueue. For NFSv3, use lockd's new nlmclnt_operations along with nfs_async_iocounter_wait to defer NLM's unlock task until the lock context's iocounter reaches zero. For NFSv4, call nfs_async_iocounter_wait() directly from unlock's current rpc_call_prepare. Signed-off-by:
Benjamin Coddington <bcodding@redhat.com> Reviewed-by:
Jeff Layton <jlayton@redhat.com> Signed-off-by:
-
Benjamin Coddington authored
NFS would enjoy the ability to modify the behavior of the NLM client's unlock RPC task in order to delay the transmission of the unlock until IO that was submitted under that lock has completed. This ability can ensure that the NLM client will always complete the transmission of an unlock even if the waiting caller has been interrupted with fatal signal. For this purpose, a pointer to a struct nlmclnt_operations can be assigned in a nfs_module's nfs_rpc_ops that will install those nlmclnt_operations on the nlm_host. The struct nlmclnt_operations defines three callback operations that will be used in a following patch: nlmclnt_alloc_call - used to call back after a successful allocation of a struct nlm_rqst in nlmclnt_proc(). nlmclnt_unlock_prepare - used to call back during NLM unlock's rpc_call_prepare. The NLM client defers calling rpc_call_start() until this callback returns false. nlmclnt_release_call - used to call back when the NLM client's struct nlm_rqst is freed. Signed-off-by:
-
Benjamin Coddington authored
By sleeping on a new NFS Unlock-On-Close waitqueue, rpc tasks may wait for a lock context's iocounter to reach zero. The rpc waitqueue is only woken when the open_context has the NFS_CONTEXT_UNLOCK flag set in order to mitigate spurious wake-ups for any iocounter reaching zero. Signed-off-by:
-
Benjamin Coddington authored
Set FL_CLOSE in fl_flags as in locks_remove_posix() when clearing locks. NFS will check for this flag to ensure an unlock is sent in a following patch. Fuse handles flock and posix locks differently for FL_CLOSE, and so requires a fixup to retain the existing behavior for flock. Signed-off-by:
Miklos Szeredi <miklos@szeredi.hu> Signed-off-by:
-
Benjamin Coddington authored
We only need to check lock exclusive/shared types against open mode when flock() is used on NFS, so move it into the flock-specific path instead of checking it for all locks. Signed-off-by:
Christoph Hellwig <hch@lst.de> Reviewed-by:
-
Benjamin Coddington authored
flock64_to_posix_lock() is already doing this check Signed-off-by:
Jeff Layton <jeff.layton@primarydata.com> Reviewed-by:
-
- 20 Apr, 2017 31 commits
-
-
Trond Myklebust authored
It is not used outside the NFSv4 module. Signed-off-by: -
Trond Myklebust authored
They are not used outside the NFSv4 module. Signed-off-by: -
Trond Myklebust authored
encode_layoutreturn and encode_layoutcommit are now unused. Let's remove them. Signed-off-by: -
Christoph Hellwig authored
The objlayout code has been in the tree, but it's been unmaintained and no server product for it actually ever shipped. Signed-off-by:
-
Trond Myklebust authored
The check in nfs4_ff_layout_prepare_ds() seems to be missing. Signed-off-by:
-
Trond Myklebust authored
If the server fails to return the attributes as part of an OPEN reply, and then reboots, we can end up hanging. The reason is that the client attempts to send a GETATTR in order to pick up the missing OPEN call, but fails to release the slot first, causing reboot recovery to deadlock. Signed-off-by:
-
Benjamin Coddington authored
Let's try to have it in a cacheline in nfs4_proc_pgio_rpc_prepare(). Signed-off-by:
-
Benjamin Coddington authored
Since commit 00bfa30a ("NFS: Create a common pgio_alloc and pgio_release function"), nfs_pgarray_set() has only a single caller. Let's open code it. Signed-off-by:
-
Benjamin Coddington authored
Prevent a deadlock that can occur if we wait on allocations that try to write back our pages. Signed-off-by:
-
Fred Isaman authored
Signed-off-by:
Fred Isaman <fred.isaman@gmail.com> Fixes: 0bcbf039 ("nfs: handle request add failure properly") Cc: stable@vger.kernel.org # v4.5+ Signed-off-by:
-
Benjamin Coddington authored
Commit a7d42ddb ("nfs: add mirroring support to pgio layer") moved pg_cleanup out of the path when there was non-sequental I/O that needed to be flushed. The result is that for layouts that have more than one layout segment per file, the pg_lseg is not cleared, so we can end up hitting the WARN_ON_ONCE(req_start >= seg_end) in pnfs_generic_pg_test since the pg_lseg will be pointing to that previously-flushed layout segment. Signed-off-by:
-
NeilBrown authored
When mempool_alloc() is allowed to sleep (GFP_NOIO allows sleeping) it cannot fail. So rpc_alloc_task() cannot fail, so rpc_new_task doesn't need to test for failure. Consequently rpc_new_task() cannot fail, so the callers don't need to test. Signed-off-by:
NeilBrown <neilb@suse.com> Signed-off-by:
-
NeilBrown authored
When passed GFP flags that allow sleeping (such as GFP_NOIO), mempool_alloc() will never return NULL, it will wait until memory is available. This means that we don't need to handle failure, but that we do need to ensure one thread doesn't call mempool_alloc() twice on the one pool without queuing or freeing the first allocation. If multiple threads did this during times of high memory pressure, the pool could be exhausted and a deadlock could result. pnfs_generic_alloc_ds_commits() attempts to allocate from the nfs_commit_mempool while already holding an allocation from that pool. This is not safe. So change nfs_commitdata_alloc() to take a flag that indicates whether failure is acceptable. In pnfs_generic_alloc_ds_commits(), accept failure and handle it as we currently do. Else where, do not accept failure, and do not handle it. Even when failure is acceptable, we want to succeed if possible. That means both - using an entry from the pool if there is one - waiting for direct reclaim is there isn't. We call mempool_alloc(GFP_NOWAIT) to achieve the first, then kmem_cache_alloc(GFP_NOIO|__GFP_NORETRY) to achieve the second. Each of these can fail, but together they do the best they can without blocking indefinitely. The objects returned by kmem_cache_alloc() will still be freed by mempool_free(). This is safe as mempool_alloc() uses exactly the same function to allocate objects (since the mempool was created with mempool_create_slab_pool()). The object returned by mempool_alloc() and kmem_cache_alloc() are indistinguishable so mempool_free() will handle both identically, either adding to the pool or calling kmem_cache_free(). Also, don't test for failure when allocating from nfs_wdata_mempool. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Returning errors directly even lets us remove the goto Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
If we cut out the dprintk()s, then we can return error codes directly and cut out the goto. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
This puts all the common code in a single place for the walk_client_list() functions. Signed-off-by:
-
Anna Schumaker authored
Once again, we can remove the function and compare integer values directly. Signed-off-by:
-
Anna Schumaker authored
If we cut out the dprintk()s, then we don't even need this to be a separate function. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Just remove the function and have the caller use nfs_release_request() instead. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
