1. 21 Mar, 2022 1 commit
  2. 18 Mar, 2022 4 commits
  3. 14 Mar, 2022 4 commits
  4. 13 Mar, 2022 1 commit
  5. 12 Mar, 2022 1 commit
  6. 11 Mar, 2022 1 commit
  7. 10 Mar, 2022 2 commits
  8. 09 Mar, 2022 1 commit
  9. 08 Mar, 2022 3 commits
  10. 07 Mar, 2022 3 commits
  11. 05 Mar, 2022 4 commits
  12. 04 Mar, 2022 3 commits
    • Takashi Sakamoto's avatar
      ALSA: firewire-lib: fix uninitialized flag for AV/C deferred transaction · bf0cd60b
      Takashi Sakamoto authored
      AV/C deferred transaction was supported at a commit 00a7bb81 ("ALSA:
      firewire-lib: Add support for deferred transaction") while 'deferrable'
      flag can be uninitialized for non-control/notify AV/C transactions.
      UBSAN reports it:
      
      kernel: ================================================================================
      kernel: UBSAN: invalid-load in /build/linux-aa0B4d/linux-5.15.0/sound/firewire/fcp.c:363:9
      kernel: load of value 158 is not a valid value for type '_Bool'
      kernel: CPU: 3 PID: 182227 Comm: irq/35-firewire Tainted: P           OE     5.15.0-18-generic #18-Ubuntu
      kernel: Hardware name: Gigabyte Technology Co., Ltd. AX370-Gaming 5/AX370-Gaming 5, BIOS F42b 08/01/2019
      kernel: Call Trace:
      kernel:  <IRQ>
      kernel:  show_stack+0x52/0x58
      kernel:  dump_stack_lvl+0x4a/0x5f
      kernel:  dump_stack+0x10/0x12
      kernel:  ubsan_epilogue+0x9/0x45
      kernel:  __ubsan_handle_load_invalid_value.cold+0x44/0x49
      kernel:  fcp_response.part.0.cold+0x1a/0x2b [snd_firewire_lib]
      kernel:  fcp_response+0x28/0x30 [snd_firewire_lib]
      kernel:  fw_core_handle_request+0x230/0x3d0 [firewire_core]
      kernel:  handle_ar_packet+0x1d9/0x200 [firewire_ohci]
      kernel:  ? handle_ar_packet+0x1d9/0x200 [firewire_ohci]
      kernel:  ? transmit_complete_callback+0x9f/0x120 [firewire_core]
      kernel:  ar_context_tasklet+0xa8/0x2e0 [firewire_ohci]
      kernel:  tasklet_action_common.constprop.0+0xea/0xf0
      kernel:  tasklet_action+0x22/0x30
      kernel:  __do_softirq+0xd9/0x2e3
      kernel:  ? irq_finalize_oneshot.part.0+0xf0/0xf0
      kernel:  do_softirq+0x75/0xa0
      kernel:  </IRQ>
      kernel:  <TASK>
      kernel:  __local_bh_enable_ip+0x50/0x60
      kernel:  irq_forced_thread_fn+0x7e/0x90
      kernel:  irq_thread+0xba/0x190
      kernel:  ? irq_thread_fn+0x60/0x60
      kernel:  kthread+0x11e/0x140
      kernel:  ? irq_thread_check_affinity+0xf0/0xf0
      kernel:  ? set_kthread_struct+0x50/0x50
      kernel:  ret_from_fork+0x22/0x30
      kernel:  </TASK>
      kernel: ================================================================================
      
      This commit fixes the bug. The bug has no disadvantage for the non-
      control/notify AV/C transactions since the flag has an effect for AV/C
      response with INTERIM (0x0f) status which is not used for the transactions
      in AV/C general specification.
      
      Fixes: 00a7bb81 ("ALSA: firewire-lib: Add support for deferred transaction")
      Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
      Link: https://lore.kernel.org/r/20220304125647.78430-1-o-takashi@sakamocchi.jpSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      bf0cd60b
    • Xiaoke Wang's avatar
      ALSA: lola: add a check for the return of vmalloc() · d7f15bef
      Xiaoke Wang authored
      vmalloc() is a memory allocation function which can return NULL when
      some internal memory errors happen. So it is better to check the return
      of it to catch the error in time.
      Signed-off-by: default avatarXiaoke Wang <xkernel.wang@foxmail.com>
      Link: https://lore.kernel.org/r/tencent_4221FC4089F6DF01C48F192E5784038BA205@qq.comSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      d7f15bef
    • Colin Ian King's avatar
      ALSA: echoaudio: remove redundant assignment to variable bytes · 3cffb26f
      Colin Ian King authored
      The variable bytes is being assigned a value that is never read, it
      is being re-assigned inside a following if block. The assignment is
      redundant and can be removed.
      
      Cleans up clang scan build warning:
      sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored
      to 'bytes' is used in the enclosing expression, the value is never
      actually read from 'bytes' [deadcode.DeadStores]
      Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
      Link: https://lore.kernel.org/r/20220302170728.1094633-1-colin.i.king@gmail.comSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      3cffb26f
  13. 02 Mar, 2022 2 commits
  14. 28 Feb, 2022 4 commits
  15. 24 Feb, 2022 6 commits