- 15 Aug, 2015 40 commits
-
-
Patrick Boettcher authored
This static can be made constant as it is never modified. Found during sparse-cleanup. Signed-off-by:
Patrick Boettcher <patrick.boettcher@posteo.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Patrick Boettcher authored
Fix sparse warnings of the following type: warning: symbol '....' was not declared. Should it be static? Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
-
Shraddha Barke authored
This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (void *) e ) Signed-off-by:
-
Shraddha Barke authored
kfree on NULL pointer is a no-op. This patch uses the following semantic patch to find such an instance where NULL check is present before kfree. // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl>smpl> Signed-off-by: -
Jacob Kiefer authored
This patch fixes the following sparse errors: CHECK drivers/staging/rtl8723au/core/rtw_security.c drivers/staging/rtl8723au/core/rtw_security.c:189:39: \ warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_security.c:189:39: \ expected unsigned int [unsigned] [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:189:39: \ got restricted __le32 [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:197:39: \ warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_security.c:197:39: \ expected unsigned int [unsigned] [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:197:39: \ got restricted __le32 [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:682:39: \ warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_security.c:682:39: \ expected unsigned int [unsigned] [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:682:39: \ got restricted __le32 [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:694:39: \ warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_security.c:694:39: \ expected unsigned int [unsigned] [usertype] <noident> drivers/staging/rtl8723au/core/rtw_security.c:694:39: \ got restricted __le32 [usertype] <noident> Signed-off-by:
Jacob Kiefer <jtk54@cornell.edu> Signed-off-by:
-
Chaehyun Lim authored
Remove wilc_strutils.c and wilc_strutils.h that are not needed. wilc_strutils.o is also removed in Makefile. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
Remove WILC_memcpy_INTERNAL that is used in the WILC_memcpy because WILC_memcpy is replaced by memcpy. Signed-off-by:
-
Chaehyun Lim authored
Remove WILC_memcpy function that is changed to memcpy. Signed-off-by:
-
Chaehyun Lim authored
Use memcpy instead of WILC_memcpy that is a custom function. Signed-off-by:
-
Chaehyun Lim authored
Remove WILC_strncmp function that is changed to strncmp. Signed-off-by:
-
Chaehyun Lim authored
Use strncmp instead of WILC_strncmp. Signed-off-by:
-
Chaehyun Lim authored
Remove WILC_strncpy function that is changed to strncpy. Signed-off-by:
-
Chaehyun Lim authored
Use strncpy instead of WILC_strncpy that is a custom function Signed-off-by:
-
Chaehyun Lim authored
Remove WILC_strlen function that is changed to strlen. Signed-off-by:
-
Chaehyun Lim authored
Use strlen instead of WILC_strlen that is a custom function. Signed-off-by:
-
Chaehyun Lim authored
Remove commented code that is not used. Signed-off-by:
-
Dan Carpenter authored
This was supposed to bitwise AND but there is a typo. Fixes: 1a023870 ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
The "adl_pci7x3x" driver replaced the "adl_pci7230" and "adl_pci7432" drivers in commits 8f567c37 ("staging: comedi: new adl_pci7x3x driver") and 657f77d1 ("staging: comedi: remove adl_pci7230 and adl_pci7432 drivers"). Although the new driver code agrees with the user manuals for the respective boards, digital outputs stopped working on the PCI-7230. This has 16 digital output channels and the previous adl_pci7230 driver shifted the 16 bit output state left by 16 bits before writing to the hardware register. The new adl_pci7x3x driver doesn't do that. Fix it in `adl_pci7x3x_do_insn_bits()` by checking for the special case of the subdevice having only 16 channels and duplicating the 16 bit output state into both halves of the 32-bit register. That should work both for what the board actually does and for what the user manual says it should do. Fixes: 8f567c37 ("staging: comedi: new adl_pci7x3x driver") Signed-off-by:
-
H Hartley Sweeten authored
Use register bit defines from addi_tcw.h to remove the "magic" numbers. Signed-off-by:
-
H Hartley Sweeten authored
Use register bit defines from addi_tcw.h to remove the "magic" numbers. Signed-off-by:
-
H Hartley Sweeten authored
Use register bit defines from addi_tcw.h to remove the "magic" numbers. Signed-off-by:
-
H Hartley Sweeten authored
Use register bit defines from addi_tcw.h to remove the "magic" numbers. Signed-off-by:
-
H Hartley Sweeten authored
The APCI3501_TIMER_* register defines in this driver are that same as the ADDI_TCW_* defines with an additional offset. Add a 'tcw' (timer/counter/watchdog) member to the private data to hold the address for the iobase of the registers. Use that and the defines from addi_tcw.h to address the registers. Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase local variables. Signed-off-by:
-
H Hartley Sweeten authored
Change the register bit defines to use the BIT macro. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase member of the private data. Also, fix the type of the member, it holds a pci_resource_start() address and should be an unsigned long. Signed-off-by:
-
H Hartley Sweeten authored
The handling for the watchdog and timer modes is very similar. Refactor this function to use a common code path for both modes. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase local variable. For aesthetics, split the mask/set operations. Signed-off-by:
-
H Hartley Sweeten authored
The handling of the ADDIDATA_WATCHDOG and ADDIDATA_TIMER is identical. Refactor this function to use a common code path for both timer modes. Remove the incorrect dev_err() noise. The subdevice is valid but the timer_mode is not supported. Signed-off-by:
-
H Hartley Sweeten authored
The handling of the ADDIDATA_WATCHDOG and ADDIDATA_TIMER is identical except for the "stop" operation. Refactor this function to use a common code path for both timer modes. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase local variable. For aesthetics, split the mask/set operations. Signed-off-by:
-
H Hartley Sweeten authored
Rename this CamelCase member of the private data. Signed-off-by:
-
H Hartley Sweeten authored
The watchdog is stopped in apci3501_write_insn_timer() by writing a 0 to the timer control register. There is no need to read the register first and mask it (as done when the timer is used as a timer). Reported-by: coverity (CID 1227052) Signed-off-by:
-
H Hartley Sweeten authored
This function is only called by comedi_cleanup_board_minors() and the 'minor' parameter will always be < COMEDI_NUM_BOARD_MINORS. For aesthetics, absorb the function and remove the unnecessary BUG_ON(). Split the comedi_clear_board_minor() out to clarify that the return value is a comedi_device pointer. Signed-off-by:
-
H Hartley Sweeten authored
This function is only called by comedi_dev_get_from_minor() and the 'minor' value will always be < COMEDI_NUM_BOARD_MINORS. Remove the unnecessary BUG_ON(). Signed-off-by:
-
H Hartley Sweeten authored
Drivers should not crash the kernel. This function is only called by comedi_device_detach_cleanup() and the s->minor will always be valid or the device wouldn't have attached in the first place. Leave the checks for safety in accessing the comedi_subdevice_minor_table array but remove the BUG_ON() calls. Signed-off-by:
-
H Hartley Sweeten authored
The BUG_ON() checks in this function are not necessary. comedi_cleanup_board_minors() clears all the entries in the comedi_board_minor_table array and will call comedi_device_cleanup() for all attached devices. comedi_device_cleanup() will then clear the entries in the comedi_subdevice_minor_table array with comedi_free_subdevice_minor(). Remove the BUG_ON(), drivers should not crash the kernel. Signed-off-by:
-
H Hartley Sweeten authored
The BUG_ON() checks in comedi_subdevice_from_minor() and comedi_dev_get_from_subdevice_minor() are not necessary. The 'minor' numbers for a given comedi driver are setup by comedi_dev_get_from_subdevice_minor() and will always be in the correct range. Drivers should not crash the kernel, remove the BUG_ON() checks. Signed-off-by:
-
H Hartley Sweeten authored
Use the bit defines from addi_tcw.h to remove the magic numbers in this function. Add the missing define for ADDI_TCW_STATUS_HARDWARE_TRIG. Signed-off-by:
-
