1. 06 Jan, 2012 4 commits
    • Andreas Herrmann's avatar
      [CPUFREQ] powernow-k8: Fix indexing issue · a8eb2848
      Andreas Herrmann authored
      The driver uses the pstate number from the status register as index in
      its table of ACPI pstates (powernow_table). This is wrong as this is
      not a 1-to-1 mapping.
      
      For example we can have _PSS information to just utilize Pstate 0 and
      Pstate 4, ie.
      
        powernow-k8: Core Performance Boosting: on.
        powernow-k8:    0 : pstate 0 (2200 MHz)
        powernow-k8:    1 : pstate 4 (1400 MHz)
      
      In this example the driver's powernow_table has just 2 entries. Using
      the pstate number (4) as index into this table is just plain wrong.
      Signed-off-by: default avatarAndreas Herrmann <andreas.herrmann3@amd.com>
      Signed-off-by: default avatarDave Jones <davej@redhat.com>
      a8eb2848
    • Andreas Herrmann's avatar
      [CPUFREQ] powernow-k8: Avoid Pstate MSR accesses on systems supporting CPB · 201bf0f1
      Andreas Herrmann authored
      Due to CPB we can't directly map SW Pstates to Pstate MSRs. Get rid of
      the paranoia check. (assuming that the ACPI Pstate information is
      correct.)
      Signed-off-by: default avatarAndreas Herrmann <andreas.herrmann3@amd.com>
      Signed-off-by: default avatarDave Jones <davej@redhat.com>
      201bf0f1
    • Afzal Mohammed's avatar
      [CPUFREQ] update lpj only if frequency has changed · d08de0c1
      Afzal Mohammed authored
      During scaling up of cpu frequency, loops_per_jiffy
      is updated upon invoking PRECHANGE notifier.
      If setting to new frequency fails in cpufreq driver,
      lpj is left at incorrect value.
      
      Hence update lpj only if cpu frequency is changed,
      i.e. upon invoking POSTCHANGE notifier.
      
      Penalty would be that during time period between
      changing cpu frequency & invocation of POSTCHANGE
      notifier, udelay(x) may not gurantee minimal delay
      of 'x' us for frequency scaling up operation.
      
      Perhaps a better solution would be to define
      CPUFREQ_ABORTCHANGE & handle accordingly, but then
      it would be more intrusive (using ABORTCHANGE may
      help drivers also; if any has registered notifier
      and expect POST for a PRECHANGE, their needs can
      be taken care using ABORT)
      Signed-off-by: default avatarAfzal Mohammed <afzal@ti.com>
      Signed-off-by: default avatarDave Jones <davej@redhat.com>
      d08de0c1
    • Afzal Mohammed's avatar
      [CPUFREQ] cpufreq:userspace: fix cpu_cur_freq updation · 226dd019
      Afzal Mohammed authored
      CPU frequency is guranteed to be changed on notifier callback with
      CPUFREQ_POSTCHANGE. Notifier callback with CPUFREQ_PRECHANGE does
      not gurantee a change in frequency; after it, if cpufreq driver is
      unable to change CPU to new frequency. This results in wrong
      information being fed to user (if setting CPU frequency fails)
      upon doing like,
      
      cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_setspeed
      
      Hence in userspace governer update cpu_cur_freq only if notifier
      has been called with POSTCHANGE.
      Signed-off-by: default avatarAfzal Mohammed <afzal@ti.com>
      Signed-off-by: default avatarDave Jones <davej@redhat.com>
      226dd019
  2. 09 Dec, 2011 5 commits
  3. 02 Dec, 2011 5 commits
    • Dave Jones's avatar
      Merge branch 'for_3.3/omap-cpufreq' of... · b191c540
      Dave Jones authored
      Merge branch 'for_3.3/omap-cpufreq' of git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm into next
      b191c540
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net · 5983fe2b
      Linus Torvalds authored
      * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (73 commits)
        netfilter: Remove ADVANCED dependency from NF_CONNTRACK_NETBIOS_NS
        ipv4: flush route cache after change accept_local
        sch_red: fix red_change
        Revert "udp: remove redundant variable"
        bridge: master device stuck in no-carrier state forever when in user-stp mode
        ipv4: Perform peer validation on cached route lookup.
        net/core: fix rollback handler in register_netdevice_notifier
        sch_red: fix red_calc_qavg_from_idle_time
        bonding: only use primary address for ARP
        ipv4: fix lockdep splat in rt_cache_seq_show
        sch_teql: fix lockdep splat
        net: fec: Select the FEC driver by default for i.MX SoCs
        isdn: avoid copying too long drvid
        isdn: make sure strings are null terminated
        netlabel: Fix build problems when IPv6 is not enabled
        sctp: better integer overflow check in sctp_auth_create_key()
        sctp: integer overflow in sctp_auth_create_key()
        ipv6: Set mcast_hops to IPV6_DEFAULT_MCASTHOPS when -1 was given.
        net: Fix corruption in /proc/*/net/dev_mcast
        mac80211: fix race between the AGG SM and the Tx data path
        ...
      5983fe2b
    • David S. Miller's avatar
      netfilter: Remove ADVANCED dependency from NF_CONNTRACK_NETBIOS_NS · 3ced1be5
      David S. Miller authored
      firewalld in Fedora 16 needs this.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3ced1be5
    • Peter Pan(潘卫平)'s avatar
      ipv4: flush route cache after change accept_local · d01ff0a0
      Peter Pan(潘卫平) authored
      After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
      we should flush route cache, or it will continue receive packets with local
      source address, which should be dropped.
      Signed-off-by: default avatarWeiping Pan <panweiping3@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d01ff0a0
    • Eric Dumazet's avatar
      sch_red: fix red_change · 1ee5fa1e
      Eric Dumazet authored
      Le mercredi 30 novembre 2011 à 14:36 -0800, Stephen Hemminger a écrit :
      
      > (Almost) nobody uses RED because they can't figure it out.
      > According to Wikipedia, VJ says that:
      >  "there are not one, but two bugs in classic RED."
      
      RED is useful for high throughput routers, I doubt many linux machines
      act as such devices.
      
      I was considering adding Adaptative RED (Sally Floyd, Ramakrishna
      Gummadi, Scott Shender), August 2001
      
      In this version, maxp is dynamic (from 1% to 50%), and user only have to
      setup min_th (target average queue size)
      (max_th and wq (burst in linux RED) are automatically setup)
      
      By the way it seems we have a small bug in red_change()
      
      if (skb_queue_empty(&sch->q))
      	red_end_of_idle_period(&q->parms);
      
      First, if queue is empty, we should call
      red_start_of_idle_period(&q->parms);
      
      Second, since we dont use anymore sch->q, but q->qdisc, the test is
      meaningless.
      
      Oh well...
      
      [PATCH] sch_red: fix red_change()
      
      Now RED is classful, we must check q->qdisc->q.qlen, and if queue is empty,
      we start an idle period, not end it.
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1ee5fa1e
  4. 01 Dec, 2011 16 commits
  5. 30 Nov, 2011 10 commits